[INFO] updating cached repository DigitalShooting/DSC-Band-Ack [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DigitalShooting/DSC-Band-Ack [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DigitalShooting/DSC-Band-Ack" "work/ex/clippy-test-run/sources/stable/gh/DigitalShooting/DSC-Band-Ack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DigitalShooting/DSC-Band-Ack'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DigitalShooting/DSC-Band-Ack" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DigitalShooting/DSC-Band-Ack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DigitalShooting/DSC-Band-Ack'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 193dc178949e69193c9f69af3f118c7751e2a86e [INFO] sha for GitHub repo DigitalShooting/DSC-Band-Ack: 193dc178949e69193c9f69af3f118c7751e2a86e [INFO] validating manifest of DigitalShooting/DSC-Band-Ack on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DigitalShooting/DSC-Band-Ack on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DigitalShooting/DSC-Band-Ack [INFO] finished frobbing DigitalShooting/DSC-Band-Ack [INFO] frobbed toml for DigitalShooting/DSC-Band-Ack written to work/ex/clippy-test-run/sources/stable/gh/DigitalShooting/DSC-Band-Ack/Cargo.toml [INFO] started frobbing DigitalShooting/DSC-Band-Ack [INFO] finished frobbing DigitalShooting/DSC-Band-Ack [INFO] frobbed toml for DigitalShooting/DSC-Band-Ack written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DigitalShooting/DSC-Band-Ack/Cargo.toml [INFO] crate DigitalShooting/DSC-Band-Ack has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DigitalShooting/DSC-Band-Ack against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DigitalShooting/DSC-Band-Ack:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0ab8bbbe0ca114ab9ba0abd37a78f064de5c5f0cdbd6e78ee81ba25cbb11e7d5 [INFO] running `"docker" "start" "-a" "0ab8bbbe0ca114ab9ba0abd37a78f064de5c5f0cdbd6e78ee81ba25cbb11e7d5"` [INFO] [stderr] Compiling dsc_band_ack v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/band_ack/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod band_ack; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/band_ack/band_ack.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | return Ok(ticks) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ticks)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/band_ack/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod band_ack; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/band_ack/band_ack.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | return Ok(ticks) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ticks)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/server.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | let _ = stream.set_nonblocking(true).expect("set_nonblocking call failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/server.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | let _ = stream.set_read_timeout(Some(Duration::from_millis(200))).expect("set_read_timeout call failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/server.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | let _ = stream.set_nonblocking(true).expect("set_nonblocking call failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/server.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | let _ = stream.set_read_timeout(Some(Duration::from_millis(200))).expect("set_read_timeout call failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.47s [INFO] running `"docker" "inspect" "0ab8bbbe0ca114ab9ba0abd37a78f064de5c5f0cdbd6e78ee81ba25cbb11e7d5"` [INFO] running `"docker" "rm" "-f" "0ab8bbbe0ca114ab9ba0abd37a78f064de5c5f0cdbd6e78ee81ba25cbb11e7d5"` [INFO] [stdout] 0ab8bbbe0ca114ab9ba0abd37a78f064de5c5f0cdbd6e78ee81ba25cbb11e7d5