[INFO] updating cached repository Dhole/rust-tor-controller [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Dhole/rust-tor-controller [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Dhole/rust-tor-controller" "work/ex/clippy-test-run/sources/stable/gh/Dhole/rust-tor-controller"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Dhole/rust-tor-controller'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Dhole/rust-tor-controller" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dhole/rust-tor-controller"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dhole/rust-tor-controller'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9acd9c314ad4214877112b3e53dafcc6e2df687e [INFO] sha for GitHub repo Dhole/rust-tor-controller: 9acd9c314ad4214877112b3e53dafcc6e2df687e [INFO] validating manifest of Dhole/rust-tor-controller on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Dhole/rust-tor-controller on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Dhole/rust-tor-controller [INFO] finished frobbing Dhole/rust-tor-controller [INFO] frobbed toml for Dhole/rust-tor-controller written to work/ex/clippy-test-run/sources/stable/gh/Dhole/rust-tor-controller/Cargo.toml [INFO] started frobbing Dhole/rust-tor-controller [INFO] finished frobbing Dhole/rust-tor-controller [INFO] frobbed toml for Dhole/rust-tor-controller written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dhole/rust-tor-controller/Cargo.toml [INFO] crate Dhole/rust-tor-controller has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Dhole/rust-tor-controller against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Dhole/rust-tor-controller:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1b0f57329fecd9504147fe31a68d447b58c1e6bc89356d3072bd717766a32d90 [INFO] running `"docker" "start" "-a" "1b0f57329fecd9504147fe31a68d447b58c1e6bc89356d3072bd717766a32d90"` [INFO] [stderr] Checking timer v0.2.0 [INFO] [stderr] Checking env_logger v0.5.9 [INFO] [stderr] Checking tor_controller v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/control.rs:490:13 [INFO] [stderr] | [INFO] [stderr] 490 | status: status, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/control.rs:551:13 [INFO] [stderr] | [INFO] [stderr] 551 | auth_methods: auth_methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `auth_methods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/control.rs:552:13 [INFO] [stderr] | [INFO] [stderr] 552 | cookie_files: cookie_files, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cookie_files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/control.rs:490:13 [INFO] [stderr] | [INFO] [stderr] 490 | status: status, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/control.rs:551:13 [INFO] [stderr] | [INFO] [stderr] 551 | auth_methods: auth_methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `auth_methods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/control.rs:552:13 [INFO] [stderr] | [INFO] [stderr] 552 | cookie_files: cookie_files, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cookie_files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: method is never used: `wrap` [INFO] [stderr] --> src/control.rs:214:5 [INFO] [stderr] | [INFO] [stderr] 214 | unsafe fn wrap(s: String) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | .map_err(|err| Error::Command(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Command` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | .map_err(|err| Error::CommandOutput(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::CommandOutput` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | .map_err(|err| Error::Regex(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Regex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/control.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | / match self { [INFO] [stderr] 149 | | &OnionKey::New(ref key_type) => write!(f, "NEW:{}", key_type), [INFO] [stderr] 150 | | &OnionKey::Rsa1024(ref key) => write!(f, "RSA1024:{}", key), [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 148 | match *self { [INFO] [stderr] 149 | OnionKey::New(ref key_type) => write!(f, "NEW:{}", key_type), [INFO] [stderr] 150 | OnionKey::Rsa1024(ref key) => write!(f, "RSA1024:{}", key), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/control.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / match self { [INFO] [stderr] 164 | | &KeyType::Rsa1024 => write!(f, "RSA1024"), [INFO] [stderr] 165 | | &KeyType::Best => write!(f, "BEST"), [INFO] [stderr] 166 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 163 | match *self { [INFO] [stderr] 164 | KeyType::Rsa1024 => write!(f, "RSA1024"), [INFO] [stderr] 165 | KeyType::Best => write!(f, "BEST"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/control.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | / match self { [INFO] [stderr] 180 | | &OnionFlags::DiscardPK => write!(f, "DiscardPK"), [INFO] [stderr] 181 | | &OnionFlags::Detach => write!(f, "Detach"), [INFO] [stderr] 182 | | &OnionFlags::BasicAuth => write!(f, "BasicAuth"), [INFO] [stderr] 183 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 179 | match *self { [INFO] [stderr] 180 | OnionFlags::DiscardPK => write!(f, "DiscardPK"), [INFO] [stderr] 181 | OnionFlags::Detach => write!(f, "Detach"), [INFO] [stderr] 182 | OnionFlags::BasicAuth => write!(f, "BasicAuth"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/control.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | / if let &Some(ref client_blob) = &self.client_blob { [INFO] [stderr] 197 | | write!(f, ":{}", client_blob)?; [INFO] [stderr] 198 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 196 | if let Some(ref client_blob) = self.client_blob { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `wrap` [INFO] [stderr] --> src/control.rs:214:5 [INFO] [stderr] | [INFO] [stderr] 214 | unsafe fn wrap(s: String) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/control.rs:324:63 [INFO] [stderr] | [INFO] [stderr] 324 | fn write_join(f: &mut fmt::Formatter, elems: &Vec, sep: &str) -> fmt::Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | .map_err(|err| Error::Command(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Command` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | .map_err(|err| Error::CommandOutput(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::CommandOutput` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | .map_err(|err| Error::Regex(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Regex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/control.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | / match self { [INFO] [stderr] 149 | | &OnionKey::New(ref key_type) => write!(f, "NEW:{}", key_type), [INFO] [stderr] 150 | | &OnionKey::Rsa1024(ref key) => write!(f, "RSA1024:{}", key), [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 148 | match *self { [INFO] [stderr] 149 | OnionKey::New(ref key_type) => write!(f, "NEW:{}", key_type), [INFO] [stderr] 150 | OnionKey::Rsa1024(ref key) => write!(f, "RSA1024:{}", key), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/control.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / match self { [INFO] [stderr] 164 | | &KeyType::Rsa1024 => write!(f, "RSA1024"), [INFO] [stderr] 165 | | &KeyType::Best => write!(f, "BEST"), [INFO] [stderr] 166 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 163 | match *self { [INFO] [stderr] 164 | KeyType::Rsa1024 => write!(f, "RSA1024"), [INFO] [stderr] 165 | KeyType::Best => write!(f, "BEST"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/control.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | / match self { [INFO] [stderr] 180 | | &OnionFlags::DiscardPK => write!(f, "DiscardPK"), [INFO] [stderr] 181 | | &OnionFlags::Detach => write!(f, "Detach"), [INFO] [stderr] 182 | | &OnionFlags::BasicAuth => write!(f, "BasicAuth"), [INFO] [stderr] 183 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 179 | match *self { [INFO] [stderr] 180 | OnionFlags::DiscardPK => write!(f, "DiscardPK"), [INFO] [stderr] 181 | OnionFlags::Detach => write!(f, "Detach"), [INFO] [stderr] 182 | OnionFlags::BasicAuth => write!(f, "BasicAuth"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/control.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | / if let &Some(ref client_blob) = &self.client_blob { [INFO] [stderr] 197 | | write!(f, ":{}", client_blob)?; [INFO] [stderr] 198 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 196 | if let Some(ref client_blob) = self.client_blob { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/control.rs:588:9 [INFO] [stderr] | [INFO] [stderr] 588 | / match &reply_line.data { [INFO] [stderr] 589 | | &Some(ref data) => Ok(data.clone()), [INFO] [stderr] 590 | | &None => Ok(reply_line.reply[info_key.len() + 1..].to_string()), [INFO] [stderr] 591 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 588 | match reply_line.data { [INFO] [stderr] 589 | Some(ref data) => Ok(data.clone()), [INFO] [stderr] 590 | None => Ok(reply_line.reply[info_key.len() + 1..].to_string()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/control.rs:324:63 [INFO] [stderr] | [INFO] [stderr] 324 | fn write_join(f: &mut fmt::Formatter, elems: &Vec, sep: &str) -> fmt::Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `process::TorProcess` [INFO] [stderr] --> src/process.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Self { [INFO] [stderr] 35 | | TorProcess { [INFO] [stderr] 36 | | tor_cmd: "tor".to_string(), [INFO] [stderr] 37 | | args: vec![], [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/process.rs:90:22 [INFO] [stderr] | [INFO] [stderr] 90 | .map_err(|err| Error::Process(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Process` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/process.rs:100:74 [INFO] [stderr] | [INFO] [stderr] 100 | let _guard = timer.schedule_with_delay(chrono::Duration::seconds(self.timeout as i64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.timeout)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/process.rs:126:22 [INFO] [stderr] | [INFO] [stderr] 126 | .map_err(|err| Error::Regex(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Regex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/process.rs:132:55 [INFO] [stderr] | [INFO] [stderr] 132 | while stdout.read_line(&mut raw_line).map_err(|err| Error::Process(err))? > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Process` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/process.rs:146:34 [INFO] [stderr] | [INFO] [stderr] 146 | .ok_or(Error::InvalidBootstrapLine(line.to_string()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::InvalidBootstrapLine(line.to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/process.rs:165:16 [INFO] [stderr] | [INFO] [stderr] 165 | Ok(process.kill().map_err(|err| Error::Process(err))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 165 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/process.rs:165:39 [INFO] [stderr] | [INFO] [stderr] 165 | Ok(process.kill().map_err(|err| Error::Process(err))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Process` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/control.rs:588:9 [INFO] [stderr] | [INFO] [stderr] 588 | / match &reply_line.data { [INFO] [stderr] 589 | | &Some(ref data) => Ok(data.clone()), [INFO] [stderr] 590 | | &None => Ok(reply_line.reply[info_key.len() + 1..].to_string()), [INFO] [stderr] 591 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 588 | match reply_line.data { [INFO] [stderr] 589 | Some(ref data) => Ok(data.clone()), [INFO] [stderr] 590 | None => Ok(reply_line.reply[info_key.len() + 1..].to_string()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `process::TorProcess` [INFO] [stderr] --> src/process.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Self { [INFO] [stderr] 35 | | TorProcess { [INFO] [stderr] 36 | | tor_cmd: "tor".to_string(), [INFO] [stderr] 37 | | args: vec![], [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/process.rs:90:22 [INFO] [stderr] | [INFO] [stderr] 90 | .map_err(|err| Error::Process(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Process` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/process.rs:100:74 [INFO] [stderr] | [INFO] [stderr] 100 | let _guard = timer.schedule_with_delay(chrono::Duration::seconds(self.timeout as i64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.timeout)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/process.rs:126:22 [INFO] [stderr] | [INFO] [stderr] 126 | .map_err(|err| Error::Regex(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Regex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/process.rs:132:55 [INFO] [stderr] | [INFO] [stderr] 132 | while stdout.read_line(&mut raw_line).map_err(|err| Error::Process(err))? > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Process` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/process.rs:146:34 [INFO] [stderr] | [INFO] [stderr] 146 | .ok_or(Error::InvalidBootstrapLine(line.to_string()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::InvalidBootstrapLine(line.to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/process.rs:165:16 [INFO] [stderr] | [INFO] [stderr] 165 | Ok(process.kill().map_err(|err| Error::Process(err))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 165 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/process.rs:165:39 [INFO] [stderr] | [INFO] [stderr] 165 | Ok(process.kill().map_err(|err| Error::Process(err))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Process` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.25s [INFO] running `"docker" "inspect" "1b0f57329fecd9504147fe31a68d447b58c1e6bc89356d3072bd717766a32d90"` [INFO] running `"docker" "rm" "-f" "1b0f57329fecd9504147fe31a68d447b58c1e6bc89356d3072bd717766a32d90"` [INFO] [stdout] 1b0f57329fecd9504147fe31a68d447b58c1e6bc89356d3072bd717766a32d90