[INFO] updating cached repository Dhole/rust-netcat
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Dhole/rust-netcat
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Dhole/rust-netcat" "work/ex/clippy-test-run/sources/stable/gh/Dhole/rust-netcat"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Dhole/rust-netcat'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Dhole/rust-netcat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dhole/rust-netcat"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dhole/rust-netcat'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b51d0d132b4d383d4068f74ba4d63dc52d73579e
[INFO] sha for GitHub repo Dhole/rust-netcat: b51d0d132b4d383d4068f74ba4d63dc52d73579e
[INFO] validating manifest of Dhole/rust-netcat on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Dhole/rust-netcat on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Dhole/rust-netcat
[INFO] finished frobbing Dhole/rust-netcat
[INFO] frobbed toml for Dhole/rust-netcat written to work/ex/clippy-test-run/sources/stable/gh/Dhole/rust-netcat/Cargo.toml
[INFO] started frobbing Dhole/rust-netcat
[INFO] finished frobbing Dhole/rust-netcat
[INFO] frobbed toml for Dhole/rust-netcat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dhole/rust-netcat/Cargo.toml
[INFO] crate Dhole/rust-netcat has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Dhole/rust-netcat against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Dhole/rust-netcat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 88ff1ff6cb940b1526e0e6f063a3b6c82f098b659e990806e01b57b154eac10e
[INFO] running `"docker" "start" "-a" "88ff1ff6cb940b1526e0e6f063a3b6c82f098b659e990806e01b57b154eac10e"`
[INFO] [stderr]     Checking netcat v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/stdio.rs:102:20
[INFO] [stderr]     |
[INFO] [stderr] 102 |         FileDesc { fd: fd }
[INFO] [stderr]     |                    ^^^^^^ help: replace it with: `fd`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:124:9
[INFO] [stderr]     |
[INFO] [stderr] 124 |         flags: flags,
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `flags`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/stdio.rs:102:20
[INFO] [stderr]     |
[INFO] [stderr] 102 |         FileDesc { fd: fd }
[INFO] [stderr]     |                    ^^^^^^ help: replace it with: `fd`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:124:9
[INFO] [stderr]     |
[INFO] [stderr] 124 |         flags: flags,
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `flags`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:484:5
[INFO] [stderr]     |
[INFO] [stderr] 484 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/main.rs:454:9
[INFO] [stderr]     |
[INFO] [stderr] 454 | /         if pfd[POLL_NETIN].revents.contains(PollEvent::POLLIN) {
[INFO] [stderr] 455 | |             if stream.fill(&mut buf_netin)? == 0 {
[INFO] [stderr] 456 | |                 pfd[POLL_NETIN].fd = NOPOLLFD;
[INFO] [stderr] 457 | |             }
[INFO] [stderr] 458 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 454 |         if pfd[POLL_NETIN].revents.contains(PollEvent::POLLIN) && stream.fill(&mut buf_netin)? == 0 {
[INFO] [stderr] 455 |     pfd[POLL_NETIN].fd = NOPOLLFD;
[INFO] [stderr] 456 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:484:5
[INFO] [stderr]     |
[INFO] [stderr] 484 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/main.rs:454:9
[INFO] [stderr]     |
[INFO] [stderr] 454 | /         if pfd[POLL_NETIN].revents.contains(PollEvent::POLLIN) {
[INFO] [stderr] 455 | |             if stream.fill(&mut buf_netin)? == 0 {
[INFO] [stderr] 456 | |                 pfd[POLL_NETIN].fd = NOPOLLFD;
[INFO] [stderr] 457 | |             }
[INFO] [stderr] 458 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 454 |         if pfd[POLL_NETIN].revents.contains(PollEvent::POLLIN) && stream.fill(&mut buf_netin)? == 0 {
[INFO] [stderr] 455 |     pfd[POLL_NETIN].fd = NOPOLLFD;
[INFO] [stderr] 456 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `family`
[INFO] [stderr]    --> src/main.rs:294:5
[INFO] [stderr]     |
[INFO] [stderr] 294 |     family: &Option<Family>,
[INFO] [stderr]     |     ^^^^^^ help: consider using `_family` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference
[INFO] [stderr]    --> src/main.rs:192:34
[INFO] [stderr]     |
[INFO] [stderr] 192 |             let len = self.write(&mut buf.buf[buf.head..buf.tail])?;
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/main.rs:291:12
[INFO] [stderr]     |
[INFO] [stderr] 291 | fn connect<'a>(
[INFO] [stderr]     |            ^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `family`
[INFO] [stderr]    --> src/main.rs:294:5
[INFO] [stderr]     |
[INFO] [stderr] 294 |     family: &Option<Family>,
[INFO] [stderr]     |     ^^^^^^ help: consider using `_family` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference
[INFO] [stderr]    --> src/main.rs:192:34
[INFO] [stderr]     |
[INFO] [stderr] 192 |             let len = self.write(&mut buf.buf[buf.head..buf.tail])?;
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/main.rs:291:12
[INFO] [stderr]     |
[INFO] [stderr] 291 | fn connect<'a>(
[INFO] [stderr]     |            ^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.31s
[INFO] running `"docker" "inspect" "88ff1ff6cb940b1526e0e6f063a3b6c82f098b659e990806e01b57b154eac10e"`
[INFO] running `"docker" "rm" "-f" "88ff1ff6cb940b1526e0e6f063a3b6c82f098b659e990806e01b57b154eac10e"`
[INFO] [stdout] 88ff1ff6cb940b1526e0e6f063a3b6c82f098b659e990806e01b57b154eac10e