[INFO] updating cached repository Dhole/gb-rw-host [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Dhole/gb-rw-host [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Dhole/gb-rw-host" "work/ex/clippy-test-run/sources/stable/gh/Dhole/gb-rw-host"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Dhole/gb-rw-host'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Dhole/gb-rw-host" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dhole/gb-rw-host"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dhole/gb-rw-host'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5a0d611914bcf1cc10c745f0d535b06081e22fba [INFO] sha for GitHub repo Dhole/gb-rw-host: 5a0d611914bcf1cc10c745f0d535b06081e22fba [INFO] validating manifest of Dhole/gb-rw-host on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Dhole/gb-rw-host on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Dhole/gb-rw-host [INFO] finished frobbing Dhole/gb-rw-host [INFO] frobbed toml for Dhole/gb-rw-host written to work/ex/clippy-test-run/sources/stable/gh/Dhole/gb-rw-host/Cargo.toml [INFO] started frobbing Dhole/gb-rw-host [INFO] finished frobbing Dhole/gb-rw-host [INFO] frobbed toml for Dhole/gb-rw-host written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dhole/gb-rw-host/Cargo.toml [INFO] crate Dhole/gb-rw-host has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Dhole/gb-rw-host against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Dhole/gb-rw-host:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eff40866d5b4f5049416f83487cdb70aa3dd2684acb142a1340bffb81d4fbb94 [INFO] running `"docker" "start" "-a" "eff40866d5b4f5049416f83487cdb70aa3dd2684acb142a1340bffb81d4fbb94"` [INFO] [stderr] Compiling bzip2-sys v0.1.5 [INFO] [stderr] Checking ioctl-rs v0.1.5 [INFO] [stderr] Checking serial-core v0.4.0 [INFO] [stderr] Checking msdos_time v0.1.5 [INFO] [stderr] Checking miniz-sys v0.1.9 [INFO] [stderr] Checking serial-unix v0.4.0 [INFO] [stderr] Checking flate2 v0.2.19 [INFO] [stderr] Checking serial v0.4.0 [INFO] [stderr] Checking bzip2 v0.3.2 [INFO] [stderr] Checking zip v0.2.6 [INFO] [stderr] Checking gb-rw-host v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/utils.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | print!("|\n"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/header.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/header.rs:55:1 [INFO] [stderr] | [INFO] [stderr] 55 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/header.rs:143:1 [INFO] [stderr] | [INFO] [stderr] 143 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/header.rs:174:1 [INFO] [stderr] | [INFO] [stderr] 174 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/header.rs:192:1 [INFO] [stderr] | [INFO] [stderr] 192 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | cgb: cgb, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cgb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | license: license, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `license` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | cart_type: cart_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cart_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | mem_controller: mem_controller, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_controller` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:261:9 [INFO] [stderr] | [INFO] [stderr] 261 | rom_banks: rom_banks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rom_banks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:262:9 [INFO] [stderr] | [INFO] [stderr] 262 | ram_banks: ram_banks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ram_banks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | ram_size: ram_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ram_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | destination: destination, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:265:9 [INFO] [stderr] | [INFO] [stderr] 265 | checksum: checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:266:9 [INFO] [stderr] | [INFO] [stderr] 266 | global_checksum: global_checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `global_checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/utils.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | print!("|\n"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/header.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/header.rs:55:1 [INFO] [stderr] | [INFO] [stderr] 55 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/header.rs:143:1 [INFO] [stderr] | [INFO] [stderr] 143 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/header.rs:174:1 [INFO] [stderr] | [INFO] [stderr] 174 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/header.rs:192:1 [INFO] [stderr] | [INFO] [stderr] 192 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | cgb: cgb, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cgb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | license: license, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `license` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | cart_type: cart_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cart_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | mem_controller: mem_controller, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_controller` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:261:9 [INFO] [stderr] | [INFO] [stderr] 261 | rom_banks: rom_banks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rom_banks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:262:9 [INFO] [stderr] | [INFO] [stderr] 262 | ram_banks: ram_banks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ram_banks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | ram_size: ram_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ram_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | destination: destination, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:265:9 [INFO] [stderr] | [INFO] [stderr] 265 | checksum: checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:266:9 [INFO] [stderr] | [INFO] [stderr] 266 | global_checksum: global_checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `global_checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return (x + y - 1) / y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(x + y - 1) / y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/header.rs:145:5 [INFO] [stderr] | [INFO] [stderr] 145 | / return match *cart_type { [INFO] [stderr] 146 | | CartType::RomOnly => MemController::None, [INFO] [stderr] 147 | | CartType::Mbc1 => MemController::Mbc1, [INFO] [stderr] 148 | | CartType::Mbc1Ram => MemController::Mbc1, [INFO] [stderr] ... | [INFO] [stderr] 170 | | _ => MemController::Unknown, [INFO] [stderr] 171 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 145 | match *cart_type { [INFO] [stderr] 146 | CartType::RomOnly => MemController::None, [INFO] [stderr] 147 | CartType::Mbc1 => MemController::Mbc1, [INFO] [stderr] 148 | CartType::Mbc1Ram => MemController::Mbc1, [INFO] [stderr] 149 | CartType::Mbc1RamBattery => MemController::Mbc1, [INFO] [stderr] 150 | CartType::Mbc2 => MemController::Mbc2, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/header.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | / return match rom_banks { [INFO] [stderr] 177 | | RomBanks::Banks002 => 2, [INFO] [stderr] 178 | | RomBanks::Banks004 => 4, [INFO] [stderr] 179 | | RomBanks::Banks008 => 8, [INFO] [stderr] ... | [INFO] [stderr] 188 | | RomBanks::Banks096 => 54, [INFO] [stderr] 189 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 176 | match rom_banks { [INFO] [stderr] 177 | RomBanks::Banks002 => 2, [INFO] [stderr] 178 | RomBanks::Banks004 => 4, [INFO] [stderr] 179 | RomBanks::Banks008 => 8, [INFO] [stderr] 180 | RomBanks::Banks016 => 16, [INFO] [stderr] 181 | RomBanks::Banks032 => 32, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/header.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | / return match ram_size { [INFO] [stderr] 195 | | RamSize::KB000 => 0, [INFO] [stderr] 196 | | RamSize::KB002 => 2, [INFO] [stderr] 197 | | RamSize::KB008 => 8, [INFO] [stderr] ... | [INFO] [stderr] 200 | | RamSize::KB064 => 64, [INFO] [stderr] 201 | | } * 1024; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 194 | match ram_size { [INFO] [stderr] 195 | RamSize::KB000 => 0, [INFO] [stderr] 196 | RamSize::KB002 => 2, [INFO] [stderr] 197 | RamSize::KB008 => 8, [INFO] [stderr] 198 | RamSize::KB032 => 32, [INFO] [stderr] 199 | RamSize::KB128 => 128, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/header.rs:255:5 [INFO] [stderr] | [INFO] [stderr] 255 | / return Ok(HeaderInfo { [INFO] [stderr] 256 | | title: title, [INFO] [stderr] 257 | | cgb: cgb, [INFO] [stderr] 258 | | license: license, [INFO] [stderr] ... | [INFO] [stderr] 266 | | global_checksum: global_checksum, [INFO] [stderr] 267 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 255 | Ok(HeaderInfo { [INFO] [stderr] 256 | title: title, [INFO] [stderr] 257 | cgb: cgb, [INFO] [stderr] 258 | license: license, [INFO] [stderr] 259 | cart_type: cart_type, [INFO] [stderr] 260 | mem_controller: mem_controller, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/header.rs:275:5 [INFO] [stderr] | [INFO] [stderr] 275 | return c.0; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `c.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/header.rs:285:5 [INFO] [stderr] | [INFO] [stderr] 285 | return c.0; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `c.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return (x + y - 1) / y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(x + y - 1) / y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/header.rs:145:5 [INFO] [stderr] | [INFO] [stderr] 145 | / return match *cart_type { [INFO] [stderr] 146 | | CartType::RomOnly => MemController::None, [INFO] [stderr] 147 | | CartType::Mbc1 => MemController::Mbc1, [INFO] [stderr] 148 | | CartType::Mbc1Ram => MemController::Mbc1, [INFO] [stderr] ... | [INFO] [stderr] 170 | | _ => MemController::Unknown, [INFO] [stderr] 171 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 145 | match *cart_type { [INFO] [stderr] 146 | CartType::RomOnly => MemController::None, [INFO] [stderr] 147 | CartType::Mbc1 => MemController::Mbc1, [INFO] [stderr] 148 | CartType::Mbc1Ram => MemController::Mbc1, [INFO] [stderr] 149 | CartType::Mbc1RamBattery => MemController::Mbc1, [INFO] [stderr] 150 | CartType::Mbc2 => MemController::Mbc2, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/header.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | / return match rom_banks { [INFO] [stderr] 177 | | RomBanks::Banks002 => 2, [INFO] [stderr] 178 | | RomBanks::Banks004 => 4, [INFO] [stderr] 179 | | RomBanks::Banks008 => 8, [INFO] [stderr] ... | [INFO] [stderr] 188 | | RomBanks::Banks096 => 54, [INFO] [stderr] 189 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 176 | match rom_banks { [INFO] [stderr] 177 | RomBanks::Banks002 => 2, [INFO] [stderr] 178 | RomBanks::Banks004 => 4, [INFO] [stderr] 179 | RomBanks::Banks008 => 8, [INFO] [stderr] 180 | RomBanks::Banks016 => 16, [INFO] [stderr] 181 | RomBanks::Banks032 => 32, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/header.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | / return match ram_size { [INFO] [stderr] 195 | | RamSize::KB000 => 0, [INFO] [stderr] 196 | | RamSize::KB002 => 2, [INFO] [stderr] 197 | | RamSize::KB008 => 8, [INFO] [stderr] ... | [INFO] [stderr] 200 | | RamSize::KB064 => 64, [INFO] [stderr] 201 | | } * 1024; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 194 | match ram_size { [INFO] [stderr] 195 | RamSize::KB000 => 0, [INFO] [stderr] 196 | RamSize::KB002 => 2, [INFO] [stderr] 197 | RamSize::KB008 => 8, [INFO] [stderr] 198 | RamSize::KB032 => 32, [INFO] [stderr] 199 | RamSize::KB128 => 128, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/header.rs:255:5 [INFO] [stderr] | [INFO] [stderr] 255 | / return Ok(HeaderInfo { [INFO] [stderr] 256 | | title: title, [INFO] [stderr] 257 | | cgb: cgb, [INFO] [stderr] 258 | | license: license, [INFO] [stderr] ... | [INFO] [stderr] 266 | | global_checksum: global_checksum, [INFO] [stderr] 267 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 255 | Ok(HeaderInfo { [INFO] [stderr] 256 | title: title, [INFO] [stderr] 257 | cgb: cgb, [INFO] [stderr] 258 | license: license, [INFO] [stderr] 259 | cart_type: cart_type, [INFO] [stderr] 260 | mem_controller: mem_controller, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/header.rs:275:5 [INFO] [stderr] | [INFO] [stderr] 275 | return c.0; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `c.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/header.rs:285:5 [INFO] [stderr] | [INFO] [stderr] 285 | return c.0; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `c.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/header.rs:253:27 [INFO] [stderr] | [INFO] [stderr] 253 | let global_checksum = (bank[0x014E] as u16) << 8 | (bank[0x014F] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(bank[0x014E])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/header.rs:253:56 [INFO] [stderr] | [INFO] [stderr] 253 | let global_checksum = (bank[0x014E] as u16) << 8 | (bank[0x014F] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(bank[0x014F])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `bank`. [INFO] [stderr] --> src/header.rs:272:14 [INFO] [stderr] | [INFO] [stderr] 272 | for i in 0x0134..0x014D { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 272 | for in bank.iter().take(0x014D).skip(0x0134) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/header.rs:281:23 [INFO] [stderr] | [INFO] [stderr] 281 | c += Wrapping(*b as u16); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(*b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/header.rs:283:19 [INFO] [stderr] | [INFO] [stderr] 283 | c -= Wrapping(rom[0x014E] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(rom[0x014E])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/header.rs:284:19 [INFO] [stderr] | [INFO] [stderr] 284 | c -= Wrapping(rom[0x014F] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(rom[0x014F])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/header.rs:253:27 [INFO] [stderr] | [INFO] [stderr] 253 | let global_checksum = (bank[0x014E] as u16) << 8 | (bank[0x014F] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(bank[0x014E])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/header.rs:253:56 [INFO] [stderr] | [INFO] [stderr] 253 | let global_checksum = (bank[0x014E] as u16) << 8 | (bank[0x014F] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(bank[0x014F])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `bank`. [INFO] [stderr] --> src/header.rs:272:14 [INFO] [stderr] | [INFO] [stderr] 272 | for i in 0x0134..0x014D { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 272 | for in bank.iter().take(0x014D).skip(0x0134) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/header.rs:281:23 [INFO] [stderr] | [INFO] [stderr] 281 | c += Wrapping(*b as u16); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(*b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/header.rs:283:19 [INFO] [stderr] | [INFO] [stderr] 283 | c -= Wrapping(rom[0x014E] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(rom[0x014E])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/header.rs:284:19 [INFO] [stderr] | [INFO] [stderr] 284 | c -= Wrapping(rom[0x014F] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(rom[0x014F])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:399:5 [INFO] [stderr] | [INFO] [stderr] 399 | / return if mode == Mode::ReadROM || mode == Mode::ReadRAM { [INFO] [stderr] 400 | | result.map_err(|e| { [INFO] [stderr] 401 | | //drop(file); [INFO] [stderr] 402 | | fs::remove_file(path).unwrap_or(()); [INFO] [stderr] ... | [INFO] [stderr] 406 | | result [INFO] [stderr] 407 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 399 | if mode == Mode::ReadROM || mode == Mode::ReadRAM { [INFO] [stderr] 400 | result.map_err(|e| { [INFO] [stderr] 401 | //drop(file); [INFO] [stderr] 402 | fs::remove_file(path).unwrap_or(()); [INFO] [stderr] 403 | return e; [INFO] [stderr] 404 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:403:13 [INFO] [stderr] | [INFO] [stderr] 403 | return e; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:529:5 [INFO] [stderr] | [INFO] [stderr] 529 | return file.write_all(&mem); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file.write_all(&mem)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:586:5 [INFO] [stderr] | [INFO] [stderr] 586 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:591:5 [INFO] [stderr] | [INFO] [stderr] 591 | return port.flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `port.flush()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:596:5 [INFO] [stderr] | [INFO] [stderr] 596 | return port.flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `port.flush()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:600:5 [INFO] [stderr] | [INFO] [stderr] 600 | return erase_flash(&mut port); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `erase_flash(&mut port)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:647:5 [INFO] [stderr] | [INFO] [stderr] 647 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:675:5 [INFO] [stderr] | [INFO] [stderr] 675 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:769:9 [INFO] [stderr] | [INFO] [stderr] 769 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:771:9 [INFO] [stderr] | [INFO] [stderr] 771 | return Err(Error::new(ErrorKind::Other, "Unexpected reply to ping")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::new(ErrorKind::Other, "Unexpected reply to ping"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:854:9 [INFO] [stderr] | [INFO] [stderr] 854 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:856:9 [INFO] [stderr] | [INFO] [stderr] 856 | return Err(Error::new(ErrorKind::Other, "Unexpected reply to ping")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::new(ErrorKind::Other, "Unexpected reply to ping"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:399:5 [INFO] [stderr] | [INFO] [stderr] 399 | / return if mode == Mode::ReadROM || mode == Mode::ReadRAM { [INFO] [stderr] 400 | | result.map_err(|e| { [INFO] [stderr] 401 | | //drop(file); [INFO] [stderr] 402 | | fs::remove_file(path).unwrap_or(()); [INFO] [stderr] ... | [INFO] [stderr] 406 | | result [INFO] [stderr] 407 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 399 | if mode == Mode::ReadROM || mode == Mode::ReadRAM { [INFO] [stderr] 400 | result.map_err(|e| { [INFO] [stderr] 401 | //drop(file); [INFO] [stderr] 402 | fs::remove_file(path).unwrap_or(()); [INFO] [stderr] 403 | return e; [INFO] [stderr] 404 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:403:13 [INFO] [stderr] | [INFO] [stderr] 403 | return e; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:529:5 [INFO] [stderr] | [INFO] [stderr] 529 | return file.write_all(&mem); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file.write_all(&mem)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:586:5 [INFO] [stderr] | [INFO] [stderr] 586 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:591:5 [INFO] [stderr] | [INFO] [stderr] 591 | return port.flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `port.flush()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:596:5 [INFO] [stderr] | [INFO] [stderr] 596 | return port.flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `port.flush()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:600:5 [INFO] [stderr] | [INFO] [stderr] 600 | return erase_flash(&mut port); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `erase_flash(&mut port)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:647:5 [INFO] [stderr] | [INFO] [stderr] 647 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:675:5 [INFO] [stderr] | [INFO] [stderr] 675 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:769:9 [INFO] [stderr] | [INFO] [stderr] 769 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:771:9 [INFO] [stderr] | [INFO] [stderr] 771 | return Err(Error::new(ErrorKind::Other, "Unexpected reply to ping")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::new(ErrorKind::Other, "Unexpected reply to ping"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:854:9 [INFO] [stderr] | [INFO] [stderr] 854 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:856:9 [INFO] [stderr] | [INFO] [stderr] 856 | return Err(Error::new(ErrorKind::Other, "Unexpected reply to ping")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::new(ErrorKind::Other, "Unexpected reply to ping"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:372:20 [INFO] [stderr] | [INFO] [stderr] 372 | if rom.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rom.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:474:25 [INFO] [stderr] | [INFO] [stderr] 474 | for bank in 1..(header_info.rom_banks + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=header_info.rom_banks` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:509:25 [INFO] [stderr] | [INFO] [stderr] 509 | for bank in 0..(header_info.ram_banks + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=header_info.ram_banks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:372:20 [INFO] [stderr] | [INFO] [stderr] 372 | if rom.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rom.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:474:25 [INFO] [stderr] | [INFO] [stderr] 474 | for bank in 1..(header_info.rom_banks + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=header_info.rom_banks` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:509:25 [INFO] [stderr] | [INFO] [stderr] 509 | for bank in 0..(header_info.ram_banks + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=header_info.ram_banks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.74s [INFO] running `"docker" "inspect" "eff40866d5b4f5049416f83487cdb70aa3dd2684acb142a1340bffb81d4fbb94"` [INFO] running `"docker" "rm" "-f" "eff40866d5b4f5049416f83487cdb70aa3dd2684acb142a1340bffb81d4fbb94"` [INFO] [stdout] eff40866d5b4f5049416f83487cdb70aa3dd2684acb142a1340bffb81d4fbb94