[INFO] updating cached repository Dhole/gb-link-host
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Dhole/gb-link-host
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Dhole/gb-link-host" "work/ex/clippy-test-run/sources/stable/gh/Dhole/gb-link-host"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Dhole/gb-link-host'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Dhole/gb-link-host" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dhole/gb-link-host"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dhole/gb-link-host'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a7610ddbacbd9d6d794ee39bbfe22f0cd8304b3e
[INFO] sha for GitHub repo Dhole/gb-link-host: a7610ddbacbd9d6d794ee39bbfe22f0cd8304b3e
[INFO] validating manifest of Dhole/gb-link-host on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Dhole/gb-link-host on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Dhole/gb-link-host
[INFO] finished frobbing Dhole/gb-link-host
[INFO] frobbed toml for Dhole/gb-link-host written to work/ex/clippy-test-run/sources/stable/gh/Dhole/gb-link-host/Cargo.toml
[INFO] started frobbing Dhole/gb-link-host
[INFO] finished frobbing Dhole/gb-link-host
[INFO] frobbed toml for Dhole/gb-link-host written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dhole/gb-link-host/Cargo.toml
[INFO] crate Dhole/gb-link-host has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Dhole/gb-link-host against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Dhole/gb-link-host:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c0eb999a6221a063daede28b328be8f119eadfcff9c85b9fa2d3585f4859e178
[INFO] running `"docker" "start" "-a" "c0eb999a6221a063daede28b328be8f119eadfcff9c85b9fa2d3585f4859e178"`
[INFO] [stderr]     Checking itertools v0.6.1
[INFO] [stderr]     Checking term_size v0.3.0
[INFO] [stderr]     Checking ioctl-rs v0.1.5
[INFO] [stderr]     Checking termios v0.2.2
[INFO] [stderr]     Checking serial-core v0.4.0
[INFO] [stderr]     Checking atty v0.2.2
[INFO] [stderr]     Checking deflate v0.7.15
[INFO] [stderr]     Checking num-bigint v0.1.40
[INFO] [stderr]     Checking textwrap v0.7.0
[INFO] [stderr]     Checking serial-unix v0.4.0
[INFO] [stderr]     Checking png v0.9.0
[INFO] [stderr]     Checking clap v2.26.0
[INFO] [stderr]     Checking serial v0.4.0
[INFO] [stderr]     Checking num-rational v0.1.39
[INFO] [stderr]     Checking num v0.1.40
[INFO] [stderr]     Checking image v0.15.0
[INFO] [stderr]     Checking gb-link v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded `()`
[INFO] [stderr]    --> src/main.rs:140:20
[INFO] [stderr]     |
[INFO] [stderr] 140 |             return ();
[INFO] [stderr]     |                    ^^ help: remove the `()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:286:9
[INFO] [stderr]     |
[INFO] [stderr] 286 | /         return self.checksum_error || self.printer_busy || self.image_data_full ||
[INFO] [stderr] 287 | |             self.unprocessed_data || self.packet_error || self.paper_jam ||
[INFO] [stderr] 288 | |             self.other_error || self.battery_too_low;
[INFO] [stderr]     | |_____________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 286 |         self.checksum_error || self.printer_busy || self.image_data_full ||
[INFO] [stderr] 287 |             self.unprocessed_data || self.packet_error || self.paper_jam ||
[INFO] [stderr] 288 |             self.other_error || self.battery_too_low
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:291:9
[INFO] [stderr]     |
[INFO] [stderr] 291 | /         return self.checksum_error ||
[INFO] [stderr] 292 | |                //self.printer_busy ||
[INFO] [stderr] 293 | |                //self.image_data_full ||
[INFO] [stderr] 294 | |                //self.unprocessed_data ||
[INFO] [stderr] 295 | |                self.packet_error || self.paper_jam || self.other_error ||
[INFO] [stderr] 296 | |             self.battery_too_low;
[INFO] [stderr]     | |_________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 291 |         self.checksum_error ||
[INFO] [stderr] 292 |                //self.printer_busy ||
[INFO] [stderr] 293 |                //self.image_data_full ||
[INFO] [stderr] 294 |                //self.unprocessed_data ||
[INFO] [stderr] 295 |                self.packet_error || self.paper_jam || self.other_error ||
[INFO] [stderr] 296 |             self.battery_too_low
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:414:5
[INFO] [stderr]     |
[INFO] [stderr] 414 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:435:5
[INFO] [stderr]     |
[INFO] [stderr] 435 |     return pixel_rows;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pixel_rows`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:439:5
[INFO] [stderr]     |
[INFO] [stderr] 439 |     return [(w & 0xff) as u8, ((w & 0xff00) >> 8) as u8];
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[(w & 0xff) as u8, ((w & 0xff00) >> 8) as u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:451:5
[INFO] [stderr]     |
[INFO] [stderr] 451 |     return u16_to_low_high(crc.0);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `u16_to_low_high(crc.0)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:481:9
[INFO] [stderr]     |
[INFO] [stderr] 481 |         return Ok(Some(PrinterStatus::from(ack_status[1])));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(PrinterStatus::from(ack_status[1])))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:483:9
[INFO] [stderr]     |
[INFO] [stderr] 483 |         return Ok(None);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:514:5
[INFO] [stderr]     |
[INFO] [stderr] 514 |     return tile_rows;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `tile_rows`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:581:5
[INFO] [stderr]     |
[INFO] [stderr] 581 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:644:5
[INFO] [stderr]     |
[INFO] [stderr] 644 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded `()`
[INFO] [stderr]    --> src/main.rs:140:20
[INFO] [stderr]     |
[INFO] [stderr] 140 |             return ();
[INFO] [stderr]     |                    ^^ help: remove the `()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:286:9
[INFO] [stderr]     |
[INFO] [stderr] 286 | /         return self.checksum_error || self.printer_busy || self.image_data_full ||
[INFO] [stderr] 287 | |             self.unprocessed_data || self.packet_error || self.paper_jam ||
[INFO] [stderr] 288 | |             self.other_error || self.battery_too_low;
[INFO] [stderr]     | |_____________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 286 |         self.checksum_error || self.printer_busy || self.image_data_full ||
[INFO] [stderr] 287 |             self.unprocessed_data || self.packet_error || self.paper_jam ||
[INFO] [stderr] 288 |             self.other_error || self.battery_too_low
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:291:9
[INFO] [stderr]     |
[INFO] [stderr] 291 | /         return self.checksum_error ||
[INFO] [stderr] 292 | |                //self.printer_busy ||
[INFO] [stderr] 293 | |                //self.image_data_full ||
[INFO] [stderr] 294 | |                //self.unprocessed_data ||
[INFO] [stderr] 295 | |                self.packet_error || self.paper_jam || self.other_error ||
[INFO] [stderr] 296 | |             self.battery_too_low;
[INFO] [stderr]     | |_________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 291 |         self.checksum_error ||
[INFO] [stderr] 292 |                //self.printer_busy ||
[INFO] [stderr] 293 |                //self.image_data_full ||
[INFO] [stderr] 294 |                //self.unprocessed_data ||
[INFO] [stderr] 295 |                self.packet_error || self.paper_jam || self.other_error ||
[INFO] [stderr] 296 |             self.battery_too_low
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:414:5
[INFO] [stderr]     |
[INFO] [stderr] 414 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:435:5
[INFO] [stderr]     |
[INFO] [stderr] 435 |     return pixel_rows;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pixel_rows`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:439:5
[INFO] [stderr]     |
[INFO] [stderr] 439 |     return [(w & 0xff) as u8, ((w & 0xff00) >> 8) as u8];
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[(w & 0xff) as u8, ((w & 0xff00) >> 8) as u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:451:5
[INFO] [stderr]     |
[INFO] [stderr] 451 |     return u16_to_low_high(crc.0);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `u16_to_low_high(crc.0)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:481:9
[INFO] [stderr]     |
[INFO] [stderr] 481 |         return Ok(Some(PrinterStatus::from(ack_status[1])));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(PrinterStatus::from(ack_status[1])))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:483:9
[INFO] [stderr]     |
[INFO] [stderr] 483 |         return Ok(None);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:514:5
[INFO] [stderr]     |
[INFO] [stderr] 514 |     return tile_rows;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `tile_rows`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:581:5
[INFO] [stderr]     |
[INFO] [stderr] 581 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:644:5
[INFO] [stderr]     |
[INFO] [stderr] 644 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 | /     match mode {
[INFO] [stderr] 50 | |         &Mode::Sniff => b's',
[INFO] [stderr] 51 | |         &Mode::Printer => b'p',
[INFO] [stderr] 52 | |         &Mode::Print => b'P',
[INFO] [stderr] 53 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 49 |     match *mode {
[INFO] [stderr] 50 |         Mode::Sniff => b's',
[INFO] [stderr] 51 |         Mode::Printer => b'p',
[INFO] [stderr] 52 |         Mode::Print => b'P',
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/main.rs:228:25
[INFO] [stderr]     |
[INFO] [stderr] 228 |     try!(port.write_all(&vec![mode_char(&mode)]));
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[mode_char(&mode)]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:245:13
[INFO] [stderr]     |
[INFO] [stderr] 245 |             format!("")
[INFO] [stderr]     |             ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:250:13
[INFO] [stderr]     |
[INFO] [stderr] 250 |             format!("")
[INFO] [stderr]     |             ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0x01`
[INFO] [stderr]    --> src/main.rs:303:34
[INFO] [stderr]     |
[INFO] [stderr] 303 |             checksum_error: (b & (0x01 << 0)) != 0,
[INFO] [stderr]     |                                  ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:344:19
[INFO] [stderr]     |
[INFO] [stderr] 344 |         let len = (args[1] as u16) + ((args[2] as u16) << 8);
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^ help: try: `u16::from(args[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:344:39
[INFO] [stderr]     |
[INFO] [stderr] 344 |         let len = (args[1] as u16) + ((args[2] as u16) << 8);
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^ help: try: `u16::from(args[2])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:382:16
[INFO] [stderr]     |
[INFO] [stderr] 382 |     tile_rows: &Vec<Vec<u8>>,
[INFO] [stderr]     |                ^^^^^^^^^^^^^ help: change this to: `&[Vec<u8>]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:383:19
[INFO] [stderr]     |
[INFO] [stderr] 383 |     palette_byte: &u8,
[INFO] [stderr]     |                   ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `k` is used to index `tile_pixel_row`
[INFO] [stderr]    --> src/main.rs:430:22
[INFO] [stderr]     |
[INFO] [stderr] 430 |             for k in 0..8 {
[INFO] [stderr]     |                      ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 430 |             for (k, <item>) in tile_pixel_row.iter().enumerate().take(8) {
[INFO] [stderr]     |                 ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:446:21
[INFO] [stderr]     |
[INFO] [stderr] 446 |     crc += Wrapping(len[0] as u16);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^ help: try: `u16::from(len[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:447:21
[INFO] [stderr]     |
[INFO] [stderr] 447 |     crc += Wrapping(len[1] as u16);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^ help: try: `u16::from(len[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:449:25
[INFO] [stderr]     |
[INFO] [stderr] 449 |         crc += Wrapping(*b as u16);
[INFO] [stderr]     |                         ^^^^^^^^^ help: try: `u16::from(*b)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:505:21
[INFO] [stderr]     |
[INFO] [stderr] 505 |                     lsb = lsb | (low << (7 - x));
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lsb |= (low << (7 - x))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:506:21
[INFO] [stderr]     |
[INFO] [stderr] 506 |                     msb = msb | (high << (7 - x));
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `msb |= (high << (7 - x))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:607:19
[INFO] [stderr]     |
[INFO] [stderr] 607 |     let height = (img.height() as f64 / 16.0).ceil() as u32 * 16;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(img.height())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 | /     match mode {
[INFO] [stderr] 50 | |         &Mode::Sniff => b's',
[INFO] [stderr] 51 | |         &Mode::Printer => b'p',
[INFO] [stderr] 52 | |         &Mode::Print => b'P',
[INFO] [stderr] 53 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 49 |     match *mode {
[INFO] [stderr] 50 |         Mode::Sniff => b's',
[INFO] [stderr] 51 |         Mode::Printer => b'p',
[INFO] [stderr] 52 |         Mode::Print => b'P',
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/main.rs:228:25
[INFO] [stderr]     |
[INFO] [stderr] 228 |     try!(port.write_all(&vec![mode_char(&mode)]));
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[mode_char(&mode)]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:245:13
[INFO] [stderr]     |
[INFO] [stderr] 245 |             format!("")
[INFO] [stderr]     |             ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:250:13
[INFO] [stderr]     |
[INFO] [stderr] 250 |             format!("")
[INFO] [stderr]     |             ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0x01`
[INFO] [stderr]    --> src/main.rs:303:34
[INFO] [stderr]     |
[INFO] [stderr] 303 |             checksum_error: (b & (0x01 << 0)) != 0,
[INFO] [stderr]     |                                  ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:344:19
[INFO] [stderr]     |
[INFO] [stderr] 344 |         let len = (args[1] as u16) + ((args[2] as u16) << 8);
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^ help: try: `u16::from(args[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:344:39
[INFO] [stderr]     |
[INFO] [stderr] 344 |         let len = (args[1] as u16) + ((args[2] as u16) << 8);
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^ help: try: `u16::from(args[2])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:382:16
[INFO] [stderr]     |
[INFO] [stderr] 382 |     tile_rows: &Vec<Vec<u8>>,
[INFO] [stderr]     |                ^^^^^^^^^^^^^ help: change this to: `&[Vec<u8>]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:383:19
[INFO] [stderr]     |
[INFO] [stderr] 383 |     palette_byte: &u8,
[INFO] [stderr]     |                   ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `k` is used to index `tile_pixel_row`
[INFO] [stderr]    --> src/main.rs:430:22
[INFO] [stderr]     |
[INFO] [stderr] 430 |             for k in 0..8 {
[INFO] [stderr]     |                      ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 430 |             for (k, <item>) in tile_pixel_row.iter().enumerate().take(8) {
[INFO] [stderr]     |                 ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:446:21
[INFO] [stderr]     |
[INFO] [stderr] 446 |     crc += Wrapping(len[0] as u16);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^ help: try: `u16::from(len[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:447:21
[INFO] [stderr]     |
[INFO] [stderr] 447 |     crc += Wrapping(len[1] as u16);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^ help: try: `u16::from(len[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:449:25
[INFO] [stderr]     |
[INFO] [stderr] 449 |         crc += Wrapping(*b as u16);
[INFO] [stderr]     |                         ^^^^^^^^^ help: try: `u16::from(*b)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:505:21
[INFO] [stderr]     |
[INFO] [stderr] 505 |                     lsb = lsb | (low << (7 - x));
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lsb |= (low << (7 - x))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:506:21
[INFO] [stderr]     |
[INFO] [stderr] 506 |                     msb = msb | (high << (7 - x));
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `msb |= (high << (7 - x))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:607:19
[INFO] [stderr]     |
[INFO] [stderr] 607 |     let height = (img.height() as f64 / 16.0).ceil() as u32 * 16;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(img.height())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 16.44s
[INFO] running `"docker" "inspect" "c0eb999a6221a063daede28b328be8f119eadfcff9c85b9fa2d3585f4859e178"`
[INFO] running `"docker" "rm" "-f" "c0eb999a6221a063daede28b328be8f119eadfcff9c85b9fa2d3585f4859e178"`
[INFO] [stdout] c0eb999a6221a063daede28b328be8f119eadfcff9c85b9fa2d3585f4859e178