[INFO] updating cached repository Devolutions/qui-vive-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Devolutions/qui-vive-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Devolutions/qui-vive-rs" "work/ex/clippy-test-run/sources/stable/gh/Devolutions/qui-vive-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Devolutions/qui-vive-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Devolutions/qui-vive-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Devolutions/qui-vive-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Devolutions/qui-vive-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f1724187d5de07606a9286f439f660a6110e3bfe [INFO] sha for GitHub repo Devolutions/qui-vive-rs: f1724187d5de07606a9286f439f660a6110e3bfe [INFO] validating manifest of Devolutions/qui-vive-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Devolutions/qui-vive-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Devolutions/qui-vive-rs [INFO] finished frobbing Devolutions/qui-vive-rs [INFO] frobbed toml for Devolutions/qui-vive-rs written to work/ex/clippy-test-run/sources/stable/gh/Devolutions/qui-vive-rs/Cargo.toml [INFO] started frobbing Devolutions/qui-vive-rs [INFO] finished frobbing Devolutions/qui-vive-rs [INFO] frobbed toml for Devolutions/qui-vive-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Devolutions/qui-vive-rs/Cargo.toml [INFO] crate Devolutions/qui-vive-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Devolutions/qui-vive-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Devolutions/qui-vive-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 823bbc4687c3ca22f8490feca2143c7b593e25437f73d621fb5a10d3823d415b [INFO] running `"docker" "start" "-a" "823bbc4687c3ca22f8490feca2143c7b593e25437f73d621fb5a10d3823d415b"` [INFO] [stderr] Checking dns-lookup v0.9.0 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Compiling syn v0.13.4 [INFO] [stderr] Checking redis v0.8.0 [INFO] [stderr] Checking mouscache v0.4.7 [INFO] [stderr] Compiling mouscache_derive v0.4.0 [INFO] [stderr] Checking qui-vive v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:154:89 [INFO] [stderr] | [INFO] [stderr] 154 | let entry = QuiViveEntry { id: id.clone(), val: "".to_string(), url: url }; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:154:89 [INFO] [stderr] | [INFO] [stderr] 154 | let entry = QuiViveEntry { id: id.clone(), val: "".to_string(), url: url }; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/service.rs:65:51 [INFO] [stderr] | [INFO] [stderr] 65 | static ref RE_KEY: Regex = Regex::new(r"^/key$").unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `==` on `str`s [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/service.rs:67:51 [INFO] [stderr] | [INFO] [stderr] 67 | static ref RE_URL: Regex = Regex::new(r"^/url$").unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `==` on `str`s [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/service.rs:69:51 [INFO] [stderr] | [INFO] [stderr] 69 | static ref RE_INV: Regex = Regex::new(r"^/inv$").unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `==` on `str`s [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/service.rs:74:20 [INFO] [stderr] | [INFO] [stderr] 74 | let path = request.path().clone().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 74 | let path = &(*request.path()).clone().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 74 | let path = &str::clone(request.path()).to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/service.rs:84:24 [INFO] [stderr] | [INFO] [stderr] 84 | if let Ok(_) = cache.insert(id.clone(), entry.clone()) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 85 | | match cache.get::(id.clone()) { [INFO] [stderr] 86 | | Ok(Some(ref entry)) if entry.val.eq(&input) => { [INFO] [stderr] 87 | | Box::new(futures::future::ok(Response::new() [INFO] [stderr] ... | [INFO] [stderr] 97 | | .with_status(StatusCode::InternalServerError))) [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________________- help: try this: `if cache.insert(id.clone(), entry.clone()).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/service.rs:110:32 [INFO] [stderr] | [INFO] [stderr] 110 | if let Ok(_) = cache.insert(id.clone(), entry.clone()) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 111 | | Response::new() [INFO] [stderr] 112 | | .with_status(StatusCode::Ok) [INFO] [stderr] 113 | | .with_header(ContentType(mime::TEXT_PLAIN_UTF_8)) [INFO] [stderr] ... | [INFO] [stderr] 117 | | .with_status(StatusCode::InternalServerError) [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________________________- help: try this: `if cache.insert(id.clone(), entry.clone()).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/service.rs:157:32 [INFO] [stderr] | [INFO] [stderr] 157 | if let Ok(_) = cache.insert(id.clone(), entry.clone()) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 158 | | Response::new() [INFO] [stderr] 159 | | .with_status(StatusCode::Ok) [INFO] [stderr] 160 | | .with_header(ContentType(mime::TEXT_PLAIN_UTF_8)) [INFO] [stderr] ... | [INFO] [stderr] 164 | | .with_status(StatusCode::InternalServerError) [INFO] [stderr] 165 | | } [INFO] [stderr] | |_________________________- help: try this: `if cache.insert(id.clone(), entry.clone()).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/service.rs:213:36 [INFO] [stderr] | [INFO] [stderr] 213 | if let Ok(_) = cache.insert(id.clone(), entry.clone()) { [INFO] [stderr] | _____________________________- ^^^^^ [INFO] [stderr] 214 | | Response::new() [INFO] [stderr] 215 | | .with_status(StatusCode::Ok) [INFO] [stderr] 216 | | .with_header(ContentType(mime::TEXT_PLAIN_UTF_8)) [INFO] [stderr] ... | [INFO] [stderr] 220 | | .with_status(StatusCode::InternalServerError) [INFO] [stderr] 221 | | } [INFO] [stderr] | |_____________________________- help: try this: `if cache.insert(id.clone(), entry.clone()).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | fn new_cache(ref cfg: &config::QuiViveConfig) -> std::result::Result { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:36:11 [INFO] [stderr] | [INFO] [stderr] 36 | match cache_type.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `cache_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/service.rs:65:51 [INFO] [stderr] | [INFO] [stderr] 65 | static ref RE_KEY: Regex = Regex::new(r"^/key$").unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `==` on `str`s [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/service.rs:67:51 [INFO] [stderr] | [INFO] [stderr] 67 | static ref RE_URL: Regex = Regex::new(r"^/url$").unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `==` on `str`s [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/service.rs:69:51 [INFO] [stderr] | [INFO] [stderr] 69 | static ref RE_INV: Regex = Regex::new(r"^/inv$").unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `==` on `str`s [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] error: Could not compile `qui-vive`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/service.rs:74:20 [INFO] [stderr] | [INFO] [stderr] 74 | let path = request.path().clone().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 74 | let path = &(*request.path()).clone().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 74 | let path = &str::clone(request.path()).to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/service.rs:84:24 [INFO] [stderr] | [INFO] [stderr] 84 | if let Ok(_) = cache.insert(id.clone(), entry.clone()) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 85 | | match cache.get::(id.clone()) { [INFO] [stderr] 86 | | Ok(Some(ref entry)) if entry.val.eq(&input) => { [INFO] [stderr] 87 | | Box::new(futures::future::ok(Response::new() [INFO] [stderr] ... | [INFO] [stderr] 97 | | .with_status(StatusCode::InternalServerError))) [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________________- help: try this: `if cache.insert(id.clone(), entry.clone()).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/service.rs:110:32 [INFO] [stderr] | [INFO] [stderr] 110 | if let Ok(_) = cache.insert(id.clone(), entry.clone()) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 111 | | Response::new() [INFO] [stderr] 112 | | .with_status(StatusCode::Ok) [INFO] [stderr] 113 | | .with_header(ContentType(mime::TEXT_PLAIN_UTF_8)) [INFO] [stderr] ... | [INFO] [stderr] 117 | | .with_status(StatusCode::InternalServerError) [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________________________- help: try this: `if cache.insert(id.clone(), entry.clone()).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/service.rs:157:32 [INFO] [stderr] | [INFO] [stderr] 157 | if let Ok(_) = cache.insert(id.clone(), entry.clone()) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 158 | | Response::new() [INFO] [stderr] 159 | | .with_status(StatusCode::Ok) [INFO] [stderr] 160 | | .with_header(ContentType(mime::TEXT_PLAIN_UTF_8)) [INFO] [stderr] ... | [INFO] [stderr] 164 | | .with_status(StatusCode::InternalServerError) [INFO] [stderr] 165 | | } [INFO] [stderr] | |_________________________- help: try this: `if cache.insert(id.clone(), entry.clone()).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/service.rs:213:36 [INFO] [stderr] | [INFO] [stderr] 213 | if let Ok(_) = cache.insert(id.clone(), entry.clone()) { [INFO] [stderr] | _____________________________- ^^^^^ [INFO] [stderr] 214 | | Response::new() [INFO] [stderr] 215 | | .with_status(StatusCode::Ok) [INFO] [stderr] 216 | | .with_header(ContentType(mime::TEXT_PLAIN_UTF_8)) [INFO] [stderr] ... | [INFO] [stderr] 220 | | .with_status(StatusCode::InternalServerError) [INFO] [stderr] 221 | | } [INFO] [stderr] | |_____________________________- help: try this: `if cache.insert(id.clone(), entry.clone()).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/main.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | fn new_cache(ref cfg: &config::QuiViveConfig) -> std::result::Result { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:36:11 [INFO] [stderr] | [INFO] [stderr] 36 | match cache_type.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `cache_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `qui-vive`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "823bbc4687c3ca22f8490feca2143c7b593e25437f73d621fb5a10d3823d415b"` [INFO] running `"docker" "rm" "-f" "823bbc4687c3ca22f8490feca2143c7b593e25437f73d621fb5a10d3823d415b"` [INFO] [stdout] 823bbc4687c3ca22f8490feca2143c7b593e25437f73d621fb5a10d3823d415b