[INFO] updating cached repository DevOrc/mazer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DevOrc/mazer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DevOrc/mazer" "work/ex/clippy-test-run/sources/stable/gh/DevOrc/mazer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DevOrc/mazer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DevOrc/mazer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DevOrc/mazer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DevOrc/mazer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c4a397f20d6cc9adaab0dfb02edd96f6edef0f75 [INFO] sha for GitHub repo DevOrc/mazer: c4a397f20d6cc9adaab0dfb02edd96f6edef0f75 [INFO] validating manifest of DevOrc/mazer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DevOrc/mazer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DevOrc/mazer [INFO] finished frobbing DevOrc/mazer [INFO] frobbed toml for DevOrc/mazer written to work/ex/clippy-test-run/sources/stable/gh/DevOrc/mazer/Cargo.toml [INFO] started frobbing DevOrc/mazer [INFO] finished frobbing DevOrc/mazer [INFO] frobbed toml for DevOrc/mazer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DevOrc/mazer/Cargo.toml [INFO] crate DevOrc/mazer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DevOrc/mazer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DevOrc/mazer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c34774a4d5a49424f04d74712d77b8473bf499f6f89738e362406491baa1ca01 [INFO] running `"docker" "start" "-a" "c34774a4d5a49424f04d74712d77b8473bf499f6f89738e362406491baa1ca01"` [INFO] [stderr] Checking png v0.9.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking image v0.15.0 [INFO] [stderr] Checking mazer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:34:23 [INFO] [stderr] | [INFO] [stderr] 34 | super::MazeConfig {entrance: entrance, exit: exit, cells: cells} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `entrance` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:34:43 [INFO] [stderr] | [INFO] [stderr] 34 | super::MazeConfig {entrance: entrance, exit: exit, cells: cells} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `exit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:34:55 [INFO] [stderr] | [INFO] [stderr] 34 | super::MazeConfig {entrance: entrance, exit: exit, cells: cells} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cells` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:70:22 [INFO] [stderr] | [INFO] [stderr] 70 | return Cell {x: x, y: y, open: true}; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:70:28 [INFO] [stderr] | [INFO] [stderr] 70 | return Cell {x: x, y: y, open: true}; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:72:22 [INFO] [stderr] | [INFO] [stderr] 72 | return Cell {x: x, y: y, open: false}; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:72:28 [INFO] [stderr] | [INFO] [stderr] 72 | return Cell {x: x, y: y, open: false}; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:92:16 [INFO] [stderr] | [INFO] [stderr] 92 | MazeImage {width: width, height: height, image: im} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:92:30 [INFO] [stderr] | [INFO] [stderr] 92 | MazeImage {width: width, height: height, image: im} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:34:23 [INFO] [stderr] | [INFO] [stderr] 34 | super::MazeConfig {entrance: entrance, exit: exit, cells: cells} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `entrance` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:34:43 [INFO] [stderr] | [INFO] [stderr] 34 | super::MazeConfig {entrance: entrance, exit: exit, cells: cells} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `exit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:34:55 [INFO] [stderr] | [INFO] [stderr] 34 | super::MazeConfig {entrance: entrance, exit: exit, cells: cells} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cells` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:70:22 [INFO] [stderr] | [INFO] [stderr] 70 | return Cell {x: x, y: y, open: true}; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:70:28 [INFO] [stderr] | [INFO] [stderr] 70 | return Cell {x: x, y: y, open: true}; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:72:22 [INFO] [stderr] | [INFO] [stderr] 72 | return Cell {x: x, y: y, open: false}; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:72:28 [INFO] [stderr] | [INFO] [stderr] 72 | return Cell {x: x, y: y, open: false}; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:92:16 [INFO] [stderr] | [INFO] [stderr] 92 | MazeImage {width: width, height: height, image: im} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:92:30 [INFO] [stderr] | [INFO] [stderr] 92 | MazeImage {width: width, height: height, image: im} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `maze_map` [INFO] [stderr] --> src/lib.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | let maze_map = parser::parse(maze_data); [INFO] [stderr] | ^^^^^^^^ help: consider using `_maze_map` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/reader.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | fn calc_entrance_exit(cells: &Vec>, config: &MazeImage) -> ((u32, u32), (u32, u32)){ [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `cells` [INFO] [stderr] --> src/reader.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | for x in 0..config.width as usize{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 41 | for (x, ) in cells.iter().enumerate().take(config.width as usize){ [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `cells` [INFO] [stderr] --> src/reader.rs:47:14 [INFO] [stderr] | [INFO] [stderr] 47 | for x in 0..config.width as usize{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 47 | for (x, ) in cells.iter().enumerate().take(config.width as usize){ [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:21:51 [INFO] [stderr] | [INFO] [stderr] 21 | fn create_connections(nodes: &mut MazeMap, cells: &Cells, width: usize, height: usize){ [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:30:58 [INFO] [stderr] | [INFO] [stderr] 30 | fn find_connection(dir: Direction, coord: &Coord, cells: &Cells, width: usize, height: usize) -> Option { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parser.rs:30:43 [INFO] [stderr] | [INFO] [stderr] 30 | fn find_connection(dir: Direction, coord: &Coord, cells: &Cells, width: usize, height: usize) -> Option { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Coord` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:58:40 [INFO] [stderr] | [INFO] [stderr] 58 | fn get_node(x: isize, y: isize, cells: &Cells, width: isize, height: isize) -> Option{ [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:73:22 [INFO] [stderr] | [INFO] [stderr] 73 | fn find_nodes(cells: &Cells, width: usize, height: usize, config: MazeConfig) -> MazeMap{ [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/parser.rs:89:16 [INFO] [stderr] | [INFO] [stderr] 89 | if current.open == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!current.open` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/parser.rs:110:64 [INFO] [stderr] | [INFO] [stderr] 110 | }else if north.open && south.open && east.open && west.open{ [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 111 | | return true; [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/parser.rs:108:42 [INFO] [stderr] | [INFO] [stderr] 108 | if vertical_block || horizontal_block{ [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 109 | | return true; [INFO] [stderr] 110 | | }else if north.open && south.open && east.open && west.open{ [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Node` [INFO] [stderr] --> src/lib.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Node{ [INFO] [stderr] 13 | | Node {connections: Vec::with_capacity(4)} [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn print_maze(cells: &Vec>, width: usize, height: usize){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `cells`. [INFO] [stderr] --> src/lib.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | for x in 0..width { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 52 | for in cells.iter().take(width) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `mazer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `maze_map` [INFO] [stderr] --> src/lib.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | let maze_map = parser::parse(maze_data); [INFO] [stderr] | ^^^^^^^^ help: consider using `_maze_map` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/reader.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | fn calc_entrance_exit(cells: &Vec>, config: &MazeImage) -> ((u32, u32), (u32, u32)){ [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `cells` [INFO] [stderr] --> src/reader.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | for x in 0..config.width as usize{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 41 | for (x, ) in cells.iter().enumerate().take(config.width as usize){ [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `cells` [INFO] [stderr] --> src/reader.rs:47:14 [INFO] [stderr] | [INFO] [stderr] 47 | for x in 0..config.width as usize{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 47 | for (x, ) in cells.iter().enumerate().take(config.width as usize){ [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:21:51 [INFO] [stderr] | [INFO] [stderr] 21 | fn create_connections(nodes: &mut MazeMap, cells: &Cells, width: usize, height: usize){ [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:30:58 [INFO] [stderr] | [INFO] [stderr] 30 | fn find_connection(dir: Direction, coord: &Coord, cells: &Cells, width: usize, height: usize) -> Option { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parser.rs:30:43 [INFO] [stderr] | [INFO] [stderr] 30 | fn find_connection(dir: Direction, coord: &Coord, cells: &Cells, width: usize, height: usize) -> Option { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Coord` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:58:40 [INFO] [stderr] | [INFO] [stderr] 58 | fn get_node(x: isize, y: isize, cells: &Cells, width: isize, height: isize) -> Option{ [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:73:22 [INFO] [stderr] | [INFO] [stderr] 73 | fn find_nodes(cells: &Cells, width: usize, height: usize, config: MazeConfig) -> MazeMap{ [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/parser.rs:89:16 [INFO] [stderr] | [INFO] [stderr] 89 | if current.open == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!current.open` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/parser.rs:110:64 [INFO] [stderr] | [INFO] [stderr] 110 | }else if north.open && south.open && east.open && west.open{ [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 111 | | return true; [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/parser.rs:108:42 [INFO] [stderr] | [INFO] [stderr] 108 | if vertical_block || horizontal_block{ [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 109 | | return true; [INFO] [stderr] 110 | | }else if north.open && south.open && east.open && west.open{ [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Node` [INFO] [stderr] --> src/lib.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Node{ [INFO] [stderr] 13 | | Node {connections: Vec::with_capacity(4)} [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn print_maze(cells: &Vec>, width: usize, height: usize){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `cells`. [INFO] [stderr] --> src/lib.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | for x in 0..width { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 52 | for in cells.iter().take(width) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `mazer`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c34774a4d5a49424f04d74712d77b8473bf499f6f89738e362406491baa1ca01"` [INFO] running `"docker" "rm" "-f" "c34774a4d5a49424f04d74712d77b8473bf499f6f89738e362406491baa1ca01"` [INFO] [stdout] c34774a4d5a49424f04d74712d77b8473bf499f6f89738e362406491baa1ca01