[INFO] updating cached repository DevOrc/aurora [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DevOrc/aurora [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DevOrc/aurora" "work/ex/clippy-test-run/sources/stable/gh/DevOrc/aurora"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DevOrc/aurora'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DevOrc/aurora" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DevOrc/aurora"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DevOrc/aurora'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8179321306a637ab6601429cc0e747f276e7c48f [INFO] sha for GitHub repo DevOrc/aurora: 8179321306a637ab6601429cc0e747f276e7c48f [INFO] validating manifest of DevOrc/aurora on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DevOrc/aurora on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DevOrc/aurora [INFO] finished frobbing DevOrc/aurora [INFO] frobbed toml for DevOrc/aurora written to work/ex/clippy-test-run/sources/stable/gh/DevOrc/aurora/Cargo.toml [INFO] started frobbing DevOrc/aurora [INFO] finished frobbing DevOrc/aurora [INFO] frobbed toml for DevOrc/aurora written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DevOrc/aurora/Cargo.toml [INFO] crate DevOrc/aurora has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DevOrc/aurora against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DevOrc/aurora:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] df42ec00ca2995c8e8f39185b6102a05ebec2c386dedab350c9c5183a1d77e50 [INFO] running `"docker" "start" "-a" "df42ec00ca2995c8e8f39185b6102a05ebec2c386dedab350c9c5183a1d77e50"` [INFO] [stderr] Checking smallvec v0.6.5 [INFO] [stderr] Checking aurora v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Compiling terminfo v0.6.1 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/expr.rs:40:43 [INFO] [stderr] | [INFO] [stderr] 40 | ExprParser {tokens: tokens_deque, expr_type: expr_type, line} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expr_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/expr.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | Ok(Expr{expr_type: expr_type, stmts: parser.parse()?}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expr_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/function.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | LuaFunc{arg_defs: arg_defs, stmts: stmts} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `arg_defs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter/function.rs:16:37 [INFO] [stderr] | [INFO] [stderr] 16 | LuaFunc{arg_defs: arg_defs, stmts: stmts} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stmts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:186:16 [INFO] [stderr] | [INFO] [stderr] 186 | Aurora{interpreter: interpreter, config: config} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interpreter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:186:42 [INFO] [stderr] | [INFO] [stderr] 186 | Aurora{interpreter: interpreter, config: config} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/scanner.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | return Ok(Token::Equal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::Equal)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/parser/expr.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | token [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/parser/expr.rs:171:21 [INFO] [stderr] | [INFO] [stderr] 171 | let token = self.tokens.pop_front(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/mod.rs:67:27 [INFO] [stderr] | [INFO] [stderr] 67 | Token::EOF => return Ok(Stmt {location, stmt_type : StmtType::EOF}), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Stmt {location, stmt_type : StmtType::EOF})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/interpreter/table.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | data [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/interpreter/table.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | let data = Table{vars : HashMap::new()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter/mod.rs:413:9 [INFO] [stderr] | [INFO] [stderr] 413 | return Ok(LuaData::Bool(right.to_string() == left.to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(LuaData::Bool(right.to_string() == left.to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/scanner.rs:38:12 [INFO] [stderr] | [INFO] [stderr] 38 | if errors.len() > 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/scanner.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | let line = self.line_num.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.line_num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/scanner.rs:47:25 [INFO] [stderr] | [INFO] [stderr] 47 | let next_char = self.advance_character().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.advance_character()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/scanner.rs:174:20 [INFO] [stderr] | [INFO] [stderr] 174 | let line = self.line_num.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.line_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser/scanner.rs:182:26 [INFO] [stderr] | [INFO] [stderr] 182 | return error(format!("File cannot end with character '.'"), line); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"File cannot end with character '.'".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser/mod.rs:154:34 [INFO] [stderr] | [INFO] [stderr] 154 | None => return error(format!("Expected to find function name but found None"), self.line), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected to find function name but found None".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser/mod.rs:222:19 [INFO] [stderr] | [INFO] [stderr] 222 | error(format!("Files cannot end with identifiers!"), self.line) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Files cannot end with identifiers!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser/mod.rs:255:34 [INFO] [stderr] | [INFO] [stderr] 255 | None => return error(format!("Expected token following keyword local, but found None!"), self.line) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected token following keyword local, but found None!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser/mod.rs:260:34 [INFO] [stderr] | [INFO] [stderr] 260 | None => return error(format!("Expected token '=' but found None!"), self.line) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected token '=' but found None!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/mod.rs:294:12 [INFO] [stderr] | [INFO] [stderr] 294 | if tokens.len() > 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/interpreter/function.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | if let Some(_) = interpreter.return_val{ [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 28 | | break; [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____________- help: try this: `if interpreter.return_val.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/interpreter/function.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | let name = match self.arg_defs.get(x).unwrap(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.arg_defs[x]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/interpreter/function.rs:44:47 [INFO] [stderr] | [INFO] [stderr] 44 | interpreter.assign_variable(name, data.get(x).unwrap().clone(), true)? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `data[x]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `interpreter::table::Table` [INFO] [stderr] --> src/interpreter/table.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Table{ [INFO] [stderr] 12 | | let data = Table{vars : HashMap::new()}; [INFO] [stderr] 13 | | [INFO] [stderr] 14 | | data [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/interpreter/library.rs:27:33 [INFO] [stderr] | [INFO] [stderr] 27 | let message = match args.get(0).unwrap(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter/library.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | Err(interpreter.error(format!("{}", message))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `message.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/interpreter/library.rs:40:30 [INFO] [stderr] | [INFO] [stderr] 40 | let path = match args.get(0).unwrap(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `interpreter::Interpreter` [INFO] [stderr] --> src/interpreter/mod.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Interpreter{ [INFO] [stderr] 32 | | Interpreter { [INFO] [stderr] 33 | | funcs: HashMap::new(), [INFO] [stderr] 34 | | func_names: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/interpreter/mod.rs:177:16 [INFO] [stderr] | [INFO] [stderr] 177 | if let Some(_) = self.return_val{ [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 178 | | return Ok(()); [INFO] [stderr] 179 | | } [INFO] [stderr] | |_________- help: try this: `if self.return_val.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/interpreter/mod.rs:206:55 [INFO] [stderr] | [INFO] [stderr] 206 | fn handle_func_def(&mut self, name: &Token, args: &Vec, stmts: &Vec) -> Result<(), LuaError>{ [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/interpreter/mod.rs:206:75 [INFO] [stderr] | [INFO] [stderr] 206 | fn handle_func_def(&mut self, name: &Token, args: &Vec, stmts: &Vec) -> Result<(), LuaError>{ [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Stmt]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/interpreter/mod.rs:261:45 [INFO] [stderr] | [INFO] [stderr] 261 | fn handle_for_incr(&mut self, var_name: &String, incr: f64) -> Result<(), LuaError>{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/interpreter/mod.rs:270:44 [INFO] [stderr] | [INFO] [stderr] 270 | fn check_for_loop(&mut self, var_name: &String, end_val: &LuaData) -> Result{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/interpreter/mod.rs:318:20 [INFO] [stderr] | [INFO] [stderr] 318 | let stmt = expr.stmts.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&expr.stmts[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/interpreter/mod.rs:327:47 [INFO] [stderr] | [INFO] [stderr] 327 | fn evaluate_value_expr(&mut self, tokens: &Vec) -> Result{ [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/interpreter/mod.rs:328:27 [INFO] [stderr] | [INFO] [stderr] 328 | let first_token = tokens.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interpreter/mod.rs:331:56 [INFO] [stderr] | [INFO] [stderr] 331 | Token::NumberLiteral(x) => LuaData::Number(x.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Checking smallstr v0.1.0 [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter/mod.rs:345:43 [INFO] [stderr] | [INFO] [stderr] 345 | return Err(self.error(format!("Failed to parse value for left curly brace!"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failed to parse value for left curly brace!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/interpreter/mod.rs:397:48 [INFO] [stderr] | [INFO] [stderr] 397 | BinOp::EqualEqual => LuaData::Bool(left_num == right_num), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(left_num - right_num).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/interpreter/mod.rs:397:48 [INFO] [stderr] | [INFO] [stderr] 397 | BinOp::EqualEqual => LuaData::Bool(left_num == right_num), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/interpreter/mod.rs:454:51 [INFO] [stderr] | [INFO] [stderr] 454 | fn get_function_id_from_identifier(&self, id: &String) -> Result{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/interpreter/mod.rs:489:13 [INFO] [stderr] | [INFO] [stderr] 489 | / match self.return_val{ [INFO] [stderr] 490 | | Some(LuaData::Table(_)) => break, [INFO] [stderr] 491 | | _ => (), [INFO] [stderr] 492 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(LuaData::Table(_)) = self.return_val { break }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/interpreter/mod.rs:579:9 [INFO] [stderr] | [INFO] [stderr] 579 | / match interpreter.run_stmt(&mut stmt){ [INFO] [stderr] 580 | | Err(e) => return Err(e), [INFO] [stderr] 581 | | _ => (), [INFO] [stderr] 582 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = interpreter.run_stmt(&mut stmt) { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:146:33 [INFO] [stderr] | [INFO] [stderr] 146 | pub fn count_stmts_recur(stmts: &Vec) -> u32{ [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Stmt]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | / match self.run_stmts(&mut stmts){ [INFO] [stderr] 204 | | Err(e) => return Err(vec![e]), [INFO] [stderr] 205 | | _ => (), [INFO] [stderr] 206 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.run_stmts(&mut stmts) { return Err(vec![e]) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:227:40 [INFO] [stderr] | [INFO] [stderr] 227 | fn print_token_info(&self, tokens: &Vec){ [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:238:38 [INFO] [stderr] | [INFO] [stderr] 238 | fn print_stmt_info(&self, stmts: &Vec){ [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Stmt]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `aurora`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "df42ec00ca2995c8e8f39185b6102a05ebec2c386dedab350c9c5183a1d77e50"` [INFO] running `"docker" "rm" "-f" "df42ec00ca2995c8e8f39185b6102a05ebec2c386dedab350c9c5183a1d77e50"` [INFO] [stdout] df42ec00ca2995c8e8f39185b6102a05ebec2c386dedab350c9c5183a1d77e50