[INFO] updating cached repository Derek-Robert-Games/doubletet [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Derek-Robert-Games/doubletet [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Derek-Robert-Games/doubletet" "work/ex/clippy-test-run/sources/stable/gh/Derek-Robert-Games/doubletet"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Derek-Robert-Games/doubletet'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Derek-Robert-Games/doubletet" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Derek-Robert-Games/doubletet"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Derek-Robert-Games/doubletet'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ec1f38f8b5101d102463b7e9f0f0015ade163ad0 [INFO] sha for GitHub repo Derek-Robert-Games/doubletet: ec1f38f8b5101d102463b7e9f0f0015ade163ad0 [INFO] validating manifest of Derek-Robert-Games/doubletet on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Derek-Robert-Games/doubletet on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Derek-Robert-Games/doubletet [INFO] finished frobbing Derek-Robert-Games/doubletet [INFO] frobbed toml for Derek-Robert-Games/doubletet written to work/ex/clippy-test-run/sources/stable/gh/Derek-Robert-Games/doubletet/Cargo.toml [INFO] started frobbing Derek-Robert-Games/doubletet [INFO] finished frobbing Derek-Robert-Games/doubletet [INFO] frobbed toml for Derek-Robert-Games/doubletet written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Derek-Robert-Games/doubletet/Cargo.toml [INFO] crate Derek-Robert-Games/doubletet has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Derek-Robert-Games/doubletet against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Derek-Robert-Games/doubletet:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f17de49776b04bed10faf1dd0b13eacc78bf932d554e9fc9f55ed276a9a09e48 [INFO] running `"docker" "start" "-a" "f17de49776b04bed10faf1dd0b13eacc78bf932d554e9fc9f55ed276a9a09e48"` [INFO] [stderr] Checking serde v1.0.46 [INFO] [stderr] Checking inflate v0.4.3 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Compiling serde_derive v1.0.46 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking shrev v1.0.1 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking hibitset v0.5.0 [INFO] [stderr] Checking shred v0.7.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking specs v0.12.0 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking glutin v0.14.0 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking piston_window v0.80.0 [INFO] [stderr] Checking double-tetris v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:49:61 [INFO] [stderr] | [INFO] [stderr] 49 | .with_thread_local(sys::piston_wrap::PistonWrapper{ window: window }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:49:61 [INFO] [stderr] | [INFO] [stderr] 49 | .with_thread_local(sys::piston_wrap::PistonWrapper{ window: window }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/sys/movement.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | / if actions.move_right { [INFO] [stderr] 29 | | if secs_since_move > settings::MAX_MOVE_SPEED { [INFO] [stderr] 30 | | pos.x = pos.x + settings::RECT_WIDTH; [INFO] [stderr] 31 | | if pos.x > (window_width - settings::RECT_WIDTH) { [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | if actions.move_right && secs_since_move > settings::MAX_MOVE_SPEED { [INFO] [stderr] 29 | pos.x = pos.x + settings::RECT_WIDTH; [INFO] [stderr] 30 | if pos.x > (window_width - settings::RECT_WIDTH) { [INFO] [stderr] 31 | pos.x = 0.0; [INFO] [stderr] 32 | } [INFO] [stderr] 33 | clock.last_player_move = Instant::now(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/sys/movement.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | / if actions.move_left { [INFO] [stderr] 38 | | if secs_since_move > settings::MAX_MOVE_SPEED { [INFO] [stderr] 39 | | pos.x = pos.x - settings::RECT_HEIGHT; [INFO] [stderr] 40 | | if pos.x < 0.0 { [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 37 | if actions.move_left && secs_since_move > settings::MAX_MOVE_SPEED { [INFO] [stderr] 38 | pos.x = pos.x - settings::RECT_HEIGHT; [INFO] [stderr] 39 | if pos.x < 0.0 { [INFO] [stderr] 40 | pos.x = window_width - settings::RECT_WIDTH [INFO] [stderr] 41 | } [INFO] [stderr] 42 | clock.last_player_move = Instant::now(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/sys/spawn.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / if secs_since_spawn > settings::MAX_SPAWN_SPEED { [INFO] [stderr] 25 | | if actions.spawn_block { [INFO] [stderr] 26 | | let new_block = entities.create(); [INFO] [stderr] 27 | | updater.insert( [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 24 | if secs_since_spawn > settings::MAX_SPAWN_SPEED && actions.spawn_block { [INFO] [stderr] 25 | let new_block = entities.create(); [INFO] [stderr] 26 | updater.insert( [INFO] [stderr] 27 | new_block, [INFO] [stderr] 28 | c::Dimensions { [INFO] [stderr] 29 | width: settings::RECT_WIDTH, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:27:39 [INFO] [stderr] | [INFO] [stderr] 27 | pub const NANOS_PER_SECOND: f64 = 1000000000.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/sys/drop.rs:10:23 [INFO] [stderr] | [INFO] [stderr] 10 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 11 | | WriteStorage<'a, c::Active>, [INFO] [stderr] 12 | | WriteStorage<'a, c::Position>, [INFO] [stderr] 13 | | WriteExpect<'a, r::Clock>, [INFO] [stderr] ... | [INFO] [stderr] 16 | | ReadExpect<'a, r::GameMap>, [INFO] [stderr] 17 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sys/drop.rs:27:31 [INFO] [stderr] | [INFO] [stderr] 27 | let y_delta = time_since_drop.subsec_nanos() as f64 * drop_speed.0 / settings::NANOS_PER_SECOND; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(time_since_drop.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sys/drop.rs:28:45 [INFO] [stderr] | [INFO] [stderr] 28 | pos.y = (pos.y + y_delta) % (settings::WINDOW_HEIGHT as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(settings::WINDOW_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sys/drop.rs:33:37 [INFO] [stderr] | [INFO] [stderr] 33 | None => (settings::WINDOW_HEIGHT as f64) - (settings::RECT_HEIGHT) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(settings::WINDOW_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sys/movement.rs:22:48 [INFO] [stderr] | [INFO] [stderr] 22 | time_since_move.as_secs() as f64 + time_since_move.subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(time_since_move.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sys/movement.rs:30:25 [INFO] [stderr] | [INFO] [stderr] 30 | pos.x = pos.x + settings::RECT_WIDTH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pos.x += settings::RECT_WIDTH` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sys/movement.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | pos.x = pos.x - settings::RECT_HEIGHT; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pos.x -= settings::RECT_HEIGHT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sys/spawn.rs:22:49 [INFO] [stderr] | [INFO] [stderr] 22 | time_since_spawn.as_secs() as f64 + time_since_spawn.subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(time_since_spawn.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/sys/piston_wrap.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 13 | | ReadStorage<'a, c::Position>, [INFO] [stderr] 14 | | ReadStorage<'a, c::Dimensions>, [INFO] [stderr] 15 | | ReadStorage<'a, c::Color>, [INFO] [stderr] 16 | | WriteExpect<'a, r::KeysPressed>, [INFO] [stderr] 17 | | WriteExpect<'a, r::Actions>, [INFO] [stderr] 18 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:53:29 [INFO] [stderr] | [INFO] [stderr] 53 | dispatcher.dispatch(&mut world.res); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/sys/movement.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | / if actions.move_right { [INFO] [stderr] 29 | | if secs_since_move > settings::MAX_MOVE_SPEED { [INFO] [stderr] 30 | | pos.x = pos.x + settings::RECT_WIDTH; [INFO] [stderr] 31 | | if pos.x > (window_width - settings::RECT_WIDTH) { [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | if actions.move_right && secs_since_move > settings::MAX_MOVE_SPEED { [INFO] [stderr] 29 | pos.x = pos.x + settings::RECT_WIDTH; [INFO] [stderr] 30 | if pos.x > (window_width - settings::RECT_WIDTH) { [INFO] [stderr] 31 | pos.x = 0.0; [INFO] [stderr] 32 | } [INFO] [stderr] 33 | clock.last_player_move = Instant::now(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/sys/movement.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | / if actions.move_left { [INFO] [stderr] 38 | | if secs_since_move > settings::MAX_MOVE_SPEED { [INFO] [stderr] 39 | | pos.x = pos.x - settings::RECT_HEIGHT; [INFO] [stderr] 40 | | if pos.x < 0.0 { [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 37 | if actions.move_left && secs_since_move > settings::MAX_MOVE_SPEED { [INFO] [stderr] 38 | pos.x = pos.x - settings::RECT_HEIGHT; [INFO] [stderr] 39 | if pos.x < 0.0 { [INFO] [stderr] 40 | pos.x = window_width - settings::RECT_WIDTH [INFO] [stderr] 41 | } [INFO] [stderr] 42 | clock.last_player_move = Instant::now(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/sys/spawn.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / if secs_since_spawn > settings::MAX_SPAWN_SPEED { [INFO] [stderr] 25 | | if actions.spawn_block { [INFO] [stderr] 26 | | let new_block = entities.create(); [INFO] [stderr] 27 | | updater.insert( [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 24 | if secs_since_spawn > settings::MAX_SPAWN_SPEED && actions.spawn_block { [INFO] [stderr] 25 | let new_block = entities.create(); [INFO] [stderr] 26 | updater.insert( [INFO] [stderr] 27 | new_block, [INFO] [stderr] 28 | c::Dimensions { [INFO] [stderr] 29 | width: settings::RECT_WIDTH, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:27:39 [INFO] [stderr] | [INFO] [stderr] 27 | pub const NANOS_PER_SECOND: f64 = 1000000000.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/sys/drop.rs:10:23 [INFO] [stderr] | [INFO] [stderr] 10 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 11 | | WriteStorage<'a, c::Active>, [INFO] [stderr] 12 | | WriteStorage<'a, c::Position>, [INFO] [stderr] 13 | | WriteExpect<'a, r::Clock>, [INFO] [stderr] ... | [INFO] [stderr] 16 | | ReadExpect<'a, r::GameMap>, [INFO] [stderr] 17 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sys/drop.rs:27:31 [INFO] [stderr] | [INFO] [stderr] 27 | let y_delta = time_since_drop.subsec_nanos() as f64 * drop_speed.0 / settings::NANOS_PER_SECOND; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(time_since_drop.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sys/drop.rs:28:45 [INFO] [stderr] | [INFO] [stderr] 28 | pos.y = (pos.y + y_delta) % (settings::WINDOW_HEIGHT as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(settings::WINDOW_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sys/drop.rs:33:37 [INFO] [stderr] | [INFO] [stderr] 33 | None => (settings::WINDOW_HEIGHT as f64) - (settings::RECT_HEIGHT) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(settings::WINDOW_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sys/movement.rs:22:48 [INFO] [stderr] | [INFO] [stderr] 22 | time_since_move.as_secs() as f64 + time_since_move.subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(time_since_move.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sys/movement.rs:30:25 [INFO] [stderr] | [INFO] [stderr] 30 | pos.x = pos.x + settings::RECT_WIDTH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pos.x += settings::RECT_WIDTH` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sys/movement.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | pos.x = pos.x - settings::RECT_HEIGHT; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pos.x -= settings::RECT_HEIGHT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sys/spawn.rs:22:49 [INFO] [stderr] | [INFO] [stderr] 22 | time_since_spawn.as_secs() as f64 + time_since_spawn.subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(time_since_spawn.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/sys/piston_wrap.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 13 | | ReadStorage<'a, c::Position>, [INFO] [stderr] 14 | | ReadStorage<'a, c::Dimensions>, [INFO] [stderr] 15 | | ReadStorage<'a, c::Color>, [INFO] [stderr] 16 | | WriteExpect<'a, r::KeysPressed>, [INFO] [stderr] 17 | | WriteExpect<'a, r::Actions>, [INFO] [stderr] 18 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:53:29 [INFO] [stderr] | [INFO] [stderr] 53 | dispatcher.dispatch(&mut world.res); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 49.37s [INFO] running `"docker" "inspect" "f17de49776b04bed10faf1dd0b13eacc78bf932d554e9fc9f55ed276a9a09e48"` [INFO] running `"docker" "rm" "-f" "f17de49776b04bed10faf1dd0b13eacc78bf932d554e9fc9f55ed276a9a09e48"` [INFO] [stdout] f17de49776b04bed10faf1dd0b13eacc78bf932d554e9fc9f55ed276a9a09e48