[INFO] updating cached repository Denu8thell/simple-rust-webserver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Denu8thell/simple-rust-webserver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Denu8thell/simple-rust-webserver" "work/ex/clippy-test-run/sources/stable/gh/Denu8thell/simple-rust-webserver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Denu8thell/simple-rust-webserver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Denu8thell/simple-rust-webserver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Denu8thell/simple-rust-webserver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Denu8thell/simple-rust-webserver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3f3948c42e8b64b0f07c76d82b8a9a2ea6d90887 [INFO] sha for GitHub repo Denu8thell/simple-rust-webserver: 3f3948c42e8b64b0f07c76d82b8a9a2ea6d90887 [INFO] validating manifest of Denu8thell/simple-rust-webserver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Denu8thell/simple-rust-webserver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Denu8thell/simple-rust-webserver [INFO] finished frobbing Denu8thell/simple-rust-webserver [INFO] frobbed toml for Denu8thell/simple-rust-webserver written to work/ex/clippy-test-run/sources/stable/gh/Denu8thell/simple-rust-webserver/Cargo.toml [INFO] started frobbing Denu8thell/simple-rust-webserver [INFO] finished frobbing Denu8thell/simple-rust-webserver [INFO] frobbed toml for Denu8thell/simple-rust-webserver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Denu8thell/simple-rust-webserver/Cargo.toml [INFO] crate Denu8thell/simple-rust-webserver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Denu8thell/simple-rust-webserver against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Denu8thell/simple-rust-webserver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6506d22f8aae1c706a4e8ba7a90d50a18cbbf27a530c30f8e5a9acef2827b73a [INFO] running `"docker" "start" "-a" "6506d22f8aae1c706a4e8ba7a90d50a18cbbf27a530c30f8e5a9acef2827b73a"` [INFO] [stderr] Checking simple_webserver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | / if ch == '\n' as u8 { [INFO] [stderr] 189 | | if lines.ends_with("\r\n\r\n") { [INFO] [stderr] 190 | | break; [INFO] [stderr] 191 | | } [INFO] [stderr] 192 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 188 | if ch == '\n' as u8 && lines.ends_with("\r\n\r\n") { [INFO] [stderr] 189 | break; [INFO] [stderr] 190 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req_type` [INFO] [stderr] --> src/main.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | let req_type = HTTPMethods::from(token_iter.next().unwrap()); [INFO] [stderr] | ^^^^^^^^ help: consider using `_req_type` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req_path` [INFO] [stderr] --> src/main.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | let req_path = token_iter.next().unwrap(); [INFO] [stderr] | ^^^^^^^^ help: consider using `_req_path` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `header_map` [INFO] [stderr] --> src/main.rs:239:64 [INFO] [stderr] | [INFO] [stderr] 239 | fn get_response_body(req_type: HTTPMethods, req_path: &String, header_map: &HashMap) -> String{ [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_header_map` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/main.rs:246:14 [INFO] [stderr] | [INFO] [stderr] 246 | fn file_dump(path: &String) -> String{ [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_response_body` [INFO] [stderr] --> src/main.rs:239:1 [INFO] [stderr] | [INFO] [stderr] 239 | fn get_response_body(req_type: HTTPMethods, req_path: &String, header_map: &HashMap) -> String{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `file_dump` [INFO] [stderr] --> src/main.rs:246:1 [INFO] [stderr] | [INFO] [stderr] 246 | fn file_dump(path: &String) -> String{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/options/mod.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | if let Ok(_) = f.read_to_string(&mut contents) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 25 | | if let Ok(o) = serde_json::from_str(&contents) { [INFO] [stderr] 26 | | let h: HTTPServerOptions = o; [INFO] [stderr] 27 | | Ok(h) [INFO] [stderr] ... | [INFO] [stderr] 32 | | Result::Err("Error reading result") [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____________- help: try this: `if f.read_to_string(&mut contents).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/options/mod.rs:40:25 [INFO] [stderr] | [INFO] [stderr] 40 | f.write(&(j.into_bytes())[..]).expect("Could not write to file!"); //TODO better error handling here. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / match self { [INFO] [stderr] 58 | | &Acl => {String::from("ACL")}, [INFO] [stderr] 59 | | &BaselineControl => {String::from("BASELINE-CONTROL")}, [INFO] [stderr] 60 | | &Bind => {String::from("BIND")}, [INFO] [stderr] ... | [INFO] [stderr] 98 | | &None => {String::from("")}, [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 57 | match *self { [INFO] [stderr] 58 | Acl => {String::from("ACL")}, [INFO] [stderr] 59 | BaselineControl => {String::from("BASELINE-CONTROL")}, [INFO] [stderr] 60 | Bind => {String::from("BIND")}, [INFO] [stderr] 61 | Checkin => {String::from("CHECKIN")}, [INFO] [stderr] 62 | Checkout => {String::from("CHECKOUT")}, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | / if ch == '\n' as u8 { [INFO] [stderr] 189 | | if lines.ends_with("\r\n\r\n") { [INFO] [stderr] 190 | | break; [INFO] [stderr] 191 | | } [INFO] [stderr] 192 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 188 | if ch == '\n' as u8 && lines.ends_with("\r\n\r\n") { [INFO] [stderr] 189 | break; [INFO] [stderr] 190 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:188:18 [INFO] [stderr] | [INFO] [stderr] 188 | if ch == '\n' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:235:35 [INFO] [stderr] | [INFO] [stderr] 235 | let h: Vec<&str> = line.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:239:55 [INFO] [stderr] | [INFO] [stderr] 239 | fn get_response_body(req_type: HTTPMethods, req_path: &String, header_map: &HashMap) -> String{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:246:20 [INFO] [stderr] | [INFO] [stderr] 246 | fn file_dump(path: &String) -> String{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `simple_webserver`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `req_type` [INFO] [stderr] --> src/main.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | let req_type = HTTPMethods::from(token_iter.next().unwrap()); [INFO] [stderr] | ^^^^^^^^ help: consider using `_req_type` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req_path` [INFO] [stderr] --> src/main.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | let req_path = token_iter.next().unwrap(); [INFO] [stderr] | ^^^^^^^^ help: consider using `_req_path` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `header_map` [INFO] [stderr] --> src/main.rs:239:64 [INFO] [stderr] | [INFO] [stderr] 239 | fn get_response_body(req_type: HTTPMethods, req_path: &String, header_map: &HashMap) -> String{ [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_header_map` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/main.rs:246:14 [INFO] [stderr] | [INFO] [stderr] 246 | fn file_dump(path: &String) -> String{ [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_response_body` [INFO] [stderr] --> src/main.rs:239:1 [INFO] [stderr] | [INFO] [stderr] 239 | fn get_response_body(req_type: HTTPMethods, req_path: &String, header_map: &HashMap) -> String{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `file_dump` [INFO] [stderr] --> src/main.rs:246:1 [INFO] [stderr] | [INFO] [stderr] 246 | fn file_dump(path: &String) -> String{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/options/mod.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | if let Ok(_) = f.read_to_string(&mut contents) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 25 | | if let Ok(o) = serde_json::from_str(&contents) { [INFO] [stderr] 26 | | let h: HTTPServerOptions = o; [INFO] [stderr] 27 | | Ok(h) [INFO] [stderr] ... | [INFO] [stderr] 32 | | Result::Err("Error reading result") [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____________- help: try this: `if f.read_to_string(&mut contents).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/options/mod.rs:40:25 [INFO] [stderr] | [INFO] [stderr] 40 | f.write(&(j.into_bytes())[..]).expect("Could not write to file!"); //TODO better error handling here. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / match self { [INFO] [stderr] 58 | | &Acl => {String::from("ACL")}, [INFO] [stderr] 59 | | &BaselineControl => {String::from("BASELINE-CONTROL")}, [INFO] [stderr] 60 | | &Bind => {String::from("BIND")}, [INFO] [stderr] ... | [INFO] [stderr] 98 | | &None => {String::from("")}, [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 57 | match *self { [INFO] [stderr] 58 | Acl => {String::from("ACL")}, [INFO] [stderr] 59 | BaselineControl => {String::from("BASELINE-CONTROL")}, [INFO] [stderr] 60 | Bind => {String::from("BIND")}, [INFO] [stderr] 61 | Checkin => {String::from("CHECKIN")}, [INFO] [stderr] 62 | Checkout => {String::from("CHECKOUT")}, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:188:18 [INFO] [stderr] | [INFO] [stderr] 188 | if ch == '\n' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:235:35 [INFO] [stderr] | [INFO] [stderr] 235 | let h: Vec<&str> = line.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:239:55 [INFO] [stderr] | [INFO] [stderr] 239 | fn get_response_body(req_type: HTTPMethods, req_path: &String, header_map: &HashMap) -> String{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:246:20 [INFO] [stderr] | [INFO] [stderr] 246 | fn file_dump(path: &String) -> String{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `simple_webserver`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6506d22f8aae1c706a4e8ba7a90d50a18cbbf27a530c30f8e5a9acef2827b73a"` [INFO] running `"docker" "rm" "-f" "6506d22f8aae1c706a4e8ba7a90d50a18cbbf27a530c30f8e5a9acef2827b73a"` [INFO] [stdout] 6506d22f8aae1c706a4e8ba7a90d50a18cbbf27a530c30f8e5a9acef2827b73a