[INFO] updating cached repository DenialAdams/steganography [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DenialAdams/steganography [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DenialAdams/steganography" "work/ex/clippy-test-run/sources/stable/gh/DenialAdams/steganography"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DenialAdams/steganography'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DenialAdams/steganography" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DenialAdams/steganography"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DenialAdams/steganography'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 74a86822d6568f5efa9712e5eff8b0a3dc5505f0 [INFO] sha for GitHub repo DenialAdams/steganography: 74a86822d6568f5efa9712e5eff8b0a3dc5505f0 [INFO] validating manifest of DenialAdams/steganography on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DenialAdams/steganography on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DenialAdams/steganography [INFO] finished frobbing DenialAdams/steganography [INFO] frobbed toml for DenialAdams/steganography written to work/ex/clippy-test-run/sources/stable/gh/DenialAdams/steganography/Cargo.toml [INFO] started frobbing DenialAdams/steganography [INFO] finished frobbing DenialAdams/steganography [INFO] frobbed toml for DenialAdams/steganography written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DenialAdams/steganography/Cargo.toml [INFO] crate DenialAdams/steganography has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DenialAdams/steganography against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DenialAdams/steganography:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] df0f7fb4a4e028f6ecb5076fa6fbbe3ba4ffe9282ab7bacb1321fc83152bbeab [INFO] running `"docker" "start" "-a" "df0f7fb4a4e028f6ecb5076fa6fbbe3ba4ffe9282ab7bacb1321fc83152bbeab"` [INFO] [stderr] Checking steganography v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `vigenere_encrypt` [INFO] [stderr] --> src/crypto.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn vigenere_encrypt(input: &[u8], key: &[u8]) -> Result, &'static str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `vigenere_decrypt` [INFO] [stderr] --> src/crypto.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn vigenere_decrypt(input: &[u8], key: &[u8]) -> Result, &'static str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `caesar_encrypt` [INFO] [stderr] --> src/crypto.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn caesar_encrypt(input: &[u8], offset: u8) -> Result, &'static str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `caesar_decrypt` [INFO] [stderr] --> src/crypto.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn caesar_decrypt(input: &[u8], offset: u8) -> Result, &'static str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `modulo` [INFO] [stderr] --> src/crypto.rs:52:1 [INFO] [stderr] | [INFO] [stderr] 52 | fn modulo(base: i8, other: u8) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `alpha_to_twosix` [INFO] [stderr] --> src/util.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn alpha_to_twosix(input: u8) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `twosix_to_alpha` [INFO] [stderr] --> src/util.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn twosix_to_alpha(input: u8) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `create_parity_chart` [INFO] [stderr] --> src/main.rs:95:1 [INFO] [stderr] | [INFO] [stderr] 95 | fn create_parity_chart(filename_in: &str, filename_out: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `is_odd_parity` [INFO] [stderr] --> src/main.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | fn is_odd_parity(mut v: u32) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_parity_message` [INFO] [stderr] --> src/main.rs:126:1 [INFO] [stderr] | [INFO] [stderr] 126 | fn read_parity_message(filename: &str) -> Result, &'static str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `write_parity_message` [INFO] [stderr] --> src/main.rs:148:1 [INFO] [stderr] | [INFO] [stderr] 148 | fn write_parity_message(message: &[u8]) -> Result<(), &'static str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `write_end_of_image_comment` [INFO] [stderr] --> src/main.rs:208:1 [INFO] [stderr] | [INFO] [stderr] 208 | fn write_end_of_image_comment(message: &[u8]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/main.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | let data: &u32 = unsafe { std::mem::transmute::<_, _>(&pixel.2.data[0]) } ; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&pixel.2.data[0] as *const u8 as *const u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | let ref mut fout = File::create(filename_out).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------------- help: try: `let fout = &mut File::create(filename_out).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/main.rs:133:35 [INFO] [stderr] | [INFO] [stderr] 133 | let data: &u32 = unsafe { std::mem::transmute::<_, _>(&pixel.2.data[0]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&pixel.2.data[0] as *const u8 as *const u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/main.rs:154:35 [INFO] [stderr] | [INFO] [stderr] 154 | let data: &u32 = unsafe { std::mem::transmute::<_, _>(&pixel.2.data[0]) } ; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&pixel.2.data[0] as *const u8 as *const u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:157:38 [INFO] [stderr] | [INFO] [stderr] 157 | let mut new_pixel_data = pixel.2.data.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `pixel.2.data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | pixel.2.data.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `pixel.2.data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:176:18 [INFO] [stderr] | [INFO] [stderr] 176 | index += offset as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:180:29 [INFO] [stderr] | [INFO] [stderr] 180 | let mut new_pixel = buf.get_pixel(index % img.width(), index / img.width()).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*buf.get_pixel(index % img.width(), index / img.width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:196:29 [INFO] [stderr] | [INFO] [stderr] 196 | let mut new_pixel = buf.get_pixel(index % img.width(), index / img.width()).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*buf.get_pixel(index % img.width(), index / img.width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | let ref mut fout = File::create("output.png").unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------------- help: try: `let fout = &mut File::create("output.png").unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | / file.write(&file_bytes) [INFO] [stderr] 244 | | .expect("Failed to write out buffer to output PNG file"); [INFO] [stderr] | |____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `steganography`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: function is never used: `create_parity_chart` [INFO] [stderr] --> src/main.rs:95:1 [INFO] [stderr] | [INFO] [stderr] 95 | fn create_parity_chart(filename_in: &str, filename_out: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `is_odd_parity` [INFO] [stderr] --> src/main.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | fn is_odd_parity(mut v: u32) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_parity_message` [INFO] [stderr] --> src/main.rs:126:1 [INFO] [stderr] | [INFO] [stderr] 126 | fn read_parity_message(filename: &str) -> Result, &'static str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `write_parity_message` [INFO] [stderr] --> src/main.rs:148:1 [INFO] [stderr] | [INFO] [stderr] 148 | fn write_parity_message(message: &[u8]) -> Result<(), &'static str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `write_end_of_image_comment` [INFO] [stderr] --> src/main.rs:208:1 [INFO] [stderr] | [INFO] [stderr] 208 | fn write_end_of_image_comment(message: &[u8]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/main.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | let data: &u32 = unsafe { std::mem::transmute::<_, _>(&pixel.2.data[0]) } ; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&pixel.2.data[0] as *const u8 as *const u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | let ref mut fout = File::create(filename_out).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------------- help: try: `let fout = &mut File::create(filename_out).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/main.rs:133:35 [INFO] [stderr] | [INFO] [stderr] 133 | let data: &u32 = unsafe { std::mem::transmute::<_, _>(&pixel.2.data[0]) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&pixel.2.data[0] as *const u8 as *const u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/main.rs:154:35 [INFO] [stderr] | [INFO] [stderr] 154 | let data: &u32 = unsafe { std::mem::transmute::<_, _>(&pixel.2.data[0]) } ; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&pixel.2.data[0] as *const u8 as *const u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:157:38 [INFO] [stderr] | [INFO] [stderr] 157 | let mut new_pixel_data = pixel.2.data.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `pixel.2.data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | pixel.2.data.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `pixel.2.data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:176:18 [INFO] [stderr] | [INFO] [stderr] 176 | index += offset as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:180:29 [INFO] [stderr] | [INFO] [stderr] 180 | let mut new_pixel = buf.get_pixel(index % img.width(), index / img.width()).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*buf.get_pixel(index % img.width(), index / img.width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:196:29 [INFO] [stderr] | [INFO] [stderr] 196 | let mut new_pixel = buf.get_pixel(index % img.width(), index / img.width()).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*buf.get_pixel(index % img.width(), index / img.width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | let ref mut fout = File::create("output.png").unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------------- help: try: `let fout = &mut File::create("output.png").unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | / file.write(&file_bytes) [INFO] [stderr] 244 | | .expect("Failed to write out buffer to output PNG file"); [INFO] [stderr] | |____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `steganography`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "df0f7fb4a4e028f6ecb5076fa6fbbe3ba4ffe9282ab7bacb1321fc83152bbeab"` [INFO] running `"docker" "rm" "-f" "df0f7fb4a4e028f6ecb5076fa6fbbe3ba4ffe9282ab7bacb1321fc83152bbeab"` [INFO] [stdout] df0f7fb4a4e028f6ecb5076fa6fbbe3ba4ffe9282ab7bacb1321fc83152bbeab