[INFO] updating cached repository DeltaManiac/kilo-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DeltaManiac/kilo-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DeltaManiac/kilo-rs" "work/ex/clippy-test-run/sources/stable/gh/DeltaManiac/kilo-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DeltaManiac/kilo-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DeltaManiac/kilo-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DeltaManiac/kilo-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DeltaManiac/kilo-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] eeb2400e027fcc394930774649f961d6e7812ae3 [INFO] sha for GitHub repo DeltaManiac/kilo-rs: eeb2400e027fcc394930774649f961d6e7812ae3 [INFO] validating manifest of DeltaManiac/kilo-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DeltaManiac/kilo-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DeltaManiac/kilo-rs [INFO] finished frobbing DeltaManiac/kilo-rs [INFO] frobbed toml for DeltaManiac/kilo-rs written to work/ex/clippy-test-run/sources/stable/gh/DeltaManiac/kilo-rs/Cargo.toml [INFO] started frobbing DeltaManiac/kilo-rs [INFO] finished frobbing DeltaManiac/kilo-rs [INFO] frobbed toml for DeltaManiac/kilo-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DeltaManiac/kilo-rs/Cargo.toml [INFO] crate DeltaManiac/kilo-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DeltaManiac/kilo-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DeltaManiac/kilo-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3a9f8c62e9c6e20b4fb10401f363016fb675789790925f6292e345011a5e636f [INFO] running `"docker" "start" "-a" "3a9f8c62e9c6e20b4fb10401f363016fb675789790925f6292e345011a5e636f"` [INFO] [stderr] Checking kilo-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:192:17 [INFO] [stderr] | [INFO] [stderr] 192 | / if len > 0 { [INFO] [stderr] 193 | | if len > self.col_screen { [INFO] [stderr] 194 | | len = self.col_screen; [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 192 | if len > 0 && len > self.col_screen { [INFO] [stderr] 193 | len = self.col_screen; [INFO] [stderr] 194 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable `tab` is assigned to, but never used [INFO] [stderr] --> src/main.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | let mut tab = 0; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_tab` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `nonprint` [INFO] [stderr] --> src/main.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | let mut nonprint = 0; [INFO] [stderr] | ^^^^^^^^ help: consider using `_nonprint` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `j` [INFO] [stderr] --> src/main.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | let mut j = 0; [INFO] [stderr] | ^ help: consider using `_j` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | let mut nonprint = 0; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | let mut j = 0; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | let mut rendered_content = self.update_row(contents.clone()); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Null` [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | Null, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CtrlC` [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | CtrlC, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CtrlD` [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | CtrlD, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CtrlF` [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | CtrlF, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CtrlH` [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | CtrlH, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ArrowLeft` [INFO] [stderr] --> src/main.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | ArrowLeft, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ArrowRight` [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | ArrowRight, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ArrowUp` [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | ArrowUp, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ArrowDown` [INFO] [stderr] --> src/main.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | ArrowDown, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `enable_raw_mode` [INFO] [stderr] --> src/main.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | fn enable_raw_mode(&mut self, fd: RawFd) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | row_screen: b.ws_row as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(b.ws_row)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:73:25 [INFO] [stderr] | [INFO] [stderr] 73 | col_screen: b.ws_col as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(b.ws_col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | write(std::io::stdout().as_raw_fd(), &output.into_bytes()[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:294:5 [INFO] [stderr] | [INFO] [stderr] 294 | c.open(args[1].to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:192:17 [INFO] [stderr] | [INFO] [stderr] 192 | / if len > 0 { [INFO] [stderr] 193 | | if len > self.col_screen { [INFO] [stderr] 194 | | len = self.col_screen; [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 192 | if len > 0 && len > self.col_screen { [INFO] [stderr] 193 | len = self.col_screen; [INFO] [stderr] 194 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable `tab` is assigned to, but never used [INFO] [stderr] --> src/main.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | let mut tab = 0; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_tab` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `nonprint` [INFO] [stderr] --> src/main.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | let mut nonprint = 0; [INFO] [stderr] | ^^^^^^^^ help: consider using `_nonprint` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `j` [INFO] [stderr] --> src/main.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | let mut j = 0; [INFO] [stderr] | ^ help: consider using `_j` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | let mut nonprint = 0; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | let mut j = 0; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | let mut rendered_content = self.update_row(contents.clone()); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Null` [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | Null, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CtrlC` [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | CtrlC, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CtrlD` [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | CtrlD, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CtrlF` [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | CtrlF, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CtrlH` [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | CtrlH, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ArrowLeft` [INFO] [stderr] --> src/main.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | ArrowLeft, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ArrowRight` [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | ArrowRight, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ArrowUp` [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | ArrowUp, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ArrowDown` [INFO] [stderr] --> src/main.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | ArrowDown, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `enable_raw_mode` [INFO] [stderr] --> src/main.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | fn enable_raw_mode(&mut self, fd: RawFd) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | row_screen: b.ws_row as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(b.ws_row)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:73:25 [INFO] [stderr] | [INFO] [stderr] 73 | col_screen: b.ws_col as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(b.ws_col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | write(std::io::stdout().as_raw_fd(), &output.into_bytes()[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:294:5 [INFO] [stderr] | [INFO] [stderr] 294 | c.open(args[1].to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.68s [INFO] running `"docker" "inspect" "3a9f8c62e9c6e20b4fb10401f363016fb675789790925f6292e345011a5e636f"` [INFO] running `"docker" "rm" "-f" "3a9f8c62e9c6e20b4fb10401f363016fb675789790925f6292e345011a5e636f"` [INFO] [stdout] 3a9f8c62e9c6e20b4fb10401f363016fb675789790925f6292e345011a5e636f