[INFO] updating cached repository DeedleFake/rust-rot13
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/DeedleFake/rust-rot13
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/DeedleFake/rust-rot13" "work/ex/clippy-test-run/sources/stable/gh/DeedleFake/rust-rot13"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DeedleFake/rust-rot13'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/DeedleFake/rust-rot13" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DeedleFake/rust-rot13"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DeedleFake/rust-rot13'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 56d155c588b6e6dfd3e60f2081f3ab45045487db
[INFO] sha for GitHub repo DeedleFake/rust-rot13: 56d155c588b6e6dfd3e60f2081f3ab45045487db
[INFO] validating manifest of DeedleFake/rust-rot13 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of DeedleFake/rust-rot13 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing DeedleFake/rust-rot13
[INFO] finished frobbing DeedleFake/rust-rot13
[INFO] frobbed toml for DeedleFake/rust-rot13 written to work/ex/clippy-test-run/sources/stable/gh/DeedleFake/rust-rot13/Cargo.toml
[INFO] started frobbing DeedleFake/rust-rot13
[INFO] finished frobbing DeedleFake/rust-rot13
[INFO] frobbed toml for DeedleFake/rust-rot13 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DeedleFake/rust-rot13/Cargo.toml
[INFO] crate DeedleFake/rust-rot13 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting DeedleFake/rust-rot13 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DeedleFake/rust-rot13:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ae9829560bd309c0151cd1e16c60e6abfb4b1d427fdf3cc0fa174b41dcd6e0c8
[INFO] running `"docker" "start" "-a" "ae9829560bd309c0151cd1e16c60e6abfb4b1d427fdf3cc0fa174b41dcd6e0c8"`
[INFO] [stderr]     Checking rot13 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/read.rs:12:13
[INFO] [stderr]    |
[INFO] [stderr] 12 |             r: r,
[INFO] [stderr]    |             ^^^^ help: replace it with: `r`
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/read.rs:12:13
[INFO] [stderr]    |
[INFO] [stderr] 12 |             r: r,
[INFO] [stderr]    |             ^^^^ help: replace it with: `r`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/write.rs:12:13
[INFO] [stderr]    |
[INFO] [stderr] 12 |             w: w,
[INFO] [stderr]    |             ^^^^ help: replace it with: `w`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/write.rs:12:13
[INFO] [stderr]    |
[INFO] [stderr] 12 |             w: w,
[INFO] [stderr]    |             ^^^^ help: replace it with: `w`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     r
[INFO] [stderr]    |     ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:17:13
[INFO] [stderr]    |
[INFO] [stderr] 17 |       let r = if (c >= 'A' as u8) && (c <= 'Z' as u8) {
[INFO] [stderr]    |  _____________^
[INFO] [stderr] 18 | |         Some('Z' as u8)
[INFO] [stderr] 19 | |     } else if (c >= 'a' as u8) && (c <= 'z' as u8) {
[INFO] [stderr] 20 | |         Some('z' as u8)
[INFO] [stderr] 21 | |     } else {
[INFO] [stderr] 22 | |         None
[INFO] [stderr] 23 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     r
[INFO] [stderr]    |     ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:17:13
[INFO] [stderr]    |
[INFO] [stderr] 17 |       let r = if (c >= 'A' as u8) && (c <= 'Z' as u8) {
[INFO] [stderr]    |  _____________^
[INFO] [stderr] 18 | |         Some('Z' as u8)
[INFO] [stderr] 19 | |     } else if (c >= 'a' as u8) && (c <= 'z' as u8) {
[INFO] [stderr] 20 | |         Some('z' as u8)
[INFO] [stderr] 21 | |     } else {
[INFO] [stderr] 22 | |         None
[INFO] [stderr] 23 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/lib.rs:17:22
[INFO] [stderr]    |
[INFO] [stderr] 17 |     let r = if (c >= 'A' as u8) && (c <= 'Z' as u8) {
[INFO] [stderr]    |                      ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'A'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/lib.rs:17:42
[INFO] [stderr]    |
[INFO] [stderr] 17 |     let r = if (c >= 'A' as u8) && (c <= 'Z' as u8) {
[INFO] [stderr]    |                                          ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'Z'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/lib.rs:18:14
[INFO] [stderr]    |
[INFO] [stderr] 18 |         Some('Z' as u8)
[INFO] [stderr]    |              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'Z'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/lib.rs:19:21
[INFO] [stderr]    |
[INFO] [stderr] 19 |     } else if (c >= 'a' as u8) && (c <= 'z' as u8) {
[INFO] [stderr]    |                     ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'a'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/lib.rs:19:41
[INFO] [stderr]    |
[INFO] [stderr] 19 |     } else if (c >= 'a' as u8) && (c <= 'z' as u8) {
[INFO] [stderr]    |                                         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'z'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/lib.rs:20:14
[INFO] [stderr]    |
[INFO] [stderr] 20 |         Some('z' as u8)
[INFO] [stderr]    |              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'z'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `buf`.
[INFO] [stderr]   --> src/lib.rs:30:14
[INFO] [stderr]    |
[INFO] [stderr] 30 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 30 |     for <item> in &mut buf {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/read.rs:40:14
[INFO] [stderr]    |
[INFO] [stderr] 40 |             ("This is a test.".as_bytes(), "Guvf vf n grfg.".to_string()),
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"This is a test."`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/write.rs:51:14
[INFO] [stderr]    |
[INFO] [stderr] 51 |             ("This is a test.".as_bytes(), "Guvf vf n grfg.".to_string()),
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"This is a test."`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/write.rs:58:17
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 w.write(t).unwrap();
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/lib.rs:17:22
[INFO] [stderr]    |
[INFO] [stderr] 17 |     let r = if (c >= 'A' as u8) && (c <= 'Z' as u8) {
[INFO] [stderr]    |                      ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'A'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/lib.rs:17:42
[INFO] [stderr]    |
[INFO] [stderr] 17 |     let r = if (c >= 'A' as u8) && (c <= 'Z' as u8) {
[INFO] [stderr]    |                                          ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'Z'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/lib.rs:18:14
[INFO] [stderr]    |
[INFO] [stderr] 18 |         Some('Z' as u8)
[INFO] [stderr]    |              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'Z'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/lib.rs:19:21
[INFO] [stderr]    |
[INFO] [stderr] 19 |     } else if (c >= 'a' as u8) && (c <= 'z' as u8) {
[INFO] [stderr]    |                     ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'a'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/lib.rs:19:41
[INFO] [stderr]    |
[INFO] [stderr] 19 |     } else if (c >= 'a' as u8) && (c <= 'z' as u8) {
[INFO] [stderr]    |                                         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'z'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/lib.rs:20:14
[INFO] [stderr]    |
[INFO] [stderr] 20 |         Some('z' as u8)
[INFO] [stderr]    |              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'z'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `buf`.
[INFO] [stderr]   --> src/lib.rs:30:14
[INFO] [stderr]    |
[INFO] [stderr] 30 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 30 |     for <item> in &mut buf {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rot13`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "ae9829560bd309c0151cd1e16c60e6abfb4b1d427fdf3cc0fa174b41dcd6e0c8"`
[INFO] running `"docker" "rm" "-f" "ae9829560bd309c0151cd1e16c60e6abfb4b1d427fdf3cc0fa174b41dcd6e0c8"`
[INFO] [stdout] ae9829560bd309c0151cd1e16c60e6abfb4b1d427fdf3cc0fa174b41dcd6e0c8