[INFO] updating cached repository Debonair2/extensionFinder [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Debonair2/extensionFinder [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Debonair2/extensionFinder" "work/ex/clippy-test-run/sources/stable/gh/Debonair2/extensionFinder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Debonair2/extensionFinder'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Debonair2/extensionFinder" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Debonair2/extensionFinder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Debonair2/extensionFinder'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0210978a27611608f8a49c43685ac9d7d6a1d1fc [INFO] sha for GitHub repo Debonair2/extensionFinder: 0210978a27611608f8a49c43685ac9d7d6a1d1fc [INFO] validating manifest of Debonair2/extensionFinder on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Debonair2/extensionFinder on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Debonair2/extensionFinder [INFO] finished frobbing Debonair2/extensionFinder [INFO] frobbed toml for Debonair2/extensionFinder written to work/ex/clippy-test-run/sources/stable/gh/Debonair2/extensionFinder/Cargo.toml [INFO] started frobbing Debonair2/extensionFinder [INFO] finished frobbing Debonair2/extensionFinder [INFO] frobbed toml for Debonair2/extensionFinder written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Debonair2/extensionFinder/Cargo.toml [INFO] crate Debonair2/extensionFinder has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Debonair2/extensionFinder against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Debonair2/extensionFinder:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fa0ac8364d882541a429310d530816a138b27036d2218705ac45015b54ec2d1d [INFO] running `"docker" "start" "-a" "fa0ac8364d882541a429310d530816a138b27036d2218705ac45015b54ec2d1d"` [INFO] [stderr] Checking extFinder v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/lib.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | if let Err(e) = fs::read_dir(path){ [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `extFinder` should have a snake case name such as `ext_finder` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / loop { [INFO] [stderr] 34 | | match args.next() { [INFO] [stderr] 35 | | Some(arg) => {extensions.insert(arg, 1);} [INFO] [stderr] 36 | | None => {break;} [INFO] [stderr] 37 | | }; [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(arg) = args.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: variable `currPath` should have a snake case name such as `curr_path` [INFO] [stderr] --> src/lib.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | let currPath = path.unwrap().path(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | process_directory (config, fs::read_dir(currPath.as_path())?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:68:26 [INFO] [stderr] | [INFO] [stderr] 68 | fn find_pattern(pattern: &String, path: &Path) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/lib.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | if let Err(e) = fs::read_dir(path){ [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `extFinder` should have a snake case name such as `ext_finder` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / loop { [INFO] [stderr] 34 | | match args.next() { [INFO] [stderr] 35 | | Some(arg) => {extensions.insert(arg, 1);} [INFO] [stderr] 36 | | None => {break;} [INFO] [stderr] 37 | | }; [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(arg) = args.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: variable `currPath` should have a snake case name such as `curr_path` [INFO] [stderr] --> src/lib.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | let currPath = path.unwrap().path(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | process_directory (config, fs::read_dir(currPath.as_path())?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:68:26 [INFO] [stderr] | [INFO] [stderr] 68 | fn find_pattern(pattern: &String, path: &Path) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: crate `extFinder` should have a snake case name such as `ext_finder` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `extFinder` should have a snake case name such as `ext_finder` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.06s [INFO] running `"docker" "inspect" "fa0ac8364d882541a429310d530816a138b27036d2218705ac45015b54ec2d1d"` [INFO] running `"docker" "rm" "-f" "fa0ac8364d882541a429310d530816a138b27036d2218705ac45015b54ec2d1d"` [INFO] [stdout] fa0ac8364d882541a429310d530816a138b27036d2218705ac45015b54ec2d1d