[INFO] updating cached repository DeMille/encrusted [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DeMille/encrusted [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DeMille/encrusted" "work/ex/clippy-test-run/sources/stable/gh/DeMille/encrusted"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DeMille/encrusted'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DeMille/encrusted" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DeMille/encrusted"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DeMille/encrusted'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] eebb792423954adccb9a94c69d5e820b5f644a32 [INFO] sha for GitHub repo DeMille/encrusted: eebb792423954adccb9a94c69d5e820b5f644a32 [INFO] validating manifest of DeMille/encrusted on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DeMille/encrusted on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DeMille/encrusted [INFO] finished frobbing DeMille/encrusted [INFO] frobbed toml for DeMille/encrusted written to work/ex/clippy-test-run/sources/stable/gh/DeMille/encrusted/Cargo.toml [INFO] started frobbing DeMille/encrusted [INFO] finished frobbing DeMille/encrusted [INFO] frobbed toml for DeMille/encrusted written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DeMille/encrusted/Cargo.toml [INFO] crate DeMille/encrusted has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DeMille/encrusted against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DeMille/encrusted:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ecce51fcd6faf5ba1acb48474c9a09604aeae890fc514447af3941291a4a9120 [INFO] running `"docker" "start" "-a" "ecce51fcd6faf5ba1acb48474c9a09604aeae890fc514447af3941291a4a9120"` [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking base64 v0.8.0 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking regex v0.2.3 [INFO] [stderr] Checking encrusted v1.0.0 (/opt/crater/workdir) [INFO] [stderr] error[E0463]: can't find crate for `wasm_glue` [INFO] [stderr] --> src/rust/main.web.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | extern crate wasm_glue; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ can't find crate [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0463`. [INFO] [stderr] error: Could not compile `encrusted`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0463]: can't find crate for `wasm_glue` [INFO] [stderr] --> src/rust/main.web.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | extern crate wasm_glue; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ can't find crate [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0463`. [INFO] [stderr] error: Could not compile `encrusted`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/rust/zmachine.rs:198:47 [INFO] [stderr] | [INFO] [stderr] 198 | rng: rand::SeedableRng::from_seed(options.rand_seed.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `options.rand_seed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/rust/zmachine.rs:221:26 [INFO] [stderr] | [INFO] [stderr] 221 | fn to_alphabet_entry(s: &str) -> Vec { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/rust/zmachine.rs:198:47 [INFO] [stderr] | [INFO] [stderr] 198 | rng: rand::SeedableRng::from_seed(options.rand_seed.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `options.rand_seed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/rust/zmachine.rs:221:26 [INFO] [stderr] | [INFO] [stderr] 221 | fn to_alphabet_entry(s: &str) -> Vec { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rust/zmachine.rs:741:18 [INFO] [stderr] | [INFO] [stderr] 741 | for i in 1..self.get_total_object_count() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=self.get_total_object_count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rust/zmachine.rs:756:18 [INFO] [stderr] | [INFO] [stderr] 756 | for i in 1..self.get_total_object_count() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=self.get_total_object_count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rust/zmachine.rs:741:18 [INFO] [stderr] | [INFO] [stderr] 741 | for i in 1..self.get_total_object_count() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=self.get_total_object_count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rust/zmachine.rs:756:18 [INFO] [stderr] | [INFO] [stderr] 756 | for i in 1..self.get_total_object_count() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=self.get_total_object_count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rust/zmachine.rs:2423:24 [INFO] [stderr] | [INFO] [stderr] 2423 | for obj_num in 1..self.get_total_object_count() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=self.get_total_object_count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rust/zmachine.rs:2438:24 [INFO] [stderr] | [INFO] [stderr] 2438 | for obj_num in 1..self.get_total_object_count() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=self.get_total_object_count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rust/zmachine.rs:2423:24 [INFO] [stderr] | [INFO] [stderr] 2423 | for obj_num in 1..self.get_total_object_count() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=self.get_total_object_count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rust/zmachine.rs:2438:24 [INFO] [stderr] | [INFO] [stderr] 2438 | for obj_num in 1..self.get_total_object_count() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=self.get_total_object_count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "ecce51fcd6faf5ba1acb48474c9a09604aeae890fc514447af3941291a4a9120"` [INFO] running `"docker" "rm" "-f" "ecce51fcd6faf5ba1acb48474c9a09604aeae890fc514447af3941291a4a9120"` [INFO] [stdout] ecce51fcd6faf5ba1acb48474c9a09604aeae890fc514447af3941291a4a9120