[INFO] updating cached repository DavidDeprost/submod_rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DavidDeprost/submod_rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DavidDeprost/submod_rs" "work/ex/clippy-test-run/sources/stable/gh/DavidDeprost/submod_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DavidDeprost/submod_rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DavidDeprost/submod_rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DavidDeprost/submod_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DavidDeprost/submod_rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cd5c42c1bed457a46019afb68f152c45aa61bc09 [INFO] sha for GitHub repo DavidDeprost/submod_rs: cd5c42c1bed457a46019afb68f152c45aa61bc09 [INFO] validating manifest of DavidDeprost/submod_rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DavidDeprost/submod_rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DavidDeprost/submod_rs [INFO] finished frobbing DavidDeprost/submod_rs [INFO] frobbed toml for DavidDeprost/submod_rs written to work/ex/clippy-test-run/sources/stable/gh/DavidDeprost/submod_rs/Cargo.toml [INFO] started frobbing DavidDeprost/submod_rs [INFO] finished frobbing DavidDeprost/submod_rs [INFO] frobbed toml for DavidDeprost/submod_rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DavidDeprost/submod_rs/Cargo.toml [INFO] crate DavidDeprost/submod_rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DavidDeprost/submod_rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DavidDeprost/submod_rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d08acec8dea0827a93d4dabe523fa89080416adfcf231c079d4f811cc8cb05a3 [INFO] running `"docker" "start" "-a" "d08acec8dea0827a93d4dabe523fa89080416adfcf231c079d4f811cc8cb05a3"` [INFO] [stderr] Checking submod v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | return deleted_subs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `deleted_subs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:271:5 [INFO] [stderr] | [INFO] [stderr] 271 | return deleted_subs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `deleted_subs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:293:5 [INFO] [stderr] | [INFO] [stderr] 293 | return line; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:323:5 [INFO] [stderr] | [INFO] [stderr] 323 | return time_string; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `time_string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | return deleted_subs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `deleted_subs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:271:5 [INFO] [stderr] | [INFO] [stderr] 271 | return deleted_subs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `deleted_subs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:293:5 [INFO] [stderr] | [INFO] [stderr] 293 | return line; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:323:5 [INFO] [stderr] | [INFO] [stderr] 323 | return time_string; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `time_string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `incr` is never read [INFO] [stderr] --> src/main.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | let mut incr: f64 = 0.0; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `output` is never read [INFO] [stderr] --> src/main.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | let mut output = String::new(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | / let mut output = String::new(); [INFO] [stderr] 125 | | [INFO] [stderr] 126 | | if processed { [INFO] [stderr] 127 | | // Regex for extracting the increment number from the inputfile: [INFO] [stderr] ... | [INFO] [stderr] 143 | | output = "{{abc.xy}_Sec}_".to_string() + input; [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let output = if processed { ..; "{{abc.xy}_Sec}_".to_string() + &input[index.end()..] } else { ..; "{{abc.xy}_Sec}_".to_string() + input };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | / out.write((new_line + "\n").as_bytes()) [INFO] [stderr] 214 | | .expect("error writing to outputfile"); [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | / out.write((new_line + "\n").as_bytes()) [INFO] [stderr] 268 | | .expect("error writing to outputfile"); [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `submod`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: value assigned to `incr` is never read [INFO] [stderr] --> src/main.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | let mut incr: f64 = 0.0; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `output` is never read [INFO] [stderr] --> src/main.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | let mut output = String::new(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | / let mut output = String::new(); [INFO] [stderr] 125 | | [INFO] [stderr] 126 | | if processed { [INFO] [stderr] 127 | | // Regex for extracting the increment number from the inputfile: [INFO] [stderr] ... | [INFO] [stderr] 143 | | output = "{{abc.xy}_Sec}_".to_string() + input; [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let output = if processed { ..; "{{abc.xy}_Sec}_".to_string() + &input[index.end()..] } else { ..; "{{abc.xy}_Sec}_".to_string() + input };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | / out.write((new_line + "\n").as_bytes()) [INFO] [stderr] 214 | | .expect("error writing to outputfile"); [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | / out.write((new_line + "\n").as_bytes()) [INFO] [stderr] 268 | | .expect("error writing to outputfile"); [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `submod`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d08acec8dea0827a93d4dabe523fa89080416adfcf231c079d4f811cc8cb05a3"` [INFO] running `"docker" "rm" "-f" "d08acec8dea0827a93d4dabe523fa89080416adfcf231c079d4f811cc8cb05a3"` [INFO] [stdout] d08acec8dea0827a93d4dabe523fa89080416adfcf231c079d4f811cc8cb05a3