[INFO] updating cached repository DavidColson/RustyRaytracer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DavidColson/RustyRaytracer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DavidColson/RustyRaytracer" "work/ex/clippy-test-run/sources/stable/gh/DavidColson/RustyRaytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DavidColson/RustyRaytracer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DavidColson/RustyRaytracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DavidColson/RustyRaytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DavidColson/RustyRaytracer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2fc154969f6e13afc2c0dce965d2e814e98e9a9e [INFO] sha for GitHub repo DavidColson/RustyRaytracer: 2fc154969f6e13afc2c0dce965d2e814e98e9a9e [INFO] validating manifest of DavidColson/RustyRaytracer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DavidColson/RustyRaytracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DavidColson/RustyRaytracer [INFO] finished frobbing DavidColson/RustyRaytracer [INFO] frobbed toml for DavidColson/RustyRaytracer written to work/ex/clippy-test-run/sources/stable/gh/DavidColson/RustyRaytracer/Cargo.toml [INFO] started frobbing DavidColson/RustyRaytracer [INFO] finished frobbing DavidColson/RustyRaytracer [INFO] frobbed toml for DavidColson/RustyRaytracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DavidColson/RustyRaytracer/Cargo.toml [INFO] crate DavidColson/RustyRaytracer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DavidColson/RustyRaytracer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DavidColson/RustyRaytracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cf222e37d636d5d63f47d484864671763a120e1745aab452ce5ee19a485123e9 [INFO] running `"docker" "start" "-a" "cf222e37d636d5d63f47d484864671763a120e1745aab452ce5ee19a485123e9"` [INFO] [stderr] Compiling version_check v0.1.4 [INFO] [stderr] Checking cfg-if v0.1.4 [INFO] [stderr] Compiling num-traits v0.2.5 [INFO] [stderr] Checking byteorder v1.2.4 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking bitflags v1.0.3 [INFO] [stderr] Checking rand_core v0.2.1 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking atomic-counter v0.1.0 [INFO] [stderr] Compiling proc-macro2 v0.4.9 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking gif v0.10.0 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Compiling lazy_static v1.1.0 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Compiling quote v0.6.5 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Compiling syn v0.14.7 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking raytracer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sphere.rs:35:48 [INFO] [stderr] | [INFO] [stderr] 35 | return Some(HitResult{t: temp, p: p, normal: norm, material: Arc::clone(&self.material)}) [INFO] [stderr] | ^^^^ help: replace it with: `p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sphere.rs:41:48 [INFO] [stderr] | [INFO] [stderr] 41 | return Some(HitResult{t: temp, p: p, normal: norm, material: Arc::clone(&self.material)}) [INFO] [stderr] | ^^^^ help: replace it with: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | let r = cam.get_ray(u, v); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sphere.rs:35:48 [INFO] [stderr] | [INFO] [stderr] 35 | return Some(HitResult{t: temp, p: p, normal: norm, material: Arc::clone(&self.material)}) [INFO] [stderr] | ^^^^ help: replace it with: `p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sphere.rs:41:48 [INFO] [stderr] | [INFO] [stderr] 41 | return Some(HitResult{t: temp, p: p, normal: norm, material: Arc::clone(&self.material)}) [INFO] [stderr] | ^^^^ help: replace it with: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | let r = cam.get_ray(u, v); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:39:55 [INFO] [stderr] | [INFO] [stderr] 39 | Some((attenuation, scattered)) => return attenuation.comp_mul(color(&scattered, world, depth + 1, rng, ray_count)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `attenuation.comp_mul(color(&scattered, world, depth + 1, rng, ray_count))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | return Vec3::new(0.0, 0.0, 0.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(0.0, 0.0, 0.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | return Vec3::new(0.0, 0.0, 0.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(0.0, 0.0, 0.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | return (1.0 - t) * Vec3::new(1.0, 1.0, 1.0) + t * Vec3::new(0.5, 0.7, 1.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(1.0 - t) * Vec3::new(1.0, 1.0, 1.0) + t * Vec3::new(0.5, 0.7, 1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:34:33 [INFO] [stderr] | [INFO] [stderr] 34 | match world.hit(ray, 0.001, 1000000000000000000.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `1_000_000_000_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/camera.rs:20:27 [INFO] [stderr] | [INFO] [stderr] 20 | let theta = fov * 3.14159 / 180.0; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:152:16 [INFO] [stderr] | [INFO] [stderr] 152 | col /= rays_per_pix as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rays_per_pix)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:163:74 [INFO] [stderr] | [INFO] [stderr] 163 | let duration = start_time.elapsed().as_secs() as f64 * 1_000_000.0 + start_time.elapsed().subsec_micros() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(start_time.elapsed().subsec_micros())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `raytracer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:39:55 [INFO] [stderr] | [INFO] [stderr] 39 | Some((attenuation, scattered)) => return attenuation.comp_mul(color(&scattered, world, depth + 1, rng, ray_count)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `attenuation.comp_mul(color(&scattered, world, depth + 1, rng, ray_count))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | return Vec3::new(0.0, 0.0, 0.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(0.0, 0.0, 0.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | return Vec3::new(0.0, 0.0, 0.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec3::new(0.0, 0.0, 0.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | return (1.0 - t) * Vec3::new(1.0, 1.0, 1.0) + t * Vec3::new(0.5, 0.7, 1.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(1.0 - t) * Vec3::new(1.0, 1.0, 1.0) + t * Vec3::new(0.5, 0.7, 1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:34:33 [INFO] [stderr] | [INFO] [stderr] 34 | match world.hit(ray, 0.001, 1000000000000000000.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `1_000_000_000_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/camera.rs:20:27 [INFO] [stderr] | [INFO] [stderr] 20 | let theta = fov * 3.14159 / 180.0; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:152:16 [INFO] [stderr] | [INFO] [stderr] 152 | col /= rays_per_pix as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rays_per_pix)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:163:74 [INFO] [stderr] | [INFO] [stderr] 163 | let duration = start_time.elapsed().as_secs() as f64 * 1_000_000.0 + start_time.elapsed().subsec_micros() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(start_time.elapsed().subsec_micros())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `raytracer`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cf222e37d636d5d63f47d484864671763a120e1745aab452ce5ee19a485123e9"` [INFO] running `"docker" "rm" "-f" "cf222e37d636d5d63f47d484864671763a120e1745aab452ce5ee19a485123e9"` [INFO] [stdout] cf222e37d636d5d63f47d484864671763a120e1745aab452ce5ee19a485123e9