[INFO] updating cached repository David-OConnor/shorthand [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/David-OConnor/shorthand [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/David-OConnor/shorthand" "work/ex/clippy-test-run/sources/stable/gh/David-OConnor/shorthand"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/David-OConnor/shorthand'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/David-OConnor/shorthand" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/David-OConnor/shorthand"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/David-OConnor/shorthand'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1adcb567ce2b91fb4b85a68f73a2f7732027bce6 [INFO] sha for GitHub repo David-OConnor/shorthand: 1adcb567ce2b91fb4b85a68f73a2f7732027bce6 [INFO] validating manifest of David-OConnor/shorthand on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of David-OConnor/shorthand on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing David-OConnor/shorthand [INFO] finished frobbing David-OConnor/shorthand [INFO] frobbed toml for David-OConnor/shorthand written to work/ex/clippy-test-run/sources/stable/gh/David-OConnor/shorthand/Cargo.toml [INFO] started frobbing David-OConnor/shorthand [INFO] finished frobbing David-OConnor/shorthand [INFO] frobbed toml for David-OConnor/shorthand written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/David-OConnor/shorthand/Cargo.toml [INFO] crate David-OConnor/shorthand has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting David-OConnor/shorthand against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/David-OConnor/shorthand:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dcd00cdfb091e38d3a81c00148fe309a83df7286dcd00e23f0a059f1ee756397 [INFO] running `"docker" "start" "-a" "dcd00cdfb091e38d3a81c00148fe309a83df7286dcd00e23f0a059f1ee756397"` [INFO] [stderr] Compiling regex v0.2.9 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking shorthand v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/to_shorthand.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/to_shorthand.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.86s [INFO] running `"docker" "inspect" "dcd00cdfb091e38d3a81c00148fe309a83df7286dcd00e23f0a059f1ee756397"` [INFO] running `"docker" "rm" "-f" "dcd00cdfb091e38d3a81c00148fe309a83df7286dcd00e23f0a059f1ee756397"` [INFO] [stdout] dcd00cdfb091e38d3a81c00148fe309a83df7286dcd00e23f0a059f1ee756397