[INFO] updating cached repository Darkeye9/rust-web-template [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Darkeye9/rust-web-template [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Darkeye9/rust-web-template" "work/ex/clippy-test-run/sources/stable/gh/Darkeye9/rust-web-template"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Darkeye9/rust-web-template'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Darkeye9/rust-web-template" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Darkeye9/rust-web-template"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Darkeye9/rust-web-template'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 88bbb91d88b0a7700a0ac5ed0e058be5576aaf90 [INFO] sha for GitHub repo Darkeye9/rust-web-template: 88bbb91d88b0a7700a0ac5ed0e058be5576aaf90 [INFO] validating manifest of Darkeye9/rust-web-template on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Darkeye9/rust-web-template on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Darkeye9/rust-web-template [INFO] finished frobbing Darkeye9/rust-web-template [INFO] frobbed toml for Darkeye9/rust-web-template written to work/ex/clippy-test-run/sources/stable/gh/Darkeye9/rust-web-template/Cargo.toml [INFO] started frobbing Darkeye9/rust-web-template [INFO] finished frobbing Darkeye9/rust-web-template [INFO] frobbed toml for Darkeye9/rust-web-template written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Darkeye9/rust-web-template/Cargo.toml [INFO] crate Darkeye9/rust-web-template has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Darkeye9/rust-web-template against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Darkeye9/rust-web-template:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fcd05a68409053a78f79396535e71a015ebbdd622e2322e6d61ee6d7e6389b5d [INFO] running `"docker" "start" "-a" "fcd05a68409053a78f79396535e71a015ebbdd622e2322e6d61ee6d7e6389b5d"` [INFO] [stderr] Checking serde v0.8.19 [INFO] [stderr] Checking sequence_trie v0.0.13 [INFO] [stderr] Checking route-recognizer v0.1.11 [INFO] [stderr] Checking conduit-mime-types v0.7.3 [INFO] [stderr] Checking handlebars v0.22.0 [INFO] [stderr] Checking clap v2.19.1 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking hyper v0.9.13 [INFO] [stderr] Checking serde_json v0.8.3 [INFO] [stderr] Checking iron v0.4.0 [INFO] [stderr] Checking persistent v0.2.1 [INFO] [stderr] Checking mount v0.2.1 [INFO] [stderr] Checking handlebars-iron v0.19.2 [INFO] [stderr] Checking router v0.4.0 [INFO] [stderr] Checking staticfile v0.3.1 [INFO] [stderr] Checking bodyparser v0.4.1 [INFO] [stderr] Checking urlencoded v0.4.1 [INFO] [stderr] Checking rust-web-template v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/middlewares/time.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / if res.headers.has::() { [INFO] [stderr] 28 | | if res.headers.get::().unwrap() == &ContentType::html() { [INFO] [stderr] 29 | | // What the hell is required to do to get the response body, LOL! [INFO] [stderr] 30 | | let mut buff = Cursor::new(Vec::new()); [INFO] [stderr] ... | [INFO] [stderr] 46 | | [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 27 | if res.headers.has::() && res.headers.get::().unwrap() == &ContentType::html() { [INFO] [stderr] 28 | // What the hell is required to do to get the response body, LOL! [INFO] [stderr] 29 | let mut buff = Cursor::new(Vec::new()); [INFO] [stderr] 30 | { [INFO] [stderr] 31 | let mut new_response = ResponseBody::new(buff.get_mut()); [INFO] [stderr] 32 | let body_writer: &mut Box = res.body.as_mut().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/middlewares/time.rs:39:43 [INFO] [stderr] | [INFO] [stderr] 39 | let ms = (delta as f64) / 1000000.0; [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/cli.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return matches; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `matches` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/lib/config/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub mod config; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib/config/config.rs:9:23 [INFO] [stderr] | [INFO] [stderr] 9 | const CONFIG_FOLDER: &'static str = "private/config/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/middlewares/time.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / if res.headers.has::() { [INFO] [stderr] 28 | | if res.headers.get::().unwrap() == &ContentType::html() { [INFO] [stderr] 29 | | // What the hell is required to do to get the response body, LOL! [INFO] [stderr] 30 | | let mut buff = Cursor::new(Vec::new()); [INFO] [stderr] ... | [INFO] [stderr] 46 | | [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 27 | if res.headers.has::() && res.headers.get::().unwrap() == &ContentType::html() { [INFO] [stderr] 28 | // What the hell is required to do to get the response body, LOL! [INFO] [stderr] 29 | let mut buff = Cursor::new(Vec::new()); [INFO] [stderr] 30 | { [INFO] [stderr] 31 | let mut new_response = ResponseBody::new(buff.get_mut()); [INFO] [stderr] 32 | let body_writer: &mut Box = res.body.as_mut().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/middlewares/time.rs:39:43 [INFO] [stderr] | [INFO] [stderr] 39 | let ms = (delta as f64) / 1000000.0; [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/cli.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return matches; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `matches` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/lib/config/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub mod config; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib/config/config.rs:9:23 [INFO] [stderr] | [INFO] [stderr] 9 | const CONFIG_FOLDER: &'static str = "private/config/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/middlewares/time.rs:33:38 [INFO] [stderr] | [INFO] [stderr] 33 | let body_writer: &mut Box = res.body.as_mut().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&mut WriteBody` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/config/site_config.rs:25:36 [INFO] [stderr] | [INFO] [stderr] 25 | new_config.site_name = site_name.get(0).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&site_name[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib/config/site_config.rs:28:36 [INFO] [stderr] | [INFO] [stderr] 28 | new_config.published = if site_published.get(0).unwrap().as_str() == "on" { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 29 | | true [INFO] [stderr] 30 | | } else { [INFO] [stderr] 31 | | false [INFO] [stderr] 32 | | }; [INFO] [stderr] | |_____________^ help: you can reduce it to: `site_published.get(0).unwrap().as_str() == "on"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/config/site_config.rs:28:39 [INFO] [stderr] | [INFO] [stderr] 28 | new_config.published = if site_published.get(0).unwrap().as_str() == "on" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&site_published[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib/ui/flash_msg.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / match self { [INFO] [stderr] 23 | | &MessageType::Normal => "".to_json(), [INFO] [stderr] 24 | | &MessageType::Info => "info".to_json(), [INFO] [stderr] 25 | | &MessageType::Warning => "warning".to_json(), [INFO] [stderr] 26 | | &MessageType::Success => "success".to_json(), [INFO] [stderr] 27 | | &MessageType::Error => "error".to_json(), [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | match *self { [INFO] [stderr] 23 | MessageType::Normal => "".to_json(), [INFO] [stderr] 24 | MessageType::Info => "info".to_json(), [INFO] [stderr] 25 | MessageType::Warning => "warning".to_json(), [INFO] [stderr] 26 | MessageType::Success => "success".to_json(), [INFO] [stderr] 27 | MessageType::Error => "error".to_json(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/middlewares/time.rs:33:38 [INFO] [stderr] | [INFO] [stderr] 33 | let body_writer: &mut Box = res.body.as_mut().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&mut WriteBody` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/config/site_config.rs:25:36 [INFO] [stderr] | [INFO] [stderr] 25 | new_config.site_name = site_name.get(0).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&site_name[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib/config/site_config.rs:28:36 [INFO] [stderr] | [INFO] [stderr] 28 | new_config.published = if site_published.get(0).unwrap().as_str() == "on" { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 29 | | true [INFO] [stderr] 30 | | } else { [INFO] [stderr] 31 | | false [INFO] [stderr] 32 | | }; [INFO] [stderr] | |_____________^ help: you can reduce it to: `site_published.get(0).unwrap().as_str() == "on"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib/config/site_config.rs:28:39 [INFO] [stderr] | [INFO] [stderr] 28 | new_config.published = if site_published.get(0).unwrap().as_str() == "on" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&site_published[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib/ui/flash_msg.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / match self { [INFO] [stderr] 23 | | &MessageType::Normal => "".to_json(), [INFO] [stderr] 24 | | &MessageType::Info => "info".to_json(), [INFO] [stderr] 25 | | &MessageType::Warning => "warning".to_json(), [INFO] [stderr] 26 | | &MessageType::Success => "success".to_json(), [INFO] [stderr] 27 | | &MessageType::Error => "error".to_json(), [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | match *self { [INFO] [stderr] 23 | MessageType::Normal => "".to_json(), [INFO] [stderr] 24 | MessageType::Info => "info".to_json(), [INFO] [stderr] 25 | MessageType::Warning => "warning".to_json(), [INFO] [stderr] 26 | MessageType::Success => "success".to_json(), [INFO] [stderr] 27 | MessageType::Error => "error".to_json(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 29.16s [INFO] running `"docker" "inspect" "fcd05a68409053a78f79396535e71a015ebbdd622e2322e6d61ee6d7e6389b5d"` [INFO] running `"docker" "rm" "-f" "fcd05a68409053a78f79396535e71a015ebbdd622e2322e6d61ee6d7e6389b5d"` [INFO] [stdout] fcd05a68409053a78f79396535e71a015ebbdd622e2322e6d61ee6d7e6389b5d