[INFO] updating cached repository Damoun/rust-ip-api [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Damoun/rust-ip-api [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Damoun/rust-ip-api" "work/ex/clippy-test-run/sources/stable/gh/Damoun/rust-ip-api"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Damoun/rust-ip-api'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Damoun/rust-ip-api" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Damoun/rust-ip-api"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Damoun/rust-ip-api'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 171618243131f654c39c29e958b724bff9602b2f [INFO] sha for GitHub repo Damoun/rust-ip-api: 171618243131f654c39c29e958b724bff9602b2f [INFO] validating manifest of Damoun/rust-ip-api on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Damoun/rust-ip-api on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Damoun/rust-ip-api [INFO] finished frobbing Damoun/rust-ip-api [INFO] frobbed toml for Damoun/rust-ip-api written to work/ex/clippy-test-run/sources/stable/gh/Damoun/rust-ip-api/Cargo.toml [INFO] started frobbing Damoun/rust-ip-api [INFO] finished frobbing Damoun/rust-ip-api [INFO] frobbed toml for Damoun/rust-ip-api written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Damoun/rust-ip-api/Cargo.toml [INFO] crate Damoun/rust-ip-api has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Damoun/rust-ip-api against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Damoun/rust-ip-api:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4f9d9fd20a33e1a24eb48b5fb6beaf58e9ba808a22e228a39fa21594e5514cad [INFO] running `"docker" "start" "-a" "4f9d9fd20a33e1a24eb48b5fb6beaf58e9ba808a22e228a39fa21594e5514cad"` [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking logger v0.3.0 [INFO] [stderr] Checking mount v0.3.0 [INFO] [stderr] Checking ip-api v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/api/remoteaddr.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | let addr = match request.headers.has::() { [INFO] [stderr] | ____________________^ [INFO] [stderr] 13 | | true => request.headers.get::().unwrap().client_ip, [INFO] [stderr] 14 | | false => request.remote_addr.ip() [INFO] [stderr] 15 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if request.headers.has::() { request.headers.get::().unwrap().client_ip } else { request.remote_addr.ip() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/api/remoteaddr.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | let addr = match request.headers.has::() { [INFO] [stderr] | ____________________^ [INFO] [stderr] 13 | | true => request.headers.get::().unwrap().client_ip, [INFO] [stderr] 14 | | false => request.remote_addr.ip() [INFO] [stderr] 15 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if request.headers.has::() { request.headers.get::().unwrap().client_ip } else { request.remote_addr.ip() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.06s [INFO] running `"docker" "inspect" "4f9d9fd20a33e1a24eb48b5fb6beaf58e9ba808a22e228a39fa21594e5514cad"` [INFO] running `"docker" "rm" "-f" "4f9d9fd20a33e1a24eb48b5fb6beaf58e9ba808a22e228a39fa21594e5514cad"` [INFO] [stdout] 4f9d9fd20a33e1a24eb48b5fb6beaf58e9ba808a22e228a39fa21594e5514cad