[INFO] updating cached repository Dacode45/letters [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Dacode45/letters [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Dacode45/letters" "work/ex/clippy-test-run/sources/stable/gh/Dacode45/letters"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Dacode45/letters'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Dacode45/letters" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dacode45/letters"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dacode45/letters'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6036a0ce9141d235a357cb14e0cbbe5f5cf1f60c [INFO] sha for GitHub repo Dacode45/letters: 6036a0ce9141d235a357cb14e0cbbe5f5cf1f60c [INFO] validating manifest of Dacode45/letters on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Dacode45/letters on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Dacode45/letters [INFO] finished frobbing Dacode45/letters [INFO] frobbed toml for Dacode45/letters written to work/ex/clippy-test-run/sources/stable/gh/Dacode45/letters/Cargo.toml [INFO] started frobbing Dacode45/letters [INFO] finished frobbing Dacode45/letters [INFO] frobbed toml for Dacode45/letters written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Dacode45/letters/Cargo.toml [INFO] crate Dacode45/letters has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Dacode45/letters against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Dacode45/letters:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e9573b58e670829727562bd716409b9e691fbff215e40f6e380d02e23c1efab9 [INFO] running `"docker" "start" "-a" "e9573b58e670829727562bd716409b9e691fbff215e40f6e380d02e23c1efab9"` [INFO] [stderr] Checking letters v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | alphabet.insert(c.clone(), true); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | if *alphabet.get(c).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&alphabet[c]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | alphabet.insert(c.clone(), true); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | if *alphabet.get(c).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&alphabet[c]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.54s [INFO] running `"docker" "inspect" "e9573b58e670829727562bd716409b9e691fbff215e40f6e380d02e23c1efab9"` [INFO] running `"docker" "rm" "-f" "e9573b58e670829727562bd716409b9e691fbff215e40f6e380d02e23c1efab9"` [INFO] [stdout] e9573b58e670829727562bd716409b9e691fbff215e40f6e380d02e23c1efab9