[INFO] updating cached repository DaanVandenBosch/psoqi
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/DaanVandenBosch/psoqi
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/DaanVandenBosch/psoqi" "work/ex/clippy-test-run/sources/stable/gh/DaanVandenBosch/psoqi"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DaanVandenBosch/psoqi'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/DaanVandenBosch/psoqi" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DaanVandenBosch/psoqi"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DaanVandenBosch/psoqi'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 03f16457308b9d7143c4bd7037cb8e00ffbcebcd
[INFO] sha for GitHub repo DaanVandenBosch/psoqi: 03f16457308b9d7143c4bd7037cb8e00ffbcebcd
[INFO] validating manifest of DaanVandenBosch/psoqi on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of DaanVandenBosch/psoqi on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing DaanVandenBosch/psoqi
[INFO] finished frobbing DaanVandenBosch/psoqi
[INFO] frobbed toml for DaanVandenBosch/psoqi written to work/ex/clippy-test-run/sources/stable/gh/DaanVandenBosch/psoqi/Cargo.toml
[INFO] started frobbing DaanVandenBosch/psoqi
[INFO] finished frobbing DaanVandenBosch/psoqi
[INFO] frobbed toml for DaanVandenBosch/psoqi written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DaanVandenBosch/psoqi/Cargo.toml
[INFO] crate DaanVandenBosch/psoqi has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting DaanVandenBosch/psoqi against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DaanVandenBosch/psoqi:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3dee1abd169da84c43e9819fea526bf8a8263ac201890cf1a862d1f2249bfc84
[INFO] running `"docker" "start" "-a" "3dee1abd169da84c43e9819fea526bf8a8263ac201890cf1a862d1f2249bfc84"`
[INFO] [stderr]     Checking csv v0.14.7
[INFO] [stderr]     Checking clap v2.19.0
[INFO] [stderr]     Checking psoqi v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/read/dat.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 |         episode: episode,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `episode`
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/read/dat.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 |         episode: episode,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `episode`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/read/dat.rs:233:21
[INFO] [stderr]     |
[INFO] [stderr] 233 |                     id: id,
[INFO] [stderr]     |                     ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/read/dat.rs:233:21
[INFO] [stderr]     |
[INFO] [stderr] 233 |                     id: id,
[INFO] [stderr]     |                     ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/read/dat.rs:234:21
[INFO] [stderr]     |
[INFO] [stderr] 234 |                     regular: regular,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: replace it with: `regular`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/read/dat.rs:235:21
[INFO] [stderr]     |
[INFO] [stderr] 235 |                     skin: skin,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `skin`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/read/dat.rs:236:21
[INFO] [stderr]     |
[INFO] [stderr] 236 |                     area: area
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `area`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]  --> src/prs.rs:5:9
[INFO] [stderr]   |
[INFO] [stderr] 5 |         src: src,
[INFO] [stderr]   |         ^^^^^^^^ help: replace it with: `src`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]  --> src/prs.rs:6:9
[INFO] [stderr]   |
[INFO] [stderr] 6 |         dst: dst,
[INFO] [stderr]   |         ^^^^^^^^ help: replace it with: `dst`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/read/dat.rs:234:21
[INFO] [stderr]     |
[INFO] [stderr] 234 |                     regular: regular,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: replace it with: `regular`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/read/dat.rs:235:21
[INFO] [stderr]     |
[INFO] [stderr] 235 |                     skin: skin,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `skin`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/read/dat.rs:236:21
[INFO] [stderr]     |
[INFO] [stderr] 236 |                     area: area
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `area`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]  --> src/prs.rs:5:9
[INFO] [stderr]   |
[INFO] [stderr] 5 |         src: src,
[INFO] [stderr]   |         ^^^^^^^^ help: replace it with: `src`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]  --> src/prs.rs:6:9
[INFO] [stderr]   |
[INFO] [stderr] 6 |         dst: dst,
[INFO] [stderr]   |         ^^^^^^^^ help: replace it with: `dst`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/read/quest.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     return Ok(Quest {
[INFO] [stderr] 11 | |         name: bin.quest_name,
[INFO] [stderr] 12 | |         short_description: bin.short_description,
[INFO] [stderr] 13 | |         episode: dat.episode,
[INFO] [stderr] 14 | |         monster_counts: dat.monster_counts,
[INFO] [stderr] 15 | |     });
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 10 |     Ok(Quest {
[INFO] [stderr] 11 |         name: bin.quest_name,
[INFO] [stderr] 12 |         short_description: bin.short_description,
[INFO] [stderr] 13 |         episode: dat.episode,
[INFO] [stderr] 14 |         monster_counts: dat.monster_counts,
[INFO] [stderr] 15 |     })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/read/qst.rs:47:5
[INFO] [stderr]    |
[INFO] [stderr] 47 | /     return Ok(QstFile {
[INFO] [stderr] 48 | |         dat: dat::read(&mut Cursor::new(decompressed_dat))?,
[INFO] [stderr] 49 | |         bin: bin::read(&mut Cursor::new(decompressed_bin))?
[INFO] [stderr] 50 | |     });
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 47 |     Ok(QstFile {
[INFO] [stderr] 48 |         dat: dat::read(&mut Cursor::new(decompressed_dat))?,
[INFO] [stderr] 49 |         bin: bin::read(&mut Cursor::new(decompressed_bin))?
[INFO] [stderr] 50 |     })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/read/qst.rs:93:5
[INFO] [stderr]    |
[INFO] [stderr] 93 |     return Ok((dat_data, bin_data));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((dat_data, bin_data))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/read/qst.rs:99:5
[INFO] [stderr]    |
[INFO] [stderr] 99 |     return Ok(decompressed.into_inner());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(decompressed.into_inner())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/read/dat.rs:170:5
[INFO] [stderr]     |
[INFO] [stderr] 170 |     return Ok(dat_file);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(dat_file)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/read/dat.rs:208:5
[INFO] [stderr]     |
[INFO] [stderr] 208 |     return None;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/read/dat.rs:246:5
[INFO] [stderr]     |
[INFO] [stderr] 246 |     return Ok(vec);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(vec)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/read/dat.rs:227:66
[INFO] [stderr]     |
[INFO] [stderr] 227 |                 let regular = data.read_u32::<LittleEndian>()? & 0x800000 == 0;
[INFO] [stderr]     |                                                                  ^^^^^^^^ help: consider: `0x0080_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/read/bin.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 | /     return Ok(BinFile {
[INFO] [stderr] 21 | |         quest_name: read_utf_16le_string(&name_buffer[..])?,
[INFO] [stderr] 22 | |         short_description: read_utf_16le_string(&short_description_buffer[..])?
[INFO] [stderr] 23 | |     });
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 20 |     Ok(BinFile {
[INFO] [stderr] 21 |         quest_name: read_utf_16le_string(&name_buffer[..])?,
[INFO] [stderr] 22 |         short_description: read_utf_16le_string(&short_description_buffer[..])?
[INFO] [stderr] 23 |     })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/prs.rs:76:9
[INFO] [stderr]    |
[INFO] [stderr] 76 |         return Ok(rv);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(rv)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/prs.rs:82:9
[INFO] [stderr]    |
[INFO] [stderr] 82 |         return Ok(());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/prs.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 |         return Ok(self.buf[0]);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self.buf[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/prs.rs:93:9
[INFO] [stderr]    |
[INFO] [stderr] 93 |         return Ok(((self.buf[1] as u16) << 8) | (self.buf[0] as u16));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(((self.buf[1] as u16) << 8) | (self.buf[0] as u16))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/prs.rs:116:9
[INFO] [stderr]     |
[INFO] [stderr] 116 |         return Ok(());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/util.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 |     return Ok(encoding::all::ASCII.decode(&buffer[0..string_end], DecoderTrap::Ignore)?);
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(encoding::all::ASCII.decode(&buffer[0..string_end], DecoderTrap::Ignore)?)`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/util.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     return Ok(encoding::all::UTF_16LE.decode(&buffer[0..string_end], DecoderTrap::Ignore)?);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(encoding::all::UTF_16LE.decode(&buffer[0..string_end], DecoderTrap::Ignore)?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:85:5
[INFO] [stderr]    |
[INFO] [stderr] 85 |     return quest::read(&mut buf_reader);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `quest::read(&mut buf_reader)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/read/quest.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     return Ok(Quest {
[INFO] [stderr] 11 | |         name: bin.quest_name,
[INFO] [stderr] 12 | |         short_description: bin.short_description,
[INFO] [stderr] 13 | |         episode: dat.episode,
[INFO] [stderr] 14 | |         monster_counts: dat.monster_counts,
[INFO] [stderr] 15 | |     });
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 10 |     Ok(Quest {
[INFO] [stderr] 11 |         name: bin.quest_name,
[INFO] [stderr] 12 |         short_description: bin.short_description,
[INFO] [stderr] 13 |         episode: dat.episode,
[INFO] [stderr] 14 |         monster_counts: dat.monster_counts,
[INFO] [stderr] 15 |     })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/read/qst.rs:47:5
[INFO] [stderr]    |
[INFO] [stderr] 47 | /     return Ok(QstFile {
[INFO] [stderr] 48 | |         dat: dat::read(&mut Cursor::new(decompressed_dat))?,
[INFO] [stderr] 49 | |         bin: bin::read(&mut Cursor::new(decompressed_bin))?
[INFO] [stderr] 50 | |     });
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 47 |     Ok(QstFile {
[INFO] [stderr] 48 |         dat: dat::read(&mut Cursor::new(decompressed_dat))?,
[INFO] [stderr] 49 |         bin: bin::read(&mut Cursor::new(decompressed_bin))?
[INFO] [stderr] 50 |     })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/read/qst.rs:93:5
[INFO] [stderr]    |
[INFO] [stderr] 93 |     return Ok((dat_data, bin_data));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((dat_data, bin_data))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/read/qst.rs:99:5
[INFO] [stderr]    |
[INFO] [stderr] 99 |     return Ok(decompressed.into_inner());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(decompressed.into_inner())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/read/dat.rs:170:5
[INFO] [stderr]     |
[INFO] [stderr] 170 |     return Ok(dat_file);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(dat_file)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/read/dat.rs:208:5
[INFO] [stderr]     |
[INFO] [stderr] 208 |     return None;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/read/dat.rs:246:5
[INFO] [stderr]     |
[INFO] [stderr] 246 |     return Ok(vec);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(vec)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/read/dat.rs:227:66
[INFO] [stderr]     |
[INFO] [stderr] 227 |                 let regular = data.read_u32::<LittleEndian>()? & 0x800000 == 0;
[INFO] [stderr]     |                                                                  ^^^^^^^^ help: consider: `0x0080_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/read/bin.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 | /     return Ok(BinFile {
[INFO] [stderr] 21 | |         quest_name: read_utf_16le_string(&name_buffer[..])?,
[INFO] [stderr] 22 | |         short_description: read_utf_16le_string(&short_description_buffer[..])?
[INFO] [stderr] 23 | |     });
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 20 |     Ok(BinFile {
[INFO] [stderr] 21 |         quest_name: read_utf_16le_string(&name_buffer[..])?,
[INFO] [stderr] 22 |         short_description: read_utf_16le_string(&short_description_buffer[..])?
[INFO] [stderr] 23 |     })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/prs.rs:76:9
[INFO] [stderr]    |
[INFO] [stderr] 76 |         return Ok(rv);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(rv)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/prs.rs:82:9
[INFO] [stderr]    |
[INFO] [stderr] 82 |         return Ok(());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/prs.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 |         return Ok(self.buf[0]);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self.buf[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/prs.rs:93:9
[INFO] [stderr]    |
[INFO] [stderr] 93 |         return Ok(((self.buf[1] as u16) << 8) | (self.buf[0] as u16));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(((self.buf[1] as u16) << 8) | (self.buf[0] as u16))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/prs.rs:116:9
[INFO] [stderr]     |
[INFO] [stderr] 116 |         return Ok(());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/util.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 |     return Ok(encoding::all::ASCII.decode(&buffer[0..string_end], DecoderTrap::Ignore)?);
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(encoding::all::ASCII.decode(&buffer[0..string_end], DecoderTrap::Ignore)?)`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/util.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     return Ok(encoding::all::UTF_16LE.decode(&buffer[0..string_end], DecoderTrap::Ignore)?);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(encoding::all::UTF_16LE.decode(&buffer[0..string_end], DecoderTrap::Ignore)?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:85:5
[INFO] [stderr]    |
[INFO] [stderr] 85 |     return quest::read(&mut buf_reader);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `quest::read(&mut buf_reader)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/read/dat.rs:180:25
[INFO] [stderr]     |
[INFO] [stderr] 180 | fn detect_episode(data: &Vec<MonsterData>) -> Option<Episode> {
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^ help: change this to: `&[MonsterData]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/read/dat.rs:181:9
[INFO] [stderr]     |
[INFO] [stderr] 181 |     for ref monster_data in data {
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^    ---- help: try: `let monster_data = &data;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/read/dat.rs:243:16
[INFO] [stderr]     |
[INFO] [stderr] 243 |         pos += next_header as u64;
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(next_header)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/prs.rs:23:24
[INFO] [stderr]    |
[INFO] [stderr] 23 |                 size = (cxt.read_flag_bit()? as u16) << 1;
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cxt.read_flag_bit()?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/prs.rs:24:25
[INFO] [stderr]    |
[INFO] [stderr] 24 |                 size |= cxt.read_flag_bit()? as u16;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cxt.read_flag_bit()?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change
[INFO] [stderr]   --> src/prs.rs:27:26
[INFO] [stderr]    |
[INFO] [stderr] 27 |                 offset = cxt.read_byte()? as i16 - 256;
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(cxt.read_byte()?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/prs.rs:42:28
[INFO] [stderr]    |
[INFO] [stderr] 42 |                     size = cxt.read_byte()? as u16;
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cxt.read_byte()?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/prs.rs:93:20
[INFO] [stderr]    |
[INFO] [stderr] 93 |         return Ok(((self.buf[1] as u16) << 8) | (self.buf[0] as u16));
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.buf[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/prs.rs:93:49
[INFO] [stderr]    |
[INFO] [stderr] 93 |         return Ok(((self.buf[1] as u16) << 8) | (self.buf[0] as u16));
[INFO] [stderr]    |                                                 ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.buf[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/prs.rs:100:22
[INFO] [stderr]     |
[INFO] [stderr] 100 |         let offset = offset as i64;
[INFO] [stderr]     |                      ^^^^^^^^^^^^^ help: try: `i64::from(offset)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]  --> src/util.rs:5:62
[INFO] [stderr]   |
[INFO] [stderr] 5 |     let string_end = buffer.iter().position(|&b| { b == 0 }).unwrap_or(buffer.len());
[INFO] [stderr]   |                                                              ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| buffer.len())`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/util.rs:14:10
[INFO] [stderr]    |
[INFO] [stderr] 14 |         .unwrap_or(buffer.len());
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| buffer.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:61:23
[INFO] [stderr]    |
[INFO] [stderr] 61 | fn read_quests(files: &Vec<&Path>, quests: &mut Vec<read::Result<Quest>>) {
[INFO] [stderr]    |                       ^^^^^^^^^^^ help: change this to: `&[&Path]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:88:26
[INFO] [stderr]    |
[INFO] [stderr] 88 | fn quests_to_csv(quests: &Vec<Quest>) -> csv::Result<()> {
[INFO] [stderr]    |                          ^^^^^^^^^^^ help: change this to: `&[Quest]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:91:38
[INFO] [stderr]    |
[INFO] [stderr] 91 |     let monster_types: Vec<String> = (0..MonsterType::Shambertin as u8 + 1)
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=MonsterType::Shambertin as u8)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:109:25
[INFO] [stderr]     |
[INFO] [stderr] 109 | fn print_quests(quests: &Vec<Quest>) {
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: change this to: `&[Quest]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:115:25
[INFO] [stderr]     |
[INFO] [stderr] 115 |         let max_count = monster_counts.values().fold(0, |acc, &count| { max(acc, count) }) as f64;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(monster_counts.values().fold(0, |acc, &count| { max(acc, count) }))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/read/dat.rs:180:25
[INFO] [stderr]     |
[INFO] [stderr] 180 | fn detect_episode(data: &Vec<MonsterData>) -> Option<Episode> {
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^ help: change this to: `&[MonsterData]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/read/dat.rs:181:9
[INFO] [stderr]     |
[INFO] [stderr] 181 |     for ref monster_data in data {
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^    ---- help: try: `let monster_data = &data;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/read/dat.rs:243:16
[INFO] [stderr]     |
[INFO] [stderr] 243 |         pos += next_header as u64;
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(next_header)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/prs.rs:23:24
[INFO] [stderr]    |
[INFO] [stderr] 23 |                 size = (cxt.read_flag_bit()? as u16) << 1;
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cxt.read_flag_bit()?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/prs.rs:24:25
[INFO] [stderr]    |
[INFO] [stderr] 24 |                 size |= cxt.read_flag_bit()? as u16;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cxt.read_flag_bit()?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change
[INFO] [stderr]   --> src/prs.rs:27:26
[INFO] [stderr]    |
[INFO] [stderr] 27 |                 offset = cxt.read_byte()? as i16 - 256;
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(cxt.read_byte()?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/prs.rs:42:28
[INFO] [stderr]    |
[INFO] [stderr] 42 |                     size = cxt.read_byte()? as u16;
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cxt.read_byte()?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/prs.rs:93:20
[INFO] [stderr]    |
[INFO] [stderr] 93 |         return Ok(((self.buf[1] as u16) << 8) | (self.buf[0] as u16));
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.buf[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/prs.rs:93:49
[INFO] [stderr]    |
[INFO] [stderr] 93 |         return Ok(((self.buf[1] as u16) << 8) | (self.buf[0] as u16));
[INFO] [stderr]    |                                                 ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.buf[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/prs.rs:100:22
[INFO] [stderr]     |
[INFO] [stderr] 100 |         let offset = offset as i64;
[INFO] [stderr]     |                      ^^^^^^^^^^^^^ help: try: `i64::from(offset)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]  --> src/util.rs:5:62
[INFO] [stderr]   |
[INFO] [stderr] 5 |     let string_end = buffer.iter().position(|&b| { b == 0 }).unwrap_or(buffer.len());
[INFO] [stderr]   |                                                              ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| buffer.len())`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/util.rs:14:10
[INFO] [stderr]    |
[INFO] [stderr] 14 |         .unwrap_or(buffer.len());
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| buffer.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:61:23
[INFO] [stderr]    |
[INFO] [stderr] 61 | fn read_quests(files: &Vec<&Path>, quests: &mut Vec<read::Result<Quest>>) {
[INFO] [stderr]    |                       ^^^^^^^^^^^ help: change this to: `&[&Path]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:88:26
[INFO] [stderr]    |
[INFO] [stderr] 88 | fn quests_to_csv(quests: &Vec<Quest>) -> csv::Result<()> {
[INFO] [stderr]    |                          ^^^^^^^^^^^ help: change this to: `&[Quest]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:91:38
[INFO] [stderr]    |
[INFO] [stderr] 91 |     let monster_types: Vec<String> = (0..MonsterType::Shambertin as u8 + 1)
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=MonsterType::Shambertin as u8)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:109:25
[INFO] [stderr]     |
[INFO] [stderr] 109 | fn print_quests(quests: &Vec<Quest>) {
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: change this to: `&[Quest]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:115:25
[INFO] [stderr]     |
[INFO] [stderr] 115 |         let max_count = monster_counts.values().fold(0, |acc, &count| { max(acc, count) }) as f64;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(monster_counts.values().fold(0, |acc, &count| { max(acc, count) }))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 6.99s
[INFO] running `"docker" "inspect" "3dee1abd169da84c43e9819fea526bf8a8263ac201890cf1a862d1f2249bfc84"`
[INFO] running `"docker" "rm" "-f" "3dee1abd169da84c43e9819fea526bf8a8263ac201890cf1a862d1f2249bfc84"`
[INFO] [stdout] 3dee1abd169da84c43e9819fea526bf8a8263ac201890cf1a862d1f2249bfc84