[INFO] updating cached repository DaMrNelson/xrb [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DaMrNelson/xrb [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DaMrNelson/xrb" "work/ex/clippy-test-run/sources/stable/gh/DaMrNelson/xrb"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DaMrNelson/xrb'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DaMrNelson/xrb" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DaMrNelson/xrb"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DaMrNelson/xrb'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 29f8d6bff2a329e017b22aee7bc3e0470bf89237 [INFO] sha for GitHub repo DaMrNelson/xrb: 29f8d6bff2a329e017b22aee7bc3e0470bf89237 [INFO] validating manifest of DaMrNelson/xrb on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DaMrNelson/xrb on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DaMrNelson/xrb [INFO] finished frobbing DaMrNelson/xrb [INFO] frobbed toml for DaMrNelson/xrb written to work/ex/clippy-test-run/sources/stable/gh/DaMrNelson/xrb/Cargo.toml [INFO] started frobbing DaMrNelson/xrb [INFO] finished frobbing DaMrNelson/xrb [INFO] frobbed toml for DaMrNelson/xrb written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DaMrNelson/xrb/Cargo.toml [INFO] crate DaMrNelson/xrb has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting DaMrNelson/xrb against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DaMrNelson/xrb:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0850ee0cd6d035fd53a0b7e10ad78bf6f4d264ede56d9c14afa4fa80e940cfdf [INFO] running `"docker" "start" "-a" "0850ee0cd6d035fd53a0b7e10ad78bf6f4d264ede56d9c14afa4fa80e940cfdf"` [INFO] [stderr] Checking xrb v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | resp_receiver: resp_receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resp_receiver` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | sq_sender: sq_sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sq_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | resp_receiver: resp_receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resp_receiver` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | sq_sender: sq_sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sq_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1431:26 [INFO] [stderr] | [INFO] [stderr] 1431 | red: ((num & 0xFF0000) >> 16) as u16, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1432:28 [INFO] [stderr] | [INFO] [stderr] 1432 | green: ((num & 0x00FF00) >> 8) as u16, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_FF00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1433:26 [INFO] [stderr] | [INFO] [stderr] 1433 | blue: (num & 0x0000FF) as u16 [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models.rs:1438:9 [INFO] [stderr] | [INFO] [stderr] 1438 | return ((self.red as u32) << 16) + ((self.green as u32) << 8) + (self.blue as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((self.red as u32) << 16) + ((self.green as u32) << 8) + (self.blue as u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1519:33 [INFO] [stderr] | [INFO] [stderr] 1519 | &Event::KeyPress => 0x00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1520:35 [INFO] [stderr] | [INFO] [stderr] 1520 | &Event::KeyRelease => 0x00000002, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1521:36 [INFO] [stderr] | [INFO] [stderr] 1521 | &Event::ButtonPress => 0x00000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1522:38 [INFO] [stderr] | [INFO] [stderr] 1522 | &Event::ButtonRelease => 0x00000008, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1523:36 [INFO] [stderr] | [INFO] [stderr] 1523 | &Event::EnterWindow => 0x00000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1524:36 [INFO] [stderr] | [INFO] [stderr] 1524 | &Event::LeaveWindow => 0x00000020, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1525:38 [INFO] [stderr] | [INFO] [stderr] 1525 | &Event::PointerMotion => 0x00000040, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1526:42 [INFO] [stderr] | [INFO] [stderr] 1526 | &Event::PointerMotionHint => 0x00000080, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1527:38 [INFO] [stderr] | [INFO] [stderr] 1527 | &Event::Button1Motion => 0x00000100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1528:38 [INFO] [stderr] | [INFO] [stderr] 1528 | &Event::Button2Motion => 0x00000200, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1529:38 [INFO] [stderr] | [INFO] [stderr] 1529 | &Event::Button3Motion => 0x00000400, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1530:38 [INFO] [stderr] | [INFO] [stderr] 1530 | &Event::Button4Motion => 0x00000800, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1531:38 [INFO] [stderr] | [INFO] [stderr] 1531 | &Event::Button5Motion => 0x00001000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1532:37 [INFO] [stderr] | [INFO] [stderr] 1532 | &Event::ButtonMotion => 0x00002000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1533:36 [INFO] [stderr] | [INFO] [stderr] 1533 | &Event::KeymapState => 0x00004000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1534:33 [INFO] [stderr] | [INFO] [stderr] 1534 | &Event::Exposure => 0x00008000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1535:41 [INFO] [stderr] | [INFO] [stderr] 1535 | &Event::VisibilityChange => 0x00010000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1536:40 [INFO] [stderr] | [INFO] [stderr] 1536 | &Event::StructureNotify => 0x00020000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1537:39 [INFO] [stderr] | [INFO] [stderr] 1537 | &Event::ResizeRedirect => 0x00040000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1538:43 [INFO] [stderr] | [INFO] [stderr] 1538 | &Event::SubstructureNotify => 0x00080000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0008_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1539:45 [INFO] [stderr] | [INFO] [stderr] 1539 | &Event::SubstructureRedirect => 0x00100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1540:36 [INFO] [stderr] | [INFO] [stderr] 1540 | &Event::FocusChange => 0x00200000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1541:39 [INFO] [stderr] | [INFO] [stderr] 1541 | &Event::PropertyChange => 0x00400000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1542:39 [INFO] [stderr] | [INFO] [stderr] 1542 | &Event::ColormapChange => 0x00800000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1543:40 [INFO] [stderr] | [INFO] [stderr] 1543 | &Event::OwnerGrabButton => 0x01000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models.rs:1676:9 [INFO] [stderr] | [INFO] [stderr] 1676 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models.rs:1738:9 [INFO] [stderr] | [INFO] [stderr] 1738 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models.rs:2388:9 [INFO] [stderr] | [INFO] [stderr] 2388 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2596:47 [INFO] [stderr] | [INFO] [stderr] 2596 | &GraphicsContextMask::Function => 0x00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2597:48 [INFO] [stderr] | [INFO] [stderr] 2597 | &GraphicsContextMask::PlaneMask => 0x00000002, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2598:49 [INFO] [stderr] | [INFO] [stderr] 2598 | &GraphicsContextMask::Foreground => 0x00000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2599:49 [INFO] [stderr] | [INFO] [stderr] 2599 | &GraphicsContextMask::Background => 0x00000008, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2600:48 [INFO] [stderr] | [INFO] [stderr] 2600 | &GraphicsContextMask::LineWidth => 0x00000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2601:48 [INFO] [stderr] | [INFO] [stderr] 2601 | &GraphicsContextMask::LineStyle => 0x00000020, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2602:47 [INFO] [stderr] | [INFO] [stderr] 2602 | &GraphicsContextMask::CapStyle => 0x00000040, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2603:48 [INFO] [stderr] | [INFO] [stderr] 2603 | &GraphicsContextMask::JoinStyle => 0x00000080, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2604:48 [INFO] [stderr] | [INFO] [stderr] 2604 | &GraphicsContextMask::FillStyle => 0x00000100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2605:47 [INFO] [stderr] | [INFO] [stderr] 2605 | &GraphicsContextMask::FillRule => 0x00000200, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2606:43 [INFO] [stderr] | [INFO] [stderr] 2606 | &GraphicsContextMask::Tile => 0x00000400, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2607:46 [INFO] [stderr] | [INFO] [stderr] 2607 | &GraphicsContextMask::Stipple => 0x00000800, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2608:57 [INFO] [stderr] | [INFO] [stderr] 2608 | &GraphicsContextMask::TileStippleXOrigin => 0x00001000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2609:57 [INFO] [stderr] | [INFO] [stderr] 2609 | &GraphicsContextMask::TileStippleYOrigin => 0x00002000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2610:43 [INFO] [stderr] | [INFO] [stderr] 2610 | &GraphicsContextMask::Font => 0x00004000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2611:52 [INFO] [stderr] | [INFO] [stderr] 2611 | &GraphicsContextMask::SubWindowMode => 0x00008000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2612:56 [INFO] [stderr] | [INFO] [stderr] 2612 | &GraphicsContextMask::GraphicsExposures => 0x00010000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2613:50 [INFO] [stderr] | [INFO] [stderr] 2613 | &GraphicsContextMask::ClipXOrigin => 0x00020000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2614:50 [INFO] [stderr] | [INFO] [stderr] 2614 | &GraphicsContextMask::ClipYOrigin => 0x00040000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2615:47 [INFO] [stderr] | [INFO] [stderr] 2615 | &GraphicsContextMask::ClipMask => 0x00080000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0008_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2616:49 [INFO] [stderr] | [INFO] [stderr] 2616 | &GraphicsContextMask::DashOffset => 0x00100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2617:45 [INFO] [stderr] | [INFO] [stderr] 2617 | &GraphicsContextMask::Dashes => 0x00200000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2618:46 [INFO] [stderr] | [INFO] [stderr] 2618 | &GraphicsContextMask::ArcMode => 0x00400000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3113:50 [INFO] [stderr] | [INFO] [stderr] 3113 | &WindowValue::BackgroundPixmap(_) => 0x00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3114:49 [INFO] [stderr] | [INFO] [stderr] 3114 | &WindowValue::BackgroundPixel(_) => 0x00000002, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3115:46 [INFO] [stderr] | [INFO] [stderr] 3115 | &WindowValue::BorderPixmap(_) => 0x00000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3116:45 [INFO] [stderr] | [INFO] [stderr] 3116 | &WindowValue::BorderPixel(_) => 0x00000008, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3117:44 [INFO] [stderr] | [INFO] [stderr] 3117 | &WindowValue::BitGravity(_) => 0x00000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3118:44 [INFO] [stderr] | [INFO] [stderr] 3118 | &WindowValue::WinGravity(_) => 0x00000020, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3119:46 [INFO] [stderr] | [INFO] [stderr] 3119 | &WindowValue::BackingStore(_) => 0x00000040, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3120:47 [INFO] [stderr] | [INFO] [stderr] 3120 | &WindowValue::BackingPlanes(_) => 0x00000080, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3121:46 [INFO] [stderr] | [INFO] [stderr] 3121 | &WindowValue::BackingPixel(_) => 0x00000100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3122:50 [INFO] [stderr] | [INFO] [stderr] 3122 | &WindowValue::OverrideRedirect(_) => 0x00000200, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3123:43 [INFO] [stderr] | [INFO] [stderr] 3123 | &WindowValue::SaveUnder(_) => 0x00000400, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3124:43 [INFO] [stderr] | [INFO] [stderr] 3124 | &WindowValue::EventMask(_) => 0x00000800, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3125:52 [INFO] [stderr] | [INFO] [stderr] 3125 | &WindowValue::DoNotPropagateMask(_) => 0x00001000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3126:42 [INFO] [stderr] | [INFO] [stderr] 3126 | &WindowValue::Colormap(_) => 0x00002000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3127:40 [INFO] [stderr] | [INFO] [stderr] 3127 | &WindowValue::Cursor(_) => 0x00004000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3181:51 [INFO] [stderr] | [INFO] [stderr] 3181 | &GraphicsContextValue::Function(_) => 0x00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3182:52 [INFO] [stderr] | [INFO] [stderr] 3182 | &GraphicsContextValue::PlaneMask(_) => 0x00000002, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3183:53 [INFO] [stderr] | [INFO] [stderr] 3183 | &GraphicsContextValue::Foreground(_) => 0x00000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3184:53 [INFO] [stderr] | [INFO] [stderr] 3184 | &GraphicsContextValue::Background(_) => 0x00000008, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3185:52 [INFO] [stderr] | [INFO] [stderr] 3185 | &GraphicsContextValue::LineWidth(_) => 0x00000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3186:52 [INFO] [stderr] | [INFO] [stderr] 3186 | &GraphicsContextValue::LineStyle(_) => 0x00000020, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3187:51 [INFO] [stderr] | [INFO] [stderr] 3187 | &GraphicsContextValue::CapStyle(_) => 0x00000040, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3188:52 [INFO] [stderr] | [INFO] [stderr] 3188 | &GraphicsContextValue::JoinStyle(_) => 0x00000080, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3189:52 [INFO] [stderr] | [INFO] [stderr] 3189 | &GraphicsContextValue::FillStyle(_) => 0x00000100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3190:51 [INFO] [stderr] | [INFO] [stderr] 3190 | &GraphicsContextValue::FillRule(_) => 0x00000200, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3191:47 [INFO] [stderr] | [INFO] [stderr] 3191 | &GraphicsContextValue::Tile(_) => 0x00000400, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3192:50 [INFO] [stderr] | [INFO] [stderr] 3192 | &GraphicsContextValue::Stipple(_) => 0x00000800, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3193:61 [INFO] [stderr] | [INFO] [stderr] 3193 | &GraphicsContextValue::TileStippleXOrigin(_) => 0x00001000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3194:61 [INFO] [stderr] | [INFO] [stderr] 3194 | &GraphicsContextValue::TileStippleYOrigin(_) => 0x00002000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3195:47 [INFO] [stderr] | [INFO] [stderr] 3195 | &GraphicsContextValue::Font(_) => 0x00004000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3196:56 [INFO] [stderr] | [INFO] [stderr] 3196 | &GraphicsContextValue::SubWindowMode(_) => 0x00008000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3197:60 [INFO] [stderr] | [INFO] [stderr] 3197 | &GraphicsContextValue::GraphicsExposures(_) => 0x00010000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3198:54 [INFO] [stderr] | [INFO] [stderr] 3198 | &GraphicsContextValue::ClipXOrigin(_) => 0x00020000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3199:54 [INFO] [stderr] | [INFO] [stderr] 3199 | &GraphicsContextValue::ClipYOrigin(_) => 0x00040000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3200:51 [INFO] [stderr] | [INFO] [stderr] 3200 | &GraphicsContextValue::ClipMask(_) => 0x00080000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0008_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3201:53 [INFO] [stderr] | [INFO] [stderr] 3201 | &GraphicsContextValue::DashOffset(_) => 0x00100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3202:49 [INFO] [stderr] | [INFO] [stderr] 3202 | &GraphicsContextValue::Dashes(_) => 0x00200000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3203:50 [INFO] [stderr] | [INFO] [stderr] 3203 | &GraphicsContextValue::ArcMode(_) => 0x00400000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `BufReader` [INFO] [stderr] --> src/xreaderwriter.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::{BufReader}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/xreaderwriter.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / return CharInfo { [INFO] [stderr] 113 | | left_side_bearing: self.read_i16(), [INFO] [stderr] 114 | | right_side_bearing: self.read_i16(), [INFO] [stderr] 115 | | character_width: self.read_i16(), [INFO] [stderr] ... | [INFO] [stderr] 118 | | attributes: self.read_u16() [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 112 | CharInfo { [INFO] [stderr] 113 | left_side_bearing: self.read_i16(), [INFO] [stderr] 114 | right_side_bearing: self.read_i16(), [INFO] [stderr] 115 | character_width: self.read_i16(), [INFO] [stderr] 116 | ascent: self.read_i16(), [INFO] [stderr] 117 | descent: self.read_i16(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/xreaderwriter.rs:876:9 [INFO] [stderr] | [INFO] [stderr] 876 | return Some(ServerEvent::KeymapNotify { keys }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(ServerEvent::KeymapNotify { keys })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `BufReader` [INFO] [stderr] --> src/lib.rs:8:26 [INFO] [stderr] | [INFO] [stderr] 8 | use std::io::{BufWriter, BufReader}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:208:52 [INFO] [stderr] | [INFO] [stderr] 208 | let opcode = opcode_original & 0b0111111; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:209:55 [INFO] [stderr] | [INFO] [stderr] 209 | let generated = opcode_original & 0b10000000 == 0x1; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2291:9 [INFO] [stderr] | [INFO] [stderr] 2291 | return Some(()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2575:13 [INFO] [stderr] | [INFO] [stderr] 2575 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2578:13 [INFO] [stderr] | [INFO] [stderr] 2578 | return 4 - len % 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `4 - len % 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1431:26 [INFO] [stderr] | [INFO] [stderr] 1431 | red: ((num & 0xFF0000) >> 16) as u16, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1432:28 [INFO] [stderr] | [INFO] [stderr] 1432 | green: ((num & 0x00FF00) >> 8) as u16, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_FF00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1433:26 [INFO] [stderr] | [INFO] [stderr] 1433 | blue: (num & 0x0000FF) as u16 [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models.rs:1438:9 [INFO] [stderr] | [INFO] [stderr] 1438 | return ((self.red as u32) << 16) + ((self.green as u32) << 8) + (self.blue as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((self.red as u32) << 16) + ((self.green as u32) << 8) + (self.blue as u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1519:33 [INFO] [stderr] | [INFO] [stderr] 1519 | &Event::KeyPress => 0x00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1520:35 [INFO] [stderr] | [INFO] [stderr] 1520 | &Event::KeyRelease => 0x00000002, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1521:36 [INFO] [stderr] | [INFO] [stderr] 1521 | &Event::ButtonPress => 0x00000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1522:38 [INFO] [stderr] | [INFO] [stderr] 1522 | &Event::ButtonRelease => 0x00000008, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1523:36 [INFO] [stderr] | [INFO] [stderr] 1523 | &Event::EnterWindow => 0x00000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1524:36 [INFO] [stderr] | [INFO] [stderr] 1524 | &Event::LeaveWindow => 0x00000020, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1525:38 [INFO] [stderr] | [INFO] [stderr] 1525 | &Event::PointerMotion => 0x00000040, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1526:42 [INFO] [stderr] | [INFO] [stderr] 1526 | &Event::PointerMotionHint => 0x00000080, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1527:38 [INFO] [stderr] | [INFO] [stderr] 1527 | &Event::Button1Motion => 0x00000100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1528:38 [INFO] [stderr] | [INFO] [stderr] 1528 | &Event::Button2Motion => 0x00000200, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1529:38 [INFO] [stderr] | [INFO] [stderr] 1529 | &Event::Button3Motion => 0x00000400, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1530:38 [INFO] [stderr] | [INFO] [stderr] 1530 | &Event::Button4Motion => 0x00000800, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1531:38 [INFO] [stderr] | [INFO] [stderr] 1531 | &Event::Button5Motion => 0x00001000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1532:37 [INFO] [stderr] | [INFO] [stderr] 1532 | &Event::ButtonMotion => 0x00002000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1533:36 [INFO] [stderr] | [INFO] [stderr] 1533 | &Event::KeymapState => 0x00004000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1534:33 [INFO] [stderr] | [INFO] [stderr] 1534 | &Event::Exposure => 0x00008000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1535:41 [INFO] [stderr] | [INFO] [stderr] 1535 | &Event::VisibilityChange => 0x00010000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1536:40 [INFO] [stderr] | [INFO] [stderr] 1536 | &Event::StructureNotify => 0x00020000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1537:39 [INFO] [stderr] | [INFO] [stderr] 1537 | &Event::ResizeRedirect => 0x00040000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1538:43 [INFO] [stderr] | [INFO] [stderr] 1538 | &Event::SubstructureNotify => 0x00080000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0008_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1539:45 [INFO] [stderr] | [INFO] [stderr] 1539 | &Event::SubstructureRedirect => 0x00100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1540:36 [INFO] [stderr] | [INFO] [stderr] 1540 | &Event::FocusChange => 0x00200000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1541:39 [INFO] [stderr] | [INFO] [stderr] 1541 | &Event::PropertyChange => 0x00400000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1542:39 [INFO] [stderr] | [INFO] [stderr] 1542 | &Event::ColormapChange => 0x00800000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:1543:40 [INFO] [stderr] | [INFO] [stderr] 1543 | &Event::OwnerGrabButton => 0x01000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models.rs:1676:9 [INFO] [stderr] | [INFO] [stderr] 1676 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models.rs:1738:9 [INFO] [stderr] | [INFO] [stderr] 1738 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models.rs:2388:9 [INFO] [stderr] | [INFO] [stderr] 2388 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2596:47 [INFO] [stderr] | [INFO] [stderr] 2596 | &GraphicsContextMask::Function => 0x00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2597:48 [INFO] [stderr] | [INFO] [stderr] 2597 | &GraphicsContextMask::PlaneMask => 0x00000002, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2598:49 [INFO] [stderr] | [INFO] [stderr] 2598 | &GraphicsContextMask::Foreground => 0x00000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2599:49 [INFO] [stderr] | [INFO] [stderr] 2599 | &GraphicsContextMask::Background => 0x00000008, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2600:48 [INFO] [stderr] | [INFO] [stderr] 2600 | &GraphicsContextMask::LineWidth => 0x00000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2601:48 [INFO] [stderr] | [INFO] [stderr] 2601 | &GraphicsContextMask::LineStyle => 0x00000020, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2602:47 [INFO] [stderr] | [INFO] [stderr] 2602 | &GraphicsContextMask::CapStyle => 0x00000040, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2603:48 [INFO] [stderr] | [INFO] [stderr] 2603 | &GraphicsContextMask::JoinStyle => 0x00000080, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2604:48 [INFO] [stderr] | [INFO] [stderr] 2604 | &GraphicsContextMask::FillStyle => 0x00000100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2605:47 [INFO] [stderr] | [INFO] [stderr] 2605 | &GraphicsContextMask::FillRule => 0x00000200, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2606:43 [INFO] [stderr] | [INFO] [stderr] 2606 | &GraphicsContextMask::Tile => 0x00000400, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2607:46 [INFO] [stderr] | [INFO] [stderr] 2607 | &GraphicsContextMask::Stipple => 0x00000800, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2608:57 [INFO] [stderr] | [INFO] [stderr] 2608 | &GraphicsContextMask::TileStippleXOrigin => 0x00001000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2609:57 [INFO] [stderr] | [INFO] [stderr] 2609 | &GraphicsContextMask::TileStippleYOrigin => 0x00002000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2610:43 [INFO] [stderr] | [INFO] [stderr] 2610 | &GraphicsContextMask::Font => 0x00004000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2611:52 [INFO] [stderr] | [INFO] [stderr] 2611 | &GraphicsContextMask::SubWindowMode => 0x00008000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2612:56 [INFO] [stderr] | [INFO] [stderr] 2612 | &GraphicsContextMask::GraphicsExposures => 0x00010000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2613:50 [INFO] [stderr] | [INFO] [stderr] 2613 | &GraphicsContextMask::ClipXOrigin => 0x00020000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2614:50 [INFO] [stderr] | [INFO] [stderr] 2614 | &GraphicsContextMask::ClipYOrigin => 0x00040000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2615:47 [INFO] [stderr] | [INFO] [stderr] 2615 | &GraphicsContextMask::ClipMask => 0x00080000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0008_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2616:49 [INFO] [stderr] | [INFO] [stderr] 2616 | &GraphicsContextMask::DashOffset => 0x00100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2617:45 [INFO] [stderr] | [INFO] [stderr] 2617 | &GraphicsContextMask::Dashes => 0x00200000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:2618:46 [INFO] [stderr] | [INFO] [stderr] 2618 | &GraphicsContextMask::ArcMode => 0x00400000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3113:50 [INFO] [stderr] | [INFO] [stderr] 3113 | &WindowValue::BackgroundPixmap(_) => 0x00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3114:49 [INFO] [stderr] | [INFO] [stderr] 3114 | &WindowValue::BackgroundPixel(_) => 0x00000002, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3115:46 [INFO] [stderr] | [INFO] [stderr] 3115 | &WindowValue::BorderPixmap(_) => 0x00000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3116:45 [INFO] [stderr] | [INFO] [stderr] 3116 | &WindowValue::BorderPixel(_) => 0x00000008, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3117:44 [INFO] [stderr] | [INFO] [stderr] 3117 | &WindowValue::BitGravity(_) => 0x00000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3118:44 [INFO] [stderr] | [INFO] [stderr] 3118 | &WindowValue::WinGravity(_) => 0x00000020, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3119:46 [INFO] [stderr] | [INFO] [stderr] 3119 | &WindowValue::BackingStore(_) => 0x00000040, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3120:47 [INFO] [stderr] | [INFO] [stderr] 3120 | &WindowValue::BackingPlanes(_) => 0x00000080, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3121:46 [INFO] [stderr] | [INFO] [stderr] 3121 | &WindowValue::BackingPixel(_) => 0x00000100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3122:50 [INFO] [stderr] | [INFO] [stderr] 3122 | &WindowValue::OverrideRedirect(_) => 0x00000200, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3123:43 [INFO] [stderr] | [INFO] [stderr] 3123 | &WindowValue::SaveUnder(_) => 0x00000400, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3124:43 [INFO] [stderr] | [INFO] [stderr] 3124 | &WindowValue::EventMask(_) => 0x00000800, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3125:52 [INFO] [stderr] | [INFO] [stderr] 3125 | &WindowValue::DoNotPropagateMask(_) => 0x00001000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3126:42 [INFO] [stderr] | [INFO] [stderr] 3126 | &WindowValue::Colormap(_) => 0x00002000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3127:40 [INFO] [stderr] | [INFO] [stderr] 3127 | &WindowValue::Cursor(_) => 0x00004000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3181:51 [INFO] [stderr] | [INFO] [stderr] 3181 | &GraphicsContextValue::Function(_) => 0x00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3182:52 [INFO] [stderr] | [INFO] [stderr] 3182 | &GraphicsContextValue::PlaneMask(_) => 0x00000002, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3183:53 [INFO] [stderr] | [INFO] [stderr] 3183 | &GraphicsContextValue::Foreground(_) => 0x00000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3184:53 [INFO] [stderr] | [INFO] [stderr] 3184 | &GraphicsContextValue::Background(_) => 0x00000008, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3185:52 [INFO] [stderr] | [INFO] [stderr] 3185 | &GraphicsContextValue::LineWidth(_) => 0x00000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3186:52 [INFO] [stderr] | [INFO] [stderr] 3186 | &GraphicsContextValue::LineStyle(_) => 0x00000020, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3187:51 [INFO] [stderr] | [INFO] [stderr] 3187 | &GraphicsContextValue::CapStyle(_) => 0x00000040, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3188:52 [INFO] [stderr] | [INFO] [stderr] 3188 | &GraphicsContextValue::JoinStyle(_) => 0x00000080, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3189:52 [INFO] [stderr] | [INFO] [stderr] 3189 | &GraphicsContextValue::FillStyle(_) => 0x00000100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3190:51 [INFO] [stderr] | [INFO] [stderr] 3190 | &GraphicsContextValue::FillRule(_) => 0x00000200, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3191:47 [INFO] [stderr] | [INFO] [stderr] 3191 | &GraphicsContextValue::Tile(_) => 0x00000400, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3192:50 [INFO] [stderr] | [INFO] [stderr] 3192 | &GraphicsContextValue::Stipple(_) => 0x00000800, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3193:61 [INFO] [stderr] | [INFO] [stderr] 3193 | &GraphicsContextValue::TileStippleXOrigin(_) => 0x00001000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3194:61 [INFO] [stderr] | [INFO] [stderr] 3194 | &GraphicsContextValue::TileStippleYOrigin(_) => 0x00002000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3195:47 [INFO] [stderr] | [INFO] [stderr] 3195 | &GraphicsContextValue::Font(_) => 0x00004000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3196:56 [INFO] [stderr] | [INFO] [stderr] 3196 | &GraphicsContextValue::SubWindowMode(_) => 0x00008000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3197:60 [INFO] [stderr] | [INFO] [stderr] 3197 | &GraphicsContextValue::GraphicsExposures(_) => 0x00010000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3198:54 [INFO] [stderr] | [INFO] [stderr] 3198 | &GraphicsContextValue::ClipXOrigin(_) => 0x00020000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3199:54 [INFO] [stderr] | [INFO] [stderr] 3199 | &GraphicsContextValue::ClipYOrigin(_) => 0x00040000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3200:51 [INFO] [stderr] | [INFO] [stderr] 3200 | &GraphicsContextValue::ClipMask(_) => 0x00080000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0008_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3201:53 [INFO] [stderr] | [INFO] [stderr] 3201 | &GraphicsContextValue::DashOffset(_) => 0x00100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3202:49 [INFO] [stderr] | [INFO] [stderr] 3202 | &GraphicsContextValue::Dashes(_) => 0x00200000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models.rs:3203:50 [INFO] [stderr] | [INFO] [stderr] 3203 | &GraphicsContextValue::ArcMode(_) => 0x00400000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `BufReader` [INFO] [stderr] --> src/xreaderwriter.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::{BufReader}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/xreaderwriter.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / return CharInfo { [INFO] [stderr] 113 | | left_side_bearing: self.read_i16(), [INFO] [stderr] 114 | | right_side_bearing: self.read_i16(), [INFO] [stderr] 115 | | character_width: self.read_i16(), [INFO] [stderr] ... | [INFO] [stderr] 118 | | attributes: self.read_u16() [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 112 | CharInfo { [INFO] [stderr] 113 | left_side_bearing: self.read_i16(), [INFO] [stderr] 114 | right_side_bearing: self.read_i16(), [INFO] [stderr] 115 | character_width: self.read_i16(), [INFO] [stderr] 116 | ascent: self.read_i16(), [INFO] [stderr] 117 | descent: self.read_i16(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/xreaderwriter.rs:876:9 [INFO] [stderr] | [INFO] [stderr] 876 | return Some(ServerEvent::KeymapNotify { keys }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(ServerEvent::KeymapNotify { keys })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `BufReader` [INFO] [stderr] --> src/lib.rs:8:26 [INFO] [stderr] | [INFO] [stderr] 8 | use std::io::{BufWriter, BufReader}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:208:52 [INFO] [stderr] | [INFO] [stderr] 208 | let opcode = opcode_original & 0b0111111; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:209:55 [INFO] [stderr] | [INFO] [stderr] 209 | let generated = opcode_original & 0b10000000 == 0x1; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2291:9 [INFO] [stderr] | [INFO] [stderr] 2291 | return Some(()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2575:13 [INFO] [stderr] | [INFO] [stderr] 2575 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2578:13 [INFO] [stderr] | [INFO] [stderr] 2578 | return 4 - len % 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `4 - len % 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/lib.rs:229:37 [INFO] [stderr] | [INFO] [stderr] 229 | ServerReplyType::GetWindowAttributes => reader.read_get_window_attributes_reply(detail), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/lib.rs:247:37 [INFO] [stderr] | [INFO] [stderr] 247 | ServerReplyType::ListFontsWithInfo => reader.read_list_fonts_with_info_reply(detail), // Note: One request will generate multiple replies here. The info specifies how to determine this [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `map_is_installed` [INFO] [stderr] --> src/models.rs:916:116 [INFO] [stderr] | [INFO] [stderr] 916 | let (backing_store, visual, class, bit_gravity, window_gravity, backing_planes, backing_pixel, save_under, map_is_installed, map_state, override_redirect, colormap, all_event_masks, your_event_mask, do_not_propagate_mask) = match client.wait_for_response(seq2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_map_is_installed` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `map_state` [INFO] [stderr] --> src/models.rs:916:134 [INFO] [stderr] | [INFO] [stderr] 916 | let (backing_store, visual, class, bit_gravity, window_gravity, backing_planes, backing_pixel, save_under, map_is_installed, map_state, override_redirect, colormap, all_event_masks, your_event_mask, do_not_propagate_mask) = match client.wait_for_response(seq2) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_map_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `all_event_masks` [INFO] [stderr] --> src/models.rs:916:174 [INFO] [stderr] | [INFO] [stderr] 916 | let (backing_store, visual, class, bit_gravity, window_gravity, backing_planes, backing_pixel, save_under, map_is_installed, map_state, override_redirect, colormap, all_event_masks, your_event_mask, do_not_propagate_mask) = match client.wait_for_response(seq2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_all_event_masks` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/models.rs:1010:43 [INFO] [stderr] | [INFO] [stderr] 1010 | WindowConfigureValue::Sibling(val) => (), [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/models.rs:1011:45 [INFO] [stderr] | [INFO] [stderr] 1011 | WindowConfigureValue::StackMode(val) => () [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/models.rs:1025:47 [INFO] [stderr] | [INFO] [stderr] 1025 | WindowConfigureValue::Sibling(val) => (), [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/models.rs:1026:49 [INFO] [stderr] | [INFO] [stderr] 1026 | WindowConfigureValue::StackMode(val) => () [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `vtype` [INFO] [stderr] --> src/models.rs:1053:17 [INFO] [stderr] | [INFO] [stderr] 1053 | Ok((vtype, value)) => { [INFO] [stderr] | ^^^^^ help: consider using `_vtype` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/models.rs:1056:25 [INFO] [stderr] | [INFO] [stderr] 1056 | Err(err) => None [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/models.rs:1059:17 [INFO] [stderr] | [INFO] [stderr] 1059 | Err(val) => None [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes_after` [INFO] [stderr] --> src/xreaderwriter.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | let bytes_after = self.read_u32(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_bytes_after` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len` [INFO] [stderr] --> src/xreaderwriter.rs:398:17 [INFO] [stderr] | [INFO] [stderr] 398 | let len = self.read_u16(); [INFO] [stderr] | ^^^ help: consider using `_len` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/xreaderwriter.rs:582:13 [INFO] [stderr] | [INFO] [stderr] 582 | for i in 0..keycode_count { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `j` [INFO] [stderr] --> src/xreaderwriter.rs:585:17 [INFO] [stderr] | [INFO] [stderr] 585 | for j in 0..keysyms_count { [INFO] [stderr] | ^ help: consider using `_j` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `atom` [INFO] [stderr] --> src/lib.rs:645:37 [INFO] [stderr] | [INFO] [stderr] 645 | pub fn get_atom_name(&mut self, atom: u32) -> u16 { [INFO] [stderr] | ^^^^ help: consider using `_atom` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pad` [INFO] [stderr] --> src/lib.rs:667:13 [INFO] [stderr] | [INFO] [stderr] 667 | let pad = self.write_dynamic_len(6, data.len()); [INFO] [stderr] | ^^^ help: consider using `_pad` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bit_plane` [INFO] [stderr] --> src/lib.rs:1694:138 [INFO] [stderr] | [INFO] [stderr] 1694 | pub fn copy_plane(&mut self, src: u32, dst: u32, gcid: u32, src_x: i16, src_y: i16, dst_x: i16, dst_y: i16, width: u16, height: u16, bit_plane: u32) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_bit_plane` instead [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/lib.rs:229:37 [INFO] [stderr] | [INFO] [stderr] 229 | ServerReplyType::GetWindowAttributes => reader.read_get_window_attributes_reply(detail), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/lib.rs:247:37 [INFO] [stderr] | [INFO] [stderr] 247 | ServerReplyType::ListFontsWithInfo => reader.read_list_fonts_with_info_reply(detail), // Note: One request will generate multiple replies here. The info specifies how to determine this [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `map_is_installed` [INFO] [stderr] --> src/models.rs:916:116 [INFO] [stderr] | [INFO] [stderr] 916 | let (backing_store, visual, class, bit_gravity, window_gravity, backing_planes, backing_pixel, save_under, map_is_installed, map_state, override_redirect, colormap, all_event_masks, your_event_mask, do_not_propagate_mask) = match client.wait_for_response(seq2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_map_is_installed` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `map_state` [INFO] [stderr] --> src/models.rs:916:134 [INFO] [stderr] | [INFO] [stderr] 916 | let (backing_store, visual, class, bit_gravity, window_gravity, backing_planes, backing_pixel, save_under, map_is_installed, map_state, override_redirect, colormap, all_event_masks, your_event_mask, do_not_propagate_mask) = match client.wait_for_response(seq2) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_map_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `all_event_masks` [INFO] [stderr] --> src/models.rs:916:174 [INFO] [stderr] | [INFO] [stderr] 916 | let (backing_store, visual, class, bit_gravity, window_gravity, backing_planes, backing_pixel, save_under, map_is_installed, map_state, override_redirect, colormap, all_event_masks, your_event_mask, do_not_propagate_mask) = match client.wait_for_response(seq2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_all_event_masks` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/models.rs:1010:43 [INFO] [stderr] | [INFO] [stderr] 1010 | WindowConfigureValue::Sibling(val) => (), [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/models.rs:1011:45 [INFO] [stderr] | [INFO] [stderr] 1011 | WindowConfigureValue::StackMode(val) => () [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/models.rs:1025:47 [INFO] [stderr] | [INFO] [stderr] 1025 | WindowConfigureValue::Sibling(val) => (), [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/models.rs:1026:49 [INFO] [stderr] | [INFO] [stderr] 1026 | WindowConfigureValue::StackMode(val) => () [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `vtype` [INFO] [stderr] --> src/models.rs:1053:17 [INFO] [stderr] | [INFO] [stderr] 1053 | Ok((vtype, value)) => { [INFO] [stderr] | ^^^^^ help: consider using `_vtype` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/models.rs:1056:25 [INFO] [stderr] | [INFO] [stderr] 1056 | Err(err) => None [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/models.rs:1059:17 [INFO] [stderr] | [INFO] [stderr] 1059 | Err(val) => None [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes_after` [INFO] [stderr] --> src/xreaderwriter.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | let bytes_after = self.read_u32(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_bytes_after` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len` [INFO] [stderr] --> src/xreaderwriter.rs:398:17 [INFO] [stderr] | [INFO] [stderr] 398 | let len = self.read_u16(); [INFO] [stderr] | ^^^ help: consider using `_len` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/xreaderwriter.rs:582:13 [INFO] [stderr] | [INFO] [stderr] 582 | for i in 0..keycode_count { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `j` [INFO] [stderr] --> src/xreaderwriter.rs:585:17 [INFO] [stderr] | [INFO] [stderr] 585 | for j in 0..keysyms_count { [INFO] [stderr] | ^ help: consider using `_j` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `atom` [INFO] [stderr] --> src/lib.rs:645:37 [INFO] [stderr] | [INFO] [stderr] 645 | pub fn get_atom_name(&mut self, atom: u32) -> u16 { [INFO] [stderr] | ^^^^ help: consider using `_atom` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pad` [INFO] [stderr] --> src/lib.rs:667:13 [INFO] [stderr] | [INFO] [stderr] 667 | let pad = self.write_dynamic_len(6, data.len()); [INFO] [stderr] | ^^^ help: consider using `_pad` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bit_plane` [INFO] [stderr] --> src/lib.rs:1694:138 [INFO] [stderr] | [INFO] [stderr] 1694 | pub fn copy_plane(&mut self, src: u32, dst: u32, gcid: u32, src_x: i16, src_y: i16, dst_x: i16, dst_y: i16, width: u16, height: u16, bit_plane: u32) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_bit_plane` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/xreaderwriter.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | let mut len = match format { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/xreaderwriter.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | let mut len = match format { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:714:79 [INFO] [stderr] | [INFO] [stderr] 714 | fn draw_point(&self, client: &mut XClient, gcid: u32, point: Point, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateMode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:719:87 [INFO] [stderr] | [INFO] [stderr] 719 | fn draw_points(&self, client: &mut XClient, gcid: u32, points: &Vec, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:724:78 [INFO] [stderr] | [INFO] [stderr] 724 | fn draw_line(&self, client: &mut XClient, gcid: u32, point: Point, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:729:86 [INFO] [stderr] | [INFO] [stderr] 729 | fn draw_lines(&self, client: &mut XClient, gcid: u32, points: &Vec, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:764:79 [INFO] [stderr] | [INFO] [stderr] 764 | fn fill_poly(&self, client: &mut XClient, gcid: u32, point: Point, shape: &PolyShape, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `PolyShape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:764:97 [INFO] [stderr] | [INFO] [stderr] 764 | fn fill_poly(&self, client: &mut XClient, gcid: u32, point: Point, shape: &PolyShape, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:769:87 [INFO] [stderr] | [INFO] [stderr] 769 | fn fill_polys(&self, client: &mut XClient, gcid: u32, points: &Vec, shape: &PolyShape, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `PolyShape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:769:105 [INFO] [stderr] | [INFO] [stderr] 769 | fn fill_polys(&self, client: &mut XClient, gcid: u32, points: &Vec, shape: &PolyShape, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:794:148 [INFO] [stderr] | [INFO] [stderr] 794 | fn put_image(&self, client: &mut XClient, gcid: u32, data: &Vec, width: u16, height: u16, x: i16, y: i16, left_pad: u8, depth: u8, format: &ImageFormat) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `ImageFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:802:113 [INFO] [stderr] | [INFO] [stderr] 802 | fn get_image(&self, client: &mut XClient, x: i16, y: i16, width: u16, height: u16, plane_mask: u32, format: &ImageFormat) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `ImageFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:719:68 [INFO] [stderr] | [INFO] [stderr] 719 | fn draw_points(&self, client: &mut XClient, gcid: u32, points: &Vec, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:714:79 [INFO] [stderr] | [INFO] [stderr] 714 | fn draw_point(&self, client: &mut XClient, gcid: u32, point: Point, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateMode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:719:87 [INFO] [stderr] | [INFO] [stderr] 719 | fn draw_points(&self, client: &mut XClient, gcid: u32, points: &Vec, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:724:78 [INFO] [stderr] | [INFO] [stderr] 724 | fn draw_line(&self, client: &mut XClient, gcid: u32, point: Point, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:729:67 [INFO] [stderr] | [INFO] [stderr] 729 | fn draw_lines(&self, client: &mut XClient, gcid: u32, points: &Vec, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:729:86 [INFO] [stderr] | [INFO] [stderr] 729 | fn draw_lines(&self, client: &mut XClient, gcid: u32, points: &Vec, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:764:79 [INFO] [stderr] | [INFO] [stderr] 764 | fn fill_poly(&self, client: &mut XClient, gcid: u32, point: Point, shape: &PolyShape, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `PolyShape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:764:97 [INFO] [stderr] | [INFO] [stderr] 764 | fn fill_poly(&self, client: &mut XClient, gcid: u32, point: Point, shape: &PolyShape, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:739:68 [INFO] [stderr] | [INFO] [stderr] 739 | fn draw_segs(&self, client: &mut XClient, gcid: u32, segments: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Segment]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:769:87 [INFO] [stderr] | [INFO] [stderr] 769 | fn fill_polys(&self, client: &mut XClient, gcid: u32, points: &Vec, shape: &PolyShape, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `PolyShape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:769:105 [INFO] [stderr] | [INFO] [stderr] 769 | fn fill_polys(&self, client: &mut XClient, gcid: u32, points: &Vec, shape: &PolyShape, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:794:148 [INFO] [stderr] | [INFO] [stderr] 794 | fn put_image(&self, client: &mut XClient, gcid: u32, data: &Vec, width: u16, height: u16, x: i16, y: i16, left_pad: u8, depth: u8, format: &ImageFormat) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `ImageFormat` [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:749:71 [INFO] [stderr] | [INFO] [stderr] 749 | fn draw_rects(&self, client: &mut XClient, gcid: u32, rectangles: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Rectangle]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:802:113 [INFO] [stderr] | [INFO] [stderr] 802 | fn get_image(&self, client: &mut XClient, x: i16, y: i16, width: u16, height: u16, plane_mask: u32, format: &ImageFormat) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `ImageFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:759:64 [INFO] [stderr] | [INFO] [stderr] 759 | fn draw_arcs(&self, client: &mut XClient, gcid: u32, arcs: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Arc]` [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:719:68 [INFO] [stderr] | [INFO] [stderr] 719 | fn draw_points(&self, client: &mut XClient, gcid: u32, points: &Vec, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:729:67 [INFO] [stderr] | [INFO] [stderr] 729 | fn draw_lines(&self, client: &mut XClient, gcid: u32, points: &Vec, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:769:67 [INFO] [stderr] | [INFO] [stderr] 769 | fn fill_polys(&self, client: &mut XClient, gcid: u32, points: &Vec, shape: &PolyShape, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:739:68 [INFO] [stderr] | [INFO] [stderr] 739 | fn draw_segs(&self, client: &mut XClient, gcid: u32, segments: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Segment]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:779:71 [INFO] [stderr] | [INFO] [stderr] 779 | fn fill_rects(&self, client: &mut XClient, gcid: u32, rectangles: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Rectangle]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:749:71 [INFO] [stderr] --> src/models.rs:789:69 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 749 | fn draw_rects(&self, client: &mut XClient, gcid: u32, rectangles: &Vec) { [INFO] [stderr] 789 | fn poly_fill_arcs(&self, client: &mut XClient, gcid: u32, arcs: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Arc]` [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Rectangle]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:794:64 [INFO] [stderr] | [INFO] [stderr] 794 | fn put_image(&self, client: &mut XClient, gcid: u32, data: &Vec, width: u16, height: u16, x: i16, y: i16, left_pad: u8, depth: u8, format: &ImageFormat) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/models.rs:794:5 [INFO] [stderr] | [INFO] [stderr] 794 | / fn put_image(&self, client: &mut XClient, gcid: u32, data: &Vec, width: u16, height: u16, x: i16, y: i16, left_pad: u8, depth: u8, format: &ImageFormat) { [INFO] [stderr] 795 | | client.put_image(self.get_drawable(), gcid, data, width, height, x, y, left_pad, depth, format) [INFO] [stderr] 796 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/models.rs:794:5 [INFO] [stderr] | [INFO] [stderr] 794 | / fn put_image(&self, client: &mut XClient, gcid: u32, data: &Vec, width: u16, height: u16, x: i16, y: i16, left_pad: u8, depth: u8, format: &ImageFormat) { [INFO] [stderr] 795 | | client.put_image(self.get_drawable(), gcid, data, width, height, x, y, left_pad, depth, format) [INFO] [stderr] 796 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:759:64 [INFO] [stderr] | [INFO] [stderr] 759 | fn draw_arcs(&self, client: &mut XClient, gcid: u32, arcs: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Arc]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/models.rs:802:5 [INFO] [stderr] | [INFO] [stderr] 802 | / fn get_image(&self, client: &mut XClient, x: i16, y: i16, width: u16, height: u16, plane_mask: u32, format: &ImageFormat) -> u16 { [INFO] [stderr] 803 | | client.get_image(self.get_drawable(), x, y, width, height, plane_mask, format) [INFO] [stderr] 804 | | // TODO: Sync get_image [INFO] [stderr] 805 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:769:67 [INFO] [stderr] | [INFO] [stderr] 769 | fn fill_polys(&self, client: &mut XClient, gcid: u32, points: &Vec, shape: &PolyShape, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:779:71 [INFO] [stderr] | [INFO] [stderr] 779 | fn fill_rects(&self, client: &mut XClient, gcid: u32, rectangles: &Vec) { [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:821:97 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Rectangle]` [INFO] [stderr] | [INFO] [stderr] 821 | fn poly_text8s(&self, client: &mut XClient, gcid: u32, x: i16, y: i16, texts: &Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:789:69 [INFO] [stderr] | [INFO] [stderr] 789 | fn poly_fill_arcs(&self, client: &mut XClient, gcid: u32, arcs: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Arc]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:839:99 [INFO] [stderr] | [INFO] [stderr] 839 | fn poly_text16s(&self, client: &mut XClient, gcid: u32, x: i16, y: i16, texts: &Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:794:64 [INFO] [stderr] | [INFO] [stderr] 794 | fn put_image(&self, client: &mut XClient, gcid: u32, data: &Vec, width: u16, height: u16, x: i16, y: i16, left_pad: u8, depth: u8, format: &ImageFormat) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/models.rs:794:5 [INFO] [stderr] | [INFO] [stderr] 794 | / fn put_image(&self, client: &mut XClient, gcid: u32, data: &Vec, width: u16, height: u16, x: i16, y: i16, left_pad: u8, depth: u8, format: &ImageFormat) { [INFO] [stderr] 795 | | client.put_image(self.get_drawable(), gcid, data, width, height, x, y, left_pad, depth, format) [INFO] [stderr] 796 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/models.rs:794:5 [INFO] [stderr] | [INFO] [stderr] 794 | / fn put_image(&self, client: &mut XClient, gcid: u32, data: &Vec, width: u16, height: u16, x: i16, y: i16, left_pad: u8, depth: u8, format: &ImageFormat) { [INFO] [stderr] 795 | | client.put_image(self.get_drawable(), gcid, data, width, height, x, y, left_pad, depth, format) [INFO] [stderr] 796 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:855:65 [INFO] [stderr] | [INFO] [stderr] 855 | fn img_text16(&self, client: &mut XClient, gcid: u32, text: &Vec, x: i16, y: i16) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/models.rs:802:5 [INFO] [stderr] | [INFO] [stderr] 802 | / fn get_image(&self, client: &mut XClient, x: i16, y: i16, width: u16, height: u16, plane_mask: u32, format: &ImageFormat) -> u16 { [INFO] [stderr] 803 | | client.get_image(self.get_drawable(), x, y, width, height, plane_mask, format) [INFO] [stderr] 804 | | // TODO: Sync get_image [INFO] [stderr] 805 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:821:97 [INFO] [stderr] | [INFO] [stderr] 821 | fn poly_text8s(&self, client: &mut XClient, gcid: u32, x: i16, y: i16, texts: &Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/models.rs:888:5 [INFO] [stderr] | [INFO] [stderr] 888 | / pub fn create(client: &mut XClient, parent: u32, depth: u8, x: i16, y: i16, width: u16, height: u16, border_width: u16, class: WindowInputType, visual_id: u32, values: Vec) -> Window { [INFO] [stderr] 889 | | let wid = client.new_resource_id(); [INFO] [stderr] 890 | | let window = Window { depth, wid, parent, x, y, width, height, border_width, class, visual_id, values }; [INFO] [stderr] 891 | | client.create_window(&window); [INFO] [stderr] 892 | | window [INFO] [stderr] 893 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:839:99 [INFO] [stderr] | [INFO] [stderr] 839 | fn poly_text16s(&self, client: &mut XClient, gcid: u32, x: i16, y: i16, texts: &Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models.rs:855:65 [INFO] [stderr] | [INFO] [stderr] 855 | fn img_text16(&self, client: &mut XClient, gcid: u32, text: &Vec, x: i16, y: i16) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/models.rs:888:5 [INFO] [stderr] | [INFO] [stderr] 888 | / pub fn create(client: &mut XClient, parent: u32, depth: u8, x: i16, y: i16, width: u16, height: u16, border_width: u16, class: WindowInputType, visual_id: u32, values: Vec) -> Window { [INFO] [stderr] 889 | | let wid = client.new_resource_id(); [INFO] [stderr] 890 | | let window = Window { depth, wid, parent, x, y, width, height, border_width, class, visual_id, values }; [INFO] [stderr] 891 | | client.create_window(&window); [INFO] [stderr] 892 | | window [INFO] [stderr] 893 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/models.rs:949:49 [INFO] [stderr] | [INFO] [stderr] 949 | WindowValue::DoNotPropagateMask(do_not_propagate_mask as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(do_not_propagate_mask)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/models.rs:949:49 [INFO] [stderr] | [INFO] [stderr] 949 | WindowValue::DoNotPropagateMask(do_not_propagate_mask as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(do_not_propagate_mask)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `ATOM__NET_WM_NAME` should have a snake case name such as `atom_net_wm_name` [INFO] [stderr] --> src/models.rs:1063:62 [INFO] [stderr] | [INFO] [stderr] 1063 | pub fn get_wm_name_sync(&mut self, client: &mut XClient, ATOM__NET_WM_NAME: u32) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/models.rs:1065:30 [INFO] [stderr] | [INFO] [stderr] 1065 | Some(name) => if name.len() == 0 { None } else { Some(name) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: variable `ATOM__NET_WM_NAME` should have a snake case name such as `atom_net_wm_name` [INFO] [stderr] --> src/models.rs:1063:62 [INFO] [stderr] | [INFO] [stderr] 1063 | pub fn get_wm_name_sync(&mut self, client: &mut XClient, ATOM__NET_WM_NAME: u32) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/models.rs:1065:30 [INFO] [stderr] | [INFO] [stderr] 1065 | Some(name) => if name.len() == 0 { None } else { Some(name) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: trait `TextItem8` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/models.rs:1302:1 [INFO] [stderr] | [INFO] [stderr] 1302 | / pub trait TextItem8 { [INFO] [stderr] 1303 | | fn len(&self) -> usize; [INFO] [stderr] 1304 | | fn write(&self, client: &mut XClient); [INFO] [stderr] 1305 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: trait `TextItem16` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/models.rs:1338:1 [INFO] [stderr] | [INFO] [stderr] 1338 | / pub trait TextItem16 { [INFO] [stderr] 1339 | | fn len(&self) -> usize; [INFO] [stderr] 1340 | | fn write(&self, client: &mut XClient); [INFO] [stderr] 1341 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: trait `TextItem8` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/models.rs:1302:1 [INFO] [stderr] | [INFO] [stderr] 1302 | / pub trait TextItem8 { [INFO] [stderr] 1303 | | fn len(&self) -> usize; [INFO] [stderr] 1304 | | fn write(&self, client: &mut XClient); [INFO] [stderr] 1305 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/models.rs:1438:17 [INFO] [stderr] | [INFO] [stderr] 1438 | return ((self.red as u32) << 16) + ((self.green as u32) << 8) + (self.blue as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/models.rs:1438:45 [INFO] [stderr] | [INFO] [stderr] 1438 | return ((self.red as u32) << 16) + ((self.green as u32) << 8) + (self.blue as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/models.rs:1438:73 [INFO] [stderr] | [INFO] [stderr] 1438 | return ((self.red as u32) << 16) + ((self.green as u32) << 8) + (self.blue as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: trait `TextItem16` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/models.rs:1338:1 [INFO] [stderr] | [INFO] [stderr] 1338 | / pub trait TextItem16 { [INFO] [stderr] 1339 | | fn len(&self) -> usize; [INFO] [stderr] 1340 | | fn write(&self, client: &mut XClient); [INFO] [stderr] 1341 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1466:16 [INFO] [stderr] | [INFO] [stderr] 1466 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1467:9 [INFO] [stderr] | [INFO] [stderr] 1467 | / match self { [INFO] [stderr] 1468 | | &BitOrder::LeastSignificant => 0, [INFO] [stderr] 1469 | | &BitOrder::MostSignificant => 1 [INFO] [stderr] 1470 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1467 | match *self { [INFO] [stderr] 1468 | BitOrder::LeastSignificant => 0, [INFO] [stderr] 1469 | BitOrder::MostSignificant => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1480:16 [INFO] [stderr] | [INFO] [stderr] 1480 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1481:9 [INFO] [stderr] | [INFO] [stderr] 1481 | / match self { [INFO] [stderr] 1482 | | &ByteOrder::LSBFirst => 0, [INFO] [stderr] 1483 | | &ByteOrder::MSBFirst => 1 [INFO] [stderr] 1484 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1481 | match *self { [INFO] [stderr] 1482 | ByteOrder::LSBFirst => 0, [INFO] [stderr] 1483 | ByteOrder::MSBFirst => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/models.rs:1438:17 [INFO] [stderr] | [INFO] [stderr] 1438 | return ((self.red as u32) << 16) + ((self.green as u32) << 8) + (self.blue as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/models.rs:1438:45 [INFO] [stderr] | [INFO] [stderr] 1438 | return ((self.red as u32) << 16) + ((self.green as u32) << 8) + (self.blue as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/models.rs:1438:73 [INFO] [stderr] | [INFO] [stderr] 1438 | return ((self.red as u32) << 16) + ((self.green as u32) << 8) + (self.blue as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1517:16 [INFO] [stderr] | [INFO] [stderr] 1517 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1518:9 [INFO] [stderr] | [INFO] [stderr] 1518 | / match self { [INFO] [stderr] 1519 | | &Event::KeyPress => 0x00000001, [INFO] [stderr] 1520 | | &Event::KeyRelease => 0x00000002, [INFO] [stderr] 1521 | | &Event::ButtonPress => 0x00000004, [INFO] [stderr] ... | [INFO] [stderr] 1543 | | &Event::OwnerGrabButton => 0x01000000 [INFO] [stderr] 1544 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1518 | match *self { [INFO] [stderr] 1519 | Event::KeyPress => 0x00000001, [INFO] [stderr] 1520 | Event::KeyRelease => 0x00000002, [INFO] [stderr] 1521 | Event::ButtonPress => 0x00000004, [INFO] [stderr] 1522 | Event::ButtonRelease => 0x00000008, [INFO] [stderr] 1523 | Event::EnterWindow => 0x00000010, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1466:16 [INFO] [stderr] | [INFO] [stderr] 1466 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1467:9 [INFO] [stderr] | [INFO] [stderr] 1467 | / match self { [INFO] [stderr] 1468 | | &BitOrder::LeastSignificant => 0, [INFO] [stderr] 1469 | | &BitOrder::MostSignificant => 1 [INFO] [stderr] 1470 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1467 | match *self { [INFO] [stderr] 1468 | BitOrder::LeastSignificant => 0, [INFO] [stderr] 1469 | BitOrder::MostSignificant => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1565:16 [INFO] [stderr] | [INFO] [stderr] 1565 | pub fn val(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1480:16 [INFO] [stderr] | [INFO] [stderr] 1480 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1566:9 [INFO] [stderr] | [INFO] [stderr] 1566 | / match self { [INFO] [stderr] 1567 | | &PointerEvent::ButtonPress => 0x0004, [INFO] [stderr] 1568 | | &PointerEvent::ButtonRelease => 0x0008, [INFO] [stderr] 1569 | | &PointerEvent::EnterWindow => 0x0010, [INFO] [stderr] ... | [INFO] [stderr] 1579 | | &PointerEvent::KeymapState => 0x4000 [INFO] [stderr] 1580 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1566 | match *self { [INFO] [stderr] 1567 | PointerEvent::ButtonPress => 0x0004, [INFO] [stderr] 1568 | PointerEvent::ButtonRelease => 0x0008, [INFO] [stderr] 1569 | PointerEvent::EnterWindow => 0x0010, [INFO] [stderr] 1570 | PointerEvent::LeaveWindow => 0x0020, [INFO] [stderr] 1571 | PointerEvent::PointerMotion => 0x0040, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1481:9 [INFO] [stderr] | [INFO] [stderr] 1481 | / match self { [INFO] [stderr] 1482 | | &ByteOrder::LSBFirst => 0, [INFO] [stderr] 1483 | | &ByteOrder::MSBFirst => 1 [INFO] [stderr] 1484 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1481 | match *self { [INFO] [stderr] 1482 | ByteOrder::LSBFirst => 0, [INFO] [stderr] 1483 | ByteOrder::MSBFirst => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1599:16 [INFO] [stderr] | [INFO] [stderr] 1599 | pub fn val(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1600:9 [INFO] [stderr] | [INFO] [stderr] 1600 | / match self { [INFO] [stderr] 1601 | | &DeviceEvent::KeyPress => 0x0001, [INFO] [stderr] 1602 | | &DeviceEvent::KeyRelease => 0x0002, [INFO] [stderr] 1603 | | &DeviceEvent::ButtonPress => 0x0004, [INFO] [stderr] ... | [INFO] [stderr] 1611 | | &DeviceEvent::ButtonMotion => 0x2000 [INFO] [stderr] 1612 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1600 | match *self { [INFO] [stderr] 1601 | DeviceEvent::KeyPress => 0x0001, [INFO] [stderr] 1602 | DeviceEvent::KeyRelease => 0x0002, [INFO] [stderr] 1603 | DeviceEvent::ButtonPress => 0x0004, [INFO] [stderr] 1604 | DeviceEvent::ButtonRelease => 0x0008, [INFO] [stderr] 1605 | DeviceEvent::PointerMotion => 0x0040, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1517:16 [INFO] [stderr] | [INFO] [stderr] 1517 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1518:9 [INFO] [stderr] | [INFO] [stderr] 1518 | / match self { [INFO] [stderr] 1519 | | &Event::KeyPress => 0x00000001, [INFO] [stderr] 1520 | | &Event::KeyRelease => 0x00000002, [INFO] [stderr] 1521 | | &Event::ButtonPress => 0x00000004, [INFO] [stderr] ... | [INFO] [stderr] 1543 | | &Event::OwnerGrabButton => 0x01000000 [INFO] [stderr] 1544 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1518 | match *self { [INFO] [stderr] 1519 | Event::KeyPress => 0x00000001, [INFO] [stderr] 1520 | Event::KeyRelease => 0x00000002, [INFO] [stderr] 1521 | Event::ButtonPress => 0x00000004, [INFO] [stderr] 1522 | Event::ButtonRelease => 0x00000008, [INFO] [stderr] 1523 | Event::EnterWindow => 0x00000010, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1565:16 [INFO] [stderr] | [INFO] [stderr] 1565 | pub fn val(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1566:9 [INFO] [stderr] | [INFO] [stderr] 1566 | / match self { [INFO] [stderr] 1567 | | &PointerEvent::ButtonPress => 0x0004, [INFO] [stderr] 1568 | | &PointerEvent::ButtonRelease => 0x0008, [INFO] [stderr] 1569 | | &PointerEvent::EnterWindow => 0x0010, [INFO] [stderr] ... | [INFO] [stderr] 1579 | | &PointerEvent::KeymapState => 0x4000 [INFO] [stderr] 1580 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1566 | match *self { [INFO] [stderr] 1567 | PointerEvent::ButtonPress => 0x0004, [INFO] [stderr] 1568 | PointerEvent::ButtonRelease => 0x0008, [INFO] [stderr] 1569 | PointerEvent::EnterWindow => 0x0010, [INFO] [stderr] 1570 | PointerEvent::LeaveWindow => 0x0020, [INFO] [stderr] 1571 | PointerEvent::PointerMotion => 0x0040, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1599:16 [INFO] [stderr] | [INFO] [stderr] 1599 | pub fn val(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1600:9 [INFO] [stderr] | [INFO] [stderr] 1600 | / match self { [INFO] [stderr] 1601 | | &DeviceEvent::KeyPress => 0x0001, [INFO] [stderr] 1602 | | &DeviceEvent::KeyRelease => 0x0002, [INFO] [stderr] 1603 | | &DeviceEvent::ButtonPress => 0x0004, [INFO] [stderr] ... | [INFO] [stderr] 1611 | | &DeviceEvent::ButtonMotion => 0x2000 [INFO] [stderr] 1612 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] --> src/models.rs:1679:16 [INFO] [stderr] | [INFO] [stderr] 1679 | pub fn val(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1600 | match *self { [INFO] [stderr] 1601 | DeviceEvent::KeyPress => 0x0001, [INFO] [stderr] 1602 | DeviceEvent::KeyRelease => 0x0002, [INFO] [stderr] 1603 | DeviceEvent::ButtonPress => 0x0004, [INFO] [stderr] 1604 | DeviceEvent::ButtonRelease => 0x0008, [INFO] [stderr] 1605 | DeviceEvent::PointerMotion => 0x0040, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1680:9 [INFO] [stderr] | [INFO] [stderr] 1680 | / match self { [INFO] [stderr] 1681 | | &KeyButton::Shift => 0x0001, [INFO] [stderr] 1682 | | &KeyButton::Lock => 0x0002, [INFO] [stderr] 1683 | | &KeyButton::Control => 0x0004, [INFO] [stderr] ... | [INFO] [stderr] 1693 | | &KeyButton::Button5 => 0x1000 [INFO] [stderr] 1694 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1680 | match *self { [INFO] [stderr] 1681 | KeyButton::Shift => 0x0001, [INFO] [stderr] 1682 | KeyButton::Lock => 0x0002, [INFO] [stderr] 1683 | KeyButton::Control => 0x0004, [INFO] [stderr] 1684 | KeyButton::Mod1 => 0x0008, [INFO] [stderr] 1685 | KeyButton::Mod2 => 0x0010, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1741:16 [INFO] [stderr] | [INFO] [stderr] 1741 | pub fn val(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1679:16 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] | [INFO] [stderr] 1679 | pub fn val(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1742:9 [INFO] [stderr] | [INFO] [stderr] 1742 | / match self { [INFO] [stderr] 1743 | | &Key::Shift => 0x0001, [INFO] [stderr] 1744 | | &Key::Lock => 0x0002, [INFO] [stderr] 1745 | | &Key::Control => 0x0004, [INFO] [stderr] ... | [INFO] [stderr] 1750 | | &Key::Mod5 => 0x0080 [INFO] [stderr] 1751 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1680:9 [INFO] [stderr] | [INFO] [stderr] 1680 | / match self { [INFO] [stderr] 1681 | | &KeyButton::Shift => 0x0001, [INFO] [stderr] 1682 | | &KeyButton::Lock => 0x0002, [INFO] [stderr] 1683 | | &KeyButton::Control => 0x0004, [INFO] [stderr] ... | [INFO] [stderr] 1693 | | &KeyButton::Button5 => 0x1000 [INFO] [stderr] 1694 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1742 | match *self { [INFO] [stderr] 1743 | Key::Shift => 0x0001, [INFO] [stderr] 1744 | Key::Lock => 0x0002, [INFO] [stderr] 1745 | Key::Control => 0x0004, [INFO] [stderr] 1746 | Key::Mod1 => 0x0008, [INFO] [stderr] 1747 | Key::Mod2 => 0x0010, [INFO] [stderr] ... [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1680 | match *self { [INFO] [stderr] 1681 | KeyButton::Shift => 0x0001, [INFO] [stderr] 1682 | KeyButton::Lock => 0x0002, [INFO] [stderr] 1683 | KeyButton::Control => 0x0004, [INFO] [stderr] 1684 | KeyButton::Mod1 => 0x0008, [INFO] [stderr] 1685 | KeyButton::Mod2 => 0x0010, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1762:16 [INFO] [stderr] | [INFO] [stderr] 1762 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1763:9 [INFO] [stderr] | [INFO] [stderr] 1763 | / match self { [INFO] [stderr] 1764 | | &ScreenBackingStores::Never => 0, [INFO] [stderr] 1765 | | &ScreenBackingStores::WhenMapped => 1, [INFO] [stderr] 1766 | | &ScreenBackingStores::Always => 2 [INFO] [stderr] 1767 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1763 | match *self { [INFO] [stderr] 1764 | ScreenBackingStores::Never => 0, [INFO] [stderr] 1765 | ScreenBackingStores::WhenMapped => 1, [INFO] [stderr] 1766 | ScreenBackingStores::Always => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1781:16 [INFO] [stderr] | [INFO] [stderr] 1781 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1782:9 [INFO] [stderr] | [INFO] [stderr] 1782 | / match self { [INFO] [stderr] 1783 | | &VisualType::StaticGray => 0, [INFO] [stderr] 1784 | | &VisualType::GrayScale => 1, [INFO] [stderr] 1785 | | &VisualType::StaticColor => 2, [INFO] [stderr] ... | [INFO] [stderr] 1788 | | &VisualType::DirectColor => 5 [INFO] [stderr] 1789 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1782 | match *self { [INFO] [stderr] 1783 | VisualType::StaticGray => 0, [INFO] [stderr] 1784 | VisualType::GrayScale => 1, [INFO] [stderr] 1785 | VisualType::StaticColor => 2, [INFO] [stderr] 1786 | VisualType::PseudoColor => 3, [INFO] [stderr] 1787 | VisualType::TrueColor => 4, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1741:16 [INFO] [stderr] | [INFO] [stderr] 1741 | pub fn val(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1742:9 [INFO] [stderr] | [INFO] [stderr] 1742 | / match self { [INFO] [stderr] 1743 | | &Key::Shift => 0x0001, [INFO] [stderr] 1744 | | &Key::Lock => 0x0002, [INFO] [stderr] 1745 | | &Key::Control => 0x0004, [INFO] [stderr] ... | [INFO] [stderr] 1750 | | &Key::Mod5 => 0x0080 [INFO] [stderr] 1751 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1742 | match *self { [INFO] [stderr] 1743 | Key::Shift => 0x0001, [INFO] [stderr] 1744 | Key::Lock => 0x0002, [INFO] [stderr] 1745 | Key::Control => 0x0004, [INFO] [stderr] 1746 | Key::Mod1 => 0x0008, [INFO] [stderr] 1747 | Key::Mod2 => 0x0010, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1762:16 [INFO] [stderr] | [INFO] [stderr] 1762 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1809:16 [INFO] [stderr] | [INFO] [stderr] 1809 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1763:9 [INFO] [stderr] | [INFO] [stderr] 1763 | / match self { [INFO] [stderr] 1764 | | &ScreenBackingStores::Never => 0, [INFO] [stderr] 1765 | | &ScreenBackingStores::WhenMapped => 1, [INFO] [stderr] 1766 | | &ScreenBackingStores::Always => 2 [INFO] [stderr] 1767 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1763 | match *self { [INFO] [stderr] 1764 | ScreenBackingStores::Never => 0, [INFO] [stderr] 1765 | ScreenBackingStores::WhenMapped => 1, [INFO] [stderr] 1766 | ScreenBackingStores::Always => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1810:9 [INFO] [stderr] | [INFO] [stderr] 1810 | / match self { [INFO] [stderr] 1811 | | &WindowInputType::CopyFromParent => 0, [INFO] [stderr] 1812 | | &WindowInputType::InputOutput => 1, [INFO] [stderr] 1813 | | &WindowInputType::InputOnly => 2 [INFO] [stderr] 1814 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1810 | match *self { [INFO] [stderr] 1811 | WindowInputType::CopyFromParent => 0, [INFO] [stderr] 1812 | WindowInputType::InputOutput => 1, [INFO] [stderr] 1813 | WindowInputType::InputOnly => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1781:16 [INFO] [stderr] | [INFO] [stderr] 1781 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1834:16 [INFO] [stderr] | [INFO] [stderr] 1834 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1782:9 [INFO] [stderr] | [INFO] [stderr] 1782 | / match self { [INFO] [stderr] 1783 | | &VisualType::StaticGray => 0, [INFO] [stderr] 1784 | | &VisualType::GrayScale => 1, [INFO] [stderr] 1785 | | &VisualType::StaticColor => 2, [INFO] [stderr] ... | [INFO] [stderr] 1788 | | &VisualType::DirectColor => 5 [INFO] [stderr] 1789 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1782 | match *self { [INFO] [stderr] 1783 | VisualType::StaticGray => 0, [INFO] [stderr] 1784 | VisualType::GrayScale => 1, [INFO] [stderr] 1785 | VisualType::StaticColor => 2, [INFO] [stderr] 1786 | VisualType::PseudoColor => 3, [INFO] [stderr] 1787 | VisualType::TrueColor => 4, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1835:9 [INFO] [stderr] | [INFO] [stderr] 1835 | / match self { [INFO] [stderr] 1836 | | &WindowBackingStore::NotUseful => 0, [INFO] [stderr] 1837 | | &WindowBackingStore::WhenMapped => 1, [INFO] [stderr] 1838 | | &WindowBackingStore::Always => 2 [INFO] [stderr] 1839 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1835 | match *self { [INFO] [stderr] 1836 | WindowBackingStore::NotUseful => 0, [INFO] [stderr] 1837 | WindowBackingStore::WhenMapped => 1, [INFO] [stderr] 1838 | WindowBackingStore::Always => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1809:16 [INFO] [stderr] | [INFO] [stderr] 1809 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1810:9 [INFO] [stderr] | [INFO] [stderr] 1810 | / match self { [INFO] [stderr] 1811 | | &WindowInputType::CopyFromParent => 0, [INFO] [stderr] 1812 | | &WindowInputType::InputOutput => 1, [INFO] [stderr] 1813 | | &WindowInputType::InputOnly => 2 [INFO] [stderr] 1814 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1810 | match *self { [INFO] [stderr] 1811 | WindowInputType::CopyFromParent => 0, [INFO] [stderr] 1812 | WindowInputType::InputOutput => 1, [INFO] [stderr] 1813 | WindowInputType::InputOnly => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1875:16 [INFO] [stderr] | [INFO] [stderr] 1875 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1834:16 [INFO] [stderr] | [INFO] [stderr] 1834 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1835:9 [INFO] [stderr] | [INFO] [stderr] 1835 | / match self { [INFO] [stderr] 1836 | | &WindowBackingStore::NotUseful => 0, [INFO] [stderr] 1837 | | &WindowBackingStore::WhenMapped => 1, [INFO] [stderr] 1838 | | &WindowBackingStore::Always => 2 [INFO] [stderr] 1839 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1835 | match *self { [INFO] [stderr] 1836 | WindowBackingStore::NotUseful => 0, [INFO] [stderr] 1837 | WindowBackingStore::WhenMapped => 1, [INFO] [stderr] 1838 | WindowBackingStore::Always => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1876:9 [INFO] [stderr] | [INFO] [stderr] 1876 | / match self { [INFO] [stderr] 1877 | | &BitGravity::Forget => 0, [INFO] [stderr] 1878 | | &BitGravity::Static => 1, [INFO] [stderr] 1879 | | &BitGravity::NorthWest => 2, [INFO] [stderr] ... | [INFO] [stderr] 1887 | | &BitGravity::SouthEast => 10 [INFO] [stderr] 1888 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1876 | match *self { [INFO] [stderr] 1877 | BitGravity::Forget => 0, [INFO] [stderr] 1878 | BitGravity::Static => 1, [INFO] [stderr] 1879 | BitGravity::NorthWest => 2, [INFO] [stderr] 1880 | BitGravity::North => 3, [INFO] [stderr] 1881 | BitGravity::NorthEast => 4, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1875:16 [INFO] [stderr] | [INFO] [stderr] 1875 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1876:9 [INFO] [stderr] | [INFO] [stderr] 1876 | / match self { [INFO] [stderr] 1877 | | &BitGravity::Forget => 0, [INFO] [stderr] 1878 | | &BitGravity::Static => 1, [INFO] [stderr] 1879 | | &BitGravity::NorthWest => 2, [INFO] [stderr] ... | [INFO] [stderr] 1887 | | &BitGravity::SouthEast => 10 [INFO] [stderr] 1888 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1924:16 [INFO] [stderr] | [INFO] [stderr] 1924 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1876 | match *self { [INFO] [stderr] 1877 | BitGravity::Forget => 0, [INFO] [stderr] 1878 | BitGravity::Static => 1, [INFO] [stderr] 1879 | BitGravity::NorthWest => 2, [INFO] [stderr] 1880 | BitGravity::North => 3, [INFO] [stderr] 1881 | BitGravity::NorthEast => 4, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1925:9 [INFO] [stderr] | [INFO] [stderr] 1925 | / match self { [INFO] [stderr] 1926 | | &WindowGravity::Unmap => 0, [INFO] [stderr] 1927 | | &WindowGravity::Static => 1, [INFO] [stderr] 1928 | | &WindowGravity::NorthWest => 2, [INFO] [stderr] ... | [INFO] [stderr] 1936 | | &WindowGravity::SouthEast => 10 [INFO] [stderr] 1937 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1925 | match *self { [INFO] [stderr] 1926 | WindowGravity::Unmap => 0, [INFO] [stderr] 1927 | WindowGravity::Static => 1, [INFO] [stderr] 1928 | WindowGravity::NorthWest => 2, [INFO] [stderr] 1929 | WindowGravity::North => 3, [INFO] [stderr] 1930 | WindowGravity::NorthEast => 4, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1924:16 [INFO] [stderr] | [INFO] [stderr] 1924 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1925:9 [INFO] [stderr] | [INFO] [stderr] 1925 | / match self { [INFO] [stderr] 1926 | | &WindowGravity::Unmap => 0, [INFO] [stderr] 1927 | | &WindowGravity::Static => 1, [INFO] [stderr] 1928 | | &WindowGravity::NorthWest => 2, [INFO] [stderr] ... | [INFO] [stderr] 1936 | | &WindowGravity::SouthEast => 10 [INFO] [stderr] 1937 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1925 | match *self { [INFO] [stderr] 1926 | WindowGravity::Unmap => 0, [INFO] [stderr] 1927 | WindowGravity::Static => 1, [INFO] [stderr] 1928 | WindowGravity::NorthWest => 2, [INFO] [stderr] 1929 | WindowGravity::North => 3, [INFO] [stderr] 1930 | WindowGravity::NorthEast => 4, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1993:16 [INFO] [stderr] | [INFO] [stderr] 1993 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1994:9 [INFO] [stderr] | [INFO] [stderr] 1994 | / match self { [INFO] [stderr] 1995 | | &GCFunction::Clear => 0, [INFO] [stderr] 1996 | | &GCFunction::And => 1, [INFO] [stderr] 1997 | | &GCFunction::AndReverse => 2, [INFO] [stderr] ... | [INFO] [stderr] 2010 | | &GCFunction::Set => 15 [INFO] [stderr] 2011 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1994 | match *self { [INFO] [stderr] 1995 | GCFunction::Clear => 0, [INFO] [stderr] 1996 | GCFunction::And => 1, [INFO] [stderr] 1997 | GCFunction::AndReverse => 2, [INFO] [stderr] 1998 | GCFunction::Copy => 3, [INFO] [stderr] 1999 | GCFunction::AndInverted => 4, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2022:16 [INFO] [stderr] | [INFO] [stderr] 2022 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2023:9 [INFO] [stderr] | [INFO] [stderr] 2023 | / match self { [INFO] [stderr] 2024 | | &GCLineStyle::Solid => 0, [INFO] [stderr] 2025 | | &GCLineStyle::OnOffDash => 1, [INFO] [stderr] 2026 | | &GCLineStyle::DoubleDash => 2 [INFO] [stderr] 2027 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2023 | match *self { [INFO] [stderr] 2024 | GCLineStyle::Solid => 0, [INFO] [stderr] 2025 | GCLineStyle::OnOffDash => 1, [INFO] [stderr] 2026 | GCLineStyle::DoubleDash => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2039:16 [INFO] [stderr] | [INFO] [stderr] 2039 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2040:9 [INFO] [stderr] | [INFO] [stderr] 2040 | / match self { [INFO] [stderr] 2041 | | &GCCapStyle::NotLast => 0, [INFO] [stderr] 2042 | | &GCCapStyle::Butt => 1, [INFO] [stderr] 2043 | | &GCCapStyle::Round => 2, [INFO] [stderr] 2044 | | &GCCapStyle::Projecting => 3 [INFO] [stderr] 2045 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2040 | match *self { [INFO] [stderr] 2041 | GCCapStyle::NotLast => 0, [INFO] [stderr] 2042 | GCCapStyle::Butt => 1, [INFO] [stderr] 2043 | GCCapStyle::Round => 2, [INFO] [stderr] 2044 | GCCapStyle::Projecting => 3 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:1993:16 [INFO] [stderr] | [INFO] [stderr] 1993 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:1994:9 [INFO] [stderr] | [INFO] [stderr] 1994 | / match self { [INFO] [stderr] 1995 | | &GCFunction::Clear => 0, [INFO] [stderr] 1996 | | &GCFunction::And => 1, [INFO] [stderr] 1997 | | &GCFunction::AndReverse => 2, [INFO] [stderr] ... | [INFO] [stderr] 2010 | | &GCFunction::Set => 15 [INFO] [stderr] 2011 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1994 | match *self { [INFO] [stderr] 1995 | GCFunction::Clear => 0, [INFO] [stderr] 1996 | GCFunction::And => 1, [INFO] [stderr] 1997 | GCFunction::AndReverse => 2, [INFO] [stderr] 1998 | GCFunction::Copy => 3, [INFO] [stderr] 1999 | GCFunction::AndInverted => 4, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2022:16 [INFO] [stderr] | [INFO] [stderr] 2022 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2023:9 [INFO] [stderr] | [INFO] [stderr] 2023 | / match self { [INFO] [stderr] 2024 | | &GCLineStyle::Solid => 0, [INFO] [stderr] 2025 | | &GCLineStyle::OnOffDash => 1, [INFO] [stderr] 2026 | | &GCLineStyle::DoubleDash => 2 [INFO] [stderr] 2027 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2023 | match *self { [INFO] [stderr] 2024 | GCLineStyle::Solid => 0, [INFO] [stderr] 2025 | GCLineStyle::OnOffDash => 1, [INFO] [stderr] 2026 | GCLineStyle::DoubleDash => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2039:16 [INFO] [stderr] | [INFO] [stderr] 2039 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2040:9 [INFO] [stderr] | [INFO] [stderr] 2040 | / match self { [INFO] [stderr] 2041 | | &GCCapStyle::NotLast => 0, [INFO] [stderr] 2042 | | &GCCapStyle::Butt => 1, [INFO] [stderr] 2043 | | &GCCapStyle::Round => 2, [INFO] [stderr] 2044 | | &GCCapStyle::Projecting => 3 [INFO] [stderr] 2045 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2040 | match *self { [INFO] [stderr] 2041 | GCCapStyle::NotLast => 0, [INFO] [stderr] 2042 | GCCapStyle::Butt => 1, [INFO] [stderr] 2043 | GCCapStyle::Round => 2, [INFO] [stderr] 2044 | GCCapStyle::Projecting => 3 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2056:16 [INFO] [stderr] | [INFO] [stderr] 2056 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2057:9 [INFO] [stderr] | [INFO] [stderr] 2057 | / match self { [INFO] [stderr] 2058 | | &GCJoinStyle::Miter => 0, [INFO] [stderr] 2059 | | &GCJoinStyle::Round => 1, [INFO] [stderr] 2060 | | &GCJoinStyle::Bevel => 2 [INFO] [stderr] 2061 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2057 | match *self { [INFO] [stderr] 2058 | GCJoinStyle::Miter => 0, [INFO] [stderr] 2059 | GCJoinStyle::Round => 1, [INFO] [stderr] 2060 | GCJoinStyle::Bevel => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2073:16 [INFO] [stderr] | [INFO] [stderr] 2073 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2074:9 [INFO] [stderr] | [INFO] [stderr] 2074 | / match self { [INFO] [stderr] 2075 | | &GCFillStyle::Solid => 0, [INFO] [stderr] 2076 | | &GCFillStyle::Tiled => 1, [INFO] [stderr] 2077 | | &GCFillStyle::Stippled => 2, [INFO] [stderr] 2078 | | &GCFillStyle::OpaqueStippled => 3 [INFO] [stderr] 2079 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2074 | match *self { [INFO] [stderr] 2075 | GCFillStyle::Solid => 0, [INFO] [stderr] 2076 | GCFillStyle::Tiled => 1, [INFO] [stderr] 2077 | GCFillStyle::Stippled => 2, [INFO] [stderr] 2078 | GCFillStyle::OpaqueStippled => 3 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2089:16 [INFO] [stderr] | [INFO] [stderr] 2089 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2090:9 [INFO] [stderr] | [INFO] [stderr] 2090 | / match self { [INFO] [stderr] 2091 | | &GCFillRule::EvenOdd => 0, [INFO] [stderr] 2092 | | &GCFillRule::Winding => 1 [INFO] [stderr] 2093 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2090 | match *self { [INFO] [stderr] 2091 | GCFillRule::EvenOdd => 0, [INFO] [stderr] 2092 | GCFillRule::Winding => 1 [INFO] [stderr] | [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2056:16 [INFO] [stderr] | [INFO] [stderr] 2056 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2057:9 [INFO] [stderr] | [INFO] [stderr] 2057 | / match self { [INFO] [stderr] 2058 | | &GCJoinStyle::Miter => 0, [INFO] [stderr] 2059 | | &GCJoinStyle::Round => 1, [INFO] [stderr] 2060 | | &GCJoinStyle::Bevel => 2 [INFO] [stderr] 2061 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2057 | match *self { [INFO] [stderr] 2058 | GCJoinStyle::Miter => 0, [INFO] [stderr] 2059 | GCJoinStyle::Round => 1, [INFO] [stderr] 2060 | GCJoinStyle::Bevel => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2103:16 [INFO] [stderr] | [INFO] [stderr] 2103 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2104:9 [INFO] [stderr] | [INFO] [stderr] 2104 | / match self { [INFO] [stderr] 2105 | | &GCSubWindowMode::ClipByChildren => 0, [INFO] [stderr] 2106 | | &GCSubWindowMode::IncludeInferiors => 1 [INFO] [stderr] 2107 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2104 | match *self { [INFO] [stderr] 2105 | GCSubWindowMode::ClipByChildren => 0, [INFO] [stderr] 2106 | GCSubWindowMode::IncludeInferiors => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2073:16 [INFO] [stderr] | [INFO] [stderr] 2073 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2074:9 [INFO] [stderr] | [INFO] [stderr] 2074 | / match self { [INFO] [stderr] 2075 | | &GCFillStyle::Solid => 0, [INFO] [stderr] 2076 | | &GCFillStyle::Tiled => 1, [INFO] [stderr] 2077 | | &GCFillStyle::Stippled => 2, [INFO] [stderr] 2078 | | &GCFillStyle::OpaqueStippled => 3 [INFO] [stderr] 2079 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2117:16 [INFO] [stderr] | [INFO] [stderr] 2117 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] | [INFO] [stderr] 2074 | match *self { [INFO] [stderr] 2075 | GCFillStyle::Solid => 0, [INFO] [stderr] 2076 | GCFillStyle::Tiled => 1, [INFO] [stderr] 2077 | GCFillStyle::Stippled => 2, [INFO] [stderr] 2078 | GCFillStyle::OpaqueStippled => 3 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2118:9 [INFO] [stderr] | [INFO] [stderr] 2118 | / match self { [INFO] [stderr] 2119 | | &GCArcMode::Chord => 0, [INFO] [stderr] 2120 | | &GCArcMode::PieSlice => 1 [INFO] [stderr] 2121 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2118 | match *self { [INFO] [stderr] 2119 | GCArcMode::Chord => 0, [INFO] [stderr] 2120 | GCArcMode::PieSlice => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2089:16 [INFO] [stderr] | [INFO] [stderr] 2089 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2139:16 [INFO] [stderr] | [INFO] [stderr] 2139 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2140:9 [INFO] [stderr] | [INFO] [stderr] 2140 | / match self { [INFO] [stderr] 2141 | | &MotionNotifyType::Normal => 0, [INFO] [stderr] 2142 | | &MotionNotifyType::Hint => 1 [INFO] [stderr] 2143 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2140 | match *self { [INFO] [stderr] 2141 | MotionNotifyType::Normal => 0, [INFO] [stderr] 2142 | MotionNotifyType::Hint => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2167:16 [INFO] [stderr] | [INFO] [stderr] 2167 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2168:9 [INFO] [stderr] | [INFO] [stderr] 2168 | / match self { [INFO] [stderr] 2169 | | &NotifyType::Ancestor => 0, [INFO] [stderr] 2170 | | &NotifyType::Virtual => 1, [INFO] [stderr] 2171 | | &NotifyType::Inferior => 2, [INFO] [stderr] 2172 | | &NotifyType::Nonlinear => 3, [INFO] [stderr] 2173 | | &NotifyType::NonlinearVirtual => 4 [INFO] [stderr] 2174 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2168 | match *self { [INFO] [stderr] 2169 | NotifyType::Ancestor => 0, [INFO] [stderr] 2170 | NotifyType::Virtual => 1, [INFO] [stderr] 2171 | NotifyType::Inferior => 2, [INFO] [stderr] 2172 | NotifyType::Nonlinear => 3, [INFO] [stderr] 2173 | NotifyType::NonlinearVirtual => 4 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2204:16 [INFO] [stderr] | [INFO] [stderr] 2204 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2205:9 [INFO] [stderr] | [INFO] [stderr] 2205 | / match self { [INFO] [stderr] 2206 | | &FocusType::Ancestor => 0, [INFO] [stderr] 2207 | | &FocusType::Virtual => 1, [INFO] [stderr] 2208 | | &FocusType::Inferior => 2, [INFO] [stderr] ... | [INFO] [stderr] 2213 | | &FocusType::None => 7 [INFO] [stderr] 2214 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2205 | match *self { [INFO] [stderr] 2206 | FocusType::Ancestor => 0, [INFO] [stderr] 2207 | FocusType::Virtual => 1, [INFO] [stderr] 2208 | FocusType::Inferior => 2, [INFO] [stderr] 2209 | FocusType::Nonlinear => 3, [INFO] [stderr] 2210 | FocusType::NonlinearVirtual => 4, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2236:16 [INFO] [stderr] | [INFO] [stderr] 2236 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2237:9 [INFO] [stderr] | [INFO] [stderr] 2237 | / match self { [INFO] [stderr] 2238 | | &FocusMode::Normal => 0, [INFO] [stderr] 2239 | | &FocusMode::Grab => 1, [INFO] [stderr] 2240 | | &FocusMode::Ungrab => 2, [INFO] [stderr] 2241 | | &FocusMode::WhileGrabbed => 3 [INFO] [stderr] 2242 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2237 | match *self { [INFO] [stderr] 2238 | FocusMode::Normal => 0, [INFO] [stderr] 2239 | FocusMode::Grab => 1, [INFO] [stderr] 2240 | FocusMode::Ungrab => 2, [INFO] [stderr] 2241 | FocusMode::WhileGrabbed => 3 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2262:16 [INFO] [stderr] | [INFO] [stderr] 2262 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2263:9 [INFO] [stderr] | [INFO] [stderr] 2263 | / match self { [INFO] [stderr] 2264 | | &InputFocusRevert::None => 0, [INFO] [stderr] 2265 | | &InputFocusRevert::PointerRoot => 1, [INFO] [stderr] 2266 | | &InputFocusRevert::Parent => 2 [INFO] [stderr] 2267 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2263 | match *self { [INFO] [stderr] 2264 | InputFocusRevert::None => 0, [INFO] [stderr] 2265 | InputFocusRevert::PointerRoot => 1, [INFO] [stderr] 2266 | InputFocusRevert::Parent => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2090:9 [INFO] [stderr] | [INFO] [stderr] 2090 | / match self { [INFO] [stderr] 2091 | | &GCFillRule::EvenOdd => 0, [INFO] [stderr] 2092 | | &GCFillRule::Winding => 1 [INFO] [stderr] 2093 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2090 | match *self { [INFO] [stderr] 2091 | GCFillRule::EvenOdd => 0, [INFO] [stderr] 2092 | GCFillRule::Winding => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2103:16 [INFO] [stderr] | [INFO] [stderr] 2103 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2287:16 [INFO] [stderr] | [INFO] [stderr] 2287 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2104:9 [INFO] [stderr] | [INFO] [stderr] 2104 | / match self { [INFO] [stderr] 2105 | | &GCSubWindowMode::ClipByChildren => 0, [INFO] [stderr] 2106 | | &GCSubWindowMode::IncludeInferiors => 1 [INFO] [stderr] 2107 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2104 | match *self { [INFO] [stderr] 2105 | GCSubWindowMode::ClipByChildren => 0, [INFO] [stderr] 2106 | GCSubWindowMode::IncludeInferiors => 1 [INFO] [stderr] | [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2288:9 [INFO] [stderr] | [INFO] [stderr] 2288 | / match self { [INFO] [stderr] 2289 | | &NotifyMode::Normal => 0, [INFO] [stderr] 2290 | | &NotifyMode::Grab => 1, [INFO] [stderr] 2291 | | &NotifyMode::Ungrab => 2 [INFO] [stderr] 2292 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2288 | match *self { [INFO] [stderr] 2289 | NotifyMode::Normal => 0, [INFO] [stderr] 2290 | NotifyMode::Grab => 1, [INFO] [stderr] 2291 | NotifyMode::Ungrab => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2117:16 [INFO] [stderr] | [INFO] [stderr] 2117 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2118:9 [INFO] [stderr] | [INFO] [stderr] 2118 | / match self { [INFO] [stderr] 2119 | | &GCArcMode::Chord => 0, [INFO] [stderr] 2120 | | &GCArcMode::PieSlice => 1 [INFO] [stderr] 2121 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2118 | match *self { [INFO] [stderr] 2119 | GCArcMode::Chord => 0, [INFO] [stderr] 2120 | GCArcMode::PieSlice => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2312:16 [INFO] [stderr] | [INFO] [stderr] 2312 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2313:9 [INFO] [stderr] | [INFO] [stderr] 2313 | / match self { [INFO] [stderr] 2314 | | &VisibilityState::Unobscured => 0, [INFO] [stderr] 2315 | | &VisibilityState::PartiallyObscured => 1, [INFO] [stderr] 2316 | | &VisibilityState::FullyObscured => 2 [INFO] [stderr] 2317 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2313 | match *self { [INFO] [stderr] 2314 | VisibilityState::Unobscured => 0, [INFO] [stderr] 2315 | VisibilityState::PartiallyObscured => 1, [INFO] [stderr] 2316 | VisibilityState::FullyObscured => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2139:16 [INFO] [stderr] | [INFO] [stderr] 2139 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2140:9 [INFO] [stderr] | [INFO] [stderr] 2140 | / match self { [INFO] [stderr] 2141 | | &MotionNotifyType::Normal => 0, [INFO] [stderr] 2142 | | &MotionNotifyType::Hint => 1 [INFO] [stderr] 2143 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2140 | match *self { [INFO] [stderr] 2141 | MotionNotifyType::Normal => 0, [INFO] [stderr] 2142 | MotionNotifyType::Hint => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2167:16 [INFO] [stderr] | [INFO] [stderr] 2167 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2168:9 [INFO] [stderr] | [INFO] [stderr] 2168 | / match self { [INFO] [stderr] 2169 | | &NotifyType::Ancestor => 0, [INFO] [stderr] 2170 | | &NotifyType::Virtual => 1, [INFO] [stderr] 2171 | | &NotifyType::Inferior => 2, [INFO] [stderr] 2172 | | &NotifyType::Nonlinear => 3, [INFO] [stderr] 2173 | | &NotifyType::NonlinearVirtual => 4 [INFO] [stderr] 2174 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2168 | match *self { [INFO] [stderr] 2169 | NotifyType::Ancestor => 0, [INFO] [stderr] 2170 | NotifyType::Virtual => 1, [INFO] [stderr] 2171 | NotifyType::Inferior => 2, [INFO] [stderr] 2172 | NotifyType::Nonlinear => 3, [INFO] [stderr] 2173 | NotifyType::NonlinearVirtual => 4 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2204:16 [INFO] [stderr] | [INFO] [stderr] 2204 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2205:9 [INFO] [stderr] | [INFO] [stderr] 2205 | / match self { [INFO] [stderr] 2206 | | &FocusType::Ancestor => 0, [INFO] [stderr] 2207 | | &FocusType::Virtual => 1, [INFO] [stderr] 2208 | | &FocusType::Inferior => 2, [INFO] [stderr] ... | [INFO] [stderr] 2213 | | &FocusType::None => 7 [INFO] [stderr] 2214 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2205 | match *self { [INFO] [stderr] 2206 | FocusType::Ancestor => 0, [INFO] [stderr] 2207 | FocusType::Virtual => 1, [INFO] [stderr] 2208 | FocusType::Inferior => 2, [INFO] [stderr] 2209 | FocusType::Nonlinear => 3, [INFO] [stderr] 2210 | FocusType::NonlinearVirtual => 4, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2341:16 [INFO] [stderr] | [INFO] [stderr] 2341 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2342:9 [INFO] [stderr] | [INFO] [stderr] 2342 | / match self { [INFO] [stderr] 2343 | | &StackMode::Above => 0, [INFO] [stderr] 2344 | | &StackMode::Below => 1, [INFO] [stderr] 2345 | | &StackMode::TopIf => 2, [INFO] [stderr] 2346 | | &StackMode::BottomIf => 3, [INFO] [stderr] 2347 | | &StackMode::Opposite => 4 [INFO] [stderr] 2348 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2342 | match *self { [INFO] [stderr] 2343 | StackMode::Above => 0, [INFO] [stderr] 2344 | StackMode::Below => 1, [INFO] [stderr] 2345 | StackMode::TopIf => 2, [INFO] [stderr] 2346 | StackMode::BottomIf => 3, [INFO] [stderr] 2347 | StackMode::Opposite => 4 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2236:16 [INFO] [stderr] | [INFO] [stderr] 2236 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2237:9 [INFO] [stderr] | [INFO] [stderr] 2237 | / match self { [INFO] [stderr] 2238 | | &FocusMode::Normal => 0, [INFO] [stderr] 2239 | | &FocusMode::Grab => 1, [INFO] [stderr] 2240 | | &FocusMode::Ungrab => 2, [INFO] [stderr] 2241 | | &FocusMode::WhileGrabbed => 3 [INFO] [stderr] 2242 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2237 | match *self { [INFO] [stderr] 2238 | FocusMode::Normal => 0, [INFO] [stderr] 2239 | FocusMode::Grab => 1, [INFO] [stderr] 2240 | FocusMode::Ungrab => 2, [INFO] [stderr] 2241 | FocusMode::WhileGrabbed => 3 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2262:16 [INFO] [stderr] | [INFO] [stderr] 2262 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2263:9 [INFO] [stderr] | [INFO] [stderr] 2263 | / match self { [INFO] [stderr] 2264 | | &InputFocusRevert::None => 0, [INFO] [stderr] 2265 | | &InputFocusRevert::PointerRoot => 1, [INFO] [stderr] 2266 | | &InputFocusRevert::Parent => 2 [INFO] [stderr] 2267 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2263 | match *self { [INFO] [stderr] 2264 | InputFocusRevert::None => 0, [INFO] [stderr] 2265 | InputFocusRevert::PointerRoot => 1, [INFO] [stderr] 2266 | InputFocusRevert::Parent => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2391:16 [INFO] [stderr] | [INFO] [stderr] 2391 | pub fn val(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2392:9 [INFO] [stderr] | [INFO] [stderr] 2392 | / match self { [INFO] [stderr] 2393 | | &ConfigureRequestValues::X => 0x0001, [INFO] [stderr] 2394 | | &ConfigureRequestValues::Y => 0x0002, [INFO] [stderr] 2395 | | &ConfigureRequestValues::Width => 0x0004, [INFO] [stderr] ... | [INFO] [stderr] 2399 | | &ConfigureRequestValues::StackMode => 0x0040 [INFO] [stderr] 2400 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2392 | match *self { [INFO] [stderr] 2393 | ConfigureRequestValues::X => 0x0001, [INFO] [stderr] 2394 | ConfigureRequestValues::Y => 0x0002, [INFO] [stderr] 2395 | ConfigureRequestValues::Width => 0x0004, [INFO] [stderr] 2396 | ConfigureRequestValues::Height => 0x0008, [INFO] [stderr] 2397 | ConfigureRequestValues::BorderWidth => 0x0010, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2287:16 [INFO] [stderr] | [INFO] [stderr] 2287 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2418:16 [INFO] [stderr] | [INFO] [stderr] 2418 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2288:9 [INFO] [stderr] | [INFO] [stderr] 2288 | / match self { [INFO] [stderr] 2289 | | &NotifyMode::Normal => 0, [INFO] [stderr] 2290 | | &NotifyMode::Grab => 1, [INFO] [stderr] 2291 | | &NotifyMode::Ungrab => 2 [INFO] [stderr] 2292 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2288 | match *self { [INFO] [stderr] 2289 | NotifyMode::Normal => 0, [INFO] [stderr] 2290 | NotifyMode::Grab => 1, [INFO] [stderr] 2291 | NotifyMode::Ungrab => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2419:9 [INFO] [stderr] | [INFO] [stderr] 2419 | / match self { [INFO] [stderr] 2420 | | &CirculatePlace::Top => 0, [INFO] [stderr] 2421 | | &CirculatePlace::Bottom => 1 [INFO] [stderr] 2422 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2419 | match *self { [INFO] [stderr] 2420 | CirculatePlace::Top => 0, [INFO] [stderr] 2421 | CirculatePlace::Bottom => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2440:16 [INFO] [stderr] | [INFO] [stderr] 2440 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2441:9 [INFO] [stderr] | [INFO] [stderr] 2441 | / match self { [INFO] [stderr] 2442 | | &PropertyState::NewValue => 0, [INFO] [stderr] 2443 | | &PropertyState::Deleted => 1 [INFO] [stderr] 2444 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2441 | match *self { [INFO] [stderr] 2442 | PropertyState::NewValue => 0, [INFO] [stderr] 2443 | PropertyState::Deleted => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2462:16 [INFO] [stderr] | [INFO] [stderr] 2462 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2463:9 [INFO] [stderr] | [INFO] [stderr] 2463 | / match self { [INFO] [stderr] 2464 | | &ColormapState::Uninstalled => 0, [INFO] [stderr] 2465 | | &ColormapState::Installed => 1 [INFO] [stderr] 2466 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2463 | match *self { [INFO] [stderr] 2464 | ColormapState::Uninstalled => 0, [INFO] [stderr] 2465 | ColormapState::Installed => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2486:16 [INFO] [stderr] | [INFO] [stderr] 2486 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2487:9 [INFO] [stderr] | [INFO] [stderr] 2487 | / match self { [INFO] [stderr] 2488 | | &MappingType::Modifier => 0, [INFO] [stderr] 2489 | | &MappingType::Keyboard => 1, [INFO] [stderr] 2490 | | &MappingType::Pointer => 2 [INFO] [stderr] 2491 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2487 | match *self { [INFO] [stderr] 2488 | MappingType::Modifier => 0, [INFO] [stderr] 2489 | MappingType::Keyboard => 1, [INFO] [stderr] 2490 | MappingType::Pointer => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2501:16 [INFO] [stderr] | [INFO] [stderr] 2501 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2502:9 [INFO] [stderr] | [INFO] [stderr] 2502 | / match self { [INFO] [stderr] 2503 | | &SaveSetMode::Insert => 0, [INFO] [stderr] 2504 | | &SaveSetMode::Delete => 1 [INFO] [stderr] 2505 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2502 | match *self { [INFO] [stderr] 2503 | SaveSetMode::Insert => 0, [INFO] [stderr] 2504 | SaveSetMode::Delete => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2515:16 [INFO] [stderr] | [INFO] [stderr] 2515 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2516:9 [INFO] [stderr] | [INFO] [stderr] 2516 | / match self { [INFO] [stderr] 2517 | | &CirculateDirection::RaiseLowest => 0, [INFO] [stderr] 2518 | | &CirculateDirection::LowerHighest => 1 [INFO] [stderr] 2519 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2516 | match *self { [INFO] [stderr] 2517 | CirculateDirection::RaiseLowest => 0, [INFO] [stderr] 2518 | CirculateDirection::LowerHighest => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2530:16 [INFO] [stderr] | [INFO] [stderr] 2530 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2531:9 [INFO] [stderr] | [INFO] [stderr] 2531 | / match self { [INFO] [stderr] 2532 | | &PropertyChangeMode::Replace => 0, [INFO] [stderr] 2533 | | &PropertyChangeMode::Prepend => 1, [INFO] [stderr] 2534 | | &PropertyChangeMode::Append => 2 [INFO] [stderr] 2535 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2531 | match *self { [INFO] [stderr] 2532 | PropertyChangeMode::Replace => 0, [INFO] [stderr] 2533 | PropertyChangeMode::Prepend => 1, [INFO] [stderr] 2534 | PropertyChangeMode::Append => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2545:16 [INFO] [stderr] | [INFO] [stderr] 2545 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2546:9 [INFO] [stderr] | [INFO] [stderr] 2546 | / match self { [INFO] [stderr] 2547 | | &PointerMode::Synchronous => 0, [INFO] [stderr] 2548 | | &PointerMode::Asynchronous => 1 [INFO] [stderr] 2549 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2546 | match *self { [INFO] [stderr] 2547 | PointerMode::Synchronous => 0, [INFO] [stderr] 2548 | PointerMode::Asynchronous => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2559:16 [INFO] [stderr] | [INFO] [stderr] 2559 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2560:9 [INFO] [stderr] | [INFO] [stderr] 2560 | / match self { [INFO] [stderr] 2561 | | &KeyboardMode::Synchronous => 0, [INFO] [stderr] 2562 | | &KeyboardMode::Asynchronous => 1 [INFO] [stderr] 2563 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2560 | match *self { [INFO] [stderr] 2561 | KeyboardMode::Synchronous => 0, [INFO] [stderr] 2562 | KeyboardMode::Asynchronous => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2312:16 [INFO] [stderr] | [INFO] [stderr] 2312 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2313:9 [INFO] [stderr] | [INFO] [stderr] 2313 | / match self { [INFO] [stderr] 2314 | | &VisibilityState::Unobscured => 0, [INFO] [stderr] 2315 | | &VisibilityState::PartiallyObscured => 1, [INFO] [stderr] 2316 | | &VisibilityState::FullyObscured => 2 [INFO] [stderr] 2317 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2313 | match *self { [INFO] [stderr] 2314 | VisibilityState::Unobscured => 0, [INFO] [stderr] 2315 | VisibilityState::PartiallyObscured => 1, [INFO] [stderr] 2316 | VisibilityState::FullyObscured => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2341:16 [INFO] [stderr] | [INFO] [stderr] 2341 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] --> src/models.rs:2594:16 [INFO] [stderr] | [INFO] [stderr] 2594 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2342:9 [INFO] [stderr] | [INFO] [stderr] 2342 | / match self { [INFO] [stderr] 2343 | | &StackMode::Above => 0, [INFO] [stderr] 2344 | | &StackMode::Below => 1, [INFO] [stderr] 2345 | | &StackMode::TopIf => 2, [INFO] [stderr] 2346 | | &StackMode::BottomIf => 3, [INFO] [stderr] 2347 | | &StackMode::Opposite => 4 [INFO] [stderr] 2348 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2595:9 [INFO] [stderr] | [INFO] [stderr] 2595 | / match self { [INFO] [stderr] 2596 | | &GraphicsContextMask::Function => 0x00000001, [INFO] [stderr] 2597 | | &GraphicsContextMask::PlaneMask => 0x00000002, [INFO] [stderr] 2598 | | &GraphicsContextMask::Foreground => 0x00000004, [INFO] [stderr] ... | [INFO] [stderr] 2618 | | &GraphicsContextMask::ArcMode => 0x00400000 [INFO] [stderr] 2619 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 2342 | match *self { [INFO] [stderr] 2595 | match *self { [INFO] [stderr] 2343 | StackMode::Above => 0, [INFO] [stderr] 2596 | GraphicsContextMask::Function => 0x00000001, [INFO] [stderr] 2344 | StackMode::Below => 1, [INFO] [stderr] 2345 | StackMode::TopIf => 2, [INFO] [stderr] 2597 | GraphicsContextMask::PlaneMask => 0x00000002, [INFO] [stderr] 2346 | StackMode::BottomIf => 3, [INFO] [stderr] 2598 | GraphicsContextMask::Foreground => 0x00000004, [INFO] [stderr] 2347 | StackMode::Opposite => 4 [INFO] [stderr] 2599 | GraphicsContextMask::Background => 0x00000008, [INFO] [stderr] 2600 | GraphicsContextMask::LineWidth => 0x00000010, [INFO] [stderr] | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2631:16 [INFO] [stderr] | [INFO] [stderr] 2631 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2632:9 [INFO] [stderr] | [INFO] [stderr] 2632 | / match self { [INFO] [stderr] 2633 | | &RectangleOrdering::UnSorted => 0, [INFO] [stderr] 2634 | | &RectangleOrdering::YSorted => 1, [INFO] [stderr] 2635 | | &RectangleOrdering::YXSorted => 2, [INFO] [stderr] 2636 | | &RectangleOrdering::YXBanded => 3 [INFO] [stderr] 2637 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2632 | match *self { [INFO] [stderr] 2633 | RectangleOrdering::UnSorted => 0, [INFO] [stderr] 2634 | RectangleOrdering::YSorted => 1, [INFO] [stderr] 2635 | RectangleOrdering::YXSorted => 2, [INFO] [stderr] 2636 | RectangleOrdering::YXBanded => 3 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2647:16 [INFO] [stderr] | [INFO] [stderr] 2647 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2648:9 [INFO] [stderr] | [INFO] [stderr] 2648 | / match self { [INFO] [stderr] 2649 | | &CoordinateMode::Origin => 0, [INFO] [stderr] 2650 | | &CoordinateMode::Previous => 1 [INFO] [stderr] 2651 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2648 | match *self { [INFO] [stderr] 2649 | CoordinateMode::Origin => 0, [INFO] [stderr] 2650 | CoordinateMode::Previous => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2662:16 [INFO] [stderr] | [INFO] [stderr] 2662 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2391:16 [INFO] [stderr] | [INFO] [stderr] 2391 | pub fn val(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2663:9 [INFO] [stderr] | [INFO] [stderr] 2663 | / match self { [INFO] [stderr] 2664 | | &PolyShape::Complex => 0, [INFO] [stderr] 2665 | | &PolyShape::Nonconvex => 1, [INFO] [stderr] 2666 | | &PolyShape::Convex => 2, [INFO] [stderr] 2667 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2663 | match *self { [INFO] [stderr] 2664 | PolyShape::Complex => 0, [INFO] [stderr] 2665 | PolyShape::Nonconvex => 1, [INFO] [stderr] 2666 | PolyShape::Convex => 2, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2392:9 [INFO] [stderr] | [INFO] [stderr] 2392 | / match self { [INFO] [stderr] 2393 | | &ConfigureRequestValues::X => 0x0001, [INFO] [stderr] 2394 | | &ConfigureRequestValues::Y => 0x0002, [INFO] [stderr] 2395 | | &ConfigureRequestValues::Width => 0x0004, [INFO] [stderr] ... | [INFO] [stderr] 2399 | | &ConfigureRequestValues::StackMode => 0x0040 [INFO] [stderr] 2400 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2392 | match *self { [INFO] [stderr] 2393 | ConfigureRequestValues::X => 0x0001, [INFO] [stderr] 2394 | ConfigureRequestValues::Y => 0x0002, [INFO] [stderr] 2395 | ConfigureRequestValues::Width => 0x0004, [INFO] [stderr] 2396 | ConfigureRequestValues::Height => 0x0008, [INFO] [stderr] 2397 | ConfigureRequestValues::BorderWidth => 0x0010, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2678:16 [INFO] [stderr] | [INFO] [stderr] 2678 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2418:16 [INFO] [stderr] | [INFO] [stderr] 2418 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2679:9 [INFO] [stderr] | [INFO] [stderr] 2679 | / match self { [INFO] [stderr] 2680 | | &ImageFormat::Bitmap => 0, [INFO] [stderr] 2681 | | &ImageFormat::XYPixmap => 1, [INFO] [stderr] 2682 | | &ImageFormat::ZPixmap => 2, [INFO] [stderr] 2683 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2679 | match *self { [INFO] [stderr] 2680 | ImageFormat::Bitmap => 0, [INFO] [stderr] 2681 | ImageFormat::XYPixmap => 1, [INFO] [stderr] 2682 | ImageFormat::ZPixmap => 2, [INFO] [stderr] | [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] [INFO] [stderr] --> src/models.rs:2419:9 [INFO] [stderr] | [INFO] [stderr] 2419 | / match self { [INFO] [stderr] 2420 | | &CirculatePlace::Top => 0, [INFO] [stderr] 2421 | | &CirculatePlace::Bottom => 1 [INFO] [stderr] 2422 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2419 | match *self { [INFO] [stderr] 2420 | CirculatePlace::Top => 0, [INFO] [stderr] 2421 | CirculatePlace::Bottom => 1 [INFO] [stderr] | [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2693:16 [INFO] [stderr] | [INFO] [stderr] 2693 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2694:9 [INFO] [stderr] | [INFO] [stderr] 2694 | / match self { [INFO] [stderr] 2695 | | &AllocMode::None => 0, [INFO] [stderr] 2696 | | &AllocMode::All => 1 [INFO] [stderr] 2697 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2694 | match *self { [INFO] [stderr] 2695 | AllocMode::None => 0, [INFO] [stderr] 2696 | AllocMode::All => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2708:16 [INFO] [stderr] | [INFO] [stderr] 2708 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2709:9 [INFO] [stderr] | [INFO] [stderr] 2709 | / match self { [INFO] [stderr] 2710 | | &SizeClass::Cursor => 0, [INFO] [stderr] 2711 | | &SizeClass::Tile => 1, [INFO] [stderr] 2712 | | &SizeClass::Stipple => 2 [INFO] [stderr] 2713 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2709 | match *self { [INFO] [stderr] 2710 | SizeClass::Cursor => 0, [INFO] [stderr] 2711 | SizeClass::Tile => 1, [INFO] [stderr] 2712 | SizeClass::Stipple => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2723:16 [INFO] [stderr] | [INFO] [stderr] 2723 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2724:9 [INFO] [stderr] | [INFO] [stderr] 2724 | / match self { [INFO] [stderr] 2725 | | &KeyboardControlLedMode::Off => 0, [INFO] [stderr] 2726 | | &KeyboardControlLedMode::On => 1 [INFO] [stderr] 2727 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2724 | match *self { [INFO] [stderr] 2725 | KeyboardControlLedMode::Off => 0, [INFO] [stderr] 2726 | KeyboardControlLedMode::On => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2738:16 [INFO] [stderr] | [INFO] [stderr] 2738 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2739:9 [INFO] [stderr] | [INFO] [stderr] 2739 | / match self { [INFO] [stderr] 2740 | | &KeyboardControlAutoRepeatMode::Off => 0, [INFO] [stderr] 2741 | | &KeyboardControlAutoRepeatMode::On => 1, [INFO] [stderr] 2742 | | &KeyboardControlAutoRepeatMode::Default => 2 [INFO] [stderr] 2743 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2739 | match *self { [INFO] [stderr] 2740 | KeyboardControlAutoRepeatMode::Off => 0, [INFO] [stderr] 2741 | KeyboardControlAutoRepeatMode::On => 1, [INFO] [stderr] 2742 | KeyboardControlAutoRepeatMode::Default => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2763:16 [INFO] [stderr] | [INFO] [stderr] 2763 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2440:16 [INFO] [stderr] | [INFO] [stderr] 2440 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2764:9 [INFO] [stderr] | [INFO] [stderr] 2764 | / match self { [INFO] [stderr] 2765 | | &YesNoDefault::No => 0, [INFO] [stderr] 2766 | | &YesNoDefault::Yes => 1, [INFO] [stderr] 2767 | | &YesNoDefault::Default => 2 [INFO] [stderr] 2768 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2441:9 [INFO] [stderr] | [INFO] [stderr] 2441 | / match self { [INFO] [stderr] 2442 | | &PropertyState::NewValue => 0, [INFO] [stderr] 2443 | | &PropertyState::Deleted => 1 [INFO] [stderr] 2444 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2764 | match *self { [INFO] [stderr] 2765 | YesNoDefault::No => 0, [INFO] [stderr] 2766 | YesNoDefault::Yes => 1, [INFO] [stderr] 2767 | YesNoDefault::Default => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2441 | match *self { [INFO] [stderr] 2442 | PropertyState::NewValue => 0, [INFO] [stderr] 2443 | PropertyState::Deleted => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2781:16 [INFO] [stderr] | [INFO] [stderr] 2781 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2782:9 [INFO] [stderr] | [INFO] [stderr] 2782 | / match self { [INFO] [stderr] 2783 | | &HostFamily::Internet => 0, [INFO] [stderr] 2784 | | &HostFamily::DECnet => 1, [INFO] [stderr] 2785 | | &HostFamily::Chaos => 2, [INFO] [stderr] 2786 | | &HostFamily::ServerInterpreted => 5, [INFO] [stderr] 2787 | | &HostFamily::InternetV6 => 6, [INFO] [stderr] 2788 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2782 | match *self { [INFO] [stderr] 2783 | HostFamily::Internet => 0, [INFO] [stderr] 2784 | HostFamily::DECnet => 1, [INFO] [stderr] 2785 | HostFamily::Chaos => 2, [INFO] [stderr] 2786 | HostFamily::ServerInterpreted => 5, [INFO] [stderr] 2787 | HostFamily::InternetV6 => 6, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2809:16 [INFO] [stderr] | [INFO] [stderr] 2809 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2810:9 [INFO] [stderr] | [INFO] [stderr] 2810 | / match self { [INFO] [stderr] 2811 | | &ChangeHostMode::Insert => 0, [INFO] [stderr] 2812 | | &ChangeHostMode::Delete => 1 [INFO] [stderr] 2813 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2810 | match *self { [INFO] [stderr] 2811 | ChangeHostMode::Insert => 0, [INFO] [stderr] 2812 | ChangeHostMode::Delete => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2824:16 [INFO] [stderr] | [INFO] [stderr] 2824 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2825:9 [INFO] [stderr] | [INFO] [stderr] 2825 | / match self { [INFO] [stderr] 2826 | | &CloseDownMode::Destroy => 0, [INFO] [stderr] 2827 | | &CloseDownMode::RetainPermanent => 1, [INFO] [stderr] 2828 | | &CloseDownMode::RetainTemporary => 2 [INFO] [stderr] 2829 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2825 | match *self { [INFO] [stderr] 2826 | CloseDownMode::Destroy => 0, [INFO] [stderr] 2827 | CloseDownMode::RetainPermanent => 1, [INFO] [stderr] 2828 | CloseDownMode::RetainTemporary => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2462:16 [INFO] [stderr] | [INFO] [stderr] 2462 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2463:9 [INFO] [stderr] | [INFO] [stderr] 2463 | / match self { [INFO] [stderr] 2464 | | &ColormapState::Uninstalled => 0, [INFO] [stderr] 2465 | | &ColormapState::Installed => 1 [INFO] [stderr] 2466 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2463 | match *self { [INFO] [stderr] 2464 | ColormapState::Uninstalled => 0, [INFO] [stderr] 2465 | ColormapState::Installed => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2486:16 [INFO] [stderr] | [INFO] [stderr] 2486 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2487:9 [INFO] [stderr] | [INFO] [stderr] 2487 | / match self { [INFO] [stderr] 2488 | | &MappingType::Modifier => 0, [INFO] [stderr] 2489 | | &MappingType::Keyboard => 1, [INFO] [stderr] 2490 | | &MappingType::Pointer => 2 [INFO] [stderr] 2491 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2487 | match *self { [INFO] [stderr] 2488 | MappingType::Modifier => 0, [INFO] [stderr] 2489 | MappingType::Keyboard => 1, [INFO] [stderr] 2490 | MappingType::Pointer => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2501:16 [INFO] [stderr] | [INFO] [stderr] 2501 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2502:9 [INFO] [stderr] | [INFO] [stderr] 2502 | / match self { [INFO] [stderr] 2503 | | &SaveSetMode::Insert => 0, [INFO] [stderr] 2504 | | &SaveSetMode::Delete => 1 [INFO] [stderr] 2505 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2502 | match *self { [INFO] [stderr] 2503 | SaveSetMode::Insert => 0, [INFO] [stderr] 2504 | SaveSetMode::Delete => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2515:16 [INFO] [stderr] | [INFO] [stderr] 2515 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2516:9 [INFO] [stderr] | [INFO] [stderr] 2516 | / match self { [INFO] [stderr] 2517 | | &CirculateDirection::RaiseLowest => 0, [INFO] [stderr] 2518 | | &CirculateDirection::LowerHighest => 1 [INFO] [stderr] 2519 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2516 | match *self { [INFO] [stderr] 2517 | CirculateDirection::RaiseLowest => 0, [INFO] [stderr] 2518 | CirculateDirection::LowerHighest => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2943:16 [INFO] [stderr] | [INFO] [stderr] 2943 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2530:16 [INFO] [stderr] | [INFO] [stderr] 2530 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2531:9 [INFO] [stderr] | [INFO] [stderr] 2531 | / match self { [INFO] [stderr] 2532 | | &PropertyChangeMode::Replace => 0, [INFO] [stderr] 2533 | | &PropertyChangeMode::Prepend => 1, [INFO] [stderr] 2534 | | &PropertyChangeMode::Append => 2 [INFO] [stderr] 2535 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2531 | match *self { [INFO] [stderr] 2532 | PropertyChangeMode::Replace => 0, [INFO] [stderr] 2533 | PropertyChangeMode::Prepend => 1, [INFO] [stderr] 2534 | PropertyChangeMode::Append => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2545:16 [INFO] [stderr] | [INFO] [stderr] 2545 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2546:9 [INFO] [stderr] | [INFO] [stderr] 2546 | / match self { [INFO] [stderr] 2547 | | &PointerMode::Synchronous => 0, [INFO] [stderr] 2548 | | &PointerMode::Asynchronous => 1 [INFO] [stderr] 2549 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2546 | match *self { [INFO] [stderr] 2547 | PointerMode::Synchronous => 0, [INFO] [stderr] 2548 | PointerMode::Asynchronous => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2559:16 [INFO] [stderr] | [INFO] [stderr] 2559 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2560:9 [INFO] [stderr] | [INFO] [stderr] 2560 | / match self { [INFO] [stderr] 2561 | | &KeyboardMode::Synchronous => 0, [INFO] [stderr] 2562 | | &KeyboardMode::Asynchronous => 1 [INFO] [stderr] 2563 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2560 | match *self { [INFO] [stderr] 2561 | KeyboardMode::Synchronous => 0, [INFO] [stderr] 2562 | KeyboardMode::Asynchronous => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2594:16 [INFO] [stderr] | [INFO] [stderr] 2594 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2595:9 [INFO] [stderr] | [INFO] [stderr] 2595 | / match self { [INFO] [stderr] 2596 | | &GraphicsContextMask::Function => 0x00000001, [INFO] [stderr] 2597 | | &GraphicsContextMask::PlaneMask => 0x00000002, [INFO] [stderr] 2598 | | &GraphicsContextMask::Foreground => 0x00000004, [INFO] [stderr] ... | [INFO] [stderr] 2618 | | &GraphicsContextMask::ArcMode => 0x00400000 [INFO] [stderr] 2619 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:3112:9 [INFO] [stderr] | [INFO] [stderr] 3112 | / match self { [INFO] [stderr] 3113 | | &WindowValue::BackgroundPixmap(_) => 0x00000001, [INFO] [stderr] 3114 | | &WindowValue::BackgroundPixel(_) => 0x00000002, [INFO] [stderr] 3115 | | &WindowValue::BorderPixmap(_) => 0x00000004, [INFO] [stderr] ... | [INFO] [stderr] 3127 | | &WindowValue::Cursor(_) => 0x00004000 [INFO] [stderr] 3128 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 3112 | match *self { [INFO] [stderr] 3113 | WindowValue::BackgroundPixmap(_) => 0x00000001, [INFO] [stderr] 3114 | WindowValue::BackgroundPixel(_) => 0x00000002, [INFO] [stderr] 3115 | WindowValue::BorderPixmap(_) => 0x00000004, [INFO] [stderr] 3116 | WindowValue::BorderPixel(_) => 0x00000008, [INFO] [stderr] 3117 | WindowValue::BitGravity(_) => 0x00000010, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:3132:9 [INFO] [stderr] | [INFO] [stderr] 3132 | / match self { [INFO] [stderr] 3133 | | &WindowValue::BackgroundPixmap(val) => client.write_val_u32(val), [INFO] [stderr] 3134 | | &WindowValue::BackgroundPixel(val) => client.write_val_u32(val), [INFO] [stderr] 3135 | | &WindowValue::BorderPixmap(val) => client.write_val_u32(val), [INFO] [stderr] ... | [INFO] [stderr] 3147 | | &WindowValue::Cursor(val) => client.write_val_u32(val) [INFO] [stderr] 3148 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 3132 | match *self { [INFO] [stderr] 3133 | WindowValue::BackgroundPixmap(val) => client.write_val_u32(val), [INFO] [stderr] 3134 | WindowValue::BackgroundPixel(val) => client.write_val_u32(val), [INFO] [stderr] 3135 | WindowValue::BorderPixmap(val) => client.write_val_u32(val), [INFO] [stderr] 3136 | WindowValue::BorderPixel(val) => client.write_val_u32(val), [INFO] [stderr] 3137 | WindowValue::BitGravity(ref val) => client.write_val(val.val()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:3154:9 [INFO] [stderr] | [INFO] [stderr] 3154 | / match self { [INFO] [stderr] 3155 | | &WindowConfigureValue::X(_) => 0x0001, [INFO] [stderr] 3156 | | &WindowConfigureValue::Y(_) => 0x0002, [INFO] [stderr] 3157 | | &WindowConfigureValue::Width(_) => 0x0004, [INFO] [stderr] ... | [INFO] [stderr] 3161 | | &WindowConfigureValue::StackMode(_) => 0x0080 [INFO] [stderr] 3162 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 3154 | match *self { [INFO] [stderr] 3155 | WindowConfigureValue::X(_) => 0x0001, [INFO] [stderr] 3156 | WindowConfigureValue::Y(_) => 0x0002, [INFO] [stderr] 3157 | WindowConfigureValue::Width(_) => 0x0004, [INFO] [stderr] 3158 | WindowConfigureValue::Height(_) => 0x0008, [INFO] [stderr] 3159 | WindowConfigureValue::BorderWidth(_) => 0x0020, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:3166:9 [INFO] [stderr] | [INFO] [stderr] 3166 | / match self { [INFO] [stderr] 3167 | | &WindowConfigureValue::X(val) => client.write_val_i16(val), [INFO] [stderr] 3168 | | &WindowConfigureValue::Y(val) => client.write_val_i16(val), [INFO] [stderr] 3169 | | &WindowConfigureValue::Width(val) => client.write_val_u16(val), [INFO] [stderr] ... | [INFO] [stderr] 3173 | | &WindowConfigureValue::StackMode(ref val) => client.write_val_u8(val.val()) [INFO] [stderr] 3174 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 3166 | match *self { [INFO] [stderr] 3167 | WindowConfigureValue::X(val) => client.write_val_i16(val), [INFO] [stderr] 3168 | WindowConfigureValue::Y(val) => client.write_val_i16(val), [INFO] [stderr] 3169 | WindowConfigureValue::Width(val) => client.write_val_u16(val), [INFO] [stderr] 3170 | WindowConfigureValue::Height(val) => client.write_val_u16(val), [INFO] [stderr] 3171 | WindowConfigureValue::BorderWidth(val) => client.write_val_u16(val), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2595 | match *self { [INFO] [stderr] 2596 | GraphicsContextMask::Function => 0x00000001, [INFO] [stderr] 2597 | GraphicsContextMask::PlaneMask => 0x00000002, [INFO] [stderr] 2598 | GraphicsContextMask::Foreground => 0x00000004, [INFO] [stderr] 2599 | GraphicsContextMask::Background => 0x00000008, [INFO] [stderr] 2600 | GraphicsContextMask::LineWidth => 0x00000010, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:3180:9 [INFO] [stderr] | [INFO] [stderr] 3180 | / match self { [INFO] [stderr] 3181 | | &GraphicsContextValue::Function(_) => 0x00000001, [INFO] [stderr] 3182 | | &GraphicsContextValue::PlaneMask(_) => 0x00000002, [INFO] [stderr] 3183 | | &GraphicsContextValue::Foreground(_) => 0x00000004, [INFO] [stderr] ... | [INFO] [stderr] 3203 | | &GraphicsContextValue::ArcMode(_) => 0x00400000 [INFO] [stderr] 3204 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 3180 | match *self { [INFO] [stderr] 3181 | GraphicsContextValue::Function(_) => 0x00000001, [INFO] [stderr] 3182 | GraphicsContextValue::PlaneMask(_) => 0x00000002, [INFO] [stderr] 3183 | GraphicsContextValue::Foreground(_) => 0x00000004, [INFO] [stderr] 3184 | GraphicsContextValue::Background(_) => 0x00000008, [INFO] [stderr] 3185 | GraphicsContextValue::LineWidth(_) => 0x00000010, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:3208:9 [INFO] [stderr] | [INFO] [stderr] 3208 | / match self { [INFO] [stderr] 3209 | | &GraphicsContextValue::Function(ref val) => client.write_val(val.val()), [INFO] [stderr] 3210 | | &GraphicsContextValue::PlaneMask(val) => client.write_val_u32(val), [INFO] [stderr] 3211 | | &GraphicsContextValue::Foreground(val) => client.write_val_u32(val), [INFO] [stderr] ... | [INFO] [stderr] 3231 | | &GraphicsContextValue::ArcMode(ref val) => client.write_val(val.val()) [INFO] [stderr] 3232 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 3208 | match *self { [INFO] [stderr] 3209 | GraphicsContextValue::Function(ref val) => client.write_val(val.val()), [INFO] [stderr] 3210 | GraphicsContextValue::PlaneMask(val) => client.write_val_u32(val), [INFO] [stderr] 3211 | GraphicsContextValue::Foreground(val) => client.write_val_u32(val), [INFO] [stderr] 3212 | GraphicsContextValue::Background(val) => client.write_val_u32(val), [INFO] [stderr] 3213 | GraphicsContextValue::LineWidth(val) => client.write_val_u16(val), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:3238:9 [INFO] [stderr] | [INFO] [stderr] 3238 | / match self { [INFO] [stderr] 3239 | | &KeyboardControlValue::KeyClickPercent(_) => 0x0001, [INFO] [stderr] 3240 | | &KeyboardControlValue::BellPercent(_) => 0x0002, [INFO] [stderr] 3241 | | &KeyboardControlValue::BellPitch(_) => 0x0004, [INFO] [stderr] ... | [INFO] [stderr] 3246 | | &KeyboardControlValue::AutoRepeatMode(_) => 0x0040 [INFO] [stderr] 3247 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 3238 | match *self { [INFO] [stderr] 3239 | KeyboardControlValue::KeyClickPercent(_) => 0x0001, [INFO] [stderr] 3240 | KeyboardControlValue::BellPercent(_) => 0x0002, [INFO] [stderr] 3241 | KeyboardControlValue::BellPitch(_) => 0x0004, [INFO] [stderr] 3242 | KeyboardControlValue::BellDuration(_) => 0x0008, [INFO] [stderr] 3243 | KeyboardControlValue::Led(_) => 0x0010, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:3251:9 [INFO] [stderr] | [INFO] [stderr] 3251 | / match self { [INFO] [stderr] 3252 | | &KeyboardControlValue::KeyClickPercent(val) => client.write_u8(val), [INFO] [stderr] 3253 | | &KeyboardControlValue::BellPercent(val) => client.write_u8(val), [INFO] [stderr] 3254 | | &KeyboardControlValue::BellPitch(val) => client.write_i16(val), [INFO] [stderr] ... | [INFO] [stderr] 3259 | | &KeyboardControlValue::AutoRepeatMode(ref val) => client.write_u8(val.val()) [INFO] [stderr] 3260 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 3251 | match *self { [INFO] [stderr] 3252 | KeyboardControlValue::KeyClickPercent(val) => client.write_u8(val), [INFO] [stderr] 3253 | KeyboardControlValue::BellPercent(val) => client.write_u8(val), [INFO] [stderr] 3254 | KeyboardControlValue::BellPitch(val) => client.write_i16(val), [INFO] [stderr] 3255 | KeyboardControlValue::BellDuration(val) => client.write_i16(val), [INFO] [stderr] 3256 | KeyboardControlValue::Led(val) => client.write_u8(val), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/xreaderwriter.rs:25:41 [INFO] [stderr] | [INFO] [stderr] 25 | fn write_mask_u16(&mut self, input: &Vec); [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/xreaderwriter.rs:26:41 [INFO] [stderr] | [INFO] [stderr] 26 | fn write_mask_u32(&mut self, input: &Vec); [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/xreaderwriter.rs:34:50 [INFO] [stderr] | [INFO] [stderr] 34 | fn write_values(&mut self, values: &Vec, mask_size: u8); [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2631:16 [INFO] [stderr] | [INFO] [stderr] 2631 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2632:9 [INFO] [stderr] | [INFO] [stderr] 2632 | / match self { [INFO] [stderr] 2633 | | &RectangleOrdering::UnSorted => 0, [INFO] [stderr] 2634 | | &RectangleOrdering::YSorted => 1, [INFO] [stderr] 2635 | | &RectangleOrdering::YXSorted => 2, [INFO] [stderr] 2636 | | &RectangleOrdering::YXBanded => 3 [INFO] [stderr] 2637 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2632 | match *self { [INFO] [stderr] 2633 | RectangleOrdering::UnSorted => 0, [INFO] [stderr] 2634 | RectangleOrdering::YSorted => 1, [INFO] [stderr] 2635 | RectangleOrdering::YXSorted => 2, [INFO] [stderr] 2636 | RectangleOrdering::YXBanded => 3 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2647:16 [INFO] [stderr] | [INFO] [stderr] 2647 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2648:9 [INFO] [stderr] | [INFO] [stderr] 2648 | / match self { [INFO] [stderr] 2649 | | &CoordinateMode::Origin => 0, [INFO] [stderr] 2650 | | &CoordinateMode::Previous => 1 [INFO] [stderr] 2651 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2648 | match *self { [INFO] [stderr] 2649 | CoordinateMode::Origin => 0, [INFO] [stderr] 2650 | CoordinateMode::Previous => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2662:16 [INFO] [stderr] | [INFO] [stderr] 2662 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2663:9 [INFO] [stderr] | [INFO] [stderr] 2663 | / match self { [INFO] [stderr] 2664 | | &PolyShape::Complex => 0, [INFO] [stderr] 2665 | | &PolyShape::Nonconvex => 1, [INFO] [stderr] 2666 | | &PolyShape::Convex => 2, [INFO] [stderr] 2667 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2663 | match *self { [INFO] [stderr] 2664 | PolyShape::Complex => 0, [INFO] [stderr] 2665 | PolyShape::Nonconvex => 1, [INFO] [stderr] 2666 | PolyShape::Convex => 2, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2678:16 [INFO] [stderr] | [INFO] [stderr] 2678 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2679:9 [INFO] [stderr] | [INFO] [stderr] 2679 | / match self { [INFO] [stderr] 2680 | | &ImageFormat::Bitmap => 0, [INFO] [stderr] 2681 | | &ImageFormat::XYPixmap => 1, [INFO] [stderr] 2682 | | &ImageFormat::ZPixmap => 2, [INFO] [stderr] 2683 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2679 | match *self { [INFO] [stderr] 2680 | ImageFormat::Bitmap => 0, [INFO] [stderr] 2681 | ImageFormat::XYPixmap => 1, [INFO] [stderr] 2682 | ImageFormat::ZPixmap => 2, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2693:16 [INFO] [stderr] | [INFO] [stderr] 2693 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2694:9 [INFO] [stderr] | [INFO] [stderr] 2694 | / match self { [INFO] [stderr] 2695 | | &AllocMode::None => 0, [INFO] [stderr] 2696 | | &AllocMode::All => 1 [INFO] [stderr] 2697 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2694 | match *self { [INFO] [stderr] 2695 | AllocMode::None => 0, [INFO] [stderr] 2696 | AllocMode::All => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2708:16 [INFO] [stderr] | [INFO] [stderr] 2708 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2709:9 [INFO] [stderr] | [INFO] [stderr] 2709 | / match self { [INFO] [stderr] 2710 | | &SizeClass::Cursor => 0, [INFO] [stderr] 2711 | | &SizeClass::Tile => 1, [INFO] [stderr] 2712 | | &SizeClass::Stipple => 2 [INFO] [stderr] 2713 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2709 | match *self { [INFO] [stderr] 2710 | SizeClass::Cursor => 0, [INFO] [stderr] 2711 | SizeClass::Tile => 1, [INFO] [stderr] 2712 | SizeClass::Stipple => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2723:16 [INFO] [stderr] | [INFO] [stderr] 2723 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2724:9 [INFO] [stderr] | [INFO] [stderr] 2724 | / match self { [INFO] [stderr] 2725 | | &KeyboardControlLedMode::Off => 0, [INFO] [stderr] 2726 | | &KeyboardControlLedMode::On => 1 [INFO] [stderr] 2727 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2724 | match *self { [INFO] [stderr] 2725 | KeyboardControlLedMode::Off => 0, [INFO] [stderr] 2726 | KeyboardControlLedMode::On => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2738:16 [INFO] [stderr] | [INFO] [stderr] 2738 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2739:9 [INFO] [stderr] | [INFO] [stderr] 2739 | / match self { [INFO] [stderr] 2740 | | &KeyboardControlAutoRepeatMode::Off => 0, [INFO] [stderr] 2741 | | &KeyboardControlAutoRepeatMode::On => 1, [INFO] [stderr] 2742 | | &KeyboardControlAutoRepeatMode::Default => 2 [INFO] [stderr] 2743 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2739 | match *self { [INFO] [stderr] 2740 | KeyboardControlAutoRepeatMode::Off => 0, [INFO] [stderr] 2741 | KeyboardControlAutoRepeatMode::On => 1, [INFO] [stderr] 2742 | KeyboardControlAutoRepeatMode::Default => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2763:16 [INFO] [stderr] | [INFO] [stderr] 2763 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2764:9 [INFO] [stderr] | [INFO] [stderr] 2764 | / match self { [INFO] [stderr] 2765 | | &YesNoDefault::No => 0, [INFO] [stderr] 2766 | | &YesNoDefault::Yes => 1, [INFO] [stderr] 2767 | | &YesNoDefault::Default => 2 [INFO] [stderr] 2768 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2764 | match *self { [INFO] [stderr] 2765 | YesNoDefault::No => 0, [INFO] [stderr] 2766 | YesNoDefault::Yes => 1, [INFO] [stderr] 2767 | YesNoDefault::Default => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2781:16 [INFO] [stderr] | [INFO] [stderr] 2781 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2782:9 [INFO] [stderr] | [INFO] [stderr] 2782 | / match self { [INFO] [stderr] 2783 | | &HostFamily::Internet => 0, [INFO] [stderr] 2784 | | &HostFamily::DECnet => 1, [INFO] [stderr] 2785 | | &HostFamily::Chaos => 2, [INFO] [stderr] 2786 | | &HostFamily::ServerInterpreted => 5, [INFO] [stderr] 2787 | | &HostFamily::InternetV6 => 6, [INFO] [stderr] 2788 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2782 | match *self { [INFO] [stderr] 2783 | HostFamily::Internet => 0, [INFO] [stderr] 2784 | HostFamily::DECnet => 1, [INFO] [stderr] 2785 | HostFamily::Chaos => 2, [INFO] [stderr] 2786 | HostFamily::ServerInterpreted => 5, [INFO] [stderr] 2787 | HostFamily::InternetV6 => 6, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2809:16 [INFO] [stderr] | [INFO] [stderr] 2809 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2810:9 [INFO] [stderr] | [INFO] [stderr] 2810 | / match self { [INFO] [stderr] 2811 | | &ChangeHostMode::Insert => 0, [INFO] [stderr] 2812 | | &ChangeHostMode::Delete => 1 [INFO] [stderr] 2813 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2810 | match *self { [INFO] [stderr] 2811 | ChangeHostMode::Insert => 0, [INFO] [stderr] 2812 | ChangeHostMode::Delete => 1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2824:16 [INFO] [stderr] | [INFO] [stderr] 2824 | pub fn val(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:2825:9 [INFO] [stderr] | [INFO] [stderr] 2825 | / match self { [INFO] [stderr] 2826 | | &CloseDownMode::Destroy => 0, [INFO] [stderr] 2827 | | &CloseDownMode::RetainPermanent => 1, [INFO] [stderr] 2828 | | &CloseDownMode::RetainTemporary => 2 [INFO] [stderr] 2829 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2825 | match *self { [INFO] [stderr] 2826 | CloseDownMode::Destroy => 0, [INFO] [stderr] 2827 | CloseDownMode::RetainPermanent => 1, [INFO] [stderr] 2828 | CloseDownMode::RetainTemporary => 2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/xreaderwriter.rs:1205:17 [INFO] [stderr] | [INFO] [stderr] 1205 | let x = (self.buf[self.pos] as u16) + ((self.buf[self.pos + 1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.buf[self.pos])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/xreaderwriter.rs:1205:48 [INFO] [stderr] | [INFO] [stderr] 1205 | let x = (self.buf[self.pos] as u16) + ((self.buf[self.pos + 1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.buf[self.pos + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xreaderwriter.rs:1223:17 [INFO] [stderr] | [INFO] [stderr] 1223 | let x = (self.buf[self.pos] as u32) + ((self.buf[self.pos + 1] as u32) << 8) + ((self.buf[self.pos + 2] as u32) << 16) + ((self.buf[self.pos + 3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.buf[self.pos])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xreaderwriter.rs:1223:48 [INFO] [stderr] | [INFO] [stderr] 1223 | let x = (self.buf[self.pos] as u32) + ((self.buf[self.pos + 1] as u32) << 8) + ((self.buf[self.pos + 2] as u32) << 16) + ((self.buf[self.pos + 3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.buf[self.pos + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xreaderwriter.rs:1223:89 [INFO] [stderr] | [INFO] [stderr] 1223 | let x = (self.buf[self.pos] as u32) + ((self.buf[self.pos + 1] as u32) << 8) + ((self.buf[self.pos + 2] as u32) << 16) + ((self.buf[self.pos + 3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.buf[self.pos + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xreaderwriter.rs:1223:131 [INFO] [stderr] | [INFO] [stderr] 1223 | let x = (self.buf[self.pos] as u32) + ((self.buf[self.pos + 1] as u32) << 8) + ((self.buf[self.pos + 2] as u32) << 16) + ((self.buf[self.pos + 3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.buf[self.pos + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models.rs:2943:16 [INFO] [stderr] | [INFO] [stderr] 2943 | pub fn val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:3112:9 [INFO] [stderr] | [INFO] [stderr] 3112 | / match self { [INFO] [stderr] 3113 | | &WindowValue::BackgroundPixmap(_) => 0x00000001, [INFO] [stderr] 3114 | | &WindowValue::BackgroundPixel(_) => 0x00000002, [INFO] [stderr] 3115 | | &WindowValue::BorderPixmap(_) => 0x00000004, [INFO] [stderr] ... | [INFO] [stderr] 3127 | | &WindowValue::Cursor(_) => 0x00004000 [INFO] [stderr] 3128 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 3112 | match *self { [INFO] [stderr] 3113 | WindowValue::BackgroundPixmap(_) => 0x00000001, [INFO] [stderr] 3114 | WindowValue::BackgroundPixel(_) => 0x00000002, [INFO] [stderr] 3115 | WindowValue::BorderPixmap(_) => 0x00000004, [INFO] [stderr] 3116 | WindowValue::BorderPixel(_) => 0x00000008, [INFO] [stderr] 3117 | WindowValue::BitGravity(_) => 0x00000010, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:3132:9 [INFO] [stderr] | [INFO] [stderr] 3132 | / match self { [INFO] [stderr] 3133 | | &WindowValue::BackgroundPixmap(val) => client.write_val_u32(val), [INFO] [stderr] 3134 | | &WindowValue::BackgroundPixel(val) => client.write_val_u32(val), [INFO] [stderr] 3135 | | &WindowValue::BorderPixmap(val) => client.write_val_u32(val), [INFO] [stderr] ... | [INFO] [stderr] 3147 | | &WindowValue::Cursor(val) => client.write_val_u32(val) [INFO] [stderr] 3148 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 3132 | match *self { [INFO] [stderr] 3133 | WindowValue::BackgroundPixmap(val) => client.write_val_u32(val), [INFO] [stderr] 3134 | WindowValue::BackgroundPixel(val) => client.write_val_u32(val), [INFO] [stderr] 3135 | WindowValue::BorderPixmap(val) => client.write_val_u32(val), [INFO] [stderr] 3136 | WindowValue::BorderPixel(val) => client.write_val_u32(val), [INFO] [stderr] 3137 | WindowValue::BitGravity(ref val) => client.write_val(val.val()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:3154:9 [INFO] [stderr] | [INFO] [stderr] 3154 | / match self { [INFO] [stderr] 3155 | | &WindowConfigureValue::X(_) => 0x0001, [INFO] [stderr] 3156 | | &WindowConfigureValue::Y(_) => 0x0002, [INFO] [stderr] 3157 | | &WindowConfigureValue::Width(_) => 0x0004, [INFO] [stderr] ... | [INFO] [stderr] 3161 | | &WindowConfigureValue::StackMode(_) => 0x0080 [INFO] [stderr] 3162 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 3154 | match *self { [INFO] [stderr] 3155 | WindowConfigureValue::X(_) => 0x0001, [INFO] [stderr] 3156 | WindowConfigureValue::Y(_) => 0x0002, [INFO] [stderr] 3157 | WindowConfigureValue::Width(_) => 0x0004, [INFO] [stderr] 3158 | WindowConfigureValue::Height(_) => 0x0008, [INFO] [stderr] 3159 | WindowConfigureValue::BorderWidth(_) => 0x0020, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:3166:9 [INFO] [stderr] | [INFO] [stderr] 3166 | / match self { [INFO] [stderr] 3167 | | &WindowConfigureValue::X(val) => client.write_val_i16(val), [INFO] [stderr] 3168 | | &WindowConfigureValue::Y(val) => client.write_val_i16(val), [INFO] [stderr] 3169 | | &WindowConfigureValue::Width(val) => client.write_val_u16(val), [INFO] [stderr] ... | [INFO] [stderr] 3173 | | &WindowConfigureValue::StackMode(ref val) => client.write_val_u8(val.val()) [INFO] [stderr] 3174 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 3166 | match *self { [INFO] [stderr] 3167 | WindowConfigureValue::X(val) => client.write_val_i16(val), [INFO] [stderr] 3168 | WindowConfigureValue::Y(val) => client.write_val_i16(val), [INFO] [stderr] 3169 | WindowConfigureValue::Width(val) => client.write_val_u16(val), [INFO] [stderr] 3170 | WindowConfigureValue::Height(val) => client.write_val_u16(val), [INFO] [stderr] 3171 | WindowConfigureValue::BorderWidth(val) => client.write_val_u16(val), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:3180:9 [INFO] [stderr] | [INFO] [stderr] 3180 | / match self { [INFO] [stderr] 3181 | | &GraphicsContextValue::Function(_) => 0x00000001, [INFO] [stderr] 3182 | | &GraphicsContextValue::PlaneMask(_) => 0x00000002, [INFO] [stderr] 3183 | | &GraphicsContextValue::Foreground(_) => 0x00000004, [INFO] [stderr] ... | [INFO] [stderr] 3203 | | &GraphicsContextValue::ArcMode(_) => 0x00400000 [INFO] [stderr] 3204 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 3180 | match *self { [INFO] [stderr] 3181 | GraphicsContextValue::Function(_) => 0x00000001, [INFO] [stderr] 3182 | GraphicsContextValue::PlaneMask(_) => 0x00000002, [INFO] [stderr] 3183 | GraphicsContextValue::Foreground(_) => 0x00000004, [INFO] [stderr] 3184 | GraphicsContextValue::Background(_) => 0x00000008, [INFO] [stderr] 3185 | GraphicsContextValue::LineWidth(_) => 0x00000010, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:3208:9 [INFO] [stderr] | [INFO] [stderr] 3208 | / match self { [INFO] [stderr] 3209 | | &GraphicsContextValue::Function(ref val) => client.write_val(val.val()), [INFO] [stderr] 3210 | | &GraphicsContextValue::PlaneMask(val) => client.write_val_u32(val), [INFO] [stderr] 3211 | | &GraphicsContextValue::Foreground(val) => client.write_val_u32(val), [INFO] [stderr] ... | [INFO] [stderr] 3231 | | &GraphicsContextValue::ArcMode(ref val) => client.write_val(val.val()) [INFO] [stderr] 3232 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 3208 | match *self { [INFO] [stderr] 3209 | GraphicsContextValue::Function(ref val) => client.write_val(val.val()), [INFO] [stderr] 3210 | GraphicsContextValue::PlaneMask(val) => client.write_val_u32(val), [INFO] [stderr] 3211 | GraphicsContextValue::Foreground(val) => client.write_val_u32(val), [INFO] [stderr] 3212 | GraphicsContextValue::Background(val) => client.write_val_u32(val), [INFO] [stderr] 3213 | GraphicsContextValue::LineWidth(val) => client.write_val_u16(val), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:3238:9 [INFO] [stderr] | [INFO] [stderr] 3238 | / match self { [INFO] [stderr] 3239 | | &KeyboardControlValue::KeyClickPercent(_) => 0x0001, [INFO] [stderr] 3240 | | &KeyboardControlValue::BellPercent(_) => 0x0002, [INFO] [stderr] 3241 | | &KeyboardControlValue::BellPitch(_) => 0x0004, [INFO] [stderr] ... | [INFO] [stderr] 3246 | | &KeyboardControlValue::AutoRepeatMode(_) => 0x0040 [INFO] [stderr] 3247 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 3238 | match *self { [INFO] [stderr] 3239 | KeyboardControlValue::KeyClickPercent(_) => 0x0001, [INFO] [stderr] 3240 | KeyboardControlValue::BellPercent(_) => 0x0002, [INFO] [stderr] 3241 | KeyboardControlValue::BellPitch(_) => 0x0004, [INFO] [stderr] 3242 | KeyboardControlValue::BellDuration(_) => 0x0008, [INFO] [stderr] 3243 | KeyboardControlValue::Led(_) => 0x0010, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/models.rs:3251:9 [INFO] [stderr] | [INFO] [stderr] 3251 | / match self { [INFO] [stderr] 3252 | | &KeyboardControlValue::KeyClickPercent(val) => client.write_u8(val), [INFO] [stderr] 3253 | | &KeyboardControlValue::BellPercent(val) => client.write_u8(val), [INFO] [stderr] 3254 | | &KeyboardControlValue::BellPitch(val) => client.write_i16(val), [INFO] [stderr] ... | [INFO] [stderr] 3259 | | &KeyboardControlValue::AutoRepeatMode(ref val) => client.write_u8(val.val()) [INFO] [stderr] 3260 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 3251 | match *self { [INFO] [stderr] 3252 | KeyboardControlValue::KeyClickPercent(val) => client.write_u8(val), [INFO] [stderr] 3253 | KeyboardControlValue::BellPercent(val) => client.write_u8(val), [INFO] [stderr] 3254 | KeyboardControlValue::BellPitch(val) => client.write_i16(val), [INFO] [stderr] 3255 | KeyboardControlValue::BellDuration(val) => client.write_i16(val), [INFO] [stderr] 3256 | KeyboardControlValue::Led(val) => client.write_u8(val), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: incompatible bit mask: `_ & 128` can never be equal to `1` [INFO] [stderr] --> src/lib.rs:209:37 [INFO] [stderr] | [INFO] [stderr] 209 | let generated = opcode_original & 0b10000000 == 0x1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::bad_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/xreaderwriter.rs:25:41 [INFO] [stderr] | [INFO] [stderr] 25 | fn write_mask_u16(&mut self, input: &Vec); [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/xreaderwriter.rs:26:41 [INFO] [stderr] | [INFO] [stderr] 26 | fn write_mask_u32(&mut self, input: &Vec); [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/xreaderwriter.rs:34:50 [INFO] [stderr] | [INFO] [stderr] 34 | fn write_values(&mut self, values: &Vec, mask_size: u8); [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:397:17 [INFO] [stderr] | [INFO] [stderr] 397 | / match res { [INFO] [stderr] 398 | | &ServerResponse::Error(_, eseq) => { [INFO] [stderr] 399 | | if eseq == seq { [INFO] [stderr] 400 | | index = i; [INFO] [stderr] ... | [INFO] [stderr] 410 | | _ => () [INFO] [stderr] 411 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 397 | match *res { [INFO] [stderr] 398 | ServerResponse::Error(_, eseq) => { [INFO] [stderr] 399 | if eseq == seq { [INFO] [stderr] 400 | index = i; [INFO] [stderr] 401 | break; [INFO] [stderr] 402 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:445:13 [INFO] [stderr] | [INFO] [stderr] 445 | / match val { [INFO] [stderr] 446 | | Some(res) => { [INFO] [stderr] 447 | | if matched { [INFO] [stderr] 448 | | return res; [INFO] [stderr] ... | [INFO] [stderr] 453 | | None => () [INFO] [stderr] 454 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 445 | if let Some(res) = val { [INFO] [stderr] 446 | if matched { [INFO] [stderr] 447 | return res; [INFO] [stderr] 448 | } else { [INFO] [stderr] 449 | self.resp_queue.push_back(res); [INFO] [stderr] 450 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:486:66 [INFO] [stderr] | [INFO] [stderr] 486 | pub fn change_window_attributes(&mut self, wid: u32, values: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[WindowValue]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:528:55 [INFO] [stderr] | [INFO] [stderr] 528 | pub fn change_save_set(&mut self, wid: u32, mode: &SaveSetMode) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `SaveSetMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:591:58 [INFO] [stderr] | [INFO] [stderr] 591 | pub fn configure_window(&mut self, wid: u32, values: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[WindowConfigureValue]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:602:61 [INFO] [stderr] | [INFO] [stderr] 602 | pub fn circulate_window(&mut self, wid: u32, direction: &CirculateDirection) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `CirculateDirection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:655:82 [INFO] [stderr] | [INFO] [stderr] 655 | pub fn change_property(&mut self, wid: u32, property: u32, ptype: u32, mode: &PropertyChangeMode, data: &[u8]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `PropertyChangeMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:776:103 [INFO] [stderr] | [INFO] [stderr] 776 | pub fn send_event(&mut self, event: &ServerEvent, propagate: bool, destination: u32, target_mask: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1225:92 [INFO] [stderr] | [INFO] [stderr] 1225 | pub fn grab_pointer(&mut self, grab_window: u32, confine_to: u32, cursor: u32, events: &Vec, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, owner_events: bool, time: u32) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[PointerEvent]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:1225:5 [INFO] [stderr] | [INFO] [stderr] 1225 | / pub fn grab_pointer(&mut self, grab_window: u32, confine_to: u32, cursor: u32, events: &Vec, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, owner_events: bool, time: u32) -> u16 { [INFO] [stderr] 1226 | | self.write_u8(protocol::OP_GRAB_POINTER); [INFO] [stderr] 1227 | | self.write_bool(owner_events); [INFO] [stderr] 1228 | | self.write_u16(6); [INFO] [stderr] ... | [INFO] [stderr] 1237 | | self.write_sequence(ServerReplyType::GrabPointer) [INFO] [stderr] 1238 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1225:126 [INFO] [stderr] | [INFO] [stderr] 1225 | pub fn grab_pointer(&mut self, grab_window: u32, confine_to: u32, cursor: u32, events: &Vec, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, owner_events: bool, time: u32) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `PointerMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1225:155 [INFO] [stderr] | [INFO] [stderr] 1225 | pub fn grab_pointer(&mut self, grab_window: u32, confine_to: u32, cursor: u32, events: &Vec, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, owner_events: bool, time: u32) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `KeyboardMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1260:103 [INFO] [stderr] | [INFO] [stderr] 1260 | pub fn grab_button(&mut self, button: u8, grab_window: u32, confine_to: u32, cursor: u32, events: &Vec, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, modifiers: &Vec, owner_events: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[PointerEvent]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1260:192 [INFO] [stderr] | [INFO] [stderr] 1260 | pub fn grab_button(&mut self, button: u8, grab_window: u32, confine_to: u32, cursor: u32, events: &Vec, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, modifiers: &Vec, owner_events: bool) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/lib.rs:1260:5 [INFO] [stderr] | [INFO] [stderr] 1260 | / pub fn grab_button(&mut self, button: u8, grab_window: u32, confine_to: u32, cursor: u32, events: &Vec, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, modifiers: &Vec, owner_events: bool) { [INFO] [stderr] 1261 | | self.write_u8(protocol::OP_GRAB_BUTTON); [INFO] [stderr] 1262 | | self.write_bool(owner_events); [INFO] [stderr] 1263 | | self.write_u16(6); [INFO] [stderr] ... | [INFO] [stderr] 1274 | | self.write_request(); [INFO] [stderr] 1275 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1260:137 [INFO] [stderr] | [INFO] [stderr] 1260 | pub fn grab_button(&mut self, button: u8, grab_window: u32, confine_to: u32, cursor: u32, events: &Vec, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, modifiers: &Vec, owner_events: bool) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `PointerMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1260:166 [INFO] [stderr] | [INFO] [stderr] 1260 | pub fn grab_button(&mut self, button: u8, grab_window: u32, confine_to: u32, cursor: u32, events: &Vec, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, modifiers: &Vec, owner_events: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `KeyboardMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1282:78 [INFO] [stderr] | [INFO] [stderr] 1282 | pub fn ungrab_button(&mut self, button: u8, grab_window: u32, modifiers: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1298:82 [INFO] [stderr] | [INFO] [stderr] 1298 | pub fn change_active_pointer_grab(&mut self, cursor: u32, time: u32, events: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[PointerEvent]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1314:69 [INFO] [stderr] | [INFO] [stderr] 1314 | pub fn grab_keyboard(&mut self, grab_window: u32, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, owner_events: bool, time: u32) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `PointerMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1314:98 [INFO] [stderr] | [INFO] [stderr] 1314 | pub fn grab_keyboard(&mut self, grab_window: u32, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, owner_events: bool, time: u32) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `KeyboardMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1345:128 [INFO] [stderr] | [INFO] [stderr] 1345 | pub fn grab_key(&mut self, key: u8, grab_window: u32, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, modifiers: &Vec, owner_events: bool) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1345:73 [INFO] [stderr] | [INFO] [stderr] 1345 | pub fn grab_key(&mut self, key: u8, grab_window: u32, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, modifiers: &Vec, owner_events: bool) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `PointerMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1345:102 [INFO] [stderr] | [INFO] [stderr] 1345 | pub fn grab_key(&mut self, key: u8, grab_window: u32, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, modifiers: &Vec, owner_events: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `KeyboardMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1364:72 [INFO] [stderr] | [INFO] [stderr] 1364 | pub fn ungrab_key(&mut self, key: u8, grab_window: u32, modifiers: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:1433:5 [INFO] [stderr] | [INFO] [stderr] 1433 | / pub fn warp_pointer(&mut self, src_window: u32, dst_window: u32, src_x: i16, src_y: i16, src_width: u16, src_height: u16, dst_x: i16, dst_y: i16) { [INFO] [stderr] 1434 | | self.write_u8(protocol::OP_WARP_POINTER); [INFO] [stderr] 1435 | | self.write_pad(1); [INFO] [stderr] 1436 | | self.write_u16(6); [INFO] [stderr] ... | [INFO] [stderr] 1446 | | self.write_request(); [INFO] [stderr] 1447 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1453:62 [INFO] [stderr] | [INFO] [stderr] 1453 | pub fn set_input_focus(&mut self, focus: u32, revert_to: &InputFocusRevert, time: u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `InputFocusRevert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1615:52 [INFO] [stderr] | [INFO] [stderr] 1615 | pub fn change_gc(&mut self, gcid: u32, values: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[GraphicsContextValue]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1626:73 [INFO] [stderr] | [INFO] [stderr] 1626 | pub fn copy_gc(&mut self, src_gc: u32, dst_gc: u32, values_to_copy: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[GraphicsContextMask]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1638:66 [INFO] [stderr] | [INFO] [stderr] 1638 | pub fn set_dashes(&mut self, gcid: u32, offset: u16, dashes: &Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1654:66 [INFO] [stderr] | [INFO] [stderr] 1654 | pub fn set_clip_rectangles(&mut self, gcid: u32, rectangles: &Vec, clip_x_origin: i16, clip_y_origin: i16, ordering: &RectangleOrdering) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Rectangle]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1654:133 [INFO] [stderr] | [INFO] [stderr] 1654 | pub fn set_clip_rectangles(&mut self, gcid: u32, rectangles: &Vec, clip_x_origin: i16, clip_y_origin: i16, ordering: &RectangleOrdering) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `RectangleOrdering` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/lib.rs:1694:5 [INFO] [stderr] | [INFO] [stderr] 1694 | / pub fn copy_plane(&mut self, src: u32, dst: u32, gcid: u32, src_x: i16, src_y: i16, dst_x: i16, dst_y: i16, width: u16, height: u16, bit_plane: u32) { [INFO] [stderr] 1695 | | self.write_u8(protocol::OP_COPY_PLANE); [INFO] [stderr] 1696 | | self.write_pad(1); [INFO] [stderr] 1697 | | self.write_u16(8); [INFO] [stderr] ... | [INFO] [stderr] 1708 | | self.write_request(); [INFO] [stderr] 1709 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1712:68 [INFO] [stderr] | [INFO] [stderr] 1712 | pub fn poly_point(&mut self, drawable: u32, gcid: u32, points: &Vec, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1712:87 [INFO] [stderr] | [INFO] [stderr] 1712 | pub fn poly_point(&mut self, drawable: u32, gcid: u32, points: &Vec, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1727:67 [INFO] [stderr] | [INFO] [stderr] 1727 | pub fn poly_line(&mut self, drawable: u32, gcid: u32, points: &Vec, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1727:86 [INFO] [stderr] | [INFO] [stderr] 1727 | pub fn poly_line(&mut self, drawable: u32, gcid: u32, points: &Vec, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1742:72 [INFO] [stderr] | [INFO] [stderr] 1742 | pub fn poly_segment(&mut self, drawable: u32, gcid: u32, segments: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Segment]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1757:76 [INFO] [stderr] | [INFO] [stderr] 1757 | pub fn poly_rectangle(&mut self, drawable: u32, gcid: u32, rectangles: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Rectangle]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1772:64 [INFO] [stderr] | [INFO] [stderr] 1772 | pub fn poly_arc(&mut self, drawable: u32, gcid: u32, arcs: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Arc]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1787:67 [INFO] [stderr] | [INFO] [stderr] 1787 | pub fn fill_poly(&mut self, drawable: u32, gcid: u32, points: &Vec, shape: &PolyShape, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/xreaderwriter.rs:1205:17 [INFO] [stderr] | [INFO] [stderr] 1205 | let x = (self.buf[self.pos] as u16) + ((self.buf[self.pos + 1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.buf[self.pos])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/xreaderwriter.rs:1205:48 [INFO] [stderr] | [INFO] [stderr] 1205 | let x = (self.buf[self.pos] as u16) + ((self.buf[self.pos + 1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.buf[self.pos + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1787:87 [INFO] [stderr] | [INFO] [stderr] 1787 | pub fn fill_poly(&mut self, drawable: u32, gcid: u32, points: &Vec, shape: &PolyShape, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `PolyShape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1787:105 [INFO] [stderr] | [INFO] [stderr] 1787 | pub fn fill_poly(&mut self, drawable: u32, gcid: u32, points: &Vec, shape: &PolyShape, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xreaderwriter.rs:1223:17 [INFO] [stderr] | [INFO] [stderr] 1223 | let x = (self.buf[self.pos] as u32) + ((self.buf[self.pos + 1] as u32) << 8) + ((self.buf[self.pos + 2] as u32) << 16) + ((self.buf[self.pos + 3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.buf[self.pos])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xreaderwriter.rs:1223:48 [INFO] [stderr] | [INFO] [stderr] 1223 | let x = (self.buf[self.pos] as u32) + ((self.buf[self.pos + 1] as u32) << 8) + ((self.buf[self.pos + 2] as u32) << 16) + ((self.buf[self.pos + 3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.buf[self.pos + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xreaderwriter.rs:1223:89 [INFO] [stderr] | [INFO] [stderr] 1223 | let x = (self.buf[self.pos] as u32) + ((self.buf[self.pos + 1] as u32) << 8) + ((self.buf[self.pos + 2] as u32) << 16) + ((self.buf[self.pos + 3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.buf[self.pos + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/xreaderwriter.rs:1223:131 [INFO] [stderr] | [INFO] [stderr] 1223 | let x = (self.buf[self.pos] as u32) + ((self.buf[self.pos + 1] as u32) << 8) + ((self.buf[self.pos + 2] as u32) << 16) + ((self.buf[self.pos + 3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.buf[self.pos + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1805:81 [INFO] [stderr] | [INFO] [stderr] 1805 | pub fn poly_fill_rectangle(&mut self, drawable: u32, gcid: u32, rectangles: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Rectangle]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1820:69 [INFO] [stderr] | [INFO] [stderr] 1820 | pub fn poly_fill_arc(&mut self, drawable: u32, gcid: u32, arcs: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Arc]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1835:65 [INFO] [stderr] | [INFO] [stderr] 1835 | pub fn put_image(&mut self, drawable: u32, gcid: u32, data: &Vec, width: u16, height: u16, x: i16, y: i16, left_pad: u8, depth: u8, format: &ImageFormat) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/lib.rs:1835:5 [INFO] [stderr] | [INFO] [stderr] 1835 | / pub fn put_image(&mut self, drawable: u32, gcid: u32, data: &Vec, width: u16, height: u16, x: i16, y: i16, left_pad: u8, depth: u8, format: &ImageFormat) { [INFO] [stderr] 1836 | | self.write_u8(protocol::OP_PUT_IMAGE); [INFO] [stderr] 1837 | | self.write_u8(format.val()); [INFO] [stderr] 1838 | | let pad = self.write_dynamic_len(6, data.len()); [INFO] [stderr] ... | [INFO] [stderr] 1851 | | self.write_request(); [INFO] [stderr] 1852 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1835:149 [INFO] [stderr] | [INFO] [stderr] 1835 | pub fn put_image(&mut self, drawable: u32, gcid: u32, data: &Vec, width: u16, height: u16, x: i16, y: i16, left_pad: u8, depth: u8, format: &ImageFormat) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `ImageFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:1858:5 [INFO] [stderr] | [INFO] [stderr] 1858 | / pub fn get_image(&mut self, drawable: u32, x: i16, y: i16, width: u16, height: u16, plane_mask: u32, format: &ImageFormat) -> u16 { [INFO] [stderr] 1859 | | self.write_u8(protocol::OP_GET_IMAGE); [INFO] [stderr] 1860 | | self.write_u8(format.val()); [INFO] [stderr] 1861 | | self.write_u16(5); [INFO] [stderr] ... | [INFO] [stderr] 1869 | | self.write_sequence(ServerReplyType::GetImage) [INFO] [stderr] 1870 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1858:114 [INFO] [stderr] | [INFO] [stderr] 1858 | pub fn get_image(&mut self, drawable: u32, x: i16, y: i16, width: u16, height: u16, plane_mask: u32, format: &ImageFormat) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `ImageFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1877:97 [INFO] [stderr] | [INFO] [stderr] 1877 | pub fn poly_text8(&mut self, drawable: u32, gcid: u32, x: i16, y: i16, texts: &Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1903:99 [INFO] [stderr] | [INFO] [stderr] 1903 | pub fn poly_text16(&mut self, drawable: u32, gcid: u32, x: i16, y: i16, texts: &Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1946:68 [INFO] [stderr] | [INFO] [stderr] 1946 | pub fn image_text16(&mut self, drawable: u32, gcid: u32, text: &Vec, x: i16, y: i16) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1960:76 [INFO] [stderr] | [INFO] [stderr] 1960 | pub fn create_colormap(&mut self, cmid: u32, wid: u32, vid: u32, mode: &AllocMode) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `AllocMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:2077:71 [INFO] [stderr] | [INFO] [stderr] 2077 | pub fn free_colors(&mut self, cmid: u32, plane_mask: u32, pixels: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:2092:54 [INFO] [stderr] | [INFO] [stderr] 2092 | pub fn store_colors(&mut self, cmid: u32, items: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[ColorItem]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:2132:55 [INFO] [stderr] | [INFO] [stderr] 2132 | pub fn query_colors(&mut self, cmid: u32, pixels: &Vec) -> u16 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/lib.rs:2163:5 [INFO] [stderr] | [INFO] [stderr] 2163 | / pub fn create_cursor(&mut self, cid: u32, source: u32, mask: u32, fore_red: u16, fore_green: u16, fore_blue: u16, back_red: u16, back_green: u16, back_blue: u16, x: u16, y: u16) { [INFO] [stderr] 2164 | | self.write_u8(protocol::OP_CREATE_CURSOR); [INFO] [stderr] 2165 | | self.write_pad(1); [INFO] [stderr] 2166 | | self.write_u16(8); [INFO] [stderr] ... | [INFO] [stderr] 2179 | | self.write_request(); [INFO] [stderr] 2180 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: incompatible bit mask: `_ & 128` can never be equal to `1` [INFO] [stderr] --> src/lib.rs:209:37 [INFO] [stderr] | [INFO] [stderr] 209 | let generated = opcode_original & 0b10000000 == 0x1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::bad_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/lib.rs:2186:5 [INFO] [stderr] | [INFO] [stderr] 2186 | / pub fn create_glyph_cursor(&mut self, cid: u32, source_font: u32, mask_font: u32, source_char: u16, mask_char: u16, fore_red: u16, fore_green: u16, fore_blue: u16, back_red: u16, back_green: u16, back_blue: u16) { [INFO] [stderr] 2187 | | self.write_u8(protocol::OP_CREATE_GLYPH_CURSOR); [INFO] [stderr] 2188 | | self.write_pad(1); [INFO] [stderr] 2189 | | self.write_u16(8); [INFO] [stderr] ... | [INFO] [stderr] 2202 | | self.write_request(); [INFO] [stderr] 2203 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:2216:5 [INFO] [stderr] | [INFO] [stderr] 2216 | / pub fn recolor_cursor(&mut self, cid: u32, fore_red: u16, fore_green: u16, fore_blue: u16, back_red: u16, back_green: u16, back_blue: u16) { [INFO] [stderr] 2217 | | self.write_u8(protocol::OP_RECOLOR_CURSOR); [INFO] [stderr] 2218 | | self.write_pad(1); [INFO] [stderr] 2219 | | self.write_u16(5); [INFO] [stderr] ... | [INFO] [stderr] 2228 | | self.write_request(); [INFO] [stderr] 2229 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:2232:61 [INFO] [stderr] | [INFO] [stderr] 2232 | pub fn query_best_size(&mut self, drawable: u32, class: &SizeClass, width: u16, height: u16) -> u16 { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `SizeClass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:2274:78 [INFO] [stderr] | [INFO] [stderr] 2274 | pub fn change_keyboard_mapping(&mut self, first: u8, count: u8, keysyms: &Vec) -> Option<()> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:2310:55 [INFO] [stderr] | [INFO] [stderr] 2310 | pub fn change_keyboard_control(&mut self, values: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[KeyboardControlValue]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:397:17 [INFO] [stderr] | [INFO] [stderr] 397 | / match res { [INFO] [stderr] 398 | | &ServerResponse::Error(_, eseq) => { [INFO] [stderr] 399 | | if eseq == seq { [INFO] [stderr] 400 | | index = i; [INFO] [stderr] ... | [INFO] [stderr] 410 | | _ => () [INFO] [stderr] 411 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 397 | match *res { [INFO] [stderr] 398 | ServerResponse::Error(_, eseq) => { [INFO] [stderr] 399 | if eseq == seq { [INFO] [stderr] 400 | index = i; [INFO] [stderr] 401 | break; [INFO] [stderr] 402 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:2362:86 [INFO] [stderr] | [INFO] [stderr] 2362 | pub fn set_screen_saver(&mut self, timeout: i16, interval: i16, prefer_blanking: &YesNoDefault, allow_exposures: &YesNoDefault) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `YesNoDefault` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:2362:118 [INFO] [stderr] | [INFO] [stderr] 2362 | pub fn set_screen_saver(&mut self, timeout: i16, interval: i16, prefer_blanking: &YesNoDefault, allow_exposures: &YesNoDefault) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `YesNoDefault` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:445:13 [INFO] [stderr] | [INFO] [stderr] 445 | / match val { [INFO] [stderr] 446 | | Some(res) => { [INFO] [stderr] 447 | | if matched { [INFO] [stderr] 448 | | return res; [INFO] [stderr] ... | [INFO] [stderr] 453 | | None => () [INFO] [stderr] 454 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 445 | if let Some(res) = val { [INFO] [stderr] 446 | if matched { [INFO] [stderr] 447 | return res; [INFO] [stderr] 448 | } else { [INFO] [stderr] 449 | self.resp_queue.push_back(res); [INFO] [stderr] 450 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:2387:45 [INFO] [stderr] | [INFO] [stderr] 2387 | pub fn change_hosts(&mut self, address: &Vec, family: &HostFamily, mode: &ChangeHostMode) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:2387:63 [INFO] [stderr] | [INFO] [stderr] 2387 | pub fn change_hosts(&mut self, address: &Vec, family: &HostFamily, mode: &ChangeHostMode) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `HostFamily` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:2387:82 [INFO] [stderr] | [INFO] [stderr] 2387 | pub fn change_hosts(&mut self, address: &Vec, family: &HostFamily, mode: &ChangeHostMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `ChangeHostMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:486:66 [INFO] [stderr] | [INFO] [stderr] 486 | pub fn change_window_attributes(&mut self, wid: u32, values: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[WindowValue]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:2419:49 [INFO] [stderr] | [INFO] [stderr] 2419 | pub fn set_close_down_mode(&mut self, mode: &CloseDownMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider passing by value instead: `CloseDownMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:2441:63 [INFO] [stderr] | [INFO] [stderr] 2441 | pub fn rotate_properties(&mut self, wid: u32, properties: &Vec, delta: i16) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:528:55 [INFO] [stderr] | [INFO] [stderr] 528 | pub fn change_save_set(&mut self, wid: u32, mode: &SaveSetMode) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `SaveSetMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:2469:48 [INFO] [stderr] | [INFO] [stderr] 2469 | pub fn set_pointer_mapping(&mut self, map: &Vec) -> u16 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:2492:54 [INFO] [stderr] | [INFO] [stderr] 2492 | pub fn set_modifier_mapping(&mut self, keycodes: &Vec) -> u16 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:591:58 [INFO] [stderr] | [INFO] [stderr] 591 | pub fn configure_window(&mut self, wid: u32, values: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[WindowConfigureValue]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:602:61 [INFO] [stderr] | [INFO] [stderr] 602 | pub fn circulate_window(&mut self, wid: u32, direction: &CirculateDirection) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `CirculateDirection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:655:82 [INFO] [stderr] | [INFO] [stderr] 655 | pub fn change_property(&mut self, wid: u32, property: u32, ptype: u32, mode: &PropertyChangeMode, data: &[u8]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `PropertyChangeMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:2586:32 [INFO] [stderr] | [INFO] [stderr] 2586 | self.buf_one_byte[0] = match input { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 2587 | | true => 1, [INFO] [stderr] 2588 | | false => 0 [INFO] [stderr] 2589 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if input { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:776:103 [INFO] [stderr] | [INFO] [stderr] 776 | pub fn send_event(&mut self, event: &ServerEvent, propagate: bool, destination: u32, target_mask: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:2694:9 [INFO] [stderr] | [INFO] [stderr] 2694 | / match input { [INFO] [stderr] 2695 | | true => self.write_val(1u8 as u32), [INFO] [stderr] 2696 | | false => self.write_val(0u8 as u32) [INFO] [stderr] 2697 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if input { self.write_val(1u8 as u32) } else { self.write_val(0u8 as u32) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:2695:36 [INFO] [stderr] | [INFO] [stderr] 2695 | true => self.write_val(1u8 as u32), [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(1u8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:2696:37 [INFO] [stderr] | [INFO] [stderr] 2696 | false => self.write_val(0u8 as u32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(0u8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:2705:24 [INFO] [stderr] | [INFO] [stderr] 2705 | self.write_val(input as u32); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:2721:24 [INFO] [stderr] | [INFO] [stderr] 2721 | self.write_val(input as u32); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1225:92 [INFO] [stderr] | [INFO] [stderr] 1225 | pub fn grab_pointer(&mut self, grab_window: u32, confine_to: u32, cursor: u32, events: &Vec, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, owner_events: bool, time: u32) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[PointerEvent]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:1225:5 [INFO] [stderr] | [INFO] [stderr] 1225 | / pub fn grab_pointer(&mut self, grab_window: u32, confine_to: u32, cursor: u32, events: &Vec, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, owner_events: bool, time: u32) -> u16 { [INFO] [stderr] 1226 | | self.write_u8(protocol::OP_GRAB_POINTER); [INFO] [stderr] 1227 | | self.write_bool(owner_events); [INFO] [stderr] 1228 | | self.write_u16(6); [INFO] [stderr] ... | [INFO] [stderr] 1237 | | self.write_sequence(ServerReplyType::GrabPointer) [INFO] [stderr] 1238 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1225:126 [INFO] [stderr] | [INFO] [stderr] 1225 | pub fn grab_pointer(&mut self, grab_window: u32, confine_to: u32, cursor: u32, events: &Vec, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, owner_events: bool, time: u32) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `PointerMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1225:155 [INFO] [stderr] | [INFO] [stderr] 1225 | pub fn grab_pointer(&mut self, grab_window: u32, confine_to: u32, cursor: u32, events: &Vec, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, owner_events: bool, time: u32) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `KeyboardMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1260:103 [INFO] [stderr] | [INFO] [stderr] 1260 | pub fn grab_button(&mut self, button: u8, grab_window: u32, confine_to: u32, cursor: u32, events: &Vec, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, modifiers: &Vec, owner_events: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[PointerEvent]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1260:192 [INFO] [stderr] | [INFO] [stderr] 1260 | pub fn grab_button(&mut self, button: u8, grab_window: u32, confine_to: u32, cursor: u32, events: &Vec, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, modifiers: &Vec, owner_events: bool) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/lib.rs:1260:5 [INFO] [stderr] | [INFO] [stderr] 1260 | / pub fn grab_button(&mut self, button: u8, grab_window: u32, confine_to: u32, cursor: u32, events: &Vec, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, modifiers: &Vec, owner_events: bool) { [INFO] [stderr] 1261 | | self.write_u8(protocol::OP_GRAB_BUTTON); [INFO] [stderr] 1262 | | self.write_bool(owner_events); [INFO] [stderr] 1263 | | self.write_u16(6); [INFO] [stderr] ... | [INFO] [stderr] 1274 | | self.write_request(); [INFO] [stderr] 1275 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1260:137 [INFO] [stderr] | [INFO] [stderr] 1260 | pub fn grab_button(&mut self, button: u8, grab_window: u32, confine_to: u32, cursor: u32, events: &Vec, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, modifiers: &Vec, owner_events: bool) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `PointerMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1260:166 [INFO] [stderr] | [INFO] [stderr] 1260 | pub fn grab_button(&mut self, button: u8, grab_window: u32, confine_to: u32, cursor: u32, events: &Vec, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, modifiers: &Vec, owner_events: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `KeyboardMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1282:78 [INFO] [stderr] | [INFO] [stderr] 1282 | pub fn ungrab_button(&mut self, button: u8, grab_window: u32, modifiers: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1298:82 [INFO] [stderr] | [INFO] [stderr] 1298 | pub fn change_active_pointer_grab(&mut self, cursor: u32, time: u32, events: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[PointerEvent]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1314:69 [INFO] [stderr] | [INFO] [stderr] 1314 | pub fn grab_keyboard(&mut self, grab_window: u32, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, owner_events: bool, time: u32) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `PointerMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1314:98 [INFO] [stderr] | [INFO] [stderr] 1314 | pub fn grab_keyboard(&mut self, grab_window: u32, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, owner_events: bool, time: u32) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `KeyboardMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1345:128 [INFO] [stderr] | [INFO] [stderr] 1345 | pub fn grab_key(&mut self, key: u8, grab_window: u32, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, modifiers: &Vec, owner_events: bool) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1345:73 [INFO] [stderr] | [INFO] [stderr] 1345 | pub fn grab_key(&mut self, key: u8, grab_window: u32, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, modifiers: &Vec, owner_events: bool) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `PointerMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1345:102 [INFO] [stderr] | [INFO] [stderr] 1345 | pub fn grab_key(&mut self, key: u8, grab_window: u32, pointer_mode: &PointerMode, keyboard_mode: &KeyboardMode, modifiers: &Vec, owner_events: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `KeyboardMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1364:72 [INFO] [stderr] | [INFO] [stderr] 1364 | pub fn ungrab_key(&mut self, key: u8, grab_window: u32, modifiers: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:1433:5 [INFO] [stderr] | [INFO] [stderr] 1433 | / pub fn warp_pointer(&mut self, src_window: u32, dst_window: u32, src_x: i16, src_y: i16, src_width: u16, src_height: u16, dst_x: i16, dst_y: i16) { [INFO] [stderr] 1434 | | self.write_u8(protocol::OP_WARP_POINTER); [INFO] [stderr] 1435 | | self.write_pad(1); [INFO] [stderr] 1436 | | self.write_u16(6); [INFO] [stderr] ... | [INFO] [stderr] 1446 | | self.write_request(); [INFO] [stderr] 1447 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1453:62 [INFO] [stderr] | [INFO] [stderr] 1453 | pub fn set_input_focus(&mut self, focus: u32, revert_to: &InputFocusRevert, time: u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `InputFocusRevert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: Could not compile `xrb`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1615:52 [INFO] [stderr] | [INFO] [stderr] 1615 | pub fn change_gc(&mut self, gcid: u32, values: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[GraphicsContextValue]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1626:73 [INFO] [stderr] | [INFO] [stderr] 1626 | pub fn copy_gc(&mut self, src_gc: u32, dst_gc: u32, values_to_copy: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[GraphicsContextMask]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1638:66 [INFO] [stderr] | [INFO] [stderr] 1638 | pub fn set_dashes(&mut self, gcid: u32, offset: u16, dashes: &Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1654:66 [INFO] [stderr] | [INFO] [stderr] 1654 | pub fn set_clip_rectangles(&mut self, gcid: u32, rectangles: &Vec, clip_x_origin: i16, clip_y_origin: i16, ordering: &RectangleOrdering) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Rectangle]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1654:133 [INFO] [stderr] | [INFO] [stderr] 1654 | pub fn set_clip_rectangles(&mut self, gcid: u32, rectangles: &Vec, clip_x_origin: i16, clip_y_origin: i16, ordering: &RectangleOrdering) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `RectangleOrdering` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/lib.rs:1694:5 [INFO] [stderr] | [INFO] [stderr] 1694 | / pub fn copy_plane(&mut self, src: u32, dst: u32, gcid: u32, src_x: i16, src_y: i16, dst_x: i16, dst_y: i16, width: u16, height: u16, bit_plane: u32) { [INFO] [stderr] 1695 | | self.write_u8(protocol::OP_COPY_PLANE); [INFO] [stderr] 1696 | | self.write_pad(1); [INFO] [stderr] 1697 | | self.write_u16(8); [INFO] [stderr] ... | [INFO] [stderr] 1708 | | self.write_request(); [INFO] [stderr] 1709 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1712:68 [INFO] [stderr] | [INFO] [stderr] 1712 | pub fn poly_point(&mut self, drawable: u32, gcid: u32, points: &Vec, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1712:87 [INFO] [stderr] | [INFO] [stderr] 1712 | pub fn poly_point(&mut self, drawable: u32, gcid: u32, points: &Vec, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1727:67 [INFO] [stderr] | [INFO] [stderr] 1727 | pub fn poly_line(&mut self, drawable: u32, gcid: u32, points: &Vec, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1727:86 [INFO] [stderr] | [INFO] [stderr] 1727 | pub fn poly_line(&mut self, drawable: u32, gcid: u32, points: &Vec, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1742:72 [INFO] [stderr] | [INFO] [stderr] 1742 | pub fn poly_segment(&mut self, drawable: u32, gcid: u32, segments: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Segment]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1757:76 [INFO] [stderr] | [INFO] [stderr] 1757 | pub fn poly_rectangle(&mut self, drawable: u32, gcid: u32, rectangles: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Rectangle]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1772:64 [INFO] [stderr] | [INFO] [stderr] 1772 | pub fn poly_arc(&mut self, drawable: u32, gcid: u32, arcs: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Arc]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1787:67 [INFO] [stderr] | [INFO] [stderr] 1787 | pub fn fill_poly(&mut self, drawable: u32, gcid: u32, points: &Vec, shape: &PolyShape, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1787:87 [INFO] [stderr] | [INFO] [stderr] 1787 | pub fn fill_poly(&mut self, drawable: u32, gcid: u32, points: &Vec, shape: &PolyShape, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `PolyShape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1787:105 [INFO] [stderr] | [INFO] [stderr] 1787 | pub fn fill_poly(&mut self, drawable: u32, gcid: u32, points: &Vec, shape: &PolyShape, mode: &CoordinateMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1805:81 [INFO] [stderr] | [INFO] [stderr] 1805 | pub fn poly_fill_rectangle(&mut self, drawable: u32, gcid: u32, rectangles: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Rectangle]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1820:69 [INFO] [stderr] | [INFO] [stderr] 1820 | pub fn poly_fill_arc(&mut self, drawable: u32, gcid: u32, arcs: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Arc]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1835:65 [INFO] [stderr] | [INFO] [stderr] 1835 | pub fn put_image(&mut self, drawable: u32, gcid: u32, data: &Vec, width: u16, height: u16, x: i16, y: i16, left_pad: u8, depth: u8, format: &ImageFormat) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/lib.rs:1835:5 [INFO] [stderr] | [INFO] [stderr] 1835 | / pub fn put_image(&mut self, drawable: u32, gcid: u32, data: &Vec, width: u16, height: u16, x: i16, y: i16, left_pad: u8, depth: u8, format: &ImageFormat) { [INFO] [stderr] 1836 | | self.write_u8(protocol::OP_PUT_IMAGE); [INFO] [stderr] 1837 | | self.write_u8(format.val()); [INFO] [stderr] 1838 | | let pad = self.write_dynamic_len(6, data.len()); [INFO] [stderr] ... | [INFO] [stderr] 1851 | | self.write_request(); [INFO] [stderr] 1852 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1835:149 [INFO] [stderr] | [INFO] [stderr] 1835 | pub fn put_image(&mut self, drawable: u32, gcid: u32, data: &Vec, width: u16, height: u16, x: i16, y: i16, left_pad: u8, depth: u8, format: &ImageFormat) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `ImageFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:1858:5 [INFO] [stderr] | [INFO] [stderr] 1858 | / pub fn get_image(&mut self, drawable: u32, x: i16, y: i16, width: u16, height: u16, plane_mask: u32, format: &ImageFormat) -> u16 { [INFO] [stderr] 1859 | | self.write_u8(protocol::OP_GET_IMAGE); [INFO] [stderr] 1860 | | self.write_u8(format.val()); [INFO] [stderr] 1861 | | self.write_u16(5); [INFO] [stderr] ... | [INFO] [stderr] 1869 | | self.write_sequence(ServerReplyType::GetImage) [INFO] [stderr] 1870 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1858:114 [INFO] [stderr] | [INFO] [stderr] 1858 | pub fn get_image(&mut self, drawable: u32, x: i16, y: i16, width: u16, height: u16, plane_mask: u32, format: &ImageFormat) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `ImageFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1877:97 [INFO] [stderr] | [INFO] [stderr] 1877 | pub fn poly_text8(&mut self, drawable: u32, gcid: u32, x: i16, y: i16, texts: &Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1903:99 [INFO] [stderr] | [INFO] [stderr] 1903 | pub fn poly_text16(&mut self, drawable: u32, gcid: u32, x: i16, y: i16, texts: &Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:1946:68 [INFO] [stderr] | [INFO] [stderr] 1946 | pub fn image_text16(&mut self, drawable: u32, gcid: u32, text: &Vec, x: i16, y: i16) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1960:76 [INFO] [stderr] | [INFO] [stderr] 1960 | pub fn create_colormap(&mut self, cmid: u32, wid: u32, vid: u32, mode: &AllocMode) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `AllocMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:2077:71 [INFO] [stderr] | [INFO] [stderr] 2077 | pub fn free_colors(&mut self, cmid: u32, plane_mask: u32, pixels: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:2092:54 [INFO] [stderr] | [INFO] [stderr] 2092 | pub fn store_colors(&mut self, cmid: u32, items: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[ColorItem]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:2132:55 [INFO] [stderr] | [INFO] [stderr] 2132 | pub fn query_colors(&mut self, cmid: u32, pixels: &Vec) -> u16 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/lib.rs:2163:5 [INFO] [stderr] | [INFO] [stderr] 2163 | / pub fn create_cursor(&mut self, cid: u32, source: u32, mask: u32, fore_red: u16, fore_green: u16, fore_blue: u16, back_red: u16, back_green: u16, back_blue: u16, x: u16, y: u16) { [INFO] [stderr] 2164 | | self.write_u8(protocol::OP_CREATE_CURSOR); [INFO] [stderr] 2165 | | self.write_pad(1); [INFO] [stderr] 2166 | | self.write_u16(8); [INFO] [stderr] ... | [INFO] [stderr] 2179 | | self.write_request(); [INFO] [stderr] 2180 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/lib.rs:2186:5 [INFO] [stderr] | [INFO] [stderr] 2186 | / pub fn create_glyph_cursor(&mut self, cid: u32, source_font: u32, mask_font: u32, source_char: u16, mask_char: u16, fore_red: u16, fore_green: u16, fore_blue: u16, back_red: u16, back_green: u16, back_blue: u16) { [INFO] [stderr] 2187 | | self.write_u8(protocol::OP_CREATE_GLYPH_CURSOR); [INFO] [stderr] 2188 | | self.write_pad(1); [INFO] [stderr] 2189 | | self.write_u16(8); [INFO] [stderr] ... | [INFO] [stderr] 2202 | | self.write_request(); [INFO] [stderr] 2203 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:2216:5 [INFO] [stderr] | [INFO] [stderr] 2216 | / pub fn recolor_cursor(&mut self, cid: u32, fore_red: u16, fore_green: u16, fore_blue: u16, back_red: u16, back_green: u16, back_blue: u16) { [INFO] [stderr] 2217 | | self.write_u8(protocol::OP_RECOLOR_CURSOR); [INFO] [stderr] 2218 | | self.write_pad(1); [INFO] [stderr] 2219 | | self.write_u16(5); [INFO] [stderr] ... | [INFO] [stderr] 2228 | | self.write_request(); [INFO] [stderr] 2229 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:2232:61 [INFO] [stderr] | [INFO] [stderr] 2232 | pub fn query_best_size(&mut self, drawable: u32, class: &SizeClass, width: u16, height: u16) -> u16 { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `SizeClass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:2274:78 [INFO] [stderr] | [INFO] [stderr] 2274 | pub fn change_keyboard_mapping(&mut self, first: u8, count: u8, keysyms: &Vec) -> Option<()> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:2310:55 [INFO] [stderr] | [INFO] [stderr] 2310 | pub fn change_keyboard_control(&mut self, values: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[KeyboardControlValue]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:2362:86 [INFO] [stderr] | [INFO] [stderr] 2362 | pub fn set_screen_saver(&mut self, timeout: i16, interval: i16, prefer_blanking: &YesNoDefault, allow_exposures: &YesNoDefault) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `YesNoDefault` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:2362:118 [INFO] [stderr] | [INFO] [stderr] 2362 | pub fn set_screen_saver(&mut self, timeout: i16, interval: i16, prefer_blanking: &YesNoDefault, allow_exposures: &YesNoDefault) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `YesNoDefault` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:2387:45 [INFO] [stderr] | [INFO] [stderr] 2387 | pub fn change_hosts(&mut self, address: &Vec, family: &HostFamily, mode: &ChangeHostMode) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:2387:63 [INFO] [stderr] | [INFO] [stderr] 2387 | pub fn change_hosts(&mut self, address: &Vec, family: &HostFamily, mode: &ChangeHostMode) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `HostFamily` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:2387:82 [INFO] [stderr] | [INFO] [stderr] 2387 | pub fn change_hosts(&mut self, address: &Vec, family: &HostFamily, mode: &ChangeHostMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `ChangeHostMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:2419:49 [INFO] [stderr] | [INFO] [stderr] 2419 | pub fn set_close_down_mode(&mut self, mode: &CloseDownMode) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider passing by value instead: `CloseDownMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:2441:63 [INFO] [stderr] | [INFO] [stderr] 2441 | pub fn rotate_properties(&mut self, wid: u32, properties: &Vec, delta: i16) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:2469:48 [INFO] [stderr] | [INFO] [stderr] 2469 | pub fn set_pointer_mapping(&mut self, map: &Vec) -> u16 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:2492:54 [INFO] [stderr] | [INFO] [stderr] 2492 | pub fn set_modifier_mapping(&mut self, keycodes: &Vec) -> u16 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:2586:32 [INFO] [stderr] | [INFO] [stderr] 2586 | self.buf_one_byte[0] = match input { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 2587 | | true => 1, [INFO] [stderr] 2588 | | false => 0 [INFO] [stderr] 2589 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if input { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:2694:9 [INFO] [stderr] | [INFO] [stderr] 2694 | / match input { [INFO] [stderr] 2695 | | true => self.write_val(1u8 as u32), [INFO] [stderr] 2696 | | false => self.write_val(0u8 as u32) [INFO] [stderr] 2697 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if input { self.write_val(1u8 as u32) } else { self.write_val(0u8 as u32) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:2695:36 [INFO] [stderr] | [INFO] [stderr] 2695 | true => self.write_val(1u8 as u32), [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(1u8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:2696:37 [INFO] [stderr] | [INFO] [stderr] 2696 | false => self.write_val(0u8 as u32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(0u8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:2705:24 [INFO] [stderr] | [INFO] [stderr] 2705 | self.write_val(input as u32); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:2721:24 [INFO] [stderr] | [INFO] [stderr] 2721 | self.write_val(input as u32); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `xrb`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0850ee0cd6d035fd53a0b7e10ad78bf6f4d264ede56d9c14afa4fa80e940cfdf"` [INFO] running `"docker" "rm" "-f" "0850ee0cd6d035fd53a0b7e10ad78bf6f4d264ede56d9c14afa4fa80e940cfdf"` [INFO] [stdout] 0850ee0cd6d035fd53a0b7e10ad78bf6f4d264ede56d9c14afa4fa80e940cfdf