[INFO] updating cached repository DBMeter/DBMeter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/DBMeter/DBMeter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/DBMeter/DBMeter" "work/ex/clippy-test-run/sources/stable/gh/DBMeter/DBMeter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/DBMeter/DBMeter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/DBMeter/DBMeter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DBMeter/DBMeter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DBMeter/DBMeter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1f66b7d8c5214aeeb9c34f3434d77e50ee66761c [INFO] sha for GitHub repo DBMeter/DBMeter: 1f66b7d8c5214aeeb9c34f3434d77e50ee66761c [INFO] validating manifest of DBMeter/DBMeter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of DBMeter/DBMeter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing DBMeter/DBMeter [INFO] finished frobbing DBMeter/DBMeter [INFO] frobbed toml for DBMeter/DBMeter written to work/ex/clippy-test-run/sources/stable/gh/DBMeter/DBMeter/Cargo.toml [INFO] started frobbing DBMeter/DBMeter [INFO] finished frobbing DBMeter/DBMeter [INFO] frobbed toml for DBMeter/DBMeter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/DBMeter/DBMeter/Cargo.toml [INFO] crate DBMeter/DBMeter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting DBMeter/DBMeter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/DBMeter/DBMeter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0e714f5ef30a673a3de844672cfec07d1372b42d5e660cc11cba838f7f669368 [INFO] running `"docker" "start" "-a" "0e714f5ef30a673a3de844672cfec07d1372b42d5e660cc11cba838f7f669368"` [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking socket2 v0.3.5 [INFO] [stderr] Checking backtrace v0.3.7 [INFO] [stderr] Checking hmac v0.5.0 [INFO] [stderr] Checking postgres-protocol v0.3.2 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking dotenv v0.10.1 [INFO] [stderr] Checking postgres-shared v0.4.1 [INFO] [stderr] Checking postgres v0.15.2 [INFO] [stderr] Checking dbmeter v0.1.13 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/drivers/postgres.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | / match &connection { [INFO] [stderr] 10 | | &Ok(ref _result) => println!("Connected"), [INFO] [stderr] 11 | | &Err(ref _error) => { [INFO] [stderr] 12 | | panic!("Connection error: {}", _error); [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 9 | match connection { [INFO] [stderr] 10 | Ok(ref _result) => println!("Connected"), [INFO] [stderr] 11 | Err(ref _error) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / if let &Some(ref dsn) = config.get_postgres() { [INFO] [stderr] 22 | | start_monitoring(dsn.to_string()); [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | if let Some(ref dsn) = *config.get_postgres() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/drivers/postgres.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | / match &connection { [INFO] [stderr] 10 | | &Ok(ref _result) => println!("Connected"), [INFO] [stderr] 11 | | &Err(ref _error) => { [INFO] [stderr] 12 | | panic!("Connection error: {}", _error); [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 9 | match connection { [INFO] [stderr] 10 | Ok(ref _result) => println!("Connected"), [INFO] [stderr] 11 | Err(ref _error) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/monitoring/history.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | assert_eq!(diff.mean_time, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/monitoring/history.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | assert_eq!(diff.mean_time, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/monitoring/history.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | assert_eq!(diff.mean_time, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/monitoring/history.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | assert_eq!(diff.mean_time, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / if let &Some(ref dsn) = config.get_postgres() { [INFO] [stderr] 22 | | start_monitoring(dsn.to_string()); [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | if let Some(ref dsn) = *config.get_postgres() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `dbmeter`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0e714f5ef30a673a3de844672cfec07d1372b42d5e660cc11cba838f7f669368"` [INFO] running `"docker" "rm" "-f" "0e714f5ef30a673a3de844672cfec07d1372b42d5e660cc11cba838f7f669368"` [INFO] [stdout] 0e714f5ef30a673a3de844672cfec07d1372b42d5e660cc11cba838f7f669368