[INFO] updating cached repository Cyberduc-k/cyberduck-lang [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Cyberduc-k/cyberduck-lang [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Cyberduc-k/cyberduck-lang" "work/ex/clippy-test-run/sources/stable/gh/Cyberduc-k/cyberduck-lang"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Cyberduc-k/cyberduck-lang'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Cyberduc-k/cyberduck-lang" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Cyberduc-k/cyberduck-lang"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Cyberduc-k/cyberduck-lang'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e2ac83f271064708db3546736725cadef35a0473 [INFO] sha for GitHub repo Cyberduc-k/cyberduck-lang: e2ac83f271064708db3546736725cadef35a0473 [INFO] validating manifest of Cyberduc-k/cyberduck-lang on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Cyberduc-k/cyberduck-lang on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Cyberduc-k/cyberduck-lang [INFO] finished frobbing Cyberduc-k/cyberduck-lang [INFO] frobbed toml for Cyberduc-k/cyberduck-lang written to work/ex/clippy-test-run/sources/stable/gh/Cyberduc-k/cyberduck-lang/Cargo.toml [INFO] started frobbing Cyberduc-k/cyberduck-lang [INFO] finished frobbing Cyberduc-k/cyberduck-lang [INFO] frobbed toml for Cyberduc-k/cyberduck-lang written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Cyberduc-k/cyberduck-lang/Cargo.toml [INFO] crate Cyberduc-k/cyberduck-lang has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Cyberduc-k/cyberduck-lang against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Cyberduc-k/cyberduck-lang:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ebe597398006c08075bd320a442003098970ba97e2164f132d8240f8899d9e5a [INFO] running `"docker" "start" "-a" "ebe597398006c08075bd320a442003098970ba97e2164f132d8240f8899d9e5a"` [INFO] [stderr] Checking rcd v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | chunk: chunk, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chunk` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | chunk: chunk, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chunk` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner/token.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | type_: type_, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `type_` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner/token.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | span: span, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner/mod.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner/token.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | type_: type_, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `type_` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner/token.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | span: span, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner/mod.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] --> src/scanner/mod.rs:202:13 [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] 202 | type_: type_, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `type_` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scanner/mod.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | type_: type_, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `type_` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/compiler/parser.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/compiler/parser.rs:63:32 [INFO] [stderr] | [INFO] [stderr] 63 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/compiler/parser.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner/mod.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/compiler/parser.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/compiler/parser.rs:63:32 [INFO] [stderr] | [INFO] [stderr] 63 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/compiler/parser.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scanner/mod.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/compiler/parser.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | if let None = prefix_rule { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 41 | | self.error_at(prev.span, "Expected an expression.".to_string()); [INFO] [stderr] 42 | | return; [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________- help: try this: `if prefix_rule.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser.rs:212:58 [INFO] [stderr] | [INFO] [stderr] 212 | ScanError::UnterminatedString(s) => (format!("Unterminated string"), s), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Unterminated string".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser.rs:213:53 [INFO] [stderr] | [INFO] [stderr] 213 | ScanError::InvalidNumber(s) => (format!("Invalid number"), s), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid number".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/compiler/parser.rs:266:17 [INFO] [stderr] | [INFO] [stderr] 266 | pub fn next(&self) -> Precedence { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scanner/mod.rs:211:20 [INFO] [stderr] | [INFO] [stderr] 211 | start: self.start.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scanner/mod.rs:212:18 [INFO] [stderr] | [INFO] [stderr] 212 | end: self.current.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.current` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vm::chunk::Chunk` [INFO] [stderr] --> src/vm/chunk.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Chunk { [INFO] [stderr] 13 | | Chunk { [INFO] [stderr] 14 | | code: Vec::new(), [INFO] [stderr] 15 | | constants: Vec::new(), [INFO] [stderr] 16 | | lines: Vec::new(), [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `vm::VM` [INFO] [stderr] --> src/vm/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> VM { [INFO] [stderr] 19 | | VM { [INFO] [stderr] 20 | | chunk: chunk::Chunk::new(), [INFO] [stderr] 21 | | pc: 0, [INFO] [stderr] 22 | | stack: Vec::new(), [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | impl Default for vm::VM { [INFO] [stderr] 18 | fn default() -> Self { [INFO] [stderr] 19 | Self::new() [INFO] [stderr] 20 | } [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/compiler/parser.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | if let None = prefix_rule { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 41 | | self.error_at(prev.span, "Expected an expression.".to_string()); [INFO] [stderr] 42 | | return; [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________- help: try this: `if prefix_rule.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vm/mod.rs:121:65 [INFO] [stderr] | [INFO] [stderr] 121 | Equal => self.stack.push(Constant::Bool(a == (b as f64))), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(a - (b as f64)).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vm/mod.rs:121:65 [INFO] [stderr] | [INFO] [stderr] 121 | Equal => self.stack.push(Constant::Bool(a == (b as f64))), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vm/mod.rs:122:68 [INFO] [stderr] | [INFO] [stderr] 122 | NotEqual => self.stack.push(Constant::Bool(a != (b as f64))), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(a - (b as f64)).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vm/mod.rs:122:68 [INFO] [stderr] | [INFO] [stderr] 122 | NotEqual => self.stack.push(Constant::Bool(a != (b as f64))), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vm/mod.rs:130:65 [INFO] [stderr] | [INFO] [stderr] 130 | Equal => self.stack.push(Constant::Bool(a == b)), [INFO] [stderr] | ^^^^^^ help: consider comparing them within some error: `(a - b).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vm/mod.rs:130:65 [INFO] [stderr] | [INFO] [stderr] 130 | Equal => self.stack.push(Constant::Bool(a == b)), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vm/mod.rs:131:68 [INFO] [stderr] | [INFO] [stderr] 131 | NotEqual => self.stack.push(Constant::Bool(a != b)), [INFO] [stderr] | ^^^^^^ help: consider comparing them within some error: `(a - b).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vm/mod.rs:131:68 [INFO] [stderr] | [INFO] [stderr] 131 | NotEqual => self.stack.push(Constant::Bool(a != b)), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser.rs:212:58 [INFO] [stderr] | [INFO] [stderr] 212 | ScanError::UnterminatedString(s) => (format!("Unterminated string"), s), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Unterminated string".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser.rs:213:53 [INFO] [stderr] | [INFO] [stderr] 213 | ScanError::InvalidNumber(s) => (format!("Invalid number"), s), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid number".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/compiler/parser.rs:266:17 [INFO] [stderr] | [INFO] [stderr] 266 | pub fn next(&self) -> Precedence { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: Could not compile `rcd`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scanner/mod.rs:211:20 [INFO] [stderr] | [INFO] [stderr] 211 | start: self.start.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scanner/mod.rs:212:18 [INFO] [stderr] | [INFO] [stderr] 212 | end: self.current.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.current` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vm::chunk::Chunk` [INFO] [stderr] --> src/vm/chunk.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Chunk { [INFO] [stderr] 13 | | Chunk { [INFO] [stderr] 14 | | code: Vec::new(), [INFO] [stderr] 15 | | constants: Vec::new(), [INFO] [stderr] 16 | | lines: Vec::new(), [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `vm::VM` [INFO] [stderr] --> src/vm/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> VM { [INFO] [stderr] 19 | | VM { [INFO] [stderr] 20 | | chunk: chunk::Chunk::new(), [INFO] [stderr] 21 | | pc: 0, [INFO] [stderr] 22 | | stack: Vec::new(), [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | impl Default for vm::VM { [INFO] [stderr] 18 | fn default() -> Self { [INFO] [stderr] 19 | Self::new() [INFO] [stderr] 20 | } [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vm/mod.rs:121:65 [INFO] [stderr] | [INFO] [stderr] 121 | Equal => self.stack.push(Constant::Bool(a == (b as f64))), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(a - (b as f64)).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vm/mod.rs:121:65 [INFO] [stderr] | [INFO] [stderr] 121 | Equal => self.stack.push(Constant::Bool(a == (b as f64))), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vm/mod.rs:122:68 [INFO] [stderr] | [INFO] [stderr] 122 | NotEqual => self.stack.push(Constant::Bool(a != (b as f64))), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(a - (b as f64)).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vm/mod.rs:122:68 [INFO] [stderr] | [INFO] [stderr] 122 | NotEqual => self.stack.push(Constant::Bool(a != (b as f64))), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vm/mod.rs:130:65 [INFO] [stderr] | [INFO] [stderr] 130 | Equal => self.stack.push(Constant::Bool(a == b)), [INFO] [stderr] | ^^^^^^ help: consider comparing them within some error: `(a - b).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vm/mod.rs:130:65 [INFO] [stderr] | [INFO] [stderr] 130 | Equal => self.stack.push(Constant::Bool(a == b)), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vm/mod.rs:131:68 [INFO] [stderr] | [INFO] [stderr] 131 | NotEqual => self.stack.push(Constant::Bool(a != b)), [INFO] [stderr] | ^^^^^^ help: consider comparing them within some error: `(a - b).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vm/mod.rs:131:68 [INFO] [stderr] | [INFO] [stderr] 131 | NotEqual => self.stack.push(Constant::Bool(a != b)), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rcd`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ebe597398006c08075bd320a442003098970ba97e2164f132d8240f8899d9e5a"` [INFO] running `"docker" "rm" "-f" "ebe597398006c08075bd320a442003098970ba97e2164f132d8240f8899d9e5a"` [INFO] [stdout] ebe597398006c08075bd320a442003098970ba97e2164f132d8240f8899d9e5a