[INFO] updating cached repository Cyberdr8gon/rustywebserver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Cyberdr8gon/rustywebserver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Cyberdr8gon/rustywebserver" "work/ex/clippy-test-run/sources/stable/gh/Cyberdr8gon/rustywebserver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Cyberdr8gon/rustywebserver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Cyberdr8gon/rustywebserver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Cyberdr8gon/rustywebserver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Cyberdr8gon/rustywebserver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2dab9b4ca1c85bfbb7668111ff71bce00bef5089 [INFO] sha for GitHub repo Cyberdr8gon/rustywebserver: 2dab9b4ca1c85bfbb7668111ff71bce00bef5089 [INFO] validating manifest of Cyberdr8gon/rustywebserver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Cyberdr8gon/rustywebserver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Cyberdr8gon/rustywebserver [INFO] finished frobbing Cyberdr8gon/rustywebserver [INFO] frobbed toml for Cyberdr8gon/rustywebserver written to work/ex/clippy-test-run/sources/stable/gh/Cyberdr8gon/rustywebserver/Cargo.toml [INFO] started frobbing Cyberdr8gon/rustywebserver [INFO] finished frobbing Cyberdr8gon/rustywebserver [INFO] frobbed toml for Cyberdr8gon/rustywebserver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Cyberdr8gon/rustywebserver/Cargo.toml [INFO] crate Cyberdr8gon/rustywebserver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Cyberdr8gon/rustywebserver against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Cyberdr8gon/rustywebserver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e47672ac6d58b984bc0321d00c7f70817d5353757fc6d81d0689859cc5bb9645 [INFO] running `"docker" "start" "-a" "e47672ac6d58b984bc0321d00c7f70817d5353757fc6d81d0689859cc5bb9645"` [INFO] [stderr] Checking rustywebserver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/bin/main.rs:17:8 [INFO] [stderr] | [INFO] [stderr] 17 | if ( !fs::metadata("index.html").unwrap().is_file() || [INFO] [stderr] | ________^ [INFO] [stderr] 18 | | !fs::metadata("404.html").unwrap().is_file()) [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 17 | if !fs::metadata("index.html").unwrap().is_file() || [INFO] [stderr] 18 | !fs::metadata("404.html").unwrap().is_file() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/bin/main.rs:63:15 [INFO] [stderr] | [INFO] [stderr] 63 | if(metadata.is_file()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/bin/main.rs:17:8 [INFO] [stderr] | [INFO] [stderr] 17 | if ( !fs::metadata("index.html").unwrap().is_file() || [INFO] [stderr] | ________^ [INFO] [stderr] 18 | | !fs::metadata("404.html").unwrap().is_file()) [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 17 | if !fs::metadata("index.html").unwrap().is_file() || [INFO] [stderr] 18 | !fs::metadata("404.html").unwrap().is_file() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/bin/main.rs:63:15 [INFO] [stderr] | [INFO] [stderr] 63 | if(metadata.is_file()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/bin/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | stream.read(&mut buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/bin/main.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | stream.write(response.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustywebserver`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/bin/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | stream.read(&mut buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/bin/main.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | stream.write(response.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustywebserver`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e47672ac6d58b984bc0321d00c7f70817d5353757fc6d81d0689859cc5bb9645"` [INFO] running `"docker" "rm" "-f" "e47672ac6d58b984bc0321d00c7f70817d5353757fc6d81d0689859cc5bb9645"` [INFO] [stdout] e47672ac6d58b984bc0321d00c7f70817d5353757fc6d81d0689859cc5bb9645