[INFO] updating cached repository CryptArchy/babylon [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/CryptArchy/babylon [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/CryptArchy/babylon" "work/ex/clippy-test-run/sources/stable/gh/CryptArchy/babylon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CryptArchy/babylon'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/CryptArchy/babylon" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CryptArchy/babylon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CryptArchy/babylon'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3ec240a7c052b8ee949b33eb3ba8511dd54a75de [INFO] sha for GitHub repo CryptArchy/babylon: 3ec240a7c052b8ee949b33eb3ba8511dd54a75de [INFO] validating manifest of CryptArchy/babylon on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of CryptArchy/babylon on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing CryptArchy/babylon [INFO] finished frobbing CryptArchy/babylon [INFO] frobbed toml for CryptArchy/babylon written to work/ex/clippy-test-run/sources/stable/gh/CryptArchy/babylon/Cargo.toml [INFO] started frobbing CryptArchy/babylon [INFO] finished frobbing CryptArchy/babylon [INFO] frobbed toml for CryptArchy/babylon written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CryptArchy/babylon/Cargo.toml [INFO] crate CryptArchy/babylon has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting CryptArchy/babylon against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/CryptArchy/babylon:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7cbc3758c115be7b4ba77fc48026659608d1568eba17190ccb71115c6fcbc05d [INFO] running `"docker" "start" "-a" "7cbc3758c115be7b4ba77fc48026659608d1568eba17190ccb71115c6fcbc05d"` [INFO] [stderr] Checking data-encoding v1.1.2 [INFO] [stderr] Checking version v2.0.1 [INFO] [stderr] Checking error-type v0.1.2 [INFO] [stderr] Checking redux v0.1.0 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking log4rs v0.4.8 [INFO] [stderr] Checking babylon v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text_generator.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text_generator.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | rng: rng, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text_generator.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text_generator.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text_generator.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | rng: rng, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text_generator.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `SeedableRng` [INFO] [stderr] --> src/text_generator.rs:1:25 [INFO] [stderr] | [INFO] [stderr] 1 | use rand::{Rng, StdRng, SeedableRng}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/text_generator.rs:3:25 [INFO] [stderr] | [INFO] [stderr] 3 | const BASE_16_CHARSET: &'static [u8] = b"abdhjklmnprstvw_"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/text_generator.rs:5:25 [INFO] [stderr] | [INFO] [stderr] 5 | const BASE_28_CHARSET: &'static [u8] = b"abcdefghijklmnopqrstuvwxyz ."; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/text_generator.rs:7:25 [INFO] [stderr] | [INFO] [stderr] 7 | const BASE_38_CHARSET: &'static [u8] = b"abcdefghijklmnopqrstuvwxyz .0123456789"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/text_generator.rs:9:25 [INFO] [stderr] | [INFO] [stderr] 9 | const BASE_62_CHARSET: &'static [u8] = b"ABCDEFGHIJKLMNOPQRSTUVWXYZ\ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/text_generator.rs:3:25 [INFO] [stderr] | [INFO] [stderr] 3 | const BASE_16_CHARSET: &'static [u8] = b"abdhjklmnprstvw_"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/text_generator.rs:5:25 [INFO] [stderr] | [INFO] [stderr] 5 | const BASE_28_CHARSET: &'static [u8] = b"abcdefghijklmnopqrstuvwxyz ."; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/text_generator.rs:7:25 [INFO] [stderr] | [INFO] [stderr] 7 | const BASE_38_CHARSET: &'static [u8] = b"abcdefghijklmnopqrstuvwxyz .0123456789"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/text_generator.rs:9:25 [INFO] [stderr] | [INFO] [stderr] 9 | const BASE_62_CHARSET: &'static [u8] = b"ABCDEFGHIJKLMNOPQRSTUVWXYZ\ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: function is never used: `gen_rand_text` [INFO] [stderr] --> src/generate.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn gen_rand_text<'a>() -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BASE_16_CHARSET` [INFO] [stderr] --> src/text_generator.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | const BASE_16_CHARSET: &'static [u8] = b"abdhjklmnprstvw_"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BASE_28_CHARSET` [INFO] [stderr] --> src/text_generator.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const BASE_28_CHARSET: &'static [u8] = b"abcdefghijklmnopqrstuvwxyz ."; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BASE_38_CHARSET` [INFO] [stderr] --> src/text_generator.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const BASE_38_CHARSET: &'static [u8] = b"abcdefghijklmnopqrstuvwxyz .0123456789"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BASE_62_CHARSET` [INFO] [stderr] --> src/text_generator.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / const BASE_62_CHARSET: &'static [u8] = b"ABCDEFGHIJKLMNOPQRSTUVWXYZ\ [INFO] [stderr] 10 | | abcdefghijklmnopqrstuvwxyz\ [INFO] [stderr] 11 | | 0123456789"; [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `TextGenerator` [INFO] [stderr] --> src/text_generator.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | pub struct TextGenerator<'a, R: 'a + Rng> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/text_generator.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn new(rng: &'a mut R, chars: &'static [u8]) -> TextGenerator<'a, R> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `base_16` [INFO] [stderr] --> src/text_generator.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn base_16(rng: &'a mut R) -> TextGenerator<'a, R> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `base_28` [INFO] [stderr] --> src/text_generator.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn base_28(rng: &'a mut R) -> TextGenerator<'a, R> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `base_38` [INFO] [stderr] --> src/text_generator.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn base_38(rng: &'a mut R) -> TextGenerator<'a, R> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `base_62` [INFO] [stderr] --> src/text_generator.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn base_62(rng: &'a mut R) -> TextGenerator<'a, R> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/generate.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn gen_rand_text<'a>() -> String { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BASE_16_CHARSET` [INFO] [stderr] --> src/text_generator.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | const BASE_16_CHARSET: &'static [u8] = b"abdhjklmnprstvw_"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `base_16` [INFO] [stderr] --> src/text_generator.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn base_16(rng: &'a mut R) -> TextGenerator<'a, R> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/generate.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn gen_rand_text<'a>() -> String { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/generate.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | assert!(actual.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!actual.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.11s [INFO] running `"docker" "inspect" "7cbc3758c115be7b4ba77fc48026659608d1568eba17190ccb71115c6fcbc05d"` [INFO] running `"docker" "rm" "-f" "7cbc3758c115be7b4ba77fc48026659608d1568eba17190ccb71115c6fcbc05d"` [INFO] [stdout] 7cbc3758c115be7b4ba77fc48026659608d1568eba17190ccb71115c6fcbc05d