[INFO] updating cached repository Crimack/snake.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Crimack/snake.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Crimack/snake.rs" "work/ex/clippy-test-run/sources/stable/gh/Crimack/snake.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Crimack/snake.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Crimack/snake.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Crimack/snake.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Crimack/snake.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 642a100828cca72083fbf9643841fe9bac8bb6a3 [INFO] sha for GitHub repo Crimack/snake.rs: 642a100828cca72083fbf9643841fe9bac8bb6a3 [INFO] validating manifest of Crimack/snake.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Crimack/snake.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Crimack/snake.rs [INFO] finished frobbing Crimack/snake.rs [INFO] frobbed toml for Crimack/snake.rs written to work/ex/clippy-test-run/sources/stable/gh/Crimack/snake.rs/Cargo.toml [INFO] started frobbing Crimack/snake.rs [INFO] finished frobbing Crimack/snake.rs [INFO] frobbed toml for Crimack/snake.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Crimack/snake.rs/Cargo.toml [INFO] crate Crimack/snake.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Crimack/snake.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Crimack/snake.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4fb9a20916e6f83767b41b3b419cb3bf52baeffb7981624042d960291723d495 [INFO] running `"docker" "start" "-a" "4fb9a20916e6f83767b41b3b419cb3bf52baeffb7981624042d960291723d495"` [INFO] [stderr] Checking x11-dl v2.17.3 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking pistoncore-window v0.31.0 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Checking pistoncore-event_loop v0.36.0 [INFO] [stderr] Checking glutin v0.12.2 [INFO] [stderr] Checking piston2d-opengl_graphics v0.52.0 [INFO] [stderr] Checking piston v0.36.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.45.3 [INFO] [stderr] Checking snake v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake.rs:119:34 [INFO] [stderr] | [INFO] [stderr] 119 | position: Position { x: x, y: y }, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake.rs:119:40 [INFO] [stderr] | [INFO] [stderr] 119 | position: Position { x: x, y: y }, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake.rs:119:34 [INFO] [stderr] | [INFO] [stderr] 119 | position: Position { x: x, y: y }, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snake.rs:119:40 [INFO] [stderr] | [INFO] [stderr] 119 | position: Position { x: x, y: y }, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `snake::Snake` [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use snake::Snake; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `snake::Snake` [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use snake::Snake; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/app.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `snake` [INFO] [stderr] --> src/edibles.rs:23:23 [INFO] [stderr] | [INFO] [stderr] 23 | fn eat(&mut self, snake: &mut Snake) { [INFO] [stderr] | ^^^^^ help: consider using `_snake` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `snake` [INFO] [stderr] --> src/edibles.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | fn eat(&mut self, snake: &mut Snake) { [INFO] [stderr] | ^^^^^ help: consider using `_snake` instead [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/app.rs:94:36 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:175:21 [INFO] [stderr] | [INFO] [stderr] 175 | let x = rng.gen_range(0, WORLD_WIDTH as u32) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rng.gen_range(0, WORLD_WIDTH as u32))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:176:21 [INFO] [stderr] | [INFO] [stderr] 176 | let y = rng.gen_range(0, WORLD_HEIGHT as u32) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rng.gen_range(0, WORLD_HEIGHT as u32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/app.rs:177:42 [INFO] [stderr] | [INFO] [stderr] 177 | if !locations.iter().any(|i| i.x == x && i.y == y) { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(i.x - x).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/app.rs:177:42 [INFO] [stderr] | [INFO] [stderr] 177 | if !locations.iter().any(|i| i.x == x && i.y == y) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/app.rs:177:54 [INFO] [stderr] | [INFO] [stderr] 177 | if !locations.iter().any(|i| i.x == x && i.y == y) { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(i.y - y).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/app.rs:177:54 [INFO] [stderr] | [INFO] [stderr] 177 | if !locations.iter().any(|i| i.x == x && i.y == y) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/snake.rs:75:16 [INFO] [stderr] | [INFO] [stderr] 75 | if head_x == part.position.x && head_y == part.position.y { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(head_x - part.position.x).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/snake.rs:75:16 [INFO] [stderr] | [INFO] [stderr] 75 | if head_x == part.position.x && head_y == part.position.y { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/snake.rs:75:45 [INFO] [stderr] | [INFO] [stderr] 75 | if head_x == part.position.x && head_y == part.position.y { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(head_y - part.position.y).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/snake.rs:75:45 [INFO] [stderr] | [INFO] [stderr] 75 | if head_x == part.position.x && head_y == part.position.y { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `snake`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/app.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `snake` [INFO] [stderr] --> src/edibles.rs:23:23 [INFO] [stderr] | [INFO] [stderr] 23 | fn eat(&mut self, snake: &mut Snake) { [INFO] [stderr] | ^^^^^ help: consider using `_snake` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `snake` [INFO] [stderr] --> src/edibles.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | fn eat(&mut self, snake: &mut Snake) { [INFO] [stderr] | ^^^^^ help: consider using `_snake` instead [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/app.rs:94:36 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:175:21 [INFO] [stderr] | [INFO] [stderr] 175 | let x = rng.gen_range(0, WORLD_WIDTH as u32) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rng.gen_range(0, WORLD_WIDTH as u32))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:176:21 [INFO] [stderr] | [INFO] [stderr] 176 | let y = rng.gen_range(0, WORLD_HEIGHT as u32) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(rng.gen_range(0, WORLD_HEIGHT as u32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/app.rs:177:42 [INFO] [stderr] | [INFO] [stderr] 177 | if !locations.iter().any(|i| i.x == x && i.y == y) { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(i.x - x).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/app.rs:177:42 [INFO] [stderr] | [INFO] [stderr] 177 | if !locations.iter().any(|i| i.x == x && i.y == y) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/app.rs:177:54 [INFO] [stderr] | [INFO] [stderr] 177 | if !locations.iter().any(|i| i.x == x && i.y == y) { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(i.y - y).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/app.rs:177:54 [INFO] [stderr] | [INFO] [stderr] 177 | if !locations.iter().any(|i| i.x == x && i.y == y) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/snake.rs:75:16 [INFO] [stderr] | [INFO] [stderr] 75 | if head_x == part.position.x && head_y == part.position.y { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(head_x - part.position.x).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/snake.rs:75:16 [INFO] [stderr] | [INFO] [stderr] 75 | if head_x == part.position.x && head_y == part.position.y { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/snake.rs:75:45 [INFO] [stderr] | [INFO] [stderr] 75 | if head_x == part.position.x && head_y == part.position.y { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(head_y - part.position.y).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/snake.rs:75:45 [INFO] [stderr] | [INFO] [stderr] 75 | if head_x == part.position.x && head_y == part.position.y { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `snake`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4fb9a20916e6f83767b41b3b419cb3bf52baeffb7981624042d960291723d495"` [INFO] running `"docker" "rm" "-f" "4fb9a20916e6f83767b41b3b419cb3bf52baeffb7981624042d960291723d495"` [INFO] [stdout] 4fb9a20916e6f83767b41b3b419cb3bf52baeffb7981624042d960291723d495