[INFO] updating cached repository CrazyFork/rs_webserver_game
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/CrazyFork/rs_webserver_game
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/CrazyFork/rs_webserver_game" "work/ex/clippy-test-run/sources/stable/gh/CrazyFork/rs_webserver_game"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CrazyFork/rs_webserver_game'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/CrazyFork/rs_webserver_game" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CrazyFork/rs_webserver_game"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CrazyFork/rs_webserver_game'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 586675fc787ab9c70fc81f8e4677dc12d239bf2b
[INFO] sha for GitHub repo CrazyFork/rs_webserver_game: 586675fc787ab9c70fc81f8e4677dc12d239bf2b
[INFO] validating manifest of CrazyFork/rs_webserver_game on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of CrazyFork/rs_webserver_game on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing CrazyFork/rs_webserver_game
[INFO] finished frobbing CrazyFork/rs_webserver_game
[INFO] frobbed toml for CrazyFork/rs_webserver_game written to work/ex/clippy-test-run/sources/stable/gh/CrazyFork/rs_webserver_game/Cargo.toml
[INFO] started frobbing CrazyFork/rs_webserver_game
[INFO] finished frobbing CrazyFork/rs_webserver_game
[INFO] frobbed toml for CrazyFork/rs_webserver_game written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CrazyFork/rs_webserver_game/Cargo.toml
[INFO] crate CrazyFork/rs_webserver_game has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting CrazyFork/rs_webserver_game against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/CrazyFork/rs_webserver_game:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] abc004748ba7179038f11dbb238fb827554391066f38fa2354b05ca028251997
[INFO] running `"docker" "start" "-a" "abc004748ba7179038f11dbb238fb827554391066f38fa2354b05ca028251997"`
[INFO] [stderr]     Checking server-tictac v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/common.rs:55:25
[INFO] [stderr]    |
[INFO] [stderr] 55 |                         return Ok(p)
[INFO] [stderr]    |                         ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(p)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/common.rs:57:29
[INFO] [stderr]    |
[INFO] [stderr] 57 |                     None => return Err(Status::faulty_query(&format!("No {:?} submitted in query", param)))
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Status::faulty_query(&format!("No {:?} submitted in query", param)))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/common.rs:61:17
[INFO] [stderr]    |
[INFO] [stderr] 61 |                 return Err(Status::faulty_query("No data submitted in query"))
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Status::faulty_query("No data submitted in query"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/common.rs:55:25
[INFO] [stderr]    |
[INFO] [stderr] 55 |                         return Ok(p)
[INFO] [stderr]    |                         ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(p)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/common.rs:57:29
[INFO] [stderr]    |
[INFO] [stderr] 57 |                     None => return Err(Status::faulty_query(&format!("No {:?} submitted in query", param)))
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Status::faulty_query(&format!("No {:?} submitted in query", param)))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/common.rs:61:17
[INFO] [stderr]    |
[INFO] [stderr] 61 |                 return Err(Status::faulty_query("No data submitted in query"))
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Status::faulty_query("No data submitted in query"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Request`
[INFO] [stderr]   --> src/common.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 | /     pub fn new() -> Request {
[INFO] [stderr] 37 | |         Request {
[INFO] [stderr] 38 | |             method  : String::new(),
[INFO] [stderr] 39 | |             url     : String::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 42 | |         }
[INFO] [stderr] 43 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 28 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Request`
[INFO] [stderr]   --> src/common.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 | /     pub fn new() -> Request {
[INFO] [stderr] 37 | |         Request {
[INFO] [stderr] 38 | |             method  : String::new(),
[INFO] [stderr] 39 | |             url     : String::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 42 | |         }
[INFO] [stderr] 43 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 28 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `n` is only used to index `buffer`.
[INFO] [stderr]   --> src/common.rs:94:18
[INFO] [stderr]    |
[INFO] [stderr] 94 |         for n in 0..read_len {
[INFO] [stderr]    |                  ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 94 |         for <item> in buffer.iter().take(read_len) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/common.rs:189:12
[INFO] [stderr]     |
[INFO] [stderr] 189 |         if body.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!body.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/common.rs:212:25
[INFO] [stderr]     |
[INFO] [stderr] 212 | fn parse_params(string: &String) -> HashMap<String,String> {
[INFO] [stderr]     |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Response`
[INFO] [stderr]    --> src/common.rs:241:5
[INFO] [stderr]     |
[INFO] [stderr] 241 | /     pub fn new() -> Response {
[INFO] [stderr] 242 | |         Response { code: String::new(),
[INFO] [stderr] 243 | |                    headers: HashMap::new(),
[INFO] [stderr] 244 | |                    body: None, }
[INFO] [stderr] 245 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 235 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/common.rs:292:9
[INFO] [stderr]     |
[INFO] [stderr] 292 | /         match self.body {
[INFO] [stderr] 293 | |             Some(ref b) => {string.push_str(&line_end);
[INFO] [stderr] 294 | |                             string.push_str(str::from_utf8(&b).unwrap());
[INFO] [stderr] 295 | |                             string.push_str(&line_end)},
[INFO] [stderr] 296 | |             None => {},
[INFO] [stderr] 297 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 292 |         if let Some(ref b) = self.body {string.push_str(&line_end);
[INFO] [stderr] 293 | string.push_str(str::from_utf8(&b).unwrap());
[INFO] [stderr] 294 | string.push_str(&line_end)}
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: module `Status` should have a snake case name such as `status`
[INFO] [stderr]    --> src/common.rs:305:1
[INFO] [stderr]     |
[INFO] [stderr] 305 | / pub mod Status {
[INFO] [stderr] 306 | |     use ::Response;
[INFO] [stderr] 307 | |     
[INFO] [stderr] 308 | |     pub fn faulty_query(text: &str) -> Response {
[INFO] [stderr] ...   |
[INFO] [stderr] 350 | |     }
[INFO] [stderr] 351 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `n` is only used to index `buffer`.
[INFO] [stderr]   --> src/common.rs:94:18
[INFO] [stderr]    |
[INFO] [stderr] 94 |         for n in 0..read_len {
[INFO] [stderr]    |                  ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 94 |         for <item> in buffer.iter().take(read_len) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/common.rs:189:12
[INFO] [stderr]     |
[INFO] [stderr] 189 |         if body.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!body.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/common.rs:212:25
[INFO] [stderr]     |
[INFO] [stderr] 212 | fn parse_params(string: &String) -> HashMap<String,String> {
[INFO] [stderr]     |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Response`
[INFO] [stderr]    --> src/common.rs:241:5
[INFO] [stderr]     |
[INFO] [stderr] 241 | /     pub fn new() -> Response {
[INFO] [stderr] 242 | |         Response { code: String::new(),
[INFO] [stderr] 243 | |                    headers: HashMap::new(),
[INFO] [stderr] 244 | |                    body: None, }
[INFO] [stderr] 245 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 235 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/common.rs:292:9
[INFO] [stderr]     |
[INFO] [stderr] 292 | /         match self.body {
[INFO] [stderr] 293 | |             Some(ref b) => {string.push_str(&line_end);
[INFO] [stderr] 294 | |                             string.push_str(str::from_utf8(&b).unwrap());
[INFO] [stderr] 295 | |                             string.push_str(&line_end)},
[INFO] [stderr] 296 | |             None => {},
[INFO] [stderr] 297 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 292 |         if let Some(ref b) = self.body {string.push_str(&line_end);
[INFO] [stderr] 293 | string.push_str(str::from_utf8(&b).unwrap());
[INFO] [stderr] 294 | string.push_str(&line_end)}
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: module `Status` should have a snake case name such as `status`
[INFO] [stderr]    --> src/common.rs:305:1
[INFO] [stderr]     |
[INFO] [stderr] 305 | / pub mod Status {
[INFO] [stderr] 306 | |     use ::Response;
[INFO] [stderr] 307 | |     
[INFO] [stderr] 308 | |     pub fn faulty_query(text: &str) -> Response {
[INFO] [stderr] ...   |
[INFO] [stderr] 350 | |     }
[INFO] [stderr] 351 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/web_server.rs:187:9
[INFO] [stderr]     |
[INFO] [stderr] 187 |         move_to: move_to,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: replace it with: `move_to`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/web_server.rs:188:9
[INFO] [stderr]     |
[INFO] [stderr] 188 |         new_game: new_game,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `new_game`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/web_server.rs:187:9
[INFO] [stderr]     |
[INFO] [stderr] 187 |         move_to: move_to,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: replace it with: `move_to`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/web_server.rs:188:9
[INFO] [stderr]     |
[INFO] [stderr] 188 |         new_game: new_game,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `new_game`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/game_server.rs:73:23
[INFO] [stderr]    |
[INFO] [stderr] 73 |             Err(e) => return Err(format!("JSON conversion failed: {:?}", e)),
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("JSON conversion failed: {:?}", e))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/game_server.rs:95:13
[INFO] [stderr]    |
[INFO] [stderr] 95 |             return Ok(true);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/game_server.rs:97:13
[INFO] [stderr]    |
[INFO] [stderr] 97 |             return Err(String::from("Illegal move"));
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(String::from("Illegal move"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/web_server.rs:216:13
[INFO] [stderr]     |
[INFO] [stderr] 216 |             s
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/web_server.rs:198:21
[INFO] [stderr]     |
[INFO] [stderr] 198 |               let s = match move_to {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 199 | |                 '0' => "0:".to_string() + &string,
[INFO] [stderr] 200 | |                 '1' => "0:".to_string() + &string,
[INFO] [stderr] 201 | |                 '2' => "0:".to_string() + &string,
[INFO] [stderr] ...   |
[INFO] [stderr] 214 | |                 }
[INFO] [stderr] 215 | |             };
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/web_server.rs:281:13
[INFO] [stderr]     |
[INFO] [stderr] 281 |             return Ok(game);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(game)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/web_server.rs:283:19
[INFO] [stderr]     |
[INFO] [stderr] 283 |         Err(e) => return Err(format!("Game server down? {:?}", e)),
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Game server down? {:?}", e))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/web_server.rs:216:13
[INFO] [stderr]     |
[INFO] [stderr] 216 |             s
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/web_server.rs:198:21
[INFO] [stderr]     |
[INFO] [stderr] 198 |               let s = match move_to {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 199 | |                 '0' => "0:".to_string() + &string,
[INFO] [stderr] 200 | |                 '1' => "0:".to_string() + &string,
[INFO] [stderr] 201 | |                 '2' => "0:".to_string() + &string,
[INFO] [stderr] ...   |
[INFO] [stderr] 214 | |                 }
[INFO] [stderr] 215 | |             };
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/web_server.rs:281:13
[INFO] [stderr]     |
[INFO] [stderr] 281 |             return Ok(game);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(game)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/web_server.rs:283:19
[INFO] [stderr]     |
[INFO] [stderr] 283 |         Err(e) => return Err(format!("Game server down? {:?}", e)),
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Game server down? {:?}", e))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/game_server.rs:79:13
[INFO] [stderr]    |
[INFO] [stderr] 79 |         let mut board = match guard.board.get_mut(&user_id) {
[INFO] [stderr]    |             ----^^^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/game_server.rs:73:23
[INFO] [stderr]    |
[INFO] [stderr] 73 |             Err(e) => return Err(format!("JSON conversion failed: {:?}", e)),
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("JSON conversion failed: {:?}", e))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/game_server.rs:95:13
[INFO] [stderr]    |
[INFO] [stderr] 95 |             return Ok(true);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/game_server.rs:97:13
[INFO] [stderr]    |
[INFO] [stderr] 97 |             return Err(String::from("Illegal move"));
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(String::from("Illegal move"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/game_server.rs:71:20
[INFO] [stderr]    |
[INFO] [stderr] 71 |         let data = guard.board.get(&user_id).unwrap().to_vec();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&guard.board[&user_id]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/game_server.rs:109:20
[INFO] [stderr]     |
[INFO] [stderr] 109 |         .unwrap_or(println!("Failed to write to stream")); // to webserver
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/game_server.rs:112:20
[INFO] [stderr]     |
[INFO] [stderr] 112 |         .unwrap_or(println!("Stream closed before write?"));
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/game_server.rs:132:29
[INFO] [stderr]     |
[INFO] [stderr] 132 |         write_error(stream, format!("Invalid JSON received"));
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid JSON received".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/game_server.rs:190:9
[INFO] [stderr]     |
[INFO] [stderr] 190 | /         match game.insert_move(user_data.user_id, ch, 'O') {
[INFO] [stderr] 191 | |             Ok(_) => break,
[INFO] [stderr] 192 | |             Err(_) => {}
[INFO] [stderr] 193 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let Ok(_) = game.insert_move(user_data.user_id, ch, 'O') { break }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/web_server.rs:115:9
[INFO] [stderr]     |
[INFO] [stderr] 115 |     let ref user_id = match request.body.as_ref() { // Option<T>.as_ref()->Option<&T>
[INFO] [stderr]     |         ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 115 |     let user_id = &(match request.body.as_ref() { // Option<T>.as_ref()->Option<&T>
[INFO] [stderr] 116 |         Some(map) => map.get("user_id").unwrap(),
[INFO] [stderr] 117 |         None => "123",// TODO - fetch unused id from game server
[INFO] [stderr] 118 |     });
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/web_server.rs:210:35
[INFO] [stderr]     |
[INFO] [stderr] 210 |                     response.body("Illegal move, please press back".as_bytes().to_vec());
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Illegal move, please press back"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/web_server.rs:115:9
[INFO] [stderr]     |
[INFO] [stderr] 115 |     let ref user_id = match request.body.as_ref() { // Option<T>.as_ref()->Option<&T>
[INFO] [stderr]     |         ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 115 |     let user_id = &(match request.body.as_ref() { // Option<T>.as_ref()->Option<&T>
[INFO] [stderr] 116 |         Some(map) => map.get("user_id").unwrap(),
[INFO] [stderr] 117 |         None => "123",// TODO - fetch unused id from game server
[INFO] [stderr] 118 |     });
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/web_server.rs:210:35
[INFO] [stderr]     |
[INFO] [stderr] 210 |                     response.body("Illegal move, please press back".as_bytes().to_vec());
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Illegal move, please press back"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/game_server.rs:79:13
[INFO] [stderr]    |
[INFO] [stderr] 79 |         let mut board = match guard.board.get_mut(&user_id) {
[INFO] [stderr]    |             ----^^^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/game_server.rs:71:20
[INFO] [stderr]    |
[INFO] [stderr] 71 |         let data = guard.board.get(&user_id).unwrap().to_vec();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&guard.board[&user_id]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/game_server.rs:109:20
[INFO] [stderr]     |
[INFO] [stderr] 109 |         .unwrap_or(println!("Failed to write to stream")); // to webserver
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/game_server.rs:112:20
[INFO] [stderr]     |
[INFO] [stderr] 112 |         .unwrap_or(println!("Stream closed before write?"));
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/game_server.rs:132:29
[INFO] [stderr]     |
[INFO] [stderr] 132 |         write_error(stream, format!("Invalid JSON received"));
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid JSON received".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/game_server.rs:190:9
[INFO] [stderr]     |
[INFO] [stderr] 190 | /         match game.insert_move(user_data.user_id, ch, 'O') {
[INFO] [stderr] 191 | |             Ok(_) => break,
[INFO] [stderr] 192 | |             Err(_) => {}
[INFO] [stderr] 193 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let Ok(_) = game.insert_move(user_data.user_id, ch, 'O') { break }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.85s
[INFO] running `"docker" "inspect" "abc004748ba7179038f11dbb238fb827554391066f38fa2354b05ca028251997"`
[INFO] running `"docker" "rm" "-f" "abc004748ba7179038f11dbb238fb827554391066f38fa2354b05ca028251997"`
[INFO] [stdout] abc004748ba7179038f11dbb238fb827554391066f38fa2354b05ca028251997