[INFO] updating cached repository Cosaquee/npm-update-checker [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Cosaquee/npm-update-checker [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Cosaquee/npm-update-checker" "work/ex/clippy-test-run/sources/stable/gh/Cosaquee/npm-update-checker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Cosaquee/npm-update-checker'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Cosaquee/npm-update-checker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Cosaquee/npm-update-checker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Cosaquee/npm-update-checker'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2fd8bcfbf41ecf721daa2dbffb39bb7b7c2aac07 [INFO] sha for GitHub repo Cosaquee/npm-update-checker: 2fd8bcfbf41ecf721daa2dbffb39bb7b7c2aac07 [INFO] validating manifest of Cosaquee/npm-update-checker on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Cosaquee/npm-update-checker on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Cosaquee/npm-update-checker [INFO] finished frobbing Cosaquee/npm-update-checker [INFO] frobbed toml for Cosaquee/npm-update-checker written to work/ex/clippy-test-run/sources/stable/gh/Cosaquee/npm-update-checker/Cargo.toml [INFO] started frobbing Cosaquee/npm-update-checker [INFO] finished frobbing Cosaquee/npm-update-checker [INFO] frobbed toml for Cosaquee/npm-update-checker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Cosaquee/npm-update-checker/Cargo.toml [INFO] crate Cosaquee/npm-update-checker has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Cosaquee/npm-update-checker against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Cosaquee/npm-update-checker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b2b0caee2a9c58af979e95c4a9962361b4def5c1bf9e7b7392b66db979362950 [INFO] running `"docker" "start" "-a" "b2b0caee2a9c58af979e95c4a9962361b4def5c1bf9e7b7392b66db979362950"` [INFO] [stderr] Checking humantime v1.1.0 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking env_logger v0.5.4 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.4 [INFO] [stderr] Checking pretty_env_logger v0.2.2 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking npm-updater v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / match version_match { [INFO] [stderr] 67 | | false => println!("{}: Hey, new version that is SemVer incompatible, our: {}, latest {}", name, version, latest_version), [INFO] [stderr] 68 | | true => match vv == latest_version { [INFO] [stderr] 69 | | false => println!("{}: Hey, new SemVer compatible version is out, our: {}, latest: {}", name, version, latest_version), [INFO] [stderr] 70 | | true => return [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 66 | if version_match { match vv == latest_version { [INFO] [stderr] 67 | false => println!("{}: Hey, new SemVer compatible version is out, our: {}, latest: {}", name, version, latest_version), [INFO] [stderr] 68 | true => return [INFO] [stderr] 69 | } } else { println!("{}: Hey, new version that is SemVer incompatible, our: {}, latest {}", name, version, latest_version) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | true => match vv == latest_version { [INFO] [stderr] | _________________^ [INFO] [stderr] 69 | | false => println!("{}: Hey, new SemVer compatible version is out, our: {}, latest: {}", name, version, latest_version), [INFO] [stderr] 70 | | true => return [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if vv == latest_version { return } else { println!("{}: Hey, new SemVer compatible version is out, our: {}, latest: {}", name, version, latest_version) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / match version_match { [INFO] [stderr] 67 | | false => println!("{}: Hey, new version that is SemVer incompatible, our: {}, latest {}", name, version, latest_version), [INFO] [stderr] 68 | | true => match vv == latest_version { [INFO] [stderr] 69 | | false => println!("{}: Hey, new SemVer compatible version is out, our: {}, latest: {}", name, version, latest_version), [INFO] [stderr] 70 | | true => return [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 66 | if version_match { match vv == latest_version { [INFO] [stderr] 67 | false => println!("{}: Hey, new SemVer compatible version is out, our: {}, latest: {}", name, version, latest_version), [INFO] [stderr] 68 | true => return [INFO] [stderr] 69 | } } else { println!("{}: Hey, new version that is SemVer incompatible, our: {}, latest {}", name, version, latest_version) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | true => match vv == latest_version { [INFO] [stderr] | _________________^ [INFO] [stderr] 69 | | false => println!("{}: Hey, new SemVer compatible version is out, our: {}, latest: {}", name, version, latest_version), [INFO] [stderr] 70 | | true => return [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if vv == latest_version { return } else { println!("{}: Hey, new SemVer compatible version is out, our: {}, latest: {}", name, version, latest_version) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.44s [INFO] running `"docker" "inspect" "b2b0caee2a9c58af979e95c4a9962361b4def5c1bf9e7b7392b66db979362950"` [INFO] running `"docker" "rm" "-f" "b2b0caee2a9c58af979e95c4a9962361b4def5c1bf9e7b7392b66db979362950"` [INFO] [stdout] b2b0caee2a9c58af979e95c4a9962361b4def5c1bf9e7b7392b66db979362950