[INFO] updating cached repository Corecii/steam_arguments_launcher [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Corecii/steam_arguments_launcher [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Corecii/steam_arguments_launcher" "work/ex/clippy-test-run/sources/stable/gh/Corecii/steam_arguments_launcher"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Corecii/steam_arguments_launcher'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Corecii/steam_arguments_launcher" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Corecii/steam_arguments_launcher"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Corecii/steam_arguments_launcher'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dfaa547d609ccc5373ab2e576833bbb048281f60 [INFO] sha for GitHub repo Corecii/steam_arguments_launcher: dfaa547d609ccc5373ab2e576833bbb048281f60 [INFO] validating manifest of Corecii/steam_arguments_launcher on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Corecii/steam_arguments_launcher on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Corecii/steam_arguments_launcher [INFO] finished frobbing Corecii/steam_arguments_launcher [INFO] frobbed toml for Corecii/steam_arguments_launcher written to work/ex/clippy-test-run/sources/stable/gh/Corecii/steam_arguments_launcher/Cargo.toml [INFO] started frobbing Corecii/steam_arguments_launcher [INFO] finished frobbing Corecii/steam_arguments_launcher [INFO] frobbed toml for Corecii/steam_arguments_launcher written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Corecii/steam_arguments_launcher/Cargo.toml [INFO] crate Corecii/steam_arguments_launcher has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Corecii/steam_arguments_launcher against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Corecii/steam_arguments_launcher:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 454433dd3fbed593baaf23ebed7cfa615bfdd8d6b1ba8212f6fc1def2ef51135 [INFO] running `"docker" "start" "-a" "454433dd3fbed593baaf23ebed7cfa615bfdd8d6b1ba8212f6fc1def2ef51135"` [INFO] [stderr] Checking steam_arguments_launcher v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / return match read_config(&config_path) { [INFO] [stderr] 60 | | Ok(config) => ConfigState::Found(config, config_path), [INFO] [stderr] 61 | | Err(err) => { [INFO] [stderr] 62 | | println!("{}", err); [INFO] [stderr] 63 | | ConfigState::Error [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 59 | match read_config(&config_path) { [INFO] [stderr] 60 | Ok(config) => ConfigState::Found(config, config_path), [INFO] [stderr] 61 | Err(err) => { [INFO] [stderr] 62 | println!("{}", err); [INFO] [stderr] 63 | ConfigState::Error [INFO] [stderr] 64 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / return match OpenOptions::new().read(true).write(false).open(config_path) { [INFO] [stderr] 70 | | Ok(mut read_file) => { [INFO] [stderr] 71 | | let mut contents = String::new(); [INFO] [stderr] 72 | | match read_file.read_to_string(&mut contents) { [INFO] [stderr] ... | [INFO] [stderr] 82 | | Err(err) => Err(format!("Could not open config file for reading at `{}`\n{}", config_path.to_string_lossy(), err)) [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 69 | match OpenOptions::new().read(true).write(false).open(config_path) { [INFO] [stderr] 70 | Ok(mut read_file) => { [INFO] [stderr] 71 | let mut contents = String::new(); [INFO] [stderr] 72 | match read_file.read_to_string(&mut contents) { [INFO] [stderr] 73 | Ok(_) => { [INFO] [stderr] 74 | match serde_json::from_str(&contents) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | return ConfigureUserResult::Configured; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ConfigureUserResult::Configured` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:129:21 [INFO] [stderr] | [INFO] [stderr] 129 | return ConfigureUserResult::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ConfigureUserResult::Error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | return ConfigureUserResult::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ConfigureUserResult::Error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:157:21 [INFO] [stderr] | [INFO] [stderr] 157 | return ConfigureUserResult::Configured; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ConfigureUserResult::Configured` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:161:21 [INFO] [stderr] | [INFO] [stderr] 161 | return ConfigureUserResult::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ConfigureUserResult::Error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | return ConfigureUserResult::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ConfigureUserResult::Error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / return match read_config(&config_path) { [INFO] [stderr] 60 | | Ok(config) => ConfigState::Found(config, config_path), [INFO] [stderr] 61 | | Err(err) => { [INFO] [stderr] 62 | | println!("{}", err); [INFO] [stderr] 63 | | ConfigState::Error [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 59 | match read_config(&config_path) { [INFO] [stderr] 60 | Ok(config) => ConfigState::Found(config, config_path), [INFO] [stderr] 61 | Err(err) => { [INFO] [stderr] 62 | println!("{}", err); [INFO] [stderr] 63 | ConfigState::Error [INFO] [stderr] 64 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / return match OpenOptions::new().read(true).write(false).open(config_path) { [INFO] [stderr] 70 | | Ok(mut read_file) => { [INFO] [stderr] 71 | | let mut contents = String::new(); [INFO] [stderr] 72 | | match read_file.read_to_string(&mut contents) { [INFO] [stderr] ... | [INFO] [stderr] 82 | | Err(err) => Err(format!("Could not open config file for reading at `{}`\n{}", config_path.to_string_lossy(), err)) [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 69 | match OpenOptions::new().read(true).write(false).open(config_path) { [INFO] [stderr] 70 | Ok(mut read_file) => { [INFO] [stderr] 71 | let mut contents = String::new(); [INFO] [stderr] 72 | match read_file.read_to_string(&mut contents) { [INFO] [stderr] 73 | Ok(_) => { [INFO] [stderr] 74 | match serde_json::from_str(&contents) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | return ConfigureUserResult::Configured; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ConfigureUserResult::Configured` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:129:21 [INFO] [stderr] | [INFO] [stderr] 129 | return ConfigureUserResult::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ConfigureUserResult::Error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | return ConfigureUserResult::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ConfigureUserResult::Error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:157:21 [INFO] [stderr] | [INFO] [stderr] 157 | return ConfigureUserResult::Configured; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ConfigureUserResult::Configured` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:161:21 [INFO] [stderr] | [INFO] [stderr] 161 | return ConfigureUserResult::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ConfigureUserResult::Error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | return ConfigureUserResult::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ConfigureUserResult::Error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | / match env::args().nth(1) { [INFO] [stderr] 204 | | Some(arg) => { [INFO] [stderr] 205 | | if arg == String::from("-steam_game_launch") { [INFO] [stderr] 206 | | run_game(&config, &config_path); [INFO] [stderr] ... | [INFO] [stderr] 210 | | None => () [INFO] [stderr] 211 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 203 | if let Some(arg) = env::args().nth(1) { [INFO] [stderr] 204 | if arg == String::from("-steam_game_launch") { [INFO] [stderr] 205 | run_game(&config, &config_path); [INFO] [stderr] 206 | return; [INFO] [stderr] 207 | } [INFO] [stderr] 208 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:205:31 [INFO] [stderr] | [INFO] [stderr] 205 | if arg == String::from("-steam_game_launch") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"-steam_game_launch"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | / match env::args().nth(1) { [INFO] [stderr] 204 | | Some(arg) => { [INFO] [stderr] 205 | | if arg == String::from("-steam_game_launch") { [INFO] [stderr] 206 | | run_game(&config, &config_path); [INFO] [stderr] ... | [INFO] [stderr] 210 | | None => () [INFO] [stderr] 211 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 203 | if let Some(arg) = env::args().nth(1) { [INFO] [stderr] 204 | if arg == String::from("-steam_game_launch") { [INFO] [stderr] 205 | run_game(&config, &config_path); [INFO] [stderr] 206 | return; [INFO] [stderr] 207 | } [INFO] [stderr] 208 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:205:31 [INFO] [stderr] | [INFO] [stderr] 205 | if arg == String::from("-steam_game_launch") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"-steam_game_launch"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.26s [INFO] running `"docker" "inspect" "454433dd3fbed593baaf23ebed7cfa615bfdd8d6b1ba8212f6fc1def2ef51135"` [INFO] running `"docker" "rm" "-f" "454433dd3fbed593baaf23ebed7cfa615bfdd8d6b1ba8212f6fc1def2ef51135"` [INFO] [stdout] 454433dd3fbed593baaf23ebed7cfa615bfdd8d6b1ba8212f6fc1def2ef51135