[INFO] updating cached repository CoreRC/rcgenmsg
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/CoreRC/rcgenmsg
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/CoreRC/rcgenmsg" "work/ex/clippy-test-run/sources/stable/gh/CoreRC/rcgenmsg"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CoreRC/rcgenmsg'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/CoreRC/rcgenmsg" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CoreRC/rcgenmsg"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CoreRC/rcgenmsg'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 30a891acc54f6c2c9edafc6d3219c7b3f5e0dd07
[INFO] sha for GitHub repo CoreRC/rcgenmsg: 30a891acc54f6c2c9edafc6d3219c7b3f5e0dd07
[INFO] validating manifest of CoreRC/rcgenmsg on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of CoreRC/rcgenmsg on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing CoreRC/rcgenmsg
[INFO] finished frobbing CoreRC/rcgenmsg
[INFO] frobbed toml for CoreRC/rcgenmsg written to work/ex/clippy-test-run/sources/stable/gh/CoreRC/rcgenmsg/Cargo.toml
[INFO] started frobbing CoreRC/rcgenmsg
[INFO] finished frobbing CoreRC/rcgenmsg
[INFO] frobbed toml for CoreRC/rcgenmsg written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CoreRC/rcgenmsg/Cargo.toml
[INFO] crate CoreRC/rcgenmsg has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting CoreRC/rcgenmsg against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/CoreRC/rcgenmsg:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8954882efe3abe139eeec096f8ba506bae2a8d8f30241eb634286c41e4c70ed9
[INFO] running `"docker" "start" "-a" "8954882efe3abe139eeec096f8ba506bae2a8d8f30241eb634286c41e4c70ed9"`
[INFO] [stderr]     Checking Inflector v0.11.3
[INFO] [stderr]     Checking handlebars v1.0.0-beta.2
[INFO] [stderr]     Checking rcgenmsg v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:135:5
[INFO] [stderr]     |
[INFO] [stderr] 135 |     return Some(ast);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(ast)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:189:5
[INFO] [stderr]     |
[INFO] [stderr] 189 |     return typ;
[INFO] [stderr]     |     ^^^^^^^^^^^ help: remove `return` as shown: `typ`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:135:5
[INFO] [stderr]     |
[INFO] [stderr] 135 |     return Some(ast);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(ast)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:189:5
[INFO] [stderr]     |
[INFO] [stderr] 189 |     return typ;
[INFO] [stderr]     |     ^^^^^^^^^^^ help: remove `return` as shown: `typ`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:98:38
[INFO] [stderr]    |
[INFO] [stderr] 98 |                     comment: comment.unwrap_or("".to_string()),
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:125:38
[INFO] [stderr]     |
[INFO] [stderr] 125 |                     comment: comment.unwrap_or("".to_string()),
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:143:5
[INFO] [stderr]     |
[INFO] [stderr] 143 | /     match arr_regex.captures(typ.clone().as_ref()) {
[INFO] [stderr] 144 | |         Some(t) => {
[INFO] [stderr] 145 | |             typ = t[1].to_string();
[INFO] [stderr] 146 | |             is_array = true;
[INFO] [stderr] 147 | |         }
[INFO] [stderr] 148 | |         None => {}
[INFO] [stderr] 149 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 143 |     if let Some(t) = arr_regex.captures(typ.clone().as_ref()) {
[INFO] [stderr] 144 |     typ = t[1].to_string();
[INFO] [stderr] 145 |     is_array = true;
[INFO] [stderr] 146 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:156:19
[INFO] [stderr]     |
[INFO] [stderr] 156 |             typ = str::replace(typ.as_ref(), "int", "Int").into();
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `str::replace(typ.as_ref(), "int", "Int")`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:159:19
[INFO] [stderr]     |
[INFO] [stderr] 159 |             typ = str::replace(typ.as_ref(), "uint", "UInt").into();
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `str::replace(typ.as_ref(), "uint", "UInt")`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:162:19
[INFO] [stderr]     |
[INFO] [stderr] 162 |             typ = str::replace(typ.as_ref(), "float", "Float").into();
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `str::replace(typ.as_ref(), "float", "Float")`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:180:27
[INFO] [stderr]     |
[INFO] [stderr] 180 |                 typ.split("/").collect::<Vec<&str>>()[1]
[INFO] [stderr]     |                           ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in json_data["fields"].as_array_mut().unwrap().enumerate()` or similar iterators
[INFO] [stderr]    --> src/main.rs:259:22
[INFO] [stderr]     |
[INFO] [stderr] 259 |         for mut f in json_data["fields"].as_array_mut().unwrap() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in json_data["consts"].as_array_mut().unwrap().enumerate()` or similar iterators
[INFO] [stderr]    --> src/main.rs:282:22
[INFO] [stderr]     |
[INFO] [stderr] 282 |         for mut f in json_data["consts"].as_array_mut().unwrap() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:343:5
[INFO] [stderr]     |
[INFO] [stderr] 343 | /     match file.read_to_string(&mut s) {
[INFO] [stderr] 344 | |         Err(why) => panic!("couldn't read {}: {}", display, why.description()),
[INFO] [stderr] 345 | |         Ok(_) => (),
[INFO] [stderr] 346 | |     }
[INFO] [stderr]     | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, why.description()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:98:38
[INFO] [stderr]    |
[INFO] [stderr] 98 |                     comment: comment.unwrap_or("".to_string()),
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:125:38
[INFO] [stderr]     |
[INFO] [stderr] 125 |                     comment: comment.unwrap_or("".to_string()),
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:143:5
[INFO] [stderr]     |
[INFO] [stderr] 143 | /     match arr_regex.captures(typ.clone().as_ref()) {
[INFO] [stderr] 144 | |         Some(t) => {
[INFO] [stderr] 145 | |             typ = t[1].to_string();
[INFO] [stderr] 146 | |             is_array = true;
[INFO] [stderr] 147 | |         }
[INFO] [stderr] 148 | |         None => {}
[INFO] [stderr] 149 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 143 |     if let Some(t) = arr_regex.captures(typ.clone().as_ref()) {
[INFO] [stderr] 144 |     typ = t[1].to_string();
[INFO] [stderr] 145 |     is_array = true;
[INFO] [stderr] 146 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:156:19
[INFO] [stderr]     |
[INFO] [stderr] 156 |             typ = str::replace(typ.as_ref(), "int", "Int").into();
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `str::replace(typ.as_ref(), "int", "Int")`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:159:19
[INFO] [stderr]     |
[INFO] [stderr] 159 |             typ = str::replace(typ.as_ref(), "uint", "UInt").into();
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `str::replace(typ.as_ref(), "uint", "UInt")`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:162:19
[INFO] [stderr]     |
[INFO] [stderr] 162 |             typ = str::replace(typ.as_ref(), "float", "Float").into();
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `str::replace(typ.as_ref(), "float", "Float")`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:180:27
[INFO] [stderr]     |
[INFO] [stderr] 180 |                 typ.split("/").collect::<Vec<&str>>()[1]
[INFO] [stderr]     |                           ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in json_data["fields"].as_array_mut().unwrap().enumerate()` or similar iterators
[INFO] [stderr]    --> src/main.rs:259:22
[INFO] [stderr]     |
[INFO] [stderr] 259 |         for mut f in json_data["fields"].as_array_mut().unwrap() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in json_data["consts"].as_array_mut().unwrap().enumerate()` or similar iterators
[INFO] [stderr]    --> src/main.rs:282:22
[INFO] [stderr]     |
[INFO] [stderr] 282 |         for mut f in json_data["consts"].as_array_mut().unwrap() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:343:5
[INFO] [stderr]     |
[INFO] [stderr] 343 | /     match file.read_to_string(&mut s) {
[INFO] [stderr] 344 | |         Err(why) => panic!("couldn't read {}: {}", display, why.description()),
[INFO] [stderr] 345 | |         Ok(_) => (),
[INFO] [stderr] 346 | |     }
[INFO] [stderr]     | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, why.description()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:380:5
[INFO] [stderr]     |
[INFO] [stderr] 380 | /     match file.read_to_string(&mut s) {
[INFO] [stderr] 381 | |         Err(why) => panic!("couldn't read {}: {}", display, why.description()),
[INFO] [stderr] 382 | |         Ok(_) => (),
[INFO] [stderr] 383 | |     }
[INFO] [stderr]     | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, why.description()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 6.88s
[INFO] running `"docker" "inspect" "8954882efe3abe139eeec096f8ba506bae2a8d8f30241eb634286c41e4c70ed9"`
[INFO] running `"docker" "rm" "-f" "8954882efe3abe139eeec096f8ba506bae2a8d8f30241eb634286c41e4c70ed9"`
[INFO] [stdout] 8954882efe3abe139eeec096f8ba506bae2a8d8f30241eb634286c41e4c70ed9