[INFO] updating cached repository ConnyOnny/sdfgen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ConnyOnny/sdfgen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ConnyOnny/sdfgen" "work/ex/clippy-test-run/sources/stable/gh/ConnyOnny/sdfgen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ConnyOnny/sdfgen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ConnyOnny/sdfgen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ConnyOnny/sdfgen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ConnyOnny/sdfgen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6ad7987ebc39ebad03d87f69a92df4e345d7d8bc [INFO] sha for GitHub repo ConnyOnny/sdfgen: 6ad7987ebc39ebad03d87f69a92df4e345d7d8bc [INFO] validating manifest of ConnyOnny/sdfgen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ConnyOnny/sdfgen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ConnyOnny/sdfgen [INFO] finished frobbing ConnyOnny/sdfgen [INFO] frobbed toml for ConnyOnny/sdfgen written to work/ex/clippy-test-run/sources/stable/gh/ConnyOnny/sdfgen/Cargo.toml [INFO] started frobbing ConnyOnny/sdfgen [INFO] finished frobbing ConnyOnny/sdfgen [INFO] frobbed toml for ConnyOnny/sdfgen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ConnyOnny/sdfgen/Cargo.toml [INFO] crate ConnyOnny/sdfgen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ConnyOnny/sdfgen against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ConnyOnny/sdfgen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5538179ffd812841d0a7f4a9513d53c452dddc01b890f32b1e6826fddec18d08 [INFO] running `"docker" "start" "-a" "5538179ffd812841d0a7f4a9513d53c452dddc01b890f32b1e6826fddec18d08"` [INFO] [stderr] Checking sdfgen v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mipmap.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | UniSquare{topleft:topleft,length:length} [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `topleft` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mipmap.rs:51:29 [INFO] [stderr] | [INFO] [stderr] 51 | UniSquare{topleft:topleft,length:length} [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mipmap.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | UniSquare{topleft:topleft,length:length} [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `topleft` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mipmap.rs:51:29 [INFO] [stderr] | [INFO] [stderr] 51 | UniSquare{topleft:topleft,length:length} [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sdf_algorithm.rs:96:7 [INFO] [stderr] | [INFO] [stderr] 96 | let mut child_tasks_slice = &mut child_tasks[0..child_tasks_idx]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mipmap.rs:78:22 [INFO] [stderr] | [INFO] [stderr] 78 | let sizelog = log2(width as u64).expect("image dimensions must be a power of two"); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/mipmap.rs:81:12 [INFO] [stderr] | [INFO] [stderr] 81 | for i in 1..sizelog+1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `1..=sizelog` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mipmap.rs:85:41 [INFO] [stderr] | [INFO] [stderr] 85 | assert_eq!(bigimg.dimensions(), (1< src/mipmap.rs:85:63 [INFO] [stderr] | [INFO] [stderr] 85 | assert_eq!(bigimg.dimensions(), (1< src/mipmap.rs:94:29 [INFO] [stderr] | [INFO] [stderr] 94 | ImageBuffer::from_fn(1< src/mipmap.rs:94:53 [INFO] [stderr] | [INFO] [stderr] 94 | ImageBuffer::from_fn(1< src/sdf_algorithm.rs:20:11 [INFO] [stderr] | [INFO] [stderr] 20 | let dx = (p1.x as i32 - p2.x as i32) as DstT; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(p1.x as i32 - p2.x as i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:21:11 [INFO] [stderr] | [INFO] [stderr] 21 | let dy = (p1.y as i32 - p2.y as i32) as DstT; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(p1.y as i32 - p2.y as i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:42:38 [INFO] [stderr] | [INFO] [stderr] 42 | dst = dst / max_expressable_dst * (127 as DstT); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(127)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | if dst < (-127 as DstT) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(-127)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:44:11 [INFO] [stderr] | [INFO] [stderr] 44 | dst = -127 as DstT; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(-127)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | } else if dst > (127 as DstT) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(127)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:46:11 [INFO] [stderr] | [INFO] [stderr] 46 | dst = 127 as DstT; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(127)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | debug_assert!(dst <= ( 127 as DstT)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(127)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:49:25 [INFO] [stderr] | [INFO] [stderr] 49 | debug_assert!(dst >= (-127 as DstT)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(-127)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/sdf_algorithm.rs:66:1 [INFO] [stderr] | [INFO] [stderr] 66 | / fn calculate_sdf_at_rec(mm: &Arc, x: u32, y:u32, dst_level: u8, best_dst_sqr_input: DstT, task: &SdfTask, needed: u8, pxpos: &UniPoint) -> DstT { [INFO] [stderr] 67 | | debug_assert!(task.best_case_dst_sqr < best_dst_sqr_input); // if not we shouldn't have been called [INFO] [stderr] 68 | | debug_assert!(has_needed(mmget(mm,task.x,task.y,task.level), needed)); [INFO] [stderr] 69 | | let mut best_dst_sqr = best_dst_sqr_input; [INFO] [stderr] ... | [INFO] [stderr] 107 | | best_dst_sqr [INFO] [stderr] 108 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/sdf_algorithm.rs:74:23 [INFO] [stderr] | [INFO] [stderr] 74 | for tup in children.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/sdf_algorithm.rs:86:23 [INFO] [stderr] | [INFO] [stderr] 86 | for tup in children.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:114:63 [INFO] [stderr] | [INFO] [stderr] 114 | let best_dst_sqr = calculate_sdf_at_rec(mm, x, y, dst_level, f32::INFINITY as DstT, &task, get_needed(pxval), &pxpos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(f32::INFINITY)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:118:15 [INFO] [stderr] | [INFO] [stderr] 118 | best_dst *= -1 as DstT; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:142:14 [INFO] [stderr] | [INFO] [stderr] 142 | let inf = f32::INFINITY as DstT; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(f32::INFINITY)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | let neginf = f32::NEG_INFINITY as DstT; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(f32::NEG_INFINITY)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:148:44 [INFO] [stderr] | [INFO] [stderr] 148 | let dst_level = mm.get_max_level() - log2(size as u64).expect("destination size must be a power of two"); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/sdf_task.rs:22:2 [INFO] [stderr] | [INFO] [stderr] 22 | fn ne (&self, other: &Self) -> bool { [INFO] [stderr] | _____^ [INFO] [stderr] 23 | | !self.eq(other) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:64:27 [INFO] [stderr] | [INFO] [stderr] 64 | let shiftedi : u64 = 1< src/sdf_algorithm.rs:96:7 [INFO] [stderr] | [INFO] [stderr] 96 | let mut child_tasks_slice = &mut child_tasks[0..child_tasks_idx]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mipmap.rs:78:22 [INFO] [stderr] | [INFO] [stderr] 78 | let sizelog = log2(width as u64).expect("image dimensions must be a power of two"); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/mipmap.rs:81:12 [INFO] [stderr] | [INFO] [stderr] 81 | for i in 1..sizelog+1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `1..=sizelog` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mipmap.rs:85:41 [INFO] [stderr] | [INFO] [stderr] 85 | assert_eq!(bigimg.dimensions(), (1< src/mipmap.rs:85:63 [INFO] [stderr] | [INFO] [stderr] 85 | assert_eq!(bigimg.dimensions(), (1< src/mipmap.rs:94:29 [INFO] [stderr] | [INFO] [stderr] 94 | ImageBuffer::from_fn(1< src/mipmap.rs:94:53 [INFO] [stderr] | [INFO] [stderr] 94 | ImageBuffer::from_fn(1< src/sdf_algorithm.rs:20:11 [INFO] [stderr] | [INFO] [stderr] 20 | let dx = (p1.x as i32 - p2.x as i32) as DstT; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(p1.x as i32 - p2.x as i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:21:11 [INFO] [stderr] | [INFO] [stderr] 21 | let dy = (p1.y as i32 - p2.y as i32) as DstT; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(p1.y as i32 - p2.y as i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:42:38 [INFO] [stderr] | [INFO] [stderr] 42 | dst = dst / max_expressable_dst * (127 as DstT); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(127)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | if dst < (-127 as DstT) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(-127)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:44:11 [INFO] [stderr] | [INFO] [stderr] 44 | dst = -127 as DstT; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(-127)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | } else if dst > (127 as DstT) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(127)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:46:11 [INFO] [stderr] | [INFO] [stderr] 46 | dst = 127 as DstT; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(127)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | debug_assert!(dst <= ( 127 as DstT)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(127)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:49:25 [INFO] [stderr] | [INFO] [stderr] 49 | debug_assert!(dst >= (-127 as DstT)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(-127)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/sdf_algorithm.rs:66:1 [INFO] [stderr] | [INFO] [stderr] 66 | / fn calculate_sdf_at_rec(mm: &Arc, x: u32, y:u32, dst_level: u8, best_dst_sqr_input: DstT, task: &SdfTask, needed: u8, pxpos: &UniPoint) -> DstT { [INFO] [stderr] 67 | | debug_assert!(task.best_case_dst_sqr < best_dst_sqr_input); // if not we shouldn't have been called [INFO] [stderr] 68 | | debug_assert!(has_needed(mmget(mm,task.x,task.y,task.level), needed)); [INFO] [stderr] 69 | | let mut best_dst_sqr = best_dst_sqr_input; [INFO] [stderr] ... | [INFO] [stderr] 107 | | best_dst_sqr [INFO] [stderr] 108 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/sdf_algorithm.rs:74:23 [INFO] [stderr] | [INFO] [stderr] 74 | for tup in children.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/sdf_algorithm.rs:86:23 [INFO] [stderr] | [INFO] [stderr] 86 | for tup in children.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:114:63 [INFO] [stderr] | [INFO] [stderr] 114 | let best_dst_sqr = calculate_sdf_at_rec(mm, x, y, dst_level, f32::INFINITY as DstT, &task, get_needed(pxval), &pxpos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(f32::INFINITY)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:118:15 [INFO] [stderr] | [INFO] [stderr] 118 | best_dst *= -1 as DstT; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:142:14 [INFO] [stderr] | [INFO] [stderr] 142 | let inf = f32::INFINITY as DstT; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(f32::INFINITY)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | let neginf = f32::NEG_INFINITY as DstT; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(f32::NEG_INFINITY)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sdf_algorithm.rs:148:44 [INFO] [stderr] | [INFO] [stderr] 148 | let dst_level = mm.get_max_level() - log2(size as u64).expect("destination size must be a power of two"); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/sdf_task.rs:22:2 [INFO] [stderr] | [INFO] [stderr] 22 | fn ne (&self, other: &Self) -> bool { [INFO] [stderr] | _____^ [INFO] [stderr] 23 | | !self.eq(other) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:64:27 [INFO] [stderr] | [INFO] [stderr] 64 | let shiftedi : u64 = 1<