[INFO] updating cached repository ConnorMinielly/Piston-Test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ConnorMinielly/Piston-Test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ConnorMinielly/Piston-Test" "work/ex/clippy-test-run/sources/stable/gh/ConnorMinielly/Piston-Test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ConnorMinielly/Piston-Test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ConnorMinielly/Piston-Test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ConnorMinielly/Piston-Test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ConnorMinielly/Piston-Test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 92ab111c586bede5c4ebba6ab9c42d7640ac331e [INFO] sha for GitHub repo ConnorMinielly/Piston-Test: 92ab111c586bede5c4ebba6ab9c42d7640ac331e [INFO] validating manifest of ConnorMinielly/Piston-Test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ConnorMinielly/Piston-Test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ConnorMinielly/Piston-Test [INFO] finished frobbing ConnorMinielly/Piston-Test [INFO] frobbed toml for ConnorMinielly/Piston-Test written to work/ex/clippy-test-run/sources/stable/gh/ConnorMinielly/Piston-Test/Cargo.toml [INFO] started frobbing ConnorMinielly/Piston-Test [INFO] finished frobbing ConnorMinielly/Piston-Test [INFO] frobbed toml for ConnorMinielly/Piston-Test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ConnorMinielly/Piston-Test/Cargo.toml [INFO] crate ConnorMinielly/Piston-Test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ConnorMinielly/Piston-Test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ConnorMinielly/Piston-Test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f5959570ce1193bef150336e78d1812778f2c5ef2c3ca91e4b0a22d1476f8af3 [INFO] running `"docker" "start" "-a" "f5959570ce1193bef150336e78d1812778f2c5ef2c3ca91e4b0a22d1476f8af3"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `spinning-square`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Compiling serde v1.0.58 [INFO] [stderr] Compiling syn v0.13.11 [INFO] [stderr] Checking x11-dl v2.17.5 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Compiling serde_derive v1.0.58 [INFO] [stderr] Compiling num-derive v0.2.1 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking glutin v0.14.0 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.53.0 [INFO] [stderr] Checking pistoncore-window v0.31.0 [INFO] [stderr] Checking pistoncore-event_loop v0.36.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.46.0 [INFO] [stderr] Checking piston v0.36.0 [INFO] [stderr] Checking piston_start v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | let (x, y) = ((args.width / 2) as f64, (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:26:48 [INFO] [stderr] | [INFO] [stderr] 26 | let (x, y) = ((args.width / 2) as f64, (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | let (x, y) = ((args.width / 2) as f64, (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:26:48 [INFO] [stderr] | [INFO] [stderr] 26 | let (x, y) = ((args.width / 2) as f64, (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 40.07s [INFO] running `"docker" "inspect" "f5959570ce1193bef150336e78d1812778f2c5ef2c3ca91e4b0a22d1476f8af3"` [INFO] running `"docker" "rm" "-f" "f5959570ce1193bef150336e78d1812778f2c5ef2c3ca91e4b0a22d1476f8af3"` [INFO] [stdout] f5959570ce1193bef150336e78d1812778f2c5ef2c3ca91e4b0a22d1476f8af3