[INFO] updating cached repository ConceptsDemo/rust-example [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ConceptsDemo/rust-example [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ConceptsDemo/rust-example" "work/ex/clippy-test-run/sources/stable/gh/ConceptsDemo/rust-example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ConceptsDemo/rust-example'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ConceptsDemo/rust-example" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ConceptsDemo/rust-example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ConceptsDemo/rust-example'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8d400f89e275040a5947640679df9a477d368595 [INFO] sha for GitHub repo ConceptsDemo/rust-example: 8d400f89e275040a5947640679df9a477d368595 [INFO] validating manifest of ConceptsDemo/rust-example on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ConceptsDemo/rust-example on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ConceptsDemo/rust-example [INFO] finished frobbing ConceptsDemo/rust-example [INFO] frobbed toml for ConceptsDemo/rust-example written to work/ex/clippy-test-run/sources/stable/gh/ConceptsDemo/rust-example/Cargo.toml [INFO] started frobbing ConceptsDemo/rust-example [INFO] finished frobbing ConceptsDemo/rust-example [INFO] frobbed toml for ConceptsDemo/rust-example written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ConceptsDemo/rust-example/Cargo.toml [INFO] crate ConceptsDemo/rust-example has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ConceptsDemo/rust-example against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ConceptsDemo/rust-example:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d1c43343f51b6626b537aca63e20d7e33f8419cb60233f56b4fada88384311e5 [INFO] running `"docker" "start" "-a" "d1c43343f51b6626b537aca63e20d7e33f8419cb60233f56b4fada88384311e5"` [INFO] [stderr] Checking rust-example v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `f32`, `i16`, `i64`, `u16`, `u64`, `u8`, `usize` [INFO] [stderr] --> src/main.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | use std::{i8, i16, i32, i64, u8, u16, u32, u64, f32, f64, isize, usize}; [INFO] [stderr] | ^^^ ^^^ ^^ ^^^ ^^^ ^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:188:2 [INFO] [stderr] | [INFO] [stderr] 188 | return num1 + num2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `num1 + num2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:193:2 [INFO] [stderr] | [INFO] [stderr] 193 | return sum; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `age` [INFO] [stderr] --> src/main.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | let mut age : u32 = 100; [INFO] [stderr] | ^^^ help: consider using `_age` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/main.rs:64:6 [INFO] [stderr] | [INFO] [stderr] 64 | let count = rand_string.chars().count(); [INFO] [stderr] | ^^^^^ help: consider using `_count` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rand_tuple` [INFO] [stderr] --> src/main.rs:134:6 [INFO] [stderr] | [INFO] [stderr] 134 | let rand_tuple = ("Vancir", 30); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_rand_tuple` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `quicksilver` [INFO] [stderr] --> src/main.rs:172:6 [INFO] [stderr] | [INFO] [stderr] 172 | let quicksilver = Hero::Fast; [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_quicksilver` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | let mut age : u32 = 100; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:18:6 [INFO] [stderr] | [INFO] [stderr] 18 | let mut var = -4i32; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:153:6 [INFO] [stderr] | [INFO] [stderr] 153 | let mut circle1 = Circle { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:166:6 [INFO] [stderr] | [INFO] [stderr] 166 | let mut rect1 = Rectangle { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] error: approximate value of `f64::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:31:33 [INFO] [stderr] | [INFO] [stderr] 31 | println!("PI to degrees = {}", 3.14f64.to_degrees()); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | let can_vote = if 10 >= 18 {true} else {false}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `10 >= 18` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:68:2 [INFO] [stderr] | [INFO] [stderr] 68 | loop { [INFO] [stderr] | _____^ [INFO] [stderr] 69 | | match indiv_char { [INFO] [stderr] 70 | | Some(x) => println!("{}", x), [INFO] [stderr] 71 | | None => break [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | indiv_char = chars.next(); [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(x) = indiv_char { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:81:2 [INFO] [stderr] | [INFO] [stderr] 81 | loop { [INFO] [stderr] | _____^ [INFO] [stderr] 82 | | match indiv_line { [INFO] [stderr] 83 | | Some(x) => println!("{}", x), [INFO] [stderr] 84 | | None => break [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | indiv_line = lines.next(); [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(x) = indiv_line { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/main.rs:100:30 [INFO] [stderr] | [INFO] [stderr] 100 | let guess : Option = input.ok().map_or(None, |_| line.trim().parse().ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `input.ok().and_then(|_| line.trim().parse().ok())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:191:19 [INFO] [stderr] | [INFO] [stderr] 191 | fn sum_vects(v1 : &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:223:3 [INFO] [stderr] | [INFO] [stderr] 223 | 3.14159 * (self.radius * self.radius) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-example`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused imports: `f32`, `i16`, `i64`, `u16`, `u64`, `u8`, `usize` [INFO] [stderr] --> src/main.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | use std::{i8, i16, i32, i64, u8, u16, u32, u64, f32, f64, isize, usize}; [INFO] [stderr] | ^^^ ^^^ ^^ ^^^ ^^^ ^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:188:2 [INFO] [stderr] | [INFO] [stderr] 188 | return num1 + num2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `num1 + num2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:193:2 [INFO] [stderr] | [INFO] [stderr] 193 | return sum; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `age` [INFO] [stderr] --> src/main.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | let mut age : u32 = 100; [INFO] [stderr] | ^^^ help: consider using `_age` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/main.rs:64:6 [INFO] [stderr] | [INFO] [stderr] 64 | let count = rand_string.chars().count(); [INFO] [stderr] | ^^^^^ help: consider using `_count` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rand_tuple` [INFO] [stderr] --> src/main.rs:134:6 [INFO] [stderr] | [INFO] [stderr] 134 | let rand_tuple = ("Vancir", 30); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_rand_tuple` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `quicksilver` [INFO] [stderr] --> src/main.rs:172:6 [INFO] [stderr] | [INFO] [stderr] 172 | let quicksilver = Hero::Fast; [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_quicksilver` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | let mut age : u32 = 100; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:18:6 [INFO] [stderr] | [INFO] [stderr] 18 | let mut var = -4i32; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:153:6 [INFO] [stderr] | [INFO] [stderr] 153 | let mut circle1 = Circle { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:166:6 [INFO] [stderr] | [INFO] [stderr] 166 | let mut rect1 = Rectangle { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] error: approximate value of `f64::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:31:33 [INFO] [stderr] | [INFO] [stderr] 31 | println!("PI to degrees = {}", 3.14f64.to_degrees()); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | let can_vote = if 10 >= 18 {true} else {false}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `10 >= 18` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:68:2 [INFO] [stderr] | [INFO] [stderr] 68 | loop { [INFO] [stderr] | _____^ [INFO] [stderr] 69 | | match indiv_char { [INFO] [stderr] 70 | | Some(x) => println!("{}", x), [INFO] [stderr] 71 | | None => break [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | indiv_char = chars.next(); [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(x) = indiv_char { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:81:2 [INFO] [stderr] | [INFO] [stderr] 81 | loop { [INFO] [stderr] | _____^ [INFO] [stderr] 82 | | match indiv_line { [INFO] [stderr] 83 | | Some(x) => println!("{}", x), [INFO] [stderr] 84 | | None => break [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | indiv_line = lines.next(); [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(x) = indiv_line { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/main.rs:100:30 [INFO] [stderr] | [INFO] [stderr] 100 | let guess : Option = input.ok().map_or(None, |_| line.trim().parse().ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `input.ok().and_then(|_| line.trim().parse().ok())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:191:19 [INFO] [stderr] | [INFO] [stderr] 191 | fn sum_vects(v1 : &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:223:3 [INFO] [stderr] | [INFO] [stderr] 223 | 3.14159 * (self.radius * self.radius) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-example`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d1c43343f51b6626b537aca63e20d7e33f8419cb60233f56b4fada88384311e5"` [INFO] running `"docker" "rm" "-f" "d1c43343f51b6626b537aca63e20d7e33f8419cb60233f56b4fada88384311e5"` [INFO] [stdout] d1c43343f51b6626b537aca63e20d7e33f8419cb60233f56b4fada88384311e5