[INFO] updating cached repository CollinValley/rust_practice
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/CollinValley/rust_practice
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/CollinValley/rust_practice" "work/ex/clippy-test-run/sources/stable/gh/CollinValley/rust_practice"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CollinValley/rust_practice'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/CollinValley/rust_practice" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CollinValley/rust_practice"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CollinValley/rust_practice'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e13912bf1c7e6b188dbf57b9a25f399b421816a2
[INFO] sha for GitHub repo CollinValley/rust_practice: e13912bf1c7e6b188dbf57b9a25f399b421816a2
[INFO] validating manifest of CollinValley/rust_practice on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of CollinValley/rust_practice on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing CollinValley/rust_practice
[INFO] finished frobbing CollinValley/rust_practice
[INFO] frobbed toml for CollinValley/rust_practice written to work/ex/clippy-test-run/sources/stable/gh/CollinValley/rust_practice/Cargo.toml
[INFO] started frobbing CollinValley/rust_practice
[INFO] finished frobbing CollinValley/rust_practice
[INFO] frobbed toml for CollinValley/rust_practice written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CollinValley/rust_practice/Cargo.toml
[INFO] crate CollinValley/rust_practice has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting CollinValley/rust_practice against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/CollinValley/rust_practice:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e2fea6e5890c247dc3f3e2af3cf2d826d0f99eca983e3014ff28ead4ce4bdf55
[INFO] running `"docker" "start" "-a" "e2fea6e5890c247dc3f3e2af3cf2d826d0f99eca983e3014ff28ead4ce4bdf55"`
[INFO] [stderr]     Checking num-complex v0.2.1
[INFO] [stderr]     Checking num v0.2.0
[INFO] [stderr]     Checking rust_practice v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: struct is never constructed: `Extrema`
[INFO] [stderr]    --> src/chapter_9.rs:157:1
[INFO] [stderr]     |
[INFO] [stderr] 157 | struct Extrema<'elt> {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `find_extrema`
[INFO] [stderr]    --> src/chapter_9.rs:162:1
[INFO] [stderr]     |
[INFO] [stderr] 162 | fn find_extrema<'s>(slice: &'s [i32]) -> Extrema<'s> {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `say_hello`
[INFO] [stderr]  --> src/chapter_11.rs:6:1
[INFO] [stderr]   |
[INFO] [stderr] 6 | fn say_hello(out: &mut Write) -> std::io::Result<()> {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `min`
[INFO] [stderr]   --> src/chapter_11.rs:32:1
[INFO] [stderr]    |
[INFO] [stderr] 32 | fn min<T: Ord>(value1: T, value2: T) -> T {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `dot`
[INFO] [stderr]    --> src/chapter_11.rs:199:1
[INFO] [stderr]     |
[INFO] [stderr] 199 | / fn dot<N>(v1: &[N], v2: &[N]) -> N
[INFO] [stderr] 200 | |     where N: Add<Output=N> + Mul<Output=N> + Default + Copy
[INFO] [stderr] 201 | | {
[INFO] [stderr] 202 | |     let mut total = N::default(); //All numerical types default will equal 0
[INFO] [stderr] ...   |
[INFO] [stderr] 206 | |     total
[INFO] [stderr] 207 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `chapter_9::Queue`
[INFO] [stderr]   --> src/chapter_9.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 | /     pub fn new() -> Queue {
[INFO] [stderr] 12 | |         Queue {older: Vec::new(), younger: Vec::new() }
[INFO] [stderr] 13 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 3  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `chapter_9::GQueue<T>`
[INFO] [stderr]   --> src/chapter_9.rs:95:5
[INFO] [stderr]    |
[INFO] [stderr] 95 | /     pub fn new() -> Self {
[INFO] [stderr] 96 | |         GQueue {older: Vec::new(), younger: Vec::new() }
[INFO] [stderr] 97 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 87 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/chapter_9.rs:162:1
[INFO] [stderr]     |
[INFO] [stderr] 162 | / fn find_extrema<'s>(slice: &'s [i32]) -> Extrema<'s> {
[INFO] [stderr] 163 | |     let mut greatest = &slice[0];
[INFO] [stderr] 164 | |     let mut least = &slice[0];
[INFO] [stderr] 165 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 170 | |     Extrema {greatest, least }
[INFO] [stderr] 171 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `slice`.
[INFO] [stderr]    --> src/chapter_9.rs:166:14
[INFO] [stderr]     |
[INFO] [stderr] 166 |     for i in 1..slice.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 166 |     for <item> in slice.iter().skip(1) {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/chapter_10.rs:114:13
[INFO] [stderr]     |
[INFO] [stderr] 114 |             format!("just now"),
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"just now".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `chapter_9::Queue`
[INFO] [stderr]   --> src/chapter_9.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 | /     pub fn new() -> Queue {
[INFO] [stderr] 12 | |         Queue {older: Vec::new(), younger: Vec::new() }
[INFO] [stderr] 13 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 3  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `chapter_9::GQueue<T>`
[INFO] [stderr]   --> src/chapter_9.rs:95:5
[INFO] [stderr]    |
[INFO] [stderr] 95 | /     pub fn new() -> Self {
[INFO] [stderr] 96 | |         GQueue {older: Vec::new(), younger: Vec::new() }
[INFO] [stderr] 97 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 87 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/chapter_9.rs:162:1
[INFO] [stderr]     |
[INFO] [stderr] 162 | / fn find_extrema<'s>(slice: &'s [i32]) -> Extrema<'s> {
[INFO] [stderr] 163 | |     let mut greatest = &slice[0];
[INFO] [stderr] 164 | |     let mut least = &slice[0];
[INFO] [stderr] 165 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 170 | |     Extrema {greatest, least }
[INFO] [stderr] 171 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `slice`.
[INFO] [stderr]    --> src/chapter_9.rs:166:14
[INFO] [stderr]     |
[INFO] [stderr] 166 |     for i in 1..slice.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 166 |     for <item> in slice.iter().skip(1) {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/chapter_10.rs:114:13
[INFO] [stderr]     |
[INFO] [stderr] 114 |             format!("just now"),
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"just now".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/chapter_11.rs:212:5
[INFO] [stderr]     |
[INFO] [stderr] 212 |     assert_eq!(dot(&[53.0, 7.0], &[1.0, 5.0]), 88.0);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/chapter_11.rs:212:5
[INFO] [stderr]     |
[INFO] [stderr] 212 |     assert_eq!(dot(&[53.0, 7.0], &[1.0, 5.0]), 88.0);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rust_practice`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "e2fea6e5890c247dc3f3e2af3cf2d826d0f99eca983e3014ff28ead4ce4bdf55"`
[INFO] running `"docker" "rm" "-f" "e2fea6e5890c247dc3f3e2af3cf2d826d0f99eca983e3014ff28ead4ce4bdf55"`
[INFO] [stdout] e2fea6e5890c247dc3f3e2af3cf2d826d0f99eca983e3014ff28ead4ce4bdf55