[INFO] updating cached repository CoiledSpring/zsteamy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/CoiledSpring/zsteamy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/CoiledSpring/zsteamy" "work/ex/clippy-test-run/sources/stable/gh/CoiledSpring/zsteamy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CoiledSpring/zsteamy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/CoiledSpring/zsteamy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CoiledSpring/zsteamy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CoiledSpring/zsteamy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 18ece811433f6c85a487faee0a95b20113f5adc8 [INFO] sha for GitHub repo CoiledSpring/zsteamy: 18ece811433f6c85a487faee0a95b20113f5adc8 [INFO] validating manifest of CoiledSpring/zsteamy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of CoiledSpring/zsteamy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing CoiledSpring/zsteamy [INFO] finished frobbing CoiledSpring/zsteamy [INFO] frobbed toml for CoiledSpring/zsteamy written to work/ex/clippy-test-run/sources/stable/gh/CoiledSpring/zsteamy/Cargo.toml [INFO] started frobbing CoiledSpring/zsteamy [INFO] finished frobbing CoiledSpring/zsteamy [INFO] frobbed toml for CoiledSpring/zsteamy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CoiledSpring/zsteamy/Cargo.toml [INFO] crate CoiledSpring/zsteamy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting CoiledSpring/zsteamy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/CoiledSpring/zsteamy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b1b55c0d2d6bc9e0be00eef738ccdd576a55ea6c71fff34e50e02dc0d47d5afd [INFO] running `"docker" "start" "-a" "b1b55c0d2d6bc9e0be00eef738ccdd576a55ea6c71fff34e50e02dc0d47d5afd"` [INFO] [stderr] Checking zsteamy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | pc: pc, [INFO] [stderr] | ^^^^^^ help: replace it with: `pc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | base_hm: base_hm, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `base_hm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | base_sm: base_sm, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `base_sm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | pos_gv: pos_gv, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pos_gv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | pos_ob: pos_ob, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pos_ob` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | pos_ab: pos_ab [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pos_ab` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/machine.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | let x = self.read_byte(address); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/opcode.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | operands: operands [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `operands` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | pc: pc, [INFO] [stderr] | ^^^^^^ help: replace it with: `pc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | base_hm: base_hm, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `base_hm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | base_sm: base_sm, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `base_sm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | pos_gv: pos_gv, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pos_gv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | pos_ob: pos_ob, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pos_ob` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | pos_ab: pos_ab [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pos_ab` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/machine.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | let x = self.read_byte(address); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/opcode.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | operands: operands [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `operands` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/instructions.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | let b = (op.operands[1].get_value(machine) as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/instructions.rs:187:24 [INFO] [stderr] | [INFO] [stderr] 187 | machine.write_byte((base + off), value as u8); [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/instructions.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | let b = (op.operands[1].get_value(machine) as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/instructions.rs:187:24 [INFO] [stderr] | [INFO] [stderr] 187 | machine.write_byte((base + off), value as u8); [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused variable: `machine` [INFO] [stderr] --> src/instructions.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | fn z_newline(_: Opcode, machine: &mut Machine) { [INFO] [stderr] | ^^^^^^^ help: consider using `_machine` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_object_parent` [INFO] [stderr] --> src/machine.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn set_object_parent(&mut self, n: u8, v: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_object_attribute` [INFO] [stderr] --> src/machine.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | pub fn set_object_attribute(&mut self, n: u8, attr: u8, v: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_object_sibling` [INFO] [stderr] --> src/machine.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | pub fn get_object_sibling(&mut self, n: u8) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `machine` [INFO] [stderr] --> src/instructions.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | fn z_newline(_: Opcode, machine: &mut Machine) { [INFO] [stderr] | ^^^^^^^ help: consider using `_machine` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | machine.store(p1 as u16); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(p1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:69:19 [INFO] [stderr] | [INFO] [stderr] 69 | machine.store(c1 as u16); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(c1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:133:19 [INFO] [stderr] | [INFO] [stderr] 133 | machine.store(value as u16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:162:19 [INFO] [stderr] | [INFO] [stderr] 162 | let address = (op.operands[0].get_value(machine) as u32) << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(op.operands[0].get_value(machine))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | let pc = buffer.read_word(0x06) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buffer.read_word(0x06))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_object_parent` [INFO] [stderr] --> src/machine.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn set_object_parent(&mut self, n: u8, v: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `params` [INFO] [stderr] --> src/machine.rs:259:18 [INFO] [stderr] | [INFO] [stderr] 259 | for i in 0..params.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 259 | for (i, ) in params.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_object_attribute` [INFO] [stderr] --> src/machine.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | pub fn set_object_attribute(&mut self, n: u8, attr: u8, v: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_object_sibling` [INFO] [stderr] --> src/machine.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | pub fn get_object_sibling(&mut self, n: u8) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:270:26 [INFO] [stderr] | [INFO] [stderr] 270 | let second = self.next_byte() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.next_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:271:15 [INFO] [stderr] | [INFO] [stderr] 271 | ((first as u32 & 0x3f) << 8) | second [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | first as u32 & 0x3f [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode.rs:44:34 [INFO] [stderr] | [INFO] [stderr] 44 | Operand::Small(v) => v as u16, [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/opcode.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | 0xb0...0xbf => Opcode { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/opcode.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | 0xbe => unimplemented!(), [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | machine.store(p1 as u16); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(p1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:69:19 [INFO] [stderr] | [INFO] [stderr] 69 | machine.store(c1 as u16); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(c1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/zstring.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / match self { [INFO] [stderr] 31 | | &Alphabet::A0 => A0, [INFO] [stderr] 32 | | &Alphabet::A1 => A1, [INFO] [stderr] 33 | | &Alphabet::A2 => A2, [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 30 | match *self { [INFO] [stderr] 31 | Alphabet::A0 => A0, [INFO] [stderr] 32 | Alphabet::A1 => A1, [INFO] [stderr] 33 | Alphabet::A2 => A2, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:133:19 [INFO] [stderr] | [INFO] [stderr] 133 | machine.store(value as u16); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:162:19 [INFO] [stderr] | [INFO] [stderr] 162 | let address = (op.operands[0].get_value(machine) as u32) << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(op.operands[0].get_value(machine))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/traits.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | ((self[address] as u16) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self[address])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/traits.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | (self[address + 1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self[address + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | let pc = buffer.read_word(0x06) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buffer.read_word(0x06))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `params` [INFO] [stderr] --> src/machine.rs:259:18 [INFO] [stderr] | [INFO] [stderr] 259 | for i in 0..params.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 259 | for (i, ) in params.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:270:26 [INFO] [stderr] | [INFO] [stderr] 270 | let second = self.next_byte() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.next_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:271:15 [INFO] [stderr] | [INFO] [stderr] 271 | ((first as u32 & 0x3f) << 8) | second [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | first as u32 & 0x3f [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode.rs:44:34 [INFO] [stderr] | [INFO] [stderr] 44 | Operand::Small(v) => v as u16, [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/opcode.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | 0xb0...0xbf => Opcode { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/opcode.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | 0xbe => unimplemented!(), [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/zstring.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / match self { [INFO] [stderr] 31 | | &Alphabet::A0 => A0, [INFO] [stderr] 32 | | &Alphabet::A1 => A1, [INFO] [stderr] 33 | | &Alphabet::A2 => A2, [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 30 | match *self { [INFO] [stderr] 31 | Alphabet::A0 => A0, [INFO] [stderr] 32 | Alphabet::A1 => A1, [INFO] [stderr] 33 | Alphabet::A2 => A2, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/traits.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | ((self[address] as u16) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self[address])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/traits.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | (self[address + 1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self[address + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.13s [INFO] running `"docker" "inspect" "b1b55c0d2d6bc9e0be00eef738ccdd576a55ea6c71fff34e50e02dc0d47d5afd"` [INFO] running `"docker" "rm" "-f" "b1b55c0d2d6bc9e0be00eef738ccdd576a55ea6c71fff34e50e02dc0d47d5afd"` [INFO] [stdout] b1b55c0d2d6bc9e0be00eef738ccdd576a55ea6c71fff34e50e02dc0d47d5afd