[INFO] updating cached repository CodogoFreddie/rusty-lemon-bar
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/CodogoFreddie/rusty-lemon-bar
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/CodogoFreddie/rusty-lemon-bar" "work/ex/clippy-test-run/sources/stable/gh/CodogoFreddie/rusty-lemon-bar"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CodogoFreddie/rusty-lemon-bar'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/CodogoFreddie/rusty-lemon-bar" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CodogoFreddie/rusty-lemon-bar"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CodogoFreddie/rusty-lemon-bar'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 61705dbd9c863cf5a01773904dcf56b9a37e3d4a
[INFO] sha for GitHub repo CodogoFreddie/rusty-lemon-bar: 61705dbd9c863cf5a01773904dcf56b9a37e3d4a
[INFO] validating manifest of CodogoFreddie/rusty-lemon-bar on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of CodogoFreddie/rusty-lemon-bar on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing CodogoFreddie/rusty-lemon-bar
[INFO] finished frobbing CodogoFreddie/rusty-lemon-bar
[INFO] frobbed toml for CodogoFreddie/rusty-lemon-bar written to work/ex/clippy-test-run/sources/stable/gh/CodogoFreddie/rusty-lemon-bar/Cargo.toml
[INFO] started frobbing CodogoFreddie/rusty-lemon-bar
[INFO] finished frobbing CodogoFreddie/rusty-lemon-bar
[INFO] frobbed toml for CodogoFreddie/rusty-lemon-bar written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CodogoFreddie/rusty-lemon-bar/Cargo.toml
[INFO] crate CodogoFreddie/rusty-lemon-bar has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting CodogoFreddie/rusty-lemon-bar against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/CodogoFreddie/rusty-lemon-bar:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0567e873086b27a75e06d17c45df99a1f221587d4122d1e47e8c29ab1f4f2f0c
[INFO] running `"docker" "start" "-a" "0567e873086b27a75e06d17c45df99a1f221587d4122d1e47e8c29ab1f4f2f0c"`
[INFO] [stderr]     Checking bytesize v0.1.3
[INFO] [stderr]     Checking i3ipc v0.8.4
[INFO] [stderr]     Checking systemstat v0.1.3
[INFO] [stderr]     Checking rusty-lemon-bar v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/blocks/mod.rs:19:56
[INFO] [stderr]    |
[INFO] [stderr] 19 | fn disk(tx: sync::mpsc::Sender<super::ThreadResponse>) -> () {
[INFO] [stderr]    |                                                        ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/blocks/mod.rs:26:58
[INFO] [stderr]    |
[INFO] [stderr] 26 |                 .filter(|mount| mount.total.as_usize() > 4000000000)
[INFO] [stderr]    |                                                          ^^^^^^^^^^ help: consider: `4_000_000_000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/blocks/mod.rs:47:55
[INFO] [stderr]    |
[INFO] [stderr] 47 | fn cpu(tx: sync::mpsc::Sender<super::ThreadResponse>) -> () {
[INFO] [stderr]    |                                                       ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/blocks/mod.rs:84:59
[INFO] [stderr]    |
[INFO] [stderr] 84 | fn battery(tx: sync::mpsc::Sender<super::ThreadResponse>) -> () {
[INFO] [stderr]    |                                                           ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/blocks/mod.rs:133:57
[INFO] [stderr]     |
[INFO] [stderr] 133 | fn clock(tx: sync::mpsc::Sender<super::ThreadResponse>) -> () {
[INFO] [stderr]     |                                                         ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/blocks/mod.rs:153:54
[INFO] [stderr]     |
[INFO] [stderr] 153 | fn i3(tx: sync::mpsc::Sender<super::ThreadResponse>) -> () {
[INFO] [stderr]     |                                                      ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 |     return acc.join("");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `acc.join("")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/blocks/mod.rs:183:38
[INFO] [stderr]     |
[INFO] [stderr] 183 |         for (_output, workspaces) in &workspaces_by_output {
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 183 |         for workspaces in workspaces_by_output.values() {
[INFO] [stderr]     |             ^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/blocks/mod.rs:19:56
[INFO] [stderr]    |
[INFO] [stderr] 19 | fn disk(tx: sync::mpsc::Sender<super::ThreadResponse>) -> () {
[INFO] [stderr]    |                                                        ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/blocks/mod.rs:26:58
[INFO] [stderr]    |
[INFO] [stderr] 26 |                 .filter(|mount| mount.total.as_usize() > 4000000000)
[INFO] [stderr]    |                                                          ^^^^^^^^^^ help: consider: `4_000_000_000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/blocks/mod.rs:47:55
[INFO] [stderr]    |
[INFO] [stderr] 47 | fn cpu(tx: sync::mpsc::Sender<super::ThreadResponse>) -> () {
[INFO] [stderr]    |                                                       ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/blocks/mod.rs:84:59
[INFO] [stderr]    |
[INFO] [stderr] 84 | fn battery(tx: sync::mpsc::Sender<super::ThreadResponse>) -> () {
[INFO] [stderr]    |                                                           ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/blocks/mod.rs:133:57
[INFO] [stderr]     |
[INFO] [stderr] 133 | fn clock(tx: sync::mpsc::Sender<super::ThreadResponse>) -> () {
[INFO] [stderr]     |                                                         ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/blocks/mod.rs:153:54
[INFO] [stderr]     |
[INFO] [stderr] 153 | fn i3(tx: sync::mpsc::Sender<super::ThreadResponse>) -> () {
[INFO] [stderr]     |                                                      ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 |     return acc.join("");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `acc.join("")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/blocks/mod.rs:183:38
[INFO] [stderr]     |
[INFO] [stderr] 183 |         for (_output, workspaces) in &workspaces_by_output {
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 183 |         for workspaces in workspaces_by_output.values() {
[INFO] [stderr]     |             ^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.75s
[INFO] running `"docker" "inspect" "0567e873086b27a75e06d17c45df99a1f221587d4122d1e47e8c29ab1f4f2f0c"`
[INFO] running `"docker" "rm" "-f" "0567e873086b27a75e06d17c45df99a1f221587d4122d1e47e8c29ab1f4f2f0c"`
[INFO] [stdout] 0567e873086b27a75e06d17c45df99a1f221587d4122d1e47e8c29ab1f4f2f0c