[INFO] updating cached repository CodeSandwich/nucleotide [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/CodeSandwich/nucleotide [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/CodeSandwich/nucleotide" "work/ex/clippy-test-run/sources/stable/gh/CodeSandwich/nucleotide"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CodeSandwich/nucleotide'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/CodeSandwich/nucleotide" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CodeSandwich/nucleotide"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CodeSandwich/nucleotide'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6eb723a17cf1185871385eb42952bbc2a92e0e2e [INFO] sha for GitHub repo CodeSandwich/nucleotide: 6eb723a17cf1185871385eb42952bbc2a92e0e2e [INFO] validating manifest of CodeSandwich/nucleotide on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of CodeSandwich/nucleotide on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing CodeSandwich/nucleotide [INFO] finished frobbing CodeSandwich/nucleotide [INFO] frobbed toml for CodeSandwich/nucleotide written to work/ex/clippy-test-run/sources/stable/gh/CodeSandwich/nucleotide/Cargo.toml [INFO] started frobbing CodeSandwich/nucleotide [INFO] finished frobbing CodeSandwich/nucleotide [INFO] frobbed toml for CodeSandwich/nucleotide written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CodeSandwich/nucleotide/Cargo.toml [INFO] crate CodeSandwich/nucleotide has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting CodeSandwich/nucleotide against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/CodeSandwich/nucleotide:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ff5866e55def76d379485331ed0e9220ec543e7854a4e53a4bb3445072f81c3d [INFO] running `"docker" "start" "-a" "ff5866e55def76d379485331ed0e9220ec543e7854a4e53a4bb3445072f81c3d"` [INFO] [stderr] Checking nucleotyde v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | const LOOKUPS: [&'static str; 5] = ["GGT", "GGTA", "GGTATT", "GGTATTTTAATT", "GGTATTTTAATTTATAGT"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:28:42 [INFO] [stderr] | [INFO] [stderr] 28 | s.chars().fold(0, |acc, c| 4 * acc + encode(c) as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(encode(c))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:62:42 [INFO] [stderr] | [INFO] [stderr] 62 | self.value = (self.value << 2) | (c as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:100:45 [INFO] [stderr] | [INFO] [stderr] 100 | vec.extend(l.trim().chars().map(|b| encode(b))); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `encode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | const LOOKUPS: [&'static str; 5] = ["GGT", "GGTA", "GGTATT", "GGTATTTTAATT", "GGTATTTTAATTTATAGT"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:28:42 [INFO] [stderr] | [INFO] [stderr] 28 | s.chars().fold(0, |acc, c| 4 * acc + encode(c) as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(encode(c))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:62:42 [INFO] [stderr] | [INFO] [stderr] 62 | self.value = (self.value << 2) | (c as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:100:45 [INFO] [stderr] | [INFO] [stderr] 100 | vec.extend(l.trim().chars().map(|b| encode(b))); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `encode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.74s [INFO] running `"docker" "inspect" "ff5866e55def76d379485331ed0e9220ec543e7854a4e53a4bb3445072f81c3d"` [INFO] running `"docker" "rm" "-f" "ff5866e55def76d379485331ed0e9220ec543e7854a4e53a4bb3445072f81c3d"` [INFO] [stdout] ff5866e55def76d379485331ed0e9220ec543e7854a4e53a4bb3445072f81c3d