[INFO] updating cached repository Cobrand/chatbix [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Cobrand/chatbix [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Cobrand/chatbix" "work/ex/clippy-test-run/sources/stable/gh/Cobrand/chatbix"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Cobrand/chatbix'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Cobrand/chatbix" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Cobrand/chatbix"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Cobrand/chatbix'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c4814e602365eff3c41ef6c3af91ecdead7f76cd [INFO] sha for GitHub repo Cobrand/chatbix: c4814e602365eff3c41ef6c3af91ecdead7f76cd [INFO] validating manifest of Cobrand/chatbix on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Cobrand/chatbix on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Cobrand/chatbix [INFO] finished frobbing Cobrand/chatbix [INFO] frobbed toml for Cobrand/chatbix written to work/ex/clippy-test-run/sources/stable/gh/Cobrand/chatbix/Cargo.toml [INFO] started frobbing Cobrand/chatbix [INFO] finished frobbing Cobrand/chatbix [INFO] frobbed toml for Cobrand/chatbix written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Cobrand/chatbix/Cargo.toml [INFO] crate Cobrand/chatbix has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Cobrand/chatbix against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Cobrand/chatbix:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dd6f90bab687b42d7f2ba528e594d331cbb92b35be01572f1f237588e3c8f7b6 [INFO] running `"docker" "start" "-a" "dd6f90bab687b42d7f2ba528e594d331cbb92b35be01572f1f237588e3c8f7b6"` [INFO] [stderr] Compiling openssl v0.9.12 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Compiling openssl-sys v0.9.12 [INFO] [stderr] Checking mime v0.2.4 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking scheduled-thread-pool v0.1.0 [INFO] [stderr] Checking postgres-protocol v0.2.2 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking r2d2 v0.7.2 [INFO] [stderr] Checking error-chain v0.9.0 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking hyper v0.10.10 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking postgres-shared v0.1.1 [INFO] [stderr] Checking dotenv v0.8.0 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking native-tls v0.1.2 [INFO] [stderr] Checking postgres v0.13.6 [INFO] [stderr] Checking persistent v0.3.0 [INFO] [stderr] Checking mount v0.3.0 [INFO] [stderr] Checking router v0.5.1 [INFO] [stderr] Checking r2d2_postgres v0.11.1 [INFO] [stderr] Checking bodyparser v0.5.0 [INFO] [stderr] Checking bodyparser v0.6.0 [INFO] [stderr] Checking staticfile v0.4.0 [INFO] [stderr] Checking urlencoded v0.5.0 [INFO] [stderr] Checking chatbix v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/user.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/user.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | logged_in: logged_in, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `logged_in` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/user.rs:105:88 [INFO] [stderr] | [INFO] [stderr] 105 | self.0.insert(username.to_owned(), CachedUser {auth_key: auth_key.clone(), admin: admin}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `admin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/user.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/user.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | logged_in: logged_in, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `logged_in` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/user.rs:105:88 [INFO] [stderr] | [INFO] [stderr] 105 | self.0.insert(username.to_owned(), CachedUser {auth_key: auth_key.clone(), admin: admin}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `admin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/routes.rs:118:50 [INFO] [stderr] | [INFO] [stderr] 118 | return Err(IronError::new(body_error,(status::BadRequest))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/routes.rs:173:50 [INFO] [stderr] | [INFO] [stderr] 173 | return Err(IronError::new(body_error,(status::BadRequest))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/routes.rs:262:50 [INFO] [stderr] | [INFO] [stderr] 262 | return Err(IronError::new(body_error,(status::BadRequest))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/routes.rs:118:50 [INFO] [stderr] | [INFO] [stderr] 118 | return Err(IronError::new(body_error,(status::BadRequest))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/routes.rs:173:50 [INFO] [stderr] | [INFO] [stderr] 173 | return Err(IronError::new(body_error,(status::BadRequest))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/routes.rs:262:50 [INFO] [stderr] | [INFO] [stderr] 262 | return Err(IronError::new(body_error,(status::BadRequest))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/user.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | self.0.get(username).unwrap().auth_key.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.0[username]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/error.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / match $expr { [INFO] [stderr] 57 | | Ok(val) => val, [INFO] [stderr] 58 | | Err(error) => return error.into() [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/routes.rs:79:33 [INFO] [stderr] | [INFO] [stderr] 79 | Some(new_message) => Ok(chatbix_try!(chatbix.new_message(new_message))), [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 56 | () [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:101:60 [INFO] [stderr] | [INFO] [stderr] 101 | let username = hashmap.get("username").map(|u| u.get(0).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `&u[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:102:60 [INFO] [stderr] | [INFO] [stderr] 102 | let auth_key = hashmap.get("auth_key").map(|k| k.get(0).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `&k[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:104:30 [INFO] [stderr] | [INFO] [stderr] 104 | let active = active.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&active[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:112:100 [INFO] [stderr] | [INFO] [stderr] 112 | (Some(timestamps),None) => Interval::AllFromTimestamp(chatbix_try!(timestamp_parse(timestamps.get(0).unwrap()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×tamps[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/routes.rs:113:124 [INFO] [stderr] | [INFO] [stderr] 113 | (_,Some(message_id)) => Interval::AllFromId(chatbix_try!(message_id.get(0).unwrap().parse::().map_err(|e| Error::from(e)))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:113:74 [INFO] [stderr] | [INFO] [stderr] 113 | (_,Some(message_id)) => Interval::AllFromId(chatbix_try!(message_id.get(0).unwrap().parse::().map_err(|e| Error::from(e)))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&message_id[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:153:66 [INFO] [stderr] | [INFO] [stderr] 153 | let timestamp = chatbix_try!(timestamp_parse(timestamps.get(0).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×tamps[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:157:66 [INFO] [stderr] | [INFO] [stderr] 157 | let timestamp = chatbix_try!(timestamp_parse(timestamps.get(0).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×tamps[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:158:70 [INFO] [stderr] | [INFO] [stderr] 158 | let timestamp_end = chatbix_try!(timestamp_parse(timestamps_end.get(0).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×tamps_end[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/routes.rs:163:34 [INFO] [stderr] | [INFO] [stderr] 163 | .map_err(|e| Error::from(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:162:51 [INFO] [stderr] | [INFO] [stderr] 162 | let message_id = chatbix_try!(message_id.get(0).unwrap().parse::() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&message_id[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:252:22 [INFO] [stderr] | [INFO] [stderr] 252 | (query.get(0).unwrap().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&query[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/handler.rs:93:39 [INFO] [stderr] | [INFO] [stderr] 93 | let mut static_root = Static::new(env::var("STATIC_ROOT_DIR").unwrap_or(String::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::var("STATIC_ROOT_DIR").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/handler.rs:96:45 [INFO] [stderr] | [INFO] [stderr] 96 | let listen_url = env::var("LISTEN_URL").unwrap_or("0.0.0.0:8080".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "0.0.0.0:8080".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/user.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | self.0.get(username).unwrap().auth_key.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.0[username]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/error.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / match $expr { [INFO] [stderr] 57 | | Ok(val) => val, [INFO] [stderr] 58 | | Err(error) => return error.into() [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/routes.rs:79:33 [INFO] [stderr] | [INFO] [stderr] 79 | Some(new_message) => Ok(chatbix_try!(chatbix.new_message(new_message))), [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 56 | () [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:101:60 [INFO] [stderr] | [INFO] [stderr] 101 | let username = hashmap.get("username").map(|u| u.get(0).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `&u[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:102:60 [INFO] [stderr] | [INFO] [stderr] 102 | let auth_key = hashmap.get("auth_key").map(|k| k.get(0).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `&k[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:104:30 [INFO] [stderr] | [INFO] [stderr] 104 | let active = active.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&active[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:112:100 [INFO] [stderr] | [INFO] [stderr] 112 | (Some(timestamps),None) => Interval::AllFromTimestamp(chatbix_try!(timestamp_parse(timestamps.get(0).unwrap()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×tamps[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/routes.rs:113:124 [INFO] [stderr] | [INFO] [stderr] 113 | (_,Some(message_id)) => Interval::AllFromId(chatbix_try!(message_id.get(0).unwrap().parse::().map_err(|e| Error::from(e)))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:113:74 [INFO] [stderr] | [INFO] [stderr] 113 | (_,Some(message_id)) => Interval::AllFromId(chatbix_try!(message_id.get(0).unwrap().parse::().map_err(|e| Error::from(e)))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&message_id[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:153:66 [INFO] [stderr] | [INFO] [stderr] 153 | let timestamp = chatbix_try!(timestamp_parse(timestamps.get(0).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×tamps[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:157:66 [INFO] [stderr] | [INFO] [stderr] 157 | let timestamp = chatbix_try!(timestamp_parse(timestamps.get(0).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×tamps[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:158:70 [INFO] [stderr] | [INFO] [stderr] 158 | let timestamp_end = chatbix_try!(timestamp_parse(timestamps_end.get(0).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×tamps_end[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/routes.rs:163:34 [INFO] [stderr] | [INFO] [stderr] 163 | .map_err(|e| Error::from(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:162:51 [INFO] [stderr] | [INFO] [stderr] 162 | let message_id = chatbix_try!(message_id.get(0).unwrap().parse::() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&message_id[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/routes.rs:252:22 [INFO] [stderr] | [INFO] [stderr] 252 | (query.get(0).unwrap().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&query[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/handler.rs:93:39 [INFO] [stderr] | [INFO] [stderr] 93 | let mut static_root = Static::new(env::var("STATIC_ROOT_DIR").unwrap_or(String::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::var("STATIC_ROOT_DIR").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/handler.rs:96:45 [INFO] [stderr] | [INFO] [stderr] 96 | let listen_url = env::var("LISTEN_URL").unwrap_or("0.0.0.0:8080".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "0.0.0.0:8080".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 42.30s [INFO] running `"docker" "inspect" "dd6f90bab687b42d7f2ba528e594d331cbb92b35be01572f1f237588e3c8f7b6"` [INFO] running `"docker" "rm" "-f" "dd6f90bab687b42d7f2ba528e594d331cbb92b35be01572f1f237588e3c8f7b6"` [INFO] [stdout] dd6f90bab687b42d7f2ba528e594d331cbb92b35be01572f1f237588e3c8f7b6