[INFO] updating cached repository CloneRob/iron_woods [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/CloneRob/iron_woods [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/CloneRob/iron_woods" "work/ex/clippy-test-run/sources/stable/gh/CloneRob/iron_woods"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CloneRob/iron_woods'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/CloneRob/iron_woods" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CloneRob/iron_woods"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CloneRob/iron_woods'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d892a15c6b4292bb45efb6a830c8b6afd5fe4ea3 [INFO] sha for GitHub repo CloneRob/iron_woods: d892a15c6b4292bb45efb6a830c8b6afd5fe4ea3 [INFO] validating manifest of CloneRob/iron_woods on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of CloneRob/iron_woods on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing CloneRob/iron_woods [INFO] finished frobbing CloneRob/iron_woods [INFO] frobbed toml for CloneRob/iron_woods written to work/ex/clippy-test-run/sources/stable/gh/CloneRob/iron_woods/Cargo.toml [INFO] started frobbing CloneRob/iron_woods [INFO] finished frobbing CloneRob/iron_woods [INFO] frobbed toml for CloneRob/iron_woods written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CloneRob/iron_woods/Cargo.toml [INFO] crate CloneRob/iron_woods has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting CloneRob/iron_woods against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/CloneRob/iron_woods:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c6c01fb4d6e1254ce3375f65e7b2a643afd2d31cae1e303a018f9d0b0745c0b9 [INFO] running `"docker" "start" "-a" "c6c01fb4d6e1254ce3375f65e7b2a643afd2d31cae1e303a018f9d0b0745c0b9"` [INFO] [stderr] Checking iron_woods v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data/mod.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | set: set, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `set` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data/mod.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | labels: labels [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `labels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data/mod.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | set: set, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `set` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data/mod.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | labels: labels [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `labels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/main.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/feature/mod.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Hash` [INFO] [stderr] --> src/feature/mod.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | use std::hash::{Hash, Hasher}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter::FromIterator` [INFO] [stderr] --> src/feature/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::iter::FromIterator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Index`, `RangeFrom`, `RangeTo` [INFO] [stderr] --> src/feature/mod.rs:5:16 [INFO] [stderr] | [INFO] [stderr] 5 | use std::ops::{Index, RangeTo, RangeFrom}; [INFO] [stderr] | ^^^^^ ^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `HashSet` [INFO] [stderr] --> src/feature/mod.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | use std::collections::{HashSet, HashMap}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Hasher` [INFO] [stderr] --> src/feature/mod.rs:3:23 [INFO] [stderr] | [INFO] [stderr] 3 | use std::hash::{Hash, Hasher}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value_index` [INFO] [stderr] --> src/decision_tree/mod.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | for (value_index, value) in feature.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_value_index` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `depth` [INFO] [stderr] --> src/decision_tree/mod.rs:30:49 [INFO] [stderr] | [INFO] [stderr] 30 | fn build_tree(&mut self, dataset: &Dataset, depth: usize) -> DecisionTree { [INFO] [stderr] | ^^^^^ help: consider using `_depth` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `data` [INFO] [stderr] --> src/decision_tree/mod.rs:51:34 [INFO] [stderr] | [INFO] [stderr] 51 | fn argmin_cost(data: D) -> (f32, usize, Value) { [INFO] [stderr] | ^^^^ help: consider using `_data` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `root` [INFO] [stderr] --> src/decision_tree/mod.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | root: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `min_split` [INFO] [stderr] --> src/decision_tree/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | min_split: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `min_impurity` [INFO] [stderr] --> src/decision_tree/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | min_impurity: f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `max_depth` [INFO] [stderr] --> src/decision_tree/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | max_depth: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `cost_fn` [INFO] [stderr] --> src/decision_tree/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | cost_fn: fn(&[f32]) -> f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `leaf_fn` [INFO] [stderr] --> src/decision_tree/mod.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | leaf_fn: fn() -> f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `build_tree` [INFO] [stderr] --> src/decision_tree/mod.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | fn build_tree(&mut self, dataset: &Dataset, depth: usize) -> DecisionTree { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `argmin_cost` [INFO] [stderr] --> src/decision_tree/mod.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | fn argmin_cost(data: D) -> (f32, usize, Value) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/data/mod.rs:24:35 [INFO] [stderr] | [INFO] [stderr] 24 | for (i, v) in feature.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/data/mod.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | if value <= &threshold { [INFO] [stderr] | ^^^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `threshold` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/data/mod.rs:108:35 [INFO] [stderr] | [INFO] [stderr] 108 | for (i, v) in feature.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/data/mod.rs:139:16 [INFO] [stderr] | [INFO] [stderr] 139 | if *value <= &threshold { [INFO] [stderr] | ^^^^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `threshold` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/main.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/feature/mod.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Hash` [INFO] [stderr] --> src/feature/mod.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | use std::hash::{Hash, Hasher}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter::FromIterator` [INFO] [stderr] --> src/feature/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::iter::FromIterator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Index`, `RangeFrom`, `RangeTo` [INFO] [stderr] --> src/feature/mod.rs:5:16 [INFO] [stderr] | [INFO] [stderr] 5 | use std::ops::{Index, RangeTo, RangeFrom}; [INFO] [stderr] | ^^^^^ ^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `HashSet` [INFO] [stderr] --> src/feature/mod.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | use std::collections::{HashSet, HashMap}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Hasher` [INFO] [stderr] --> src/feature/mod.rs:3:23 [INFO] [stderr] | [INFO] [stderr] 3 | use std::hash::{Hash, Hasher}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value_index` [INFO] [stderr] --> src/decision_tree/mod.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | for (value_index, value) in feature.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_value_index` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `depth` [INFO] [stderr] --> src/decision_tree/mod.rs:30:49 [INFO] [stderr] | [INFO] [stderr] 30 | fn build_tree(&mut self, dataset: &Dataset, depth: usize) -> DecisionTree { [INFO] [stderr] | ^^^^^ help: consider using `_depth` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `data` [INFO] [stderr] --> src/decision_tree/mod.rs:51:34 [INFO] [stderr] | [INFO] [stderr] 51 | fn argmin_cost(data: D) -> (f32, usize, Value) { [INFO] [stderr] | ^^^^ help: consider using `_data` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `root` [INFO] [stderr] --> src/decision_tree/mod.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | root: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `min_split` [INFO] [stderr] --> src/decision_tree/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | min_split: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `min_impurity` [INFO] [stderr] --> src/decision_tree/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | min_impurity: f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `max_depth` [INFO] [stderr] --> src/decision_tree/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | max_depth: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `cost_fn` [INFO] [stderr] --> src/decision_tree/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | cost_fn: fn(&[f32]) -> f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `leaf_fn` [INFO] [stderr] --> src/decision_tree/mod.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | leaf_fn: fn() -> f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `build_tree` [INFO] [stderr] --> src/decision_tree/mod.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | fn build_tree(&mut self, dataset: &Dataset, depth: usize) -> DecisionTree { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `argmin_cost` [INFO] [stderr] --> src/decision_tree/mod.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | fn argmin_cost(data: D) -> (f32, usize, Value) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/data/mod.rs:24:35 [INFO] [stderr] | [INFO] [stderr] 24 | for (i, v) in feature.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/data/mod.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | if value <= &threshold { [INFO] [stderr] | ^^^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `threshold` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/data/mod.rs:108:35 [INFO] [stderr] | [INFO] [stderr] 108 | for (i, v) in feature.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/data/mod.rs:139:16 [INFO] [stderr] | [INFO] [stderr] 139 | if *value <= &threshold { [INFO] [stderr] | ^^^^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `threshold` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.21s [INFO] running `"docker" "inspect" "c6c01fb4d6e1254ce3375f65e7b2a643afd2d31cae1e303a018f9d0b0745c0b9"` [INFO] running `"docker" "rm" "-f" "c6c01fb4d6e1254ce3375f65e7b2a643afd2d31cae1e303a018f9d0b0745c0b9"` [INFO] [stdout] c6c01fb4d6e1254ce3375f65e7b2a643afd2d31cae1e303a018f9d0b0745c0b9