[INFO] updating cached repository CloneRob/Simple-Parse-Generator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/CloneRob/Simple-Parse-Generator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/CloneRob/Simple-Parse-Generator" "work/ex/clippy-test-run/sources/stable/gh/CloneRob/Simple-Parse-Generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CloneRob/Simple-Parse-Generator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/CloneRob/Simple-Parse-Generator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CloneRob/Simple-Parse-Generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CloneRob/Simple-Parse-Generator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ab705cbb92aca2a45a70f818daabbf37e0c3a18e [INFO] sha for GitHub repo CloneRob/Simple-Parse-Generator: ab705cbb92aca2a45a70f818daabbf37e0c3a18e [INFO] validating manifest of CloneRob/Simple-Parse-Generator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of CloneRob/Simple-Parse-Generator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing CloneRob/Simple-Parse-Generator [INFO] finished frobbing CloneRob/Simple-Parse-Generator [INFO] frobbed toml for CloneRob/Simple-Parse-Generator written to work/ex/clippy-test-run/sources/stable/gh/CloneRob/Simple-Parse-Generator/Cargo.toml [INFO] started frobbing CloneRob/Simple-Parse-Generator [INFO] finished frobbing CloneRob/Simple-Parse-Generator [INFO] frobbed toml for CloneRob/Simple-Parse-Generator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CloneRob/Simple-Parse-Generator/Cargo.toml [INFO] crate CloneRob/Simple-Parse-Generator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting CloneRob/Simple-Parse-Generator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/CloneRob/Simple-Parse-Generator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 727f0c66bddaa6838c6df2ad88443bb71c31e9368c5fd372dcbbe278bbad23a1 [INFO] running `"docker" "start" "-a" "727f0c66bddaa6838c6df2ad88443bb71c31e9368c5fd372dcbbe278bbad23a1"` [INFO] [stderr] Checking parse_generator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grammar.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | start_symbol: start_symbol, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_symbol` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grammar.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | non_terminals: non_terminals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `non_terminals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grammar.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | terminals: terminals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `terminals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grammar.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | production_rules: production_rules, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `production_rules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/grammar.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/grammar.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/set_builder.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | first_set: first_set, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/set_builder.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | follow_set: follow_set, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `follow_set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/set_builder.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | first_plus_set: first_plus_set, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_plus_set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/set_builder.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/set_builder.rs:217:9 [INFO] [stderr] | [INFO] [stderr] 217 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/set_builder.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/set_builder.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/set_builder.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/set_builder.rs:239:9 [INFO] [stderr] | [INFO] [stderr] 239 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/set_state.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | max_time: max_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | grammar: grammar, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `grammar` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grammar.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | start_symbol: start_symbol, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_symbol` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grammar.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | non_terminals: non_terminals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `non_terminals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grammar.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | terminals: terminals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `terminals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grammar.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | production_rules: production_rules, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `production_rules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/grammar.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/grammar.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/set_builder.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | first_set: first_set, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/set_builder.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | follow_set: follow_set, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `follow_set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/set_builder.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | first_plus_set: first_plus_set, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_plus_set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/set_builder.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/set_builder.rs:217:9 [INFO] [stderr] | [INFO] [stderr] 217 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/set_builder.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/set_builder.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/set_builder.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/set_builder.rs:239:9 [INFO] [stderr] | [INFO] [stderr] 239 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/set_state.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | max_time: max_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | grammar: grammar, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `grammar` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/set_builder.rs:152:32 [INFO] [stderr] | [INFO] [stderr] 152 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 153 | | if let Some(symbol_first_set) = first_set.get(symbol) { [INFO] [stderr] 154 | | trailer = symbol_first_set.clone(); [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 152 | } else if let Some(symbol_first_set) = first_set.get(symbol) { [INFO] [stderr] 153 | trailer = symbol_first_set.clone(); [INFO] [stderr] 154 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/set_state.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 32 | | if boolean { [INFO] [stderr] 33 | | self.state = true; [INFO] [stderr] 34 | | self.time = 0; [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 31 | } else if boolean { [INFO] [stderr] 32 | self.state = true; [INFO] [stderr] 33 | self.time = 0; [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/set_state.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / if !boolean { [INFO] [stderr] 27 | | if self.time >= self.max_time { [INFO] [stderr] 28 | | self.state = false; [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 26 | if !boolean && self.time >= self.max_time { [INFO] [stderr] 27 | self.state = false; [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:95:24 [INFO] [stderr] | [INFO] [stderr] 95 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 96 | | if outer_val.intersection(inner_val).collect::>().len() > 0 { [INFO] [stderr] 97 | | return Err("No LL(1) grammar"); [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 95 | } else if outer_val.intersection(inner_val).collect::>().len() > 0 { [INFO] [stderr] 96 | return Err("No LL(1) grammar"); [INFO] [stderr] 97 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:133:24 [INFO] [stderr] | [INFO] [stderr] 133 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 134 | | if let Some(entry) = self.ll1_table.get(&(focus, word)) { [INFO] [stderr] 135 | | if let Some(rule) = *entry { [INFO] [stderr] 136 | | [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 133 | } else if let Some(entry) = self.ll1_table.get(&(focus, word)) { [INFO] [stderr] 134 | if let Some(rule) = *entry { [INFO] [stderr] 135 | [INFO] [stderr] 136 | stack.pop(); [INFO] [stderr] 137 | // focus_index = stack.len(); [INFO] [stderr] 138 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/set_builder.rs:152:32 [INFO] [stderr] | [INFO] [stderr] 152 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 153 | | if let Some(symbol_first_set) = first_set.get(symbol) { [INFO] [stderr] 154 | | trailer = symbol_first_set.clone(); [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 152 | } else if let Some(symbol_first_set) = first_set.get(symbol) { [INFO] [stderr] 153 | trailer = symbol_first_set.clone(); [INFO] [stderr] 154 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/set_state.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 32 | | if boolean { [INFO] [stderr] 33 | | self.state = true; [INFO] [stderr] 34 | | self.time = 0; [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 31 | } else if boolean { [INFO] [stderr] 32 | self.state = true; [INFO] [stderr] 33 | self.time = 0; [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/set_state.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / if !boolean { [INFO] [stderr] 27 | | if self.time >= self.max_time { [INFO] [stderr] 28 | | self.state = false; [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 26 | if !boolean && self.time >= self.max_time { [INFO] [stderr] 27 | self.state = false; [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:95:24 [INFO] [stderr] | [INFO] [stderr] 95 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 96 | | if outer_val.intersection(inner_val).collect::>().len() > 0 { [INFO] [stderr] 97 | | return Err("No LL(1) grammar"); [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 95 | } else if outer_val.intersection(inner_val).collect::>().len() > 0 { [INFO] [stderr] 96 | return Err("No LL(1) grammar"); [INFO] [stderr] 97 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:133:24 [INFO] [stderr] | [INFO] [stderr] 133 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 134 | | if let Some(entry) = self.ll1_table.get(&(focus, word)) { [INFO] [stderr] 135 | | if let Some(rule) = *entry { [INFO] [stderr] 136 | | [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 133 | } else if let Some(entry) = self.ll1_table.get(&(focus, word)) { [INFO] [stderr] 134 | if let Some(rule) = *entry { [INFO] [stderr] 135 | [INFO] [stderr] 136 | stack.pop(); [INFO] [stderr] 137 | // focus_index = stack.len(); [INFO] [stderr] 138 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_sets` [INFO] [stderr] --> src/set_builder.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn get_sets(self) [INFO] [stderr] 26 | | -> (HashMap>, [INFO] [stderr] 27 | | HashMap>, [INFO] [stderr] 28 | | HashMap<(char, &'rule str), HashSet>) { [INFO] [stderr] 29 | | (self.first_set, self.follow_set, self.first_plus_set) [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_first_set` [INFO] [stderr] --> src/set_builder.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | pub fn get_first_set(&self) -> &HashMap> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_follow_set` [INFO] [stderr] --> src/set_builder.rs:201:5 [INFO] [stderr] | [INFO] [stderr] 201 | pub fn get_follow_set(&self) -> &HashMap> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/set_builder.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | -> (HashMap>, [INFO] [stderr] | ________________________^ [INFO] [stderr] 27 | | HashMap>, [INFO] [stderr] 28 | | HashMap<(char, &'rule str), HashSet>) { [INFO] [stderr] | |___________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/set_builder.rs:86:31 [INFO] [stderr] | [INFO] [stderr] 86 | } else if &symbols[i] == &'e' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 86 | } else if symbols[i] == 'e' { [INFO] [stderr] | ^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/set_builder.rs:187:24 [INFO] [stderr] | [INFO] [stderr] 187 | if hash_set.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!hash_set.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/set_builder.rs:188:49 [INFO] [stderr] | [INFO] [stderr] 188 | first_plust_set.insert((non_terminal.clone(), rule.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*non_terminal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/set_builder.rs:188:71 [INFO] [stderr] | [INFO] [stderr] 188 | first_plust_set.insert((non_terminal.clone(), rule.clone()), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 188 | first_plust_set.insert((non_terminal.clone(), &(*rule).clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 188 | first_plust_set.insert((non_terminal.clone(), &str::clone(rule)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/set_state.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn is_changing(&mut self, boolean: bool) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/parser.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | -> Result>, &'static str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / match Parser::check_ll1(set_builder) { [INFO] [stderr] 57 | | Err(msg) => return Err(msg), [INFO] [stderr] 58 | | _ => (), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(msg) = Parser::check_ll1(set_builder) { return Err(msg) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | table.insert((nt.clone(), t.clone()), None); [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*nt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:64:43 [INFO] [stderr] | [INFO] [stderr] 64 | table.insert((nt.clone(), t.clone()), None); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | let rules = grammar.production_rules.get(nt).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&grammar.production_rules[nt]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:73:39 [INFO] [stderr] | [INFO] [stderr] 73 | table.insert((nt.clone(), fps_t.clone()), [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*nt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:73:51 [INFO] [stderr] | [INFO] [stderr] 73 | table.insert((nt.clone(), fps_t.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*fps_t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:74:44 [INFO] [stderr] | [INFO] [stderr] 74 | Some((nt.clone(), rule.clone()))); [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*nt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/parser.rs:74:56 [INFO] [stderr] | [INFO] [stderr] 74 | Some((nt.clone(), rule.clone()))); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 74 | Some((nt.clone(), &(*rule).clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 74 | Some((nt.clone(), &str::clone(rule)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:81:35 [INFO] [stderr] | [INFO] [stderr] 81 | table.insert((nt.clone(), '$'), Some((nt.clone(), rule.clone()))); [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*nt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:81:59 [INFO] [stderr] | [INFO] [stderr] 81 | table.insert((nt.clone(), '$'), Some((nt.clone(), rule.clone()))); [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*nt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/parser.rs:81:71 [INFO] [stderr] | [INFO] [stderr] 81 | table.insert((nt.clone(), '$'), Some((nt.clone(), rule.clone()))); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 81 | table.insert((nt.clone(), '$'), Some((nt.clone(), &(*rule).clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 81 | table.insert((nt.clone(), '$'), Some((nt.clone(), &str::clone(rule)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/parser.rs:93:54 [INFO] [stderr] | [INFO] [stderr] 93 | } else if outer_key.1 == inner_key.1 { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 94 | | continue; [INFO] [stderr] 95 | | } else { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/parser.rs:91:47 [INFO] [stderr] | [INFO] [stderr] 91 | if outer_key.0 != inner_key.0 { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 92 | | continue; [INFO] [stderr] 93 | | } else if outer_key.1 == inner_key.1 { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:96:24 [INFO] [stderr] | [INFO] [stderr] 96 | if outer_val.intersection(inner_val).collect::>().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!outer_val.intersection(inner_val).collect::>().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/parser.rs:96:57 [INFO] [stderr] | [INFO] [stderr] 96 | if outer_val.intersection(inner_val).collect::>().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `parse_generator`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: method is never used: `get_sets` [INFO] [stderr] --> src/set_builder.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn get_sets(self) [INFO] [stderr] 26 | | -> (HashMap>, [INFO] [stderr] 27 | | HashMap>, [INFO] [stderr] 28 | | HashMap<(char, &'rule str), HashSet>) { [INFO] [stderr] 29 | | (self.first_set, self.follow_set, self.first_plus_set) [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_first_set` [INFO] [stderr] --> src/set_builder.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | pub fn get_first_set(&self) -> &HashMap> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_follow_set` [INFO] [stderr] --> src/set_builder.rs:201:5 [INFO] [stderr] | [INFO] [stderr] 201 | pub fn get_follow_set(&self) -> &HashMap> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/set_builder.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | -> (HashMap>, [INFO] [stderr] | ________________________^ [INFO] [stderr] 27 | | HashMap>, [INFO] [stderr] 28 | | HashMap<(char, &'rule str), HashSet>) { [INFO] [stderr] | |___________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/set_builder.rs:86:31 [INFO] [stderr] | [INFO] [stderr] 86 | } else if &symbols[i] == &'e' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 86 | } else if symbols[i] == 'e' { [INFO] [stderr] | ^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/set_builder.rs:187:24 [INFO] [stderr] | [INFO] [stderr] 187 | if hash_set.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!hash_set.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/set_builder.rs:188:49 [INFO] [stderr] | [INFO] [stderr] 188 | first_plust_set.insert((non_terminal.clone(), rule.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*non_terminal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/set_builder.rs:188:71 [INFO] [stderr] | [INFO] [stderr] 188 | first_plust_set.insert((non_terminal.clone(), rule.clone()), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 188 | first_plust_set.insert((non_terminal.clone(), &(*rule).clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 188 | first_plust_set.insert((non_terminal.clone(), &str::clone(rule)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/set_state.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn is_changing(&mut self, boolean: bool) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/parser.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | -> Result>, &'static str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / match Parser::check_ll1(set_builder) { [INFO] [stderr] 57 | | Err(msg) => return Err(msg), [INFO] [stderr] 58 | | _ => (), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(msg) = Parser::check_ll1(set_builder) { return Err(msg) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | table.insert((nt.clone(), t.clone()), None); [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*nt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:64:43 [INFO] [stderr] | [INFO] [stderr] 64 | table.insert((nt.clone(), t.clone()), None); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | let rules = grammar.production_rules.get(nt).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&grammar.production_rules[nt]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:73:39 [INFO] [stderr] | [INFO] [stderr] 73 | table.insert((nt.clone(), fps_t.clone()), [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*nt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:73:51 [INFO] [stderr] | [INFO] [stderr] 73 | table.insert((nt.clone(), fps_t.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*fps_t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:74:44 [INFO] [stderr] | [INFO] [stderr] 74 | Some((nt.clone(), rule.clone()))); [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*nt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/parser.rs:74:56 [INFO] [stderr] | [INFO] [stderr] 74 | Some((nt.clone(), rule.clone()))); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 74 | Some((nt.clone(), &(*rule).clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 74 | Some((nt.clone(), &str::clone(rule)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:81:35 [INFO] [stderr] | [INFO] [stderr] 81 | table.insert((nt.clone(), '$'), Some((nt.clone(), rule.clone()))); [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*nt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:81:59 [INFO] [stderr] | [INFO] [stderr] 81 | table.insert((nt.clone(), '$'), Some((nt.clone(), rule.clone()))); [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*nt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/parser.rs:81:71 [INFO] [stderr] | [INFO] [stderr] 81 | table.insert((nt.clone(), '$'), Some((nt.clone(), rule.clone()))); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 81 | table.insert((nt.clone(), '$'), Some((nt.clone(), &(*rule).clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 81 | table.insert((nt.clone(), '$'), Some((nt.clone(), &str::clone(rule)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/parser.rs:93:54 [INFO] [stderr] | [INFO] [stderr] 93 | } else if outer_key.1 == inner_key.1 { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 94 | | continue; [INFO] [stderr] 95 | | } else { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/parser.rs:91:47 [INFO] [stderr] | [INFO] [stderr] 91 | if outer_key.0 != inner_key.0 { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 92 | | continue; [INFO] [stderr] 93 | | } else if outer_key.1 == inner_key.1 { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:96:24 [INFO] [stderr] | [INFO] [stderr] 96 | if outer_val.intersection(inner_val).collect::>().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!outer_val.intersection(inner_val).collect::>().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/parser.rs:96:57 [INFO] [stderr] | [INFO] [stderr] 96 | if outer_val.intersection(inner_val).collect::>().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `parse_generator`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "727f0c66bddaa6838c6df2ad88443bb71c31e9368c5fd372dcbbe278bbad23a1"` [INFO] running `"docker" "rm" "-f" "727f0c66bddaa6838c6df2ad88443bb71c31e9368c5fd372dcbbe278bbad23a1"` [INFO] [stdout] 727f0c66bddaa6838c6df2ad88443bb71c31e9368c5fd372dcbbe278bbad23a1