[INFO] updating cached repository Clemente12/pacman [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Clemente12/pacman [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Clemente12/pacman" "work/ex/clippy-test-run/sources/stable/gh/Clemente12/pacman"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Clemente12/pacman'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Clemente12/pacman" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Clemente12/pacman"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Clemente12/pacman'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4690d35ea5362e0f3ecfb2df11c70138468a64b4 [INFO] sha for GitHub repo Clemente12/pacman: 4690d35ea5362e0f3ecfb2df11c70138468a64b4 [INFO] validating manifest of Clemente12/pacman on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Clemente12/pacman on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Clemente12/pacman [INFO] finished frobbing Clemente12/pacman [INFO] frobbed toml for Clemente12/pacman written to work/ex/clippy-test-run/sources/stable/gh/Clemente12/pacman/Cargo.toml [INFO] started frobbing Clemente12/pacman [INFO] finished frobbing Clemente12/pacman [INFO] frobbed toml for Clemente12/pacman written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Clemente12/pacman/Cargo.toml [INFO] crate Clemente12/pacman has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting Clemente12/pacman against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Clemente12/pacman:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2be34b8b4e726d27920a6c5ab34781381d9747a7c751f9c57baf11f2ad31d0d2 [INFO] running `"docker" "start" "-a" "2be34b8b4e726d27920a6c5ab34781381d9747a7c751f9c57baf11f2ad31d0d2"` [INFO] [stderr] Checking termios v0.3.0 [INFO] [stderr] Checking rand v0.5.3 [INFO] [stderr] Compiling quote v0.5.2 [INFO] [stderr] Compiling syn v0.13.1 [INFO] [stderr] Compiling serde_derive_internals v0.23.1 [INFO] [stderr] Compiling serde_derive v1.0.43 [INFO] [stderr] Checking docopt v0.8.3 [INFO] [stderr] Checking pacman v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:123:22 [INFO] [stderr] | [INFO] [stderr] 123 | return Self {map: map, player: player.unwrap(), ghosts: ghosts, end: GameCondition::GameOngoing}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:123:57 [INFO] [stderr] | [INFO] [stderr] 123 | return Self {map: map, player: player.unwrap(), ghosts: ghosts, end: GameCondition::GameOngoing}; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ghosts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ghost.rs:39:35 [INFO] [stderr] | [INFO] [stderr] 39 | return Self {origin: pos, pos: pos, direction: Direction::Standing, is_edible: false}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | return Self {cells: cells}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cells` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player.rs:30:35 [INFO] [stderr] | [INFO] [stderr] 30 | return Self {origin: pos, pos: pos, dir: Direction::Standing, lives: 3, score: 0}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/position.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | return Self {x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/position.rs:18:28 [INFO] [stderr] | [INFO] [stderr] 18 | return Self {x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:123:22 [INFO] [stderr] | [INFO] [stderr] 123 | return Self {map: map, player: player.unwrap(), ghosts: ghosts, end: GameCondition::GameOngoing}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:123:57 [INFO] [stderr] | [INFO] [stderr] 123 | return Self {map: map, player: player.unwrap(), ghosts: ghosts, end: GameCondition::GameOngoing}; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ghosts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ghost.rs:39:35 [INFO] [stderr] | [INFO] [stderr] 39 | return Self {origin: pos, pos: pos, direction: Direction::Standing, is_edible: false}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | return Self {cells: cells}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cells` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player.rs:30:35 [INFO] [stderr] | [INFO] [stderr] 30 | return Self {origin: pos, pos: pos, dir: Direction::Standing, lives: 3, score: 0}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/position.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | return Self {x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/position.rs:18:28 [INFO] [stderr] | [INFO] [stderr] 18 | return Self {x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cell.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return self.has_wall; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.has_wall` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cell.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return self.has_point; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.has_point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cell.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | return canvas[self.pos.y][self.pos.x] = '.'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `canvas[self.pos.y][self.pos.x] = '.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cell.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | return canvas[self.pos.y][self.pos.x] = '#'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `canvas[self.pos.y][self.pos.x] = '#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cell.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | return canvas[self.pos.y][self.pos.x] = 'W'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `canvas[self.pos.y][self.pos.x] = 'W'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cell.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | return canvas[self.pos.y][self.pos.x] = ' '; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `canvas[self.pos.y][self.pos.x] = ' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Game` [INFO] [stderr] --> src/game.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / enum GameCondition [INFO] [stderr] 19 | | { [INFO] [stderr] 20 | | GameOngoing, [INFO] [stderr] 21 | | GameOver, [INFO] [stderr] 22 | | GameWon, [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | return Self {map: map, player: player.unwrap(), ghosts: ghosts, end: GameCondition::GameOngoing}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self {map: map, player: player.unwrap(), ghosts: ghosts, end: GameCondition::GameOngoing}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ghost.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return Self {origin: pos, pos: pos, direction: Direction::Standing, is_edible: false}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self {origin: pos, pos: pos, direction: Direction::Standing, is_edible: false}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/input.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return handle; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/map.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return Self {cells: cells}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self {cells: cells}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/map.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return x + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `x + 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/map.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return y + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `y + 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/player.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return Self {origin: pos, pos: pos, dir: Direction::Standing, lives: 3, score: 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self {origin: pos, pos: pos, dir: Direction::Standing, lives: 3, score: 0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/position.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return Self {x: x, y: y}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self {x: x, y: y}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the variable `y` is used as a loop counter. Consider using `for (y, item) in data.split('\n').enumerate()` or similar iterators [INFO] [stderr] --> src/game.rs:85:18 [INFO] [stderr] | [INFO] [stderr] 85 | for l in data.split('\n') [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `x` is used as a loop counter. Consider using `for (x, item) in l.chars().enumerate()` or similar iterators [INFO] [stderr] --> src/game.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | for c in l.chars() [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/game.rs:148:12 [INFO] [stderr] | [INFO] [stderr] 148 | if self.player.lives <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.player.lives == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cell.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return self.has_wall; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.has_wall` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cell.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return self.has_point; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.has_point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cell.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | return canvas[self.pos.y][self.pos.x] = '.'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `canvas[self.pos.y][self.pos.x] = '.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cell.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | return canvas[self.pos.y][self.pos.x] = '#'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `canvas[self.pos.y][self.pos.x] = '#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cell.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | return canvas[self.pos.y][self.pos.x] = 'W'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `canvas[self.pos.y][self.pos.x] = 'W'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cell.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | return canvas[self.pos.y][self.pos.x] = ' '; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `canvas[self.pos.y][self.pos.x] = ' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Game` [INFO] [stderr] --> src/game.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / enum GameCondition [INFO] [stderr] 19 | | { [INFO] [stderr] 20 | | GameOngoing, [INFO] [stderr] 21 | | GameOver, [INFO] [stderr] 22 | | GameWon, [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | return Self {map: map, player: player.unwrap(), ghosts: ghosts, end: GameCondition::GameOngoing}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self {map: map, player: player.unwrap(), ghosts: ghosts, end: GameCondition::GameOngoing}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ghost.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return Self {origin: pos, pos: pos, direction: Direction::Standing, is_edible: false}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self {origin: pos, pos: pos, direction: Direction::Standing, is_edible: false}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/input.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return handle; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/map.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return Self {cells: cells}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self {cells: cells}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/map.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return x + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `x + 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/map.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return y + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `y + 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/player.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return Self {origin: pos, pos: pos, dir: Direction::Standing, lives: 3, score: 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self {origin: pos, pos: pos, dir: Direction::Standing, lives: 3, score: 0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/position.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return Self {x: x, y: y}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self {x: x, y: y}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/input.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | let mut new = self.orig_termios.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.orig_termios` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: The function/method `tcsetattr` doesn't need a mutable reference [INFO] [stderr] --> src/input.rs:50:31 [INFO] [stderr] | [INFO] [stderr] 50 | tcsetattr(0, TCSANOW, &mut new).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/direction.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn inverse(&self) -> Direction [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pacman`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the variable `y` is used as a loop counter. Consider using `for (y, item) in data.split('\n').enumerate()` or similar iterators [INFO] [stderr] --> src/game.rs:85:18 [INFO] [stderr] | [INFO] [stderr] 85 | for l in data.split('\n') [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `x` is used as a loop counter. Consider using `for (x, item) in l.chars().enumerate()` or similar iterators [INFO] [stderr] --> src/game.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | for c in l.chars() [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/game.rs:148:12 [INFO] [stderr] | [INFO] [stderr] 148 | if self.player.lives <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.player.lives == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/input.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | let mut new = self.orig_termios.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.orig_termios` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: The function/method `tcsetattr` doesn't need a mutable reference [INFO] [stderr] --> src/input.rs:50:31 [INFO] [stderr] | [INFO] [stderr] 50 | tcsetattr(0, TCSANOW, &mut new).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/direction.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn inverse(&self) -> Direction [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pacman`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2be34b8b4e726d27920a6c5ab34781381d9747a7c751f9c57baf11f2ad31d0d2"` [INFO] running `"docker" "rm" "-f" "2be34b8b4e726d27920a6c5ab34781381d9747a7c751f9c57baf11f2ad31d0d2"` [INFO] [stdout] 2be34b8b4e726d27920a6c5ab34781381d9747a7c751f9c57baf11f2ad31d0d2