[INFO] updating cached repository Chthonography/lustrum [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Chthonography/lustrum [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Chthonography/lustrum" "work/ex/clippy-test-run/sources/stable/gh/Chthonography/lustrum"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Chthonography/lustrum'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Chthonography/lustrum" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Chthonography/lustrum"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Chthonography/lustrum'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0e1cc2b4d33c93636c6c256e8d197772dd2c002d [INFO] sha for GitHub repo Chthonography/lustrum: 0e1cc2b4d33c93636c6c256e8d197772dd2c002d [INFO] validating manifest of Chthonography/lustrum on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Chthonography/lustrum on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Chthonography/lustrum [INFO] finished frobbing Chthonography/lustrum [INFO] frobbed toml for Chthonography/lustrum written to work/ex/clippy-test-run/sources/stable/gh/Chthonography/lustrum/Cargo.toml [INFO] started frobbing Chthonography/lustrum [INFO] finished frobbing Chthonography/lustrum [INFO] frobbed toml for Chthonography/lustrum written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Chthonography/lustrum/Cargo.toml [INFO] crate Chthonography/lustrum has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Chthonography/lustrum against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Chthonography/lustrum:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] afb47fdab58961230badfd562bb553ae53ea5915cee159d848b87b20e73108e5 [INFO] running `"docker" "start" "-a" "afb47fdab58961230badfd562bb553ae53ea5915cee159d848b87b20e73108e5"` [INFO] [stderr] Compiling serde_derive v1.0.62 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking gfx_device_gl v0.15.2 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking glutin v0.14.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking camera_controllers v0.24.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking piston_window v0.80.0 [INFO] [stderr] Checking lustrum v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | let ref mut factory = window.factory.clone(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^-------------------------- help: try: `let factory = &mut window.factory.clone();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:205:16 [INFO] [stderr] | [INFO] [stderr] 205 | if let Some(_) = e.resize_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 206 | | projection = get_projection(&window); [INFO] [stderr] 207 | | data.out_color = window.output_color.clone(); [INFO] [stderr] 208 | | data.out_depth = window.output_stencil.clone(); [INFO] [stderr] 209 | | } [INFO] [stderr] | |_________- help: try this: `if e.resize_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | let ref mut factory = window.factory.clone(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^-------------------------- help: try: `let factory = &mut window.factory.clone();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:205:16 [INFO] [stderr] | [INFO] [stderr] 205 | if let Some(_) = e.resize_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 206 | | projection = get_projection(&window); [INFO] [stderr] 207 | | data.out_color = window.output_color.clone(); [INFO] [stderr] 208 | | data.out_depth = window.output_stencil.clone(); [INFO] [stderr] 209 | | } [INFO] [stderr] | |_________- help: try this: `if e.resize_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 44.43s [INFO] running `"docker" "inspect" "afb47fdab58961230badfd562bb553ae53ea5915cee159d848b87b20e73108e5"` [INFO] running `"docker" "rm" "-f" "afb47fdab58961230badfd562bb553ae53ea5915cee159d848b87b20e73108e5"` [INFO] [stdout] afb47fdab58961230badfd562bb553ae53ea5915cee159d848b87b20e73108e5