[INFO] updating cached repository ChristophWurst/media_import [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ChristophWurst/media_import [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ChristophWurst/media_import" "work/ex/clippy-test-run/sources/stable/gh/ChristophWurst/media_import"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ChristophWurst/media_import'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ChristophWurst/media_import" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChristophWurst/media_import"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChristophWurst/media_import'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b0b26bdc821b3382e9307f278ef00c36726c0d5d [INFO] sha for GitHub repo ChristophWurst/media_import: b0b26bdc821b3382e9307f278ef00c36726c0d5d [INFO] validating manifest of ChristophWurst/media_import on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ChristophWurst/media_import on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ChristophWurst/media_import [INFO] finished frobbing ChristophWurst/media_import [INFO] frobbed toml for ChristophWurst/media_import written to work/ex/clippy-test-run/sources/stable/gh/ChristophWurst/media_import/Cargo.toml [INFO] started frobbing ChristophWurst/media_import [INFO] finished frobbing ChristophWurst/media_import [INFO] frobbed toml for ChristophWurst/media_import written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChristophWurst/media_import/Cargo.toml [INFO] crate ChristophWurst/media_import has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ChristophWurst/media_import against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ChristophWurst/media_import:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4abd443d6f5a25a4c1e5a6523e954234db903a35861878d139e9f917c7d7e29a [INFO] running `"docker" "start" "-a" "4abd443d6f5a25a4c1e5a6523e954234db903a35861878d139e9f917c7d7e29a"` [INFO] [stderr] Checking termios v0.3.1 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking clicolors-control v0.3.1 [INFO] [stderr] Checking walkdir v2.2.7 [INFO] [stderr] Checking number_prefix v0.2.8 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] Compiling syn v0.15.22 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking mime v0.3.12 [INFO] [stderr] Checking regex v1.0.4 [INFO] [stderr] Checking tree_magic v0.2.1 [INFO] [stderr] Checking console v0.7.1 [INFO] [stderr] Checking indicatif v0.10.3 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling serde_derive v1.0.82 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking docopt v1.0.2 [INFO] [stderr] Checking media_import v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:29:70 [INFO] [stderr] | [INFO] [stderr] 29 | let xdg = BaseDirectories::new().map_err(|err| Error::XDGError { err: err })?; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:41:87 [INFO] [stderr] | [INFO] [stderr] 41 | let config = serde_json::from_str(config_str).map_err(|err| Error::ParsingError { err: err })?; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:29:70 [INFO] [stderr] | [INFO] [stderr] 29 | let xdg = BaseDirectories::new().map_err(|err| Error::XDGError { err: err })?; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:41:87 [INFO] [stderr] | [INFO] [stderr] 41 | let config = serde_json::from_str(config_str).map_err(|err| Error::ParsingError { err: err })?; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/config.rs:40:34 [INFO] [stderr] | [INFO] [stderr] 40 | fn parse_user_config(config_str: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:39:35 [INFO] [stderr] | [INFO] [stderr] 39 | let time = metadata.created().or(metadata.modified())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| metadata.modified())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:49:10 [INFO] [stderr] | [INFO] [stderr] 49 | dir: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `MediaImport` [INFO] [stderr] --> src/lib.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / pub fn new() -> Self { [INFO] [stderr] 110 | | MediaImport {} [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/config.rs:40:34 [INFO] [stderr] | [INFO] [stderr] 40 | fn parse_user_config(config_str: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:39:35 [INFO] [stderr] | [INFO] [stderr] 39 | let time = metadata.created().or(metadata.modified())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| metadata.modified())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:49:10 [INFO] [stderr] | [INFO] [stderr] 49 | dir: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `MediaImport` [INFO] [stderr] --> src/lib.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / pub fn new() -> Self { [INFO] [stderr] 110 | | MediaImport {} [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:12:15 [INFO] [stderr] | [INFO] [stderr] 12 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:12:15 [INFO] [stderr] | [INFO] [stderr] 12 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 43.89s [INFO] running `"docker" "inspect" "4abd443d6f5a25a4c1e5a6523e954234db903a35861878d139e9f917c7d7e29a"` [INFO] running `"docker" "rm" "-f" "4abd443d6f5a25a4c1e5a6523e954234db903a35861878d139e9f917c7d7e29a"` [INFO] [stdout] 4abd443d6f5a25a4c1e5a6523e954234db903a35861878d139e9f917c7d7e29a