[INFO] updating cached repository ChristianLowe/ReverseCarlos
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ChristianLowe/ReverseCarlos
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ChristianLowe/ReverseCarlos" "work/ex/clippy-test-run/sources/stable/gh/ChristianLowe/ReverseCarlos"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ChristianLowe/ReverseCarlos'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ChristianLowe/ReverseCarlos" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChristianLowe/ReverseCarlos"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChristianLowe/ReverseCarlos'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a3624c1811c039a606ce6467f29ebca7132349e5
[INFO] sha for GitHub repo ChristianLowe/ReverseCarlos: a3624c1811c039a606ce6467f29ebca7132349e5
[INFO] validating manifest of ChristianLowe/ReverseCarlos on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ChristianLowe/ReverseCarlos on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ChristianLowe/ReverseCarlos
[INFO] finished frobbing ChristianLowe/ReverseCarlos
[INFO] frobbed toml for ChristianLowe/ReverseCarlos written to work/ex/clippy-test-run/sources/stable/gh/ChristianLowe/ReverseCarlos/Cargo.toml
[INFO] started frobbing ChristianLowe/ReverseCarlos
[INFO] finished frobbing ChristianLowe/ReverseCarlos
[INFO] frobbed toml for ChristianLowe/ReverseCarlos written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChristianLowe/ReverseCarlos/Cargo.toml
[INFO] crate ChristianLowe/ReverseCarlos has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ChristianLowe/ReverseCarlos against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ChristianLowe/ReverseCarlos:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0a03fe57f994295a5980fbabc4aba224d67259e9f0d4a1cad05e58a568d1c5c4
[INFO] running `"docker" "start" "-a" "0a03fe57f994295a5980fbabc4aba224d67259e9f0d4a1cad05e58a568d1c5c4"`
[INFO] [stderr]     Checking strum v0.8.0
[INFO] [stderr]    Compiling strum_macros v0.8.0
[INFO] [stderr]     Checking reverse-carlos v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/board.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         write!(f, "  A B C D E F G H\n")?;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/board.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 |             write!(f, "\n")?;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/board.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         write!(f, "  A B C D E F G H\n")?;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/board.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 |             write!(f, "\n")?;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/direction.rs:24:30
[INFO] [stderr]    |
[INFO] [stderr] 24 |             Direction::Up => 0xFFFFFFFFFFFFFFFF,
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/direction.rs:25:32
[INFO] [stderr]    |
[INFO] [stderr] 25 |             Direction::Down => 0xFFFFFFFFFFFFFFFF,
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/direction.rs:26:32
[INFO] [stderr]    |
[INFO] [stderr] 26 |             Direction::Left => 0xFEFEFEFEFEFEFEFE,
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^ help: consider: `0xFEFE_FEFE_FEFE_FEFE`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/direction.rs:27:33
[INFO] [stderr]    |
[INFO] [stderr] 27 |             Direction::Right => 0x7F7F7F7F7F7F7F7F,
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^ help: consider: `0x7F7F_7F7F_7F7F_7F7F`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/direction.rs:28:34
[INFO] [stderr]    |
[INFO] [stderr] 28 |             Direction::UpLeft => 0xFEFEFEFEFEFEFE00,
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^ help: consider: `0xFEFE_FEFE_FEFE_FE00`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/direction.rs:29:35
[INFO] [stderr]    |
[INFO] [stderr] 29 |             Direction::UpRight => 0x7F7F7F7F7F7F7F00,
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^ help: consider: `0x7F7F_7F7F_7F7F_7F00`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/direction.rs:30:36
[INFO] [stderr]    |
[INFO] [stderr] 30 |             Direction::DownLeft => 0x00FEFEFEFEFEFEFE,
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^ help: consider: `0x00FE_FEFE_FEFE_FEFE`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/direction.rs:31:37
[INFO] [stderr]    |
[INFO] [stderr] 31 |             Direction::DownRight => 0x007F7F7F7F7F7F7F,
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^ help: consider: `0x007F_7F7F_7F7F_7F7F`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/direction.rs:24:30
[INFO] [stderr]    |
[INFO] [stderr] 24 |             Direction::Up => 0xFFFFFFFFFFFFFFFF,
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/direction.rs:25:32
[INFO] [stderr]    |
[INFO] [stderr] 25 |             Direction::Down => 0xFFFFFFFFFFFFFFFF,
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/direction.rs:26:32
[INFO] [stderr]    |
[INFO] [stderr] 26 |             Direction::Left => 0xFEFEFEFEFEFEFEFE,
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^ help: consider: `0xFEFE_FEFE_FEFE_FEFE`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/direction.rs:27:33
[INFO] [stderr]    |
[INFO] [stderr] 27 |             Direction::Right => 0x7F7F7F7F7F7F7F7F,
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^ help: consider: `0x7F7F_7F7F_7F7F_7F7F`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/direction.rs:28:34
[INFO] [stderr]    |
[INFO] [stderr] 28 |             Direction::UpLeft => 0xFEFEFEFEFEFEFE00,
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^ help: consider: `0xFEFE_FEFE_FEFE_FE00`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/direction.rs:29:35
[INFO] [stderr]    |
[INFO] [stderr] 29 |             Direction::UpRight => 0x7F7F7F7F7F7F7F00,
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^ help: consider: `0x7F7F_7F7F_7F7F_7F00`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/direction.rs:30:36
[INFO] [stderr]    |
[INFO] [stderr] 30 |             Direction::DownLeft => 0x00FEFEFEFEFEFEFE,
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^ help: consider: `0x00FE_FEFE_FEFE_FEFE`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/direction.rs:31:37
[INFO] [stderr]    |
[INFO] [stderr] 31 |             Direction::DownRight => 0x007F7F7F7F7F7F7F,
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^ help: consider: `0x007F_7F7F_7F7F_7F7F`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/cell.rs:10:45
[INFO] [stderr]    |
[INFO] [stderr] 10 |         let row = ((self.board_index / 8) + ('1' as u8)) as char;
[INFO] [stderr]    |                                             ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'1'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/cell.rs:11:45
[INFO] [stderr]    |
[INFO] [stderr] 11 |         let col = ((self.board_index % 8) + ('A' as u8)) as char;
[INFO] [stderr]    |                                             ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'A'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/cell.rs:30:43
[INFO] [stderr]    |
[INFO] [stderr] 30 |     pub fn from_algebraic_notation(input: &String) -> Result<Cell, ()> {
[INFO] [stderr]    |                                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/cell.rs:35:23
[INFO] [stderr]    |
[INFO] [stderr] 35 |         if bytes[0] > 'H' as u8 || bytes[0] < 'A' as u8
[INFO] [stderr]    |                       ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'H'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/cell.rs:35:47
[INFO] [stderr]    |
[INFO] [stderr] 35 |         if bytes[0] > 'H' as u8 || bytes[0] < 'A' as u8
[INFO] [stderr]    |                                               ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'A'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/cell.rs:36:23
[INFO] [stderr]    |
[INFO] [stderr] 36 |         || bytes[1] > '9' as u8 || bytes[1] < '1' as u8 {
[INFO] [stderr]    |                       ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'9'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/cell.rs:36:47
[INFO] [stderr]    |
[INFO] [stderr] 36 |         || bytes[1] > '9' as u8 || bytes[1] < '1' as u8 {
[INFO] [stderr]    |                                               ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'1'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/cell.rs:40:30
[INFO] [stderr]    |
[INFO] [stderr] 40 |         let row = bytes[1] - ('1' as u8);
[INFO] [stderr]    |                              ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'1'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/cell.rs:41:33
[INFO] [stderr]    |
[INFO] [stderr] 41 |         let column = bytes[0] - ('A' as u8);
[INFO] [stderr]    |                                 ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'A'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `board::Board`
[INFO] [stderr]   --> src/board.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 | /     pub fn new() -> Board {
[INFO] [stderr] 50 | |         let mut board = Board {
[INFO] [stderr] 51 | |             white_board: 0b0,
[INFO] [stderr] 52 | |             black_board: 0b0,
[INFO] [stderr] ...  |
[INFO] [stderr] 60 | |         board
[INFO] [stderr] 61 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 7  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:26:12
[INFO] [stderr]    |
[INFO] [stderr] 26 |         if valid_moves.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `valid_moves.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/cell.rs:10:45
[INFO] [stderr]    |
[INFO] [stderr] 10 |         let row = ((self.board_index / 8) + ('1' as u8)) as char;
[INFO] [stderr]    |                                             ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'1'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/cell.rs:11:45
[INFO] [stderr]    |
[INFO] [stderr] 11 |         let col = ((self.board_index % 8) + ('A' as u8)) as char;
[INFO] [stderr]    |                                             ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'A'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/cell.rs:30:43
[INFO] [stderr]    |
[INFO] [stderr] 30 |     pub fn from_algebraic_notation(input: &String) -> Result<Cell, ()> {
[INFO] [stderr]    |                                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/cell.rs:35:23
[INFO] [stderr]    |
[INFO] [stderr] 35 |         if bytes[0] > 'H' as u8 || bytes[0] < 'A' as u8
[INFO] [stderr]    |                       ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'H'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/cell.rs:35:47
[INFO] [stderr]    |
[INFO] [stderr] 35 |         if bytes[0] > 'H' as u8 || bytes[0] < 'A' as u8
[INFO] [stderr]    |                                               ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'A'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/cell.rs:36:23
[INFO] [stderr]    |
[INFO] [stderr] 36 |         || bytes[1] > '9' as u8 || bytes[1] < '1' as u8 {
[INFO] [stderr]    |                       ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'9'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/cell.rs:36:47
[INFO] [stderr]    |
[INFO] [stderr] 36 |         || bytes[1] > '9' as u8 || bytes[1] < '1' as u8 {
[INFO] [stderr]    |                                               ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'1'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/cell.rs:40:30
[INFO] [stderr]    |
[INFO] [stderr] 40 |         let row = bytes[1] - ('1' as u8);
[INFO] [stderr]    |                              ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'1'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/cell.rs:41:33
[INFO] [stderr]    |
[INFO] [stderr] 41 |         let column = bytes[0] - ('A' as u8);
[INFO] [stderr]    |                                 ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'A'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `board::Board`
[INFO] [stderr]   --> src/board.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 | /     pub fn new() -> Board {
[INFO] [stderr] 50 | |         let mut board = Board {
[INFO] [stderr] 51 | |             white_board: 0b0,
[INFO] [stderr] 52 | |             black_board: 0b0,
[INFO] [stderr] ...  |
[INFO] [stderr] 60 | |         board
[INFO] [stderr] 61 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 7  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:26:12
[INFO] [stderr]    |
[INFO] [stderr] 26 |         if valid_moves.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `valid_moves.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.65s
[INFO] running `"docker" "inspect" "0a03fe57f994295a5980fbabc4aba224d67259e9f0d4a1cad05e58a568d1c5c4"`
[INFO] running `"docker" "rm" "-f" "0a03fe57f994295a5980fbabc4aba224d67259e9f0d4a1cad05e58a568d1c5c4"`
[INFO] [stdout] 0a03fe57f994295a5980fbabc4aba224d67259e9f0d4a1cad05e58a568d1c5c4