[INFO] updating cached repository ChrisSerpico/Rust-Subdomain-Enumerator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ChrisSerpico/Rust-Subdomain-Enumerator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ChrisSerpico/Rust-Subdomain-Enumerator" "work/ex/clippy-test-run/sources/stable/gh/ChrisSerpico/Rust-Subdomain-Enumerator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ChrisSerpico/Rust-Subdomain-Enumerator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ChrisSerpico/Rust-Subdomain-Enumerator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChrisSerpico/Rust-Subdomain-Enumerator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChrisSerpico/Rust-Subdomain-Enumerator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 35e1686d6cd92843ab1eff3dd01876214b49792e [INFO] sha for GitHub repo ChrisSerpico/Rust-Subdomain-Enumerator: 35e1686d6cd92843ab1eff3dd01876214b49792e [INFO] validating manifest of ChrisSerpico/Rust-Subdomain-Enumerator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ChrisSerpico/Rust-Subdomain-Enumerator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ChrisSerpico/Rust-Subdomain-Enumerator [INFO] finished frobbing ChrisSerpico/Rust-Subdomain-Enumerator [INFO] frobbed toml for ChrisSerpico/Rust-Subdomain-Enumerator written to work/ex/clippy-test-run/sources/stable/gh/ChrisSerpico/Rust-Subdomain-Enumerator/Cargo.toml [INFO] started frobbing ChrisSerpico/Rust-Subdomain-Enumerator [INFO] finished frobbing ChrisSerpico/Rust-Subdomain-Enumerator [INFO] frobbed toml for ChrisSerpico/Rust-Subdomain-Enumerator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChrisSerpico/Rust-Subdomain-Enumerator/Cargo.toml [INFO] crate ChrisSerpico/Rust-Subdomain-Enumerator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ChrisSerpico/Rust-Subdomain-Enumerator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ChrisSerpico/Rust-Subdomain-Enumerator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b2172356c2cdbb3a76417852367e953943521299e9f5d4ec253c09608b95f7d0 [INFO] running `"docker" "start" "-a" "b2172356c2cdbb3a76417852367e953943521299e9f5d4ec253c09608b95f7d0"` [INFO] [stderr] Checking socket2 v0.3.5 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Compiling serde_derive v1.0.59 [INFO] [stderr] Checking dns-lookup v0.9.1 [INFO] [stderr] Checking subdomain_enumerator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/library_enumerator.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/library_enumerator.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/enumerator.rs:26:40 [INFO] [stderr] | [INFO] [stderr] 26 | store: Arc>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 25 | pub fn query_database(domain: String, [INFO] [stderr] 26 | store: Arc>>, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/library_enumerator.rs:37:36 [INFO] [stderr] | [INFO] [stderr] 37 | store : Arc>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 35 | pub fn enumerate(domain: String, [INFO] [stderr] 36 | library: String, [INFO] [stderr] 37 | store : Arc>>, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/library_enumerator.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | fn get_wildcards(domain : &String, wc : &mut HashSet) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/library_enumerator.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | fn query(name : &String, wc : &HashSet) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/library_enumerator.rs:109:36 [INFO] [stderr] | [INFO] [stderr] 109 | while let Some(addr) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for addr in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `query::Query` [INFO] [stderr] --> src/query.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | Query { [INFO] [stderr] 25 | | domains: Vec::new(), [INFO] [stderr] 26 | | library: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/query.rs:80:12 [INFO] [stderr] | [INFO] [stderr] 80 | if self.library.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.library.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/query.rs:85:31 [INFO] [stderr] | [INFO] [stderr] 85 | let db_arg3 = self.limit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/query.rs:103:31 [INFO] [stderr] | [INFO] [stderr] 103 | let db_arg3 = self.limit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/enumerator.rs:26:40 [INFO] [stderr] | [INFO] [stderr] 26 | store: Arc>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 25 | pub fn query_database(domain: String, [INFO] [stderr] 26 | store: Arc>>, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/library_enumerator.rs:37:36 [INFO] [stderr] | [INFO] [stderr] 37 | store : Arc>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 35 | pub fn enumerate(domain: String, [INFO] [stderr] 36 | library: String, [INFO] [stderr] 37 | store : Arc>>, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/library_enumerator.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | fn get_wildcards(domain : &String, wc : &mut HashSet) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/library_enumerator.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | fn query(name : &String, wc : &HashSet) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/library_enumerator.rs:109:36 [INFO] [stderr] | [INFO] [stderr] 109 | while let Some(addr) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for addr in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/library_enumerator.rs:142:40 [INFO] [stderr] | [INFO] [stderr] 142 | while let Some(addr) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for addr in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `query::Query` [INFO] [stderr] --> src/query.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | Query { [INFO] [stderr] 25 | | domains: Vec::new(), [INFO] [stderr] 26 | | library: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/query.rs:80:12 [INFO] [stderr] | [INFO] [stderr] 80 | if self.library.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.library.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/query.rs:85:31 [INFO] [stderr] | [INFO] [stderr] 85 | let db_arg3 = self.limit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/query.rs:103:31 [INFO] [stderr] | [INFO] [stderr] 103 | let db_arg3 = self.limit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 31.24s [INFO] running `"docker" "inspect" "b2172356c2cdbb3a76417852367e953943521299e9f5d4ec253c09608b95f7d0"` [INFO] running `"docker" "rm" "-f" "b2172356c2cdbb3a76417852367e953943521299e9f5d4ec253c09608b95f7d0"` [INFO] [stdout] b2172356c2cdbb3a76417852367e953943521299e9f5d4ec253c09608b95f7d0