[INFO] updating cached repository ChrisMacNaughton/euler-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ChrisMacNaughton/euler-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ChrisMacNaughton/euler-rs" "work/ex/clippy-test-run/sources/stable/gh/ChrisMacNaughton/euler-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ChrisMacNaughton/euler-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ChrisMacNaughton/euler-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChrisMacNaughton/euler-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChrisMacNaughton/euler-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 725e2f5e689d2e94cada7a25e66af39e8b01c354 [INFO] sha for GitHub repo ChrisMacNaughton/euler-rs: 725e2f5e689d2e94cada7a25e66af39e8b01c354 [INFO] validating manifest of ChrisMacNaughton/euler-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ChrisMacNaughton/euler-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ChrisMacNaughton/euler-rs [INFO] finished frobbing ChrisMacNaughton/euler-rs [INFO] frobbed toml for ChrisMacNaughton/euler-rs written to work/ex/clippy-test-run/sources/stable/gh/ChrisMacNaughton/euler-rs/Cargo.toml [INFO] started frobbing ChrisMacNaughton/euler-rs [INFO] finished frobbing ChrisMacNaughton/euler-rs [INFO] frobbed toml for ChrisMacNaughton/euler-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChrisMacNaughton/euler-rs/Cargo.toml [INFO] crate ChrisMacNaughton/euler-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ChrisMacNaughton/euler-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ChrisMacNaughton/euler-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 32cbc5eaa46bfb565b5cc21d66f59ffb935f9332318211e7f3c83cc565039ac6 [INFO] running `"docker" "start" "-a" "32cbc5eaa46bfb565b5cc21d66f59ffb935f9332318211e7f3c83cc565039ac6"` [INFO] [stderr] Checking euler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/problems.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | let source = 600851475143; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/problems.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | target = target / factor; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target /= factor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/problems.rs:97:27 [INFO] [stderr] | [INFO] [stderr] 97 | (1 .. max + 1).reduce(|a, b| lcm(a, b)).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `lcm` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problems.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | (1 .. max + 1).reduce(|a, b| lcm(a, b)).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `(1..=max)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fibonacci.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | self.current = self.current + self.last; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.current += self.last` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/problems.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | let source = 600851475143; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:13:36 [INFO] [stderr] | [INFO] [stderr] 13 | assert_eq!(problems::p1(), 233168); [INFO] [stderr] | ^^^^^^ help: consider: `233_168` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:18:36 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(problems::p2(), 4613732); [INFO] [stderr] | ^^^^^^^ help: consider: `4_613_732` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:28:36 [INFO] [stderr] | [INFO] [stderr] 28 | assert_eq!(problems::p4(), 906609); [INFO] [stderr] | ^^^^^^ help: consider: `906_609` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:33:36 [INFO] [stderr] | [INFO] [stderr] 33 | assert_eq!(problems::p5(), 232792560); [INFO] [stderr] | ^^^^^^^^^ help: consider: `232_792_560` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:38:36 [INFO] [stderr] | [INFO] [stderr] 38 | assert_eq!(problems::p6(), 25164150); [INFO] [stderr] | ^^^^^^^^ help: consider: `25_164_150` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:43:36 [INFO] [stderr] | [INFO] [stderr] 43 | assert_eq!(problems::p7(), 104743); [INFO] [stderr] | ^^^^^^ help: consider: `104_743` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/problems.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | target = target / factor; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target /= factor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/problems.rs:97:27 [INFO] [stderr] | [INFO] [stderr] 97 | (1 .. max + 1).reduce(|a, b| lcm(a, b)).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `lcm` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problems.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | (1 .. max + 1).reduce(|a, b| lcm(a, b)).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `(1..=max)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fibonacci.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | self.current = self.current + self.last; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.current += self.last` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: function is never used: `p01` [INFO] [stderr] --> benches/euler.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | fn p01(bench: &mut Bencher) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `p02` [INFO] [stderr] --> benches/euler.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | fn p02(bench: &mut Bencher) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `p03` [INFO] [stderr] --> benches/euler.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | fn p03(bench: &mut Bencher) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `p04` [INFO] [stderr] --> benches/euler.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | fn p04(bench: &mut Bencher) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `p05` [INFO] [stderr] --> benches/euler.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | fn p05(bench: &mut Bencher) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `p06` [INFO] [stderr] --> benches/euler.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | fn p06(bench: &mut Bencher) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> benches/euler.rs:9:16 [INFO] [stderr] | [INFO] [stderr] 9 | bench.iter(|| problems::p1()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `problems::p1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> benches/euler.rs:13:16 [INFO] [stderr] | [INFO] [stderr] 13 | bench.iter(|| problems::p2()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `problems::p2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> benches/euler.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | bench.iter(|| problems::p3()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `problems::p3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> benches/euler.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | bench.iter(|| problems::p4()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `problems::p4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> benches/euler.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | bench.iter(|| problems::p5()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `problems::p5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> benches/euler.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | bench.iter(|| problems::p6()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `problems::p6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> benches/euler.rs:33:16 [INFO] [stderr] | [INFO] [stderr] 33 | bench.iter(|| problems::p7()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `problems::p7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.28s [INFO] running `"docker" "inspect" "32cbc5eaa46bfb565b5cc21d66f59ffb935f9332318211e7f3c83cc565039ac6"` [INFO] running `"docker" "rm" "-f" "32cbc5eaa46bfb565b5cc21d66f59ffb935f9332318211e7f3c83cc565039ac6"` [INFO] [stdout] 32cbc5eaa46bfb565b5cc21d66f59ffb935f9332318211e7f3c83cc565039ac6