[INFO] updating cached repository ChrisDavison/mdlc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ChrisDavison/mdlc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ChrisDavison/mdlc" "work/ex/clippy-test-run/sources/stable/gh/ChrisDavison/mdlc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ChrisDavison/mdlc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ChrisDavison/mdlc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChrisDavison/mdlc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChrisDavison/mdlc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9a448c0fc49b5efb8928f26edf56ed8538a1e999 [INFO] sha for GitHub repo ChrisDavison/mdlc: 9a448c0fc49b5efb8928f26edf56ed8538a1e999 [INFO] validating manifest of ChrisDavison/mdlc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ChrisDavison/mdlc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ChrisDavison/mdlc [INFO] finished frobbing ChrisDavison/mdlc [INFO] frobbed toml for ChrisDavison/mdlc written to work/ex/clippy-test-run/sources/stable/gh/ChrisDavison/mdlc/Cargo.toml [INFO] started frobbing ChrisDavison/mdlc [INFO] finished frobbing ChrisDavison/mdlc [INFO] frobbed toml for ChrisDavison/mdlc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChrisDavison/mdlc/Cargo.toml [INFO] crate ChrisDavison/mdlc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ChrisDavison/mdlc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ChrisDavison/mdlc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7654dd7e4a3f24065243a95b854a00401d686a70253b36361e809ca7690a4bc8 [INFO] running `"docker" "start" "-a" "7654dd7e4a3f24065243a95b854a00401d686a70253b36361e809ca7690a4bc8"` [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking mdlc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/link.rs:13:20 [INFO] [stderr] | [INFO] [stderr] 13 | const RX_MDLOCAL: &'static str = r"^.{1,2}/([a-zA-Z0-9-_]+/)*[a-zA-Z0-9-_]+.md"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/link.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | const RX_MDWEB: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/link.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | const RX_LINK: &'static str = r"\[.+?\]\((.+?)\)|^ \[.+?\]: (.+)"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/link.rs:115:29 [INFO] [stderr] | [INFO] [stderr] 115 | .filter(|x| x.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/link.rs:13:20 [INFO] [stderr] | [INFO] [stderr] 13 | const RX_MDLOCAL: &'static str = r"^.{1,2}/([a-zA-Z0-9-_]+/)*[a-zA-Z0-9-_]+.md"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/link.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | const RX_MDWEB: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/link.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | const RX_LINK: &'static str = r"\[.+?\]\((.+?)\)|^ \[.+?\]: (.+)"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/link.rs:115:29 [INFO] [stderr] | [INFO] [stderr] 115 | .filter(|x| x.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.37s [INFO] running `"docker" "inspect" "7654dd7e4a3f24065243a95b854a00401d686a70253b36361e809ca7690a4bc8"` [INFO] running `"docker" "rm" "-f" "7654dd7e4a3f24065243a95b854a00401d686a70253b36361e809ca7690a4bc8"` [INFO] [stdout] 7654dd7e4a3f24065243a95b854a00401d686a70253b36361e809ca7690a4bc8