[INFO] updating cached repository CheukNgai/PageRank_Timely [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/CheukNgai/PageRank_Timely [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/CheukNgai/PageRank_Timely" "work/ex/clippy-test-run/sources/stable/gh/CheukNgai/PageRank_Timely"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CheukNgai/PageRank_Timely'... [INFO] [stderr] done. [INFO] [stderr] Checking out files: 22% (161/718) Checking out files: 23% (166/718) Checking out files: 24% (173/718) Checking out files: 25% (180/718) Checking out files: 26% (187/718) Checking out files: 27% (194/718) Checking out files: 28% (202/718) Checking out files: 29% (209/718) Checking out files: 30% (216/718) Checking out files: 31% (223/718) Checking out files: 32% (230/718) Checking out files: 33% (237/718) Checking out files: 34% (245/718) Checking out files: 35% (252/718) Checking out files: 36% (259/718) Checking out files: 37% (266/718) Checking out files: 38% (273/718) Checking out files: 39% (281/718) Checking out files: 40% (288/718) Checking out files: 41% (295/718) Checking out files: 42% (302/718) Checking out files: 43% (309/718) Checking out files: 44% (316/718) Checking out files: 45% (324/718) Checking out files: 46% (331/718) Checking out files: 47% (338/718) Checking out files: 48% (345/718) Checking out files: 49% (352/718) Checking out files: 50% (359/718) Checking out files: 51% (367/718) Checking out files: 52% (374/718) Checking out files: 53% (381/718) Checking out files: 54% (388/718) Checking out files: 55% (395/718) Checking out files: 56% (403/718) Checking out files: 57% (410/718) Checking out files: 58% (417/718) Checking out files: 59% (424/718) Checking out files: 60% (431/718) Checking out files: 61% (438/718) Checking out files: 62% (446/718) Checking out files: 63% (453/718) Checking out files: 64% (460/718) Checking out files: 65% (467/718) Checking out files: 66% (474/718) Checking out files: 67% (482/718) Checking out files: 68% (489/718) Checking out files: 69% (496/718) Checking out files: 70% (503/718) Checking out files: 71% (510/718) Checking out files: 72% (517/718) Checking out files: 73% (525/718) Checking out files: 74% (532/718) Checking out files: 75% (539/718) Checking out files: 76% (546/718) Checking out files: 77% (553/718) Checking out files: 78% (561/718) Checking out files: 79% (568/718) Checking out files: 80% (575/718) Checking out files: 81% (582/718) Checking out files: 82% (589/718) Checking out files: 83% (596/718) Checking out files: 84% (604/718) Checking out files: 85% (611/718) Checking out files: 86% (618/718) Checking out files: 87% (625/718) Checking out files: 88% (632/718) Checking out files: 89% (640/718) Checking out files: 90% (647/718) Checking out files: 91% (654/718) Checking out files: 92% (661/718) Checking out files: 93% (668/718) Checking out files: 94% (675/718) Checking out files: 95% (683/718) Checking out files: 96% (690/718) Checking out files: 97% (697/718) Checking out files: 98% (704/718) Checking out files: 99% (711/718) Checking out files: 100% (718/718) Checking out files: 100% (718/718), done. [INFO] running `"git" "clone" "work/cache/sources/gh/CheukNgai/PageRank_Timely" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CheukNgai/PageRank_Timely"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CheukNgai/PageRank_Timely'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2828a9534788794f7c93d9d888eb8170488b1a7c [INFO] sha for GitHub repo CheukNgai/PageRank_Timely: 2828a9534788794f7c93d9d888eb8170488b1a7c [INFO] validating manifest of CheukNgai/PageRank_Timely on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of CheukNgai/PageRank_Timely on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing CheukNgai/PageRank_Timely [INFO] finished frobbing CheukNgai/PageRank_Timely [INFO] frobbed toml for CheukNgai/PageRank_Timely written to work/ex/clippy-test-run/sources/stable/gh/CheukNgai/PageRank_Timely/Cargo.toml [INFO] started frobbing CheukNgai/PageRank_Timely [INFO] finished frobbing CheukNgai/PageRank_Timely [INFO] frobbed toml for CheukNgai/PageRank_Timely written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CheukNgai/PageRank_Timely/Cargo.toml [INFO] crate CheukNgai/PageRank_Timely has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting CheukNgai/PageRank_Timely against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/CheukNgai/PageRank_Timely:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e4b6e27b0ded69f5ac359621800b9f4a24b36d5ee41f8f23de64d97cd568ac63 [INFO] running `"docker" "start" "-a" "e4b6e27b0ded69f5ac359621800b9f4a24b36d5ee41f8f23de64d97cd568ac63"` [INFO] [stderr] Checking abomonation v0.5.0 [INFO] [stderr] Checking timely_sort v0.1.6 [INFO] [stderr] Checking file v1.1.2 [INFO] [stderr] Compiling abomonation_derive v0.3.0 [INFO] [stderr] Checking timely_communication v0.6.0 [INFO] [stderr] Checking timely v0.6.0 [INFO] [stderr] Checking pagerank v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | if (index == 0) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | if (index == 0) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `diff` [INFO] [stderr] --> src/main.rs:115:43 [INFO] [stderr] | [INFO] [stderr] 115 | for (dst, diff) in rank_changes.iter_mut() { [INFO] [stderr] | ^^^^ help: consider using `_diff` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | let mut round = 0; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | let mut round = 0; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:187:6 [INFO] [stderr] | [INFO] [stderr] 187 | let mut file = BufReader::new(&f); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | let mut node_number = node_list.len(); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable `default_PR` should have a snake case name such as `default_pr` [INFO] [stderr] --> src/main.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | let default_PR:f32 = 1.0 / node_number as f32; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:64:61 [INFO] [stderr] | [INFO] [stderr] 64 | edge_stash.entry(time.retain()).or_insert(Vec::new()).extend(data.drain(..)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:69:61 [INFO] [stderr] | [INFO] [stderr] 69 | rank_stash.entry(time.retain()).or_insert(Vec::new()).extend(data.drain(..)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:86:56 [INFO] [stderr] | [INFO] [stderr] 86 | edges.entry(src.clone()).or_insert(HashSet::new()).insert(dst.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:87:56 [INFO] [stderr] | [INFO] [stderr] 87 | edges.entry(dst.clone()).or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:95:48 [INFO] [stderr] | [INFO] [stderr] 95 | let mut delta = ranks[src].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ranks[src]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:124:85 [INFO] [stderr] | [INFO] [stderr] 124 | *new_ranks.entry(dst.clone()).or_insert(0.0) += diff.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `diff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:140:57 [INFO] [stderr] | [INFO] [stderr] 140 | let mut delta = ranks[src].clone() / dst_num as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ranks[src]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in tuple.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:196:21 [INFO] [stderr] | [INFO] [stderr] 196 | for node in tuple{ [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: unused variable: `diff` [INFO] [stderr] --> src/main.rs:115:43 [INFO] [stderr] | [INFO] [stderr] 115 | for (dst, diff) in rank_changes.iter_mut() { [INFO] [stderr] | ^^^^ help: consider using `_diff` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | let mut round = 0; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | let mut round = 0; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:187:6 [INFO] [stderr] | [INFO] [stderr] 187 | let mut file = BufReader::new(&f); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | let mut node_number = node_list.len(); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable `default_PR` should have a snake case name such as `default_pr` [INFO] [stderr] --> src/main.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | let default_PR:f32 = 1.0 / node_number as f32; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:64:61 [INFO] [stderr] | [INFO] [stderr] 64 | edge_stash.entry(time.retain()).or_insert(Vec::new()).extend(data.drain(..)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:69:61 [INFO] [stderr] | [INFO] [stderr] 69 | rank_stash.entry(time.retain()).or_insert(Vec::new()).extend(data.drain(..)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:86:56 [INFO] [stderr] | [INFO] [stderr] 86 | edges.entry(src.clone()).or_insert(HashSet::new()).insert(dst.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:87:56 [INFO] [stderr] | [INFO] [stderr] 87 | edges.entry(dst.clone()).or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:95:48 [INFO] [stderr] | [INFO] [stderr] 95 | let mut delta = ranks[src].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ranks[src]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:124:85 [INFO] [stderr] | [INFO] [stderr] 124 | *new_ranks.entry(dst.clone()).or_insert(0.0) += diff.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `diff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:140:57 [INFO] [stderr] | [INFO] [stderr] 140 | let mut delta = ranks[src].clone() / dst_num as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ranks[src]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in tuple.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:196:21 [INFO] [stderr] | [INFO] [stderr] 196 | for node in tuple{ [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.87s [INFO] running `"docker" "inspect" "e4b6e27b0ded69f5ac359621800b9f4a24b36d5ee41f8f23de64d97cd568ac63"` [INFO] running `"docker" "rm" "-f" "e4b6e27b0ded69f5ac359621800b9f4a24b36d5ee41f8f23de64d97cd568ac63"` [INFO] [stdout] e4b6e27b0ded69f5ac359621800b9f4a24b36d5ee41f8f23de64d97cd568ac63